211784 2020-05-12 09:37:43 -0700 -Wattribute warning in BreakLines.cpp 2020-05-12 15:08:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro changseok darin esprehn+autocc ews-watchlist glenn kondapallykalyan mcatanzaro pdr webkit-bug-importer oldest_to_newest 1651771 0 mcatanzaro 2020-05-12 09:37:43 -0700 Looks like another new GCC 10 warning: [625/1151] Building CXX object Source/...sources/UnifiedSource-043dd90b-1.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-1.cpp:4: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/BreakLines.cpp:53:78: warning: ‘visibility’ attribute ignored [-Wattributes] 53 | WEBCORE_EXPORT const unsigned char lineBreakTable[][lineBreakTableColumnCount] = { | ^ This variable does not seem to be used outside WebCore, so let's try removing it and see if EWS is happy. 1651772 1 399135 mcatanzaro 2020-05-12 09:39:29 -0700 Created attachment 399135 Patch 1651811 2 399135 darin 2020-05-12 10:55:07 -0700 Comment on attachment 399135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399135&action=review > Source/WebCore/ChangeLog:8 > + Don't export lineBreakTable. It's not used outside WebCore anyway. This comment is not accurate; it’s not what is done by this patch. Removing the WEBCORE_EXPORT from the definition does not change whether lineBreakTable is exported. That’s decided by the WEBCORE_EXPORT on the declaration in the header. I don’t know if lineBreakTable is used outside WebCore; to find out we’d have to check on the callers of all the WebCore inline functions that use lineBreakTable. If any of them are called outside WebCore, then it *is* used outside. If we wanted to not export it, then we’d have to remove the WEBCORE_EXPORT from the header. Removing this export from the .cpp file does seem like an acceptable way to fix the warning, so r=me on the code change, but please change this change log comment. 1651923 3 mcatanzaro 2020-05-12 14:03:08 -0700 You're right! Learning is good.... 1651954 4 399180 mcatanzaro 2020-05-12 14:42:00 -0700 Created attachment 399180 Patch for landing 1651972 5 ews-feeder 2020-05-12 15:07:30 -0700 Committed r261580: <https://trac.webkit.org/changeset/261580> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399180. 1651973 6 webkit-bug-importer 2020-05-12 15:08:21 -0700 <rdar://problem/63156143> 399135 2020-05-12 09:39:29 -0700 2020-05-12 14:41:58 -0700 Patch bug-211784-20200512113928.patch text/plain 1945 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk0M2Q2YWMxZjkwMWRh NWVmNjZhYjgxZjJiOWNiOGFiOTMxMjAyOC4uYmUyMzdlMGRjMThiNTkzZDMzNTBhN2QyNjhkNTU3 OTc5MWVlMjdkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTEyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXR0cmli dXRlIHdhcm5pbmcgaW4gQnJlYWtMaW5lcy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTc4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGV4cG9ydCBsaW5lQnJlYWtUYWJsZS4gSXQncyBu b3QgdXNlZCBvdXRzaWRlIFdlYkNvcmUgYW55d2F5LgorCisgICAgICAgICogcmVuZGVyaW5nL0Jy ZWFrTGluZXMuY3BwOgorCiAyMDIwLTA1LTA5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gU2VhcmNoIGZpZWxkIG9uIG1heW9jbGluaWMu b3JnL2Zvcm1zL3VzLXJlc2lkZW50LWFwcG9pbnRtZW50IGNsaXBzIHRoZSBzdWJtaXQgYnV0dG9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQnJlYWtMaW5lcy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQnJlYWtMaW5lcy5jcHAKaW5kZXggOWMzMzljZTMyYzY0 MDI2MmU2MjhkYzY1ODM3ODgwNWZkNTc0MTU0OC4uZDhmYzM4MTVkMGViZTM2ZDQ1YjFmYmE1ODVj ZTkxNTU1NTQ3YjYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0JyZWFr TGluZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9CcmVha0xpbmVzLmNwcApA QCAtNTAsNyArNTAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyAtIGFmdGVyICctJyBhbmQg Jz8nIChiYWNrd2FyZC1jb21wYXRpYmxlLCBhbmQgY29tcGF0aWJsZSB3aXRoIEludGVybmV0IEV4 cGxvcmVyKS4KIC8vIFBsZWFzZSByZWZlciB0byA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3Njk4PiBmb3IgbGluZSBicmVha2luZyBtYXRyaXhlcyBvZiBkaWZmZXJl bnQgYnJvd3NlcnMKIC8vIGFuZCB0aGUgSUNVIHN0YW5kYXJkLgotV0VCQ09SRV9FWFBPUlQgY29u c3QgdW5zaWduZWQgY2hhciBsaW5lQnJlYWtUYWJsZVtdW2xpbmVCcmVha1RhYmxlQ29sdW1uQ291 bnRdID0geworY29uc3QgdW5zaWduZWQgY2hhciBsaW5lQnJlYWtUYWJsZVtdW2xpbmVCcmVha1Rh YmxlQ29sdW1uQ291bnRdID0gewogICAgIC8vICAhICAiICAjICAkICAlICAmICAnICAoICAgICAp ICAqICArICAsICAtICAuICAvICAwICAxLTggICA5ICA6ICA7ICA8ICA9ICA+ICA/ICBAICAgICBB LVggICAgICBZICBaICBbICBcICBdICBeICBfICBgICAgICBhLXggICAgICB5ICB6ICB7ICB8ICB9 ICB+ICBERUwKICAgICB7IEIoMCwgMCwgMCwgMCwgMCwgMCwgMCwgMSksIEIoMCwgMCwgMCwgMCwg MCwgMCwgMCwgMCksIDAsIEIoMCwgMCwgMCwgMSwgMCwgMCwgMCwgMCksIDAsIDAsIDAsIEIoMCwg MCwgMSwgMCwgMCwgMCwgMCwgMCksIDAsIDAsIDAsIEIoMCwgMCwgMSwgMCwgMCwgMCwgMCwgMCkg fSwgLy8gIQogICAgIHsgQigwLCAwLCAwLCAwLCAwLCAwLCAwLCAxKSwgQigwLCAwLCAwLCAwLCAw LCAwLCAwLCAwKSwgMCwgQigwLCAwLCAwLCAxLCAwLCAwLCAwLCAwKSwgMCwgMCwgMCwgQigwLCAw LCAxLCAwLCAwLCAwLCAwLCAwKSwgMCwgMCwgMCwgQigwLCAwLCAxLCAwLCAwLCAwLCAwLCAwKSB9 LCAvLyAiCg== 399180 2020-05-12 14:42:00 -0700 2020-05-12 15:07:31 -0700 Patch for landing bug-211784-20200512164200.patch text/plain 1891 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmEzZjQ3ODFhZjYyNWRm NWE4ODliYjliYTg5MWJiMGZjMTdhODYxYS4uOTlmNGFkY2QzZDdlYTk5ZWY0ZTgzZWNmNmQxNjFl MDY4OGIxOWZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTEyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XYXR0cmli dXRlIHdhcm5pbmcgaW4gQnJlYWtMaW5lcy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTc4NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgorCisgICAgICAgIFJlbW92ZSBleHBvcnQgYXR0cmlidXRlLiBUaGVzZSBvbmx5IHdv cmsgaW4gaGVhZGVyIGZpbGVzLgorCisgICAgICAgICogcmVuZGVyaW5nL0JyZWFrTGluZXMuY3Bw OgorCiAyMDIwLTA1LTEyICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgog CiAgICAgICAgIFBvc3RlciBzZXQgYWZ0ZXIgcGxheWJhY2sgYmVnaW5zIHNob3VsZCBiZSBpZ25v cmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQnJlYWtMaW5lcy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQnJlYWtMaW5lcy5jcHAKaW5kZXggOWMzMzljZTMy YzY0MDI2MmU2MjhkYzY1ODM3ODgwNWZkNTc0MTU0OC4uZDhmYzM4MTVkMGViZTM2ZDQ1YjFmYmE1 ODVjZTkxNTU1NTQ3YjYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Jy ZWFrTGluZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9CcmVha0xpbmVzLmNw cApAQCAtNTAsNyArNTAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyAtIGFmdGVyICctJyBh bmQgJz8nIChiYWNrd2FyZC1jb21wYXRpYmxlLCBhbmQgY29tcGF0aWJsZSB3aXRoIEludGVybmV0 IEV4cGxvcmVyKS4KIC8vIFBsZWFzZSByZWZlciB0byA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3Njk4PiBmb3IgbGluZSBicmVha2luZyBtYXRyaXhlcyBvZiBkaWZm ZXJlbnQgYnJvd3NlcnMKIC8vIGFuZCB0aGUgSUNVIHN0YW5kYXJkLgotV0VCQ09SRV9FWFBPUlQg Y29uc3QgdW5zaWduZWQgY2hhciBsaW5lQnJlYWtUYWJsZVtdW2xpbmVCcmVha1RhYmxlQ29sdW1u Q291bnRdID0geworY29uc3QgdW5zaWduZWQgY2hhciBsaW5lQnJlYWtUYWJsZVtdW2xpbmVCcmVh a1RhYmxlQ29sdW1uQ291bnRdID0gewogICAgIC8vICAhICAiICAjICAkICAlICAmICAnICAoICAg ICApICAqICArICAsICAtICAuICAvICAwICAxLTggICA5ICA6ICA7ICA8ICA9ICA+ICA/ICBAICAg ICBBLVggICAgICBZICBaICBbICBcICBdICBeICBfICBgICAgICBhLXggICAgICB5ICB6ICB7ICB8 ICB9ICB+ICBERUwKICAgICB7IEIoMCwgMCwgMCwgMCwgMCwgMCwgMCwgMSksIEIoMCwgMCwgMCwg MCwgMCwgMCwgMCwgMCksIDAsIEIoMCwgMCwgMCwgMSwgMCwgMCwgMCwgMCksIDAsIDAsIDAsIEIo MCwgMCwgMSwgMCwgMCwgMCwgMCwgMCksIDAsIDAsIDAsIEIoMCwgMCwgMSwgMCwgMCwgMCwgMCwg MCkgfSwgLy8gIQogICAgIHsgQigwLCAwLCAwLCAwLCAwLCAwLCAwLCAxKSwgQigwLCAwLCAwLCAw LCAwLCAwLCAwLCAwKSwgMCwgQigwLCAwLCAwLCAxLCAwLCAwLCAwLCAwKSwgMCwgMCwgMCwgQigw LCAwLCAxLCAwLCAwLCAwLCAwLCAwKSwgMCwgMCwgMCwgQigwLCAwLCAxLCAwLCAwLCAwLCAwLCAw KSB9LCAvLyAiCg==