211773 2020-05-11 23:55:38 -0700 REGRESSION(r261538): [GTK] API tests are failing 2020-05-12 01:50:19 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211729 InRadar P2 Normal --- 1 dpino mark.lam ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1651646 0 dpino 2020-05-11 23:55:38 -0700 API tests started failing in the interval [r261537-r261541] (See: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)?numbuilds=50). The EWS API-GTK bot reported the tests were failing on r261538 (https://bugs.webkit.org/show_bug.cgi?id=211729) (https://ews-build.webkit.org/#/builders/34/builds/9068). So it was either r261537 or r261538. I run the API tests on r261537 and the tests run fine (only 1 unexpected timeout and 1 unexpected pass), so the regression was introduced in r261538. 1651654 1 399108 mark.lam 2020-05-12 00:56:01 -0700 Created attachment 399108 proposed patch. 1651655 2 399108 mark.lam 2020-05-12 00:59:43 -0700 Comment on attachment 399108 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=399108&action=review > Source/WebKit/ChangeLog:8 > + Previously, we were calling Wasm::enableFastMemory(). By then, it is too late Missing some text here. I meant to say we were calling Wasm::enableFastMemory() in WebProcess::initializeWebProcess(). 1651656 3 399108 ysuzuki 2020-05-12 01:00:55 -0700 Comment on attachment 399108 proposed patch. r=me 1651660 4 mark.lam 2020-05-12 01:48:49 -0700 Diego has tested the patch manually and confirmed that it resolved the API test failures on GTK. I will land it shortly. 1651661 5 mark.lam 2020-05-12 01:49:50 -0700 Landed in r261549: <http://trac.webkit.org/r261549>. 1651663 6 webkit-bug-importer 2020-05-12 01:50:19 -0700 <rdar://problem/63127074> 399108 2020-05-12 00:56:01 -0700 2020-05-12 01:00:55 -0700 proposed patch. bug-211773.patch text/plain 4975 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYxNTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDIwLTA1LTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX YXNtOjplbmFibGVGYXN0TWVtb3J5KCkgd2FzIGNhbGxlZCB0b28gbGF0ZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTc3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIFdhc20gZmFzdCBtZW1vcnkg aXMgdG8gYmUgZW5hYmxlZCwgd2Ugc2hvdWxkIGp1c3QgZG8gaXQgaW4gaW5pdGlhbGl6ZVRocmVh ZGluZygpCisgICAgICAgIGp1c3QgbGlrZSBmb3IgYWxsIHRoZSBvdGhlciBzaWduYWwgaGFuZGxl cnMgdGhhdCBuZWVkIHRvIGJlIGluaXRpYWxpemVkIGZvciBKU0MuCisgICAgICAgIFRoaXMgc2lt cGxpZmllcyBpdHMgaW5pdGlhbGl6YXRpb24gYW5kIGVuc3VyZXMgdGhhdCBpdCBpcyBkb25lIGlu IGEgdGltZWx5IG1hbm5lcgorICAgICAgICBiZWZvcmUgQ29uZmlncyBhcmUgZnJvemVuLgorCisg ICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKGpzY21haW4pOgorICAgICAgICAqIHJ1bnRpbWUv SW5pdGlhbGl6ZVRocmVhZGluZy5jcHA6CisgICAgICAgIChKU0M6OmluaXRpYWxpemVUaHJlYWRp bmcpOgorCiAyMDIwLTA1LTExICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggcHJvYmxlbXMgY2F1Z2h0IGJ5IHJlcGxhY2luZyBXVEY6Ok9wdGlvbmFsIHdpdGgg c3RkOjpvcHRpb25hbApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDI2MTU0OCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYg KzEsNiBAQAogLyoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMCBIYXJyaSBQb3J0ZW4gKHBv cnRlbkBrZGUub3JnKQotICogIENvcHlyaWdodCAoQykgMjAwNC0yMDE5IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDQtMjAyMCBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiAgQ29weXJpZ2h0IChDKSAyMDA2IEJqb2VybiBHcmFm IChiam9lcm4uZ3JhZkBnbWFpbC5jb20pCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNv ZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKQEAgLTc2LDcgKzc2LDYgQEAK ICNpbmNsdWRlICJWTUluc3BlY3Rvci5oIgogI2luY2x1ZGUgIldhc21DYXBhYmlsaXRpZXMuaCIK ICNpbmNsdWRlICJXYXNtQ29udGV4dC5oIgotI2luY2x1ZGUgIldhc21GYXVsdFNpZ25hbEhhbmRs ZXIuaCIKICNpbmNsdWRlICJXYXNtTWVtb3J5LmgiCiAjaW5jbHVkZSA8bG9jYWxlLmg+CiAjaW5j bHVkZSA8bWF0aC5oPgpAQCAtMzIzMSw5ICszMjMwLDYgQEAgaW50IGpzY21haW4oaW50IGFyZ2Ms IGNoYXIqKiBhcmd2KQogICAgIC8vIEluaXRpYWxpemUgSlNDIGJlZm9yZSBnZXR0aW5nIFZNLgog ICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOwogICAgIGluaXRpYWxpemVUaW1lb3V0SWZO ZWVkZWQoKTsKLSNpZiBFTkFCTEUoV0VCQVNTRU1CTFkpCi0gICAgSlNDOjpXYXNtOjplbmFibGVG YXN0TWVtb3J5KCk7Ci0jZW5kaWYKIAogICAgIGJvb2wgZ2lnYWNhZ2VEaXNhYmxlUmVxdWVzdGVk ID0gZmFsc2U7CiAjaWYgR0lHQUNBR0VfRU5BQkxFRCAmJiAhQ09NUElMRVIoTVNWQykKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luaXRpYWxpemVUaHJl YWRpbmcuY3BwCShyZXZpc2lvbiAyNjE1NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Jbml0aWFsaXplVGhyZWFkaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcs NyBAQAogI2luY2x1ZGUgIlZNVHJhcHMuaCIKICNpbmNsdWRlICJXYXNtQ2FsbGVlUmVnaXN0cnku aCIKICNpbmNsdWRlICJXYXNtQ2FwYWJpbGl0aWVzLmgiCisjaW5jbHVkZSAiV2FzbUZhdWx0U2ln bmFsSGFuZGxlci5oIgogI2luY2x1ZGUgIldhc21UaHVua3MuaCIKICNpbmNsdWRlICJXcml0ZUJh cnJpZXIuaCIKICNpbmNsdWRlIDxtdXRleD4KQEAgLTEwNCw2ICsxMDUsOSBAQCB2b2lkIGluaXRp YWxpemVUaHJlYWRpbmcoKQogICAgICAgICBXVEY6OnN0YXJ0TWFjaEV4Y2VwdGlvbkhhbmRsZXJU aHJlYWQoKTsKICNlbmRpZgogICAgICAgICBWTVRyYXBzOjppbml0aWFsaXplU2lnbmFscygpOwor I2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKKyAgICAgICAgV2FzbTo6ZW5hYmxlRmFzdE1lbW9yeSgp OworI2VuZGlmCiAKICAgICAgICAgV1RGOjpjb21waWxlckZlbmNlKCk7CiAgICAgICAgIFJFTEVB U0VfQVNTRVJUKCFnX2pzY0NvbmZpZy5pbml0aWFsaXplVGhyZWFkaW5nSGFzQmVlbkNhbGxlZCk7 CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjYxNTQ4KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAyMC0wNS0xMiAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgV2FzbTo6ZW5hYmxlRmFzdE1lbW9yeSgp IHdhcyBjYWxsZWQgdG9vIGxhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTE3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQcmV2aW91c2x5LCB3ZSB3ZXJlIGNhbGxpbmcgV2FzbTo6ZW5hYmxlRmFz dE1lbW9yeSgpLiAgQnkgdGhlbiwgaXQgaXMgdG9vIGxhdGUKKyAgICAgICAgYmVjYXVzZSB0aGUg SlNDOjpDb25maWcgYW5kIFdURjo6Q29uZmlnIGhhdmUgYWxyZWFkeSBiZWVuIGZyb3plbi4gIFRo ZXJlIGlzCisgICAgICAgIG5vdGhpbmcgc3BlY2lhbCBhYm91dCBXYXNtOjplbmFibGVGYXN0TWVt b3J5KCkgdGhhdCBpdCBuZWVkcyB0byBiZSBjYWxsZWQgdGhpcworICAgICAgICBsYXRlLiAgVGhp cyBwYXRjaCBtb3ZlcyBpdCBpbnRvIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpIHdoZXJlIGl0 IGJlbG9uZ3MuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgYWxzbyBtYWtlIHRoZSBpbml0aWFsaXph dGlvbiBvZiBXYXNtIGZhc3QgbWVtb3J5IGNvbnNpc3RlbnQgd2l0aCBob3cKKyAgICAgICAgd2Ug aGF2ZSBhbHdheXMgZG9uZSBpdCBmb3IgdGhlIGpzYyBzaGVsbCBpLmUuIGl0IGlzIGluaXRpYWxp emVkIGF0IHRoZSBlbmQgb2YKKyAgICAgICAgSlNDOjppbml0aWFsaXplVGhyZWFkaW5nKCkuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzOjppbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMjAtMDUtMTEgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBwcm9ibGVtcyBjYXVnaHQgYnkg cmVwbGFjaW5nIFdURjo6T3B0aW9uYWwgd2l0aCBzdGQ6Om9wdGlvbmFsCkluZGV4OiBTb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAyNjE1NDgpCisrKyBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgz LDcgKzgzLDYgQEAKICNpbmNsdWRlICJXZWJzaXRlRGF0YVR5cGUuaCIKICNpbmNsdWRlIDxKYXZh U2NyaXB0Q29yZS9KU0xvY2suaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9NZW1vcnlTdGF0 aXN0aWNzLmg+Ci0jaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvV2FzbUZhdWx0U2lnbmFsSGFuZGxl ci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvQVhPYmplY3RDYWNoZS5oPgogI2luY2x1ZGUgPFdlYkNv cmUvQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0F1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlLmg+CkBAIC00NjYsMTAgKzQ2NSw2IEBAIHZvaWQgV2ViUHJvY2Vzczo6 aW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2UKICAgICBTZXJ2aWNlV29ya2VyUHJvdmlkZXI6OnNldFNo YXJlZFByb3ZpZGVyKFdlYlNlcnZpY2VXb3JrZXJQcm92aWRlcjo6c2luZ2xldG9uKCkpOwogI2Vu ZGlmCiAKLSNpZiBFTkFCTEUoV0VCQVNTRU1CTFkpCi0gICAgSlNDOjpXYXNtOjplbmFibGVGYXN0 TWVtb3J5KCk7Ci0jZW5kaWYKLQogI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1Mp ICYmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAgIFdlYlJlc291cmNlTG9hZE9ic2VydmVyOjpz ZXRTaG91bGRMb2dVc2VySW50ZXJhY3Rpb24ocGFyYW1ldGVycy5zaG91bGRMb2dVc2VySW50ZXJh Y3Rpb24pOwogI2VuZGlmCg==