211762 2020-05-11 19:59:15 -0700 WPT test importer fails to update references in <link> tags 2020-05-12 04:19:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191460 InRadar P2 Normal --- 207734 1 clopez clopez cdumez clopez ews-watchlist glenn jbedard rniwa webkit-bug-importer youennf oldest_to_newest 1651590 0 clopez 2020-05-11 19:59:15 -0700 When importing WPT tests, the WebKit WPT importer rewrites references inside several tags, but fails to update references inside link tags. This was causing failures when importing the css-flexbox suite in bug 191460 For example the WPT test css/css-flexbox/reference/stretch-input-in-column-ref.html has this: <link href="../support/flexbox.css" rel="stylesheet"> And the test has to be moved from folder css/css-flexbox/reference/ to css/css-flexbox/ in order to be in the same folder than the test. So the link href has to be updated accordingly 1651608 1 399094 clopez 2020-05-11 20:52:22 -0700 Created attachment 399094 Patch 1651682 2 ews-feeder 2020-05-12 04:18:02 -0700 Committed r261552: <https://trac.webkit.org/changeset/261552> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399094. 1651683 3 webkit-bug-importer 2020-05-12 04:19:16 -0700 <rdar://problem/63131152> 399094 2020-05-11 20:52:22 -0700 2020-05-12 04:18:02 -0700 Patch bug-211762-20200512055221.patch text/plain 5952 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNTA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWQ3NTZhZTEwYWQ1YzFkODRjNDA1YzczNjkyMTE3MjY0 MzJhOTNmOC4uYjdhYzU4ZTgxNzg5NTM2ODg4OGJjYzRjNTFiZDNlODg5NmMzMzc2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIwLTA1LTExICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFdQVCB0ZXN0IGltcG9ydGVyIGZhaWxzIHRvIHVwZGF0ZSByZWZl cmVuY2VzIGluIDxsaW5rPiB0YWdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTE3NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIGltcG9ydGluZyBXUFQgdGVzdCByZWZlcmVuY2VzLCBlbnN1cmUg cmVsYXRpdmUgcGF0aHMgYXJlIGFsc28KKyAgICAgICAgdXBkYXRlZCBmb3IgdGhlIGhyZWYgYXR0 cmlidXRlIGluIDxsaW5rPiB0YWdzLgorICAgICAgICBBbHNvIGZpeCBhIGJ1ZyB0aGF0IHdhcyBj YXVzaW5nIHdyb25nIHVwZGF0ZXMgb24gdGhlIHBhdGhzIGR1ZSB0bworICAgICAgICB0aGUgY2hh cmFjdGVycyBpbiByZWZlcmVuY2VfcmVscGF0aCBub3QgZXNjYXBlZCB3aGVuIHBlcmZvcm1pbmcK KyAgICAgICAgdGhlIHJlZ2V4IHN1YnN0aXR1dGlvbiBpbiBjb252ZXJ0X3JlZmVyZW5jZV9yZWxw YXRocygpLiBGb3IgZXhhbXBsZToKKyAgICAgICAgInJlc291cmNlcy9zY3JpcHQuanMiIHdhcyBj aGFuZ2VkIHRvICJyZXNvdXJjc2NyaXB0LmpzIiB3aGVuIHJlZmVyZW5jZV9yZWxwYXRoIHdhcyAn Li4vJworCisgICAgICAgIEltcHJvdmUgYWxzbyB0aGUgdW5pdCB0ZXN0IGNhc2UgdG8gY2hlY2sg Zm9yIHRoZSBmaXhlcyBpbiB0aGlzIHBhdGNoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS93M2MvdGVzdF9jb252ZXJ0ZXIucHk6CisgICAgICAgIChfVzNDVGVzdENvbnZlcnRlci5jb252 ZXJ0X3JlZmVyZW5jZV9yZWxwYXRocyk6CisgICAgICAgIChfVzNDVGVzdENvbnZlcnRlci5jb252 ZXJ0X2F0dHJpYnV0ZXNfaWZfbmVlZGVkKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3cz Yy90ZXN0X2NvbnZlcnRlcl91bml0dGVzdC5weToKKwogMjAyMC0wNS0xMSAgS2F0ZSBDaGVuZXkg IDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBGYWlsIG5hdmlnYXRpb25z IHRvIG5vbiBhcHAtYm91bmQgZG9tYWlucyBhZnRlciB1c2Ugb2YgYXBwLWJvdW5kIEFQSXMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXIucHkKaW5kZXggZDRlMDVl NDUxYTFmYjM5ZjA4YzFlMDFlOGJmMTRhNWEzZmNiMDRiOC4uN2NiYzhmZTliZGMzMTRiMTYyZmJj Y2MzMDgxMzgwOGYwNjkwNjM4ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93 M2MvdGVzdF9jb252ZXJ0ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVz dF9jb252ZXJ0ZXIucHkKQEAgLTE4Niw4ICsxODYsOCBAQCBjbGFzcyBfVzNDVGVzdENvbnZlcnRl cihIVE1MUGFyc2VyKToKICAgICAgICAgICAgIGlmIGNvbnZlcnRlZC5maW5kKHBhdGgpICE9IC0x OgogICAgICAgICAgICAgICAgICMgRklYTUU6IFRoaXMgZG9lc24ndCBoYW5kbGUgYW4gZWRnZSBj YXNlIHdoZXJlIHNpbXBseSByZW1vdmluZyB0aGUgcmVsYXRpdmUgcGF0aCBkb2Vzbid0IHdvcmsu CiAgICAgICAgICAgICAgICAgIyBTZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8xMzU2NzcgZm9yIGRl dGFpbHMuCi0gICAgICAgICAgICAgICAgbmV3X3BhdGggPSByZS5zdWIoc2VsZi5yZWZlcmVuY2Vf c3VwcG9ydF9pbmZvWydyZWZlcmVuY2VfcmVscGF0aCddLCAnJywgcGF0aCwgMSkKLSAgICAgICAg ICAgICAgICBjb252ZXJ0ZWQgPSByZS5zdWIocGF0aCwgbmV3X3BhdGgsIGNvbnZlcnRlZCkKKyAg ICAgICAgICAgICAgICBuZXdfcGF0aCA9IHJlLnN1YihyZS5lc2NhcGUoc2VsZi5yZWZlcmVuY2Vf c3VwcG9ydF9pbmZvWydyZWZlcmVuY2VfcmVscGF0aCddKSwgJycsIHBhdGgsIDEpCisgICAgICAg ICAgICAgICAgY29udmVydGVkID0gcmUuc3ViKHJlLmVzY2FwZShwYXRoKSwgbmV3X3BhdGgsIGNv bnZlcnRlZCkKIAogICAgICAgICByZXR1cm4gY29udmVydGVkCiAKQEAgLTIxOSwxMyArMjE5LDE5 IEBAIGNsYXNzIF9XM0NUZXN0Q29udmVydGVyKEhUTUxQYXJzZXIpOgogICAgICAgICAgICAgICAg IG5ld19zdHlsZSA9IHNlbGYuY29udmVydF9zdHlsZV9kYXRhKGF0dHJbMV0pCiAgICAgICAgICAg ICAgICAgY29udmVydGVkID0gcmUuc3ViKHJlLmVzY2FwZShhdHRyWzFdKSwgbmV3X3N0eWxlLCBj b252ZXJ0ZWQpCiAKKyAgICAgICAgIyBDb252ZXJ0IHJlbGF0aXZlIHBhdGhzCiAgICAgICAgIHNy Y190YWdzID0gKCdzY3JpcHQnLCAnc3R5bGUnLCAnaW1nJywgJ2ZyYW1lJywgJ2lmcmFtZScsICdp bnB1dCcsICdsYXllcicsICd0ZXh0YXJlYScsICd2aWRlbycsICdhdWRpbycpCi0gICAgICAgIGlm IHRhZyBpbiBzcmNfdGFncyBhbmQgc2VsZi5yZWZlcmVuY2Vfc3VwcG9ydF9pbmZvIGlzIG5vdCBO b25lIGFuZCAgc2VsZi5yZWZlcmVuY2Vfc3VwcG9ydF9pbmZvICE9IHt9OgotICAgICAgICAgICAg Zm9yIGF0dHJfbmFtZSwgYXR0cl92YWx1ZSBpbiBhdHRyczoKLSAgICAgICAgICAgICAgICBpZiBh dHRyX25hbWUgPT0gJ3NyYyc6Ci0gICAgICAgICAgICAgICAgICAgIG5ld19wYXRoID0gc2VsZi5j b252ZXJ0X3JlZmVyZW5jZV9yZWxwYXRocyhhdHRyX3ZhbHVlKQotICAgICAgICAgICAgICAgICAg ICBjb252ZXJ0ZWQgPSByZS5zdWIocmUuZXNjYXBlKGF0dHJfdmFsdWUpLCBuZXdfcGF0aCwgY29u dmVydGVkKQotCisgICAgICAgIGlmIHNlbGYucmVmZXJlbmNlX3N1cHBvcnRfaW5mbyBpcyBub3Qg Tm9uZSBhbmQgc2VsZi5yZWZlcmVuY2Vfc3VwcG9ydF9pbmZvICE9IHt9OgorICAgICAgICAgICAg aWYgdGFnIGluIHNyY190YWdzOgorICAgICAgICAgICAgICAgIGZvciBhdHRyX25hbWUsIGF0dHJf dmFsdWUgaW4gYXR0cnM6CisgICAgICAgICAgICAgICAgICAgIGlmIGF0dHJfbmFtZSA9PSAnc3Jj JzoKKyAgICAgICAgICAgICAgICAgICAgICAgIG5ld19wYXRoID0gc2VsZi5jb252ZXJ0X3JlZmVy ZW5jZV9yZWxwYXRocyhhdHRyX3ZhbHVlKQorICAgICAgICAgICAgICAgICAgICAgICAgY29udmVy dGVkID0gcmUuc3ViKHJlLmVzY2FwZShhdHRyX3ZhbHVlKSwgbmV3X3BhdGgsIGNvbnZlcnRlZCkK KyAgICAgICAgICAgIGlmIHRhZyA9PSAnbGluayc6CisgICAgICAgICAgICAgICAgZm9yIGF0dHJf bmFtZSwgYXR0cl92YWx1ZSBpbiBhdHRyczoKKyAgICAgICAgICAgICAgICAgICAgaWYgYXR0cl9u YW1lID09ICdocmVmJzoKKyAgICAgICAgICAgICAgICAgICAgICAgIG5ld19wYXRoID0gc2VsZi5j b252ZXJ0X3JlZmVyZW5jZV9yZWxwYXRocyhhdHRyX3ZhbHVlKQorICAgICAgICAgICAgICAgICAg ICAgICAgY29udmVydGVkID0gcmUuc3ViKHJlLmVzY2FwZShhdHRyX3ZhbHVlKSwgbmV3X3BhdGgs IGNvbnZlcnRlZCkKICAgICAgICAgc2VsZi5jb252ZXJ0ZWRfZGF0YS5hcHBlbmQoY29udmVydGVk KQogCiAgICAgZGVmIGFkZF93ZWJraXRfdGVzdF9ydW5uZXJfb3B0aW9uc19pZl9uZWVkZWQoc2Vs Zik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRl cl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVy X3VuaXR0ZXN0LnB5CmluZGV4IGI5Y2JkMWJlMjkyZDYyNzRiZDRmYmJhYWU3YmMwMDJmN2FjOGVh MGIuLmI3NzJkNmU2MTA3YmZjZjUwMjAzOWFmMTJjMmNjNDQzYjYxYTBmZmYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyX3VuaXR0ZXN0LnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyX3VuaXR0ZXN0LnB5 CkBAIC0yOTYsNiArMjk2LDggQEAgQ09OVEVOVCBPRiBURVNUCiAKICAgICAgICAgdGVzdF9odG1s ID0gIiIiPGh0bWw+CiA8aGVhZD4KKzxsaW5rIGhyZWY9Ii4uL3N1cHBvcnQvYmFzZS1zdHlsZS5j c3MiPgorPHZpZGVvIHNyYz0icmVzb3VyY2VzL3ZpZGVvLm1rdiI+PC92aWRlbz4KIDxzY3JpcHQg c3JjPSIuLi8uLi9zb21lLXNjcmlwdC5qcyI+PC9zY3JpcHQ+CiA8c3R5bGUgc3JjPSIuLi8uLi8u Li9zb21lLXN0eWxlLmNzcyI+PC9zdHlsZT4KIDwvaGVhZD4KQEAgLTMwNCw3ICszMDYsOCBAQCBD T05URU5UIE9GIFRFU1QKIDwvYm9keT4KIDwvaHRtbD4KICIiIgotICAgICAgICB0ZXN0X3JlZmVy ZW5jZV9zdXBwb3J0X2luZm8gPSB7J3JlZmVyZW5jZV9yZWxwYXRoJzogJy4uLycsICdmaWxlcyc6 IFsnLi4vLi4vc29tZS1zY3JpcHQuanMnLCAnLi4vLi4vLi4vc29tZS1zdHlsZS5jc3MnLCAnLi4v Li4vLi4vLi4vc29tZS1pbWFnZS5qcGcnXSwgJ2VsZW1lbnRzJzogWydzY3JpcHQnLCAnc3R5bGUn LCAnaW1nJ119CisgICAgICAgIHRlc3RfcmVmZXJlbmNlX3N1cHBvcnRfaW5mbyA9IHsncmVmZXJl bmNlX3JlbHBhdGgnOiAnLi4vJywgJ2ZpbGVzJzogWycuLi8uLi9zb21lLXNjcmlwdC5qcycsICcu Li8uLi8uLi9zb21lLXN0eWxlLmNzcycsICcuLi8uLi8uLi8uLi9zb21lLWltYWdlLmpwZycsICcu Li9zdXBwb3J0L2Jhc2Utc3R5bGUuY3NzJywgJ3Jlc291cmNlcy92aWRlby5ta3YnXSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdlbGVtZW50cyc6IFsnc2NyaXB0Jywg J3N0eWxlJywgJ2ltZycsICdsaW5rJywgJ3ZpZGVvJ119CiAgICAgICAgIGNvbnZlcnRlciA9IF9X M0NUZXN0Q29udmVydGVyKERVTU1ZX1BBVEgsIERVTU1ZX0ZJTEVOQU1FLCB0ZXN0X3JlZmVyZW5j ZV9zdXBwb3J0X2luZm8pCiAKICAgICAgICAgb2MgPSBPdXRwdXRDYXB0dXJlKCkKQEAgLTQxMCw5 ICs0MTMsMTAgQEAgQ09OVEVOVCBPRiBURVNUCiAgICAgZGVmIHZlcmlmeV9yZWZlcmVuY2VfcmVs YXRpdmVfcGF0aHMoc2VsZiwgY29udmVydGVkLCByZWZlcmVuY2Vfc3VwcG9ydF9pbmZvKToKICAg ICAgICAgaWR4ID0gMAogICAgICAgICBmb3IgcGF0aCBpbiByZWZlcmVuY2Vfc3VwcG9ydF9pbmZv WydmaWxlcyddOgotICAgICAgICAgICAgZXhwZWN0ZWRfcGF0aCA9IHJlLnN1YihyZWZlcmVuY2Vf c3VwcG9ydF9pbmZvWydyZWZlcmVuY2VfcmVscGF0aCddLCAnJywgcGF0aCwgMSkKKyAgICAgICAg ICAgIGV4cGVjdGVkX3BhdGggPSByZS5zdWIocmUuZXNjYXBlKHJlZmVyZW5jZV9zdXBwb3J0X2lu Zm9bJ3JlZmVyZW5jZV9yZWxwYXRoJ10pLCAnJywgcGF0aCwgMSkKICAgICAgICAgICAgIGVsZW1l bnQgPSByZWZlcmVuY2Vfc3VwcG9ydF9pbmZvWydlbGVtZW50cyddW2lkeF0KLSAgICAgICAgICAg IGV4cGVjdGVkX3RhZyA9ICc8JyArIGVsZW1lbnQgKyAnIHNyYz1cIicgKyBleHBlY3RlZF9wYXRo ICsgJ1wiPicKKyAgICAgICAgICAgIGVsZW1lbnRfc3JjID0gJ2hyZWYnIGlmIGVsZW1lbnQgPT0g J2xpbmsnIGVsc2UgJ3NyYycKKyAgICAgICAgICAgIGV4cGVjdGVkX3RhZyA9ICc8JyArIGVsZW1l bnQgKyAnICcgKyBlbGVtZW50X3NyYyArICc9XCInICsgZXhwZWN0ZWRfcGF0aCArICdcIj4nCiAg ICAgICAgICAgICBzZWxmLmFzc2VydFRydWUoZXhwZWN0ZWRfdGFnIGluIGNvbnZlcnRlZFsyXSwg J3JlbGF0aXZlIHBhdGggJyArIHBhdGggKyAnIHdhcyBub3QgY29udmVydGVkIGNvcnJlY3R5JykK ICAgICAgICAgICAgIGlkeCArPSAxCiAK