211756 2020-05-11 17:23:09 -0700 Fix build errors after r260992 2020-05-11 20:53:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211020 InRadar P2 Normal --- 1 yoshiaki.jitsukawa yoshiaki.jitsukawa ashvayka darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1651533 0 yoshiaki.jitsukawa 2020-05-11 17:23:09 -0700 Fix build errors after r260992 1651536 1 399072 yoshiaki.jitsukawa 2020-05-11 17:30:24 -0700 Created attachment 399072 Patch 1651542 2 yoshiaki.jitsukawa 2020-05-11 17:37:28 -0700 I'm not 100% sure this is the best fix. Another way would be to add "JSC::" to the macros in JSObject.h. 1651552 3 399072 ysuzuki 2020-05-11 17:58:55 -0700 Comment on attachment 399072 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399072&action=review Nice catch! I think putting "JSC::" to JSC_TO_STRING_TAG_WITHOUT_TRANSITION is better if this macro is used in WebCore side too. > Source/WebCore/ChangeLog:10 > + Introduce JSC::PropertyAttribute into WebCore::JSDOMIteratorPrototype() since > + PropertyAttribute is used without JSC namespace specifier there > + by JSC_TO_STRING_TAG_WITHOUT_TRANSITION() macro. Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side. 1651560 4 yoshiaki.jitsukawa 2020-05-11 18:24:09 -0700 > Let's put `JSC::` to JSC_TO_STRING_TAG_WITHOUT_TRANSITION side. Will do. Thank you! 1651566 5 399082 yoshiaki.jitsukawa 2020-05-11 18:40:29 -0700 Created attachment 399082 Patch 1651605 6 399082 darin 2020-05-11 20:33:16 -0700 Comment on attachment 399082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399082&action=review > Source/JavaScriptCore/runtime/JSObject.h:1627 > + JSC_NATIVE_INTRINSIC_FUNCTION(jsName, cppName, (attributes), (length), JSC::NoIntrinsic) This is OK. Could also have written ::JSC::NoIntrinsic, which makes this work even when inside a namespace that happens to have the identifier JSC in it. 1651609 7 ews-feeder 2020-05-11 20:52:26 -0700 Committed r261544: <https://trac.webkit.org/changeset/261544> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399082. 1651610 8 webkit-bug-importer 2020-05-11 20:53:14 -0700 <rdar://problem/63119218> 399072 2020-05-11 17:30:24 -0700 2020-05-11 18:40:26 -0700 Patch bug-211756-20200512093022.patch text/plain 1795 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU3NDcwZmUwN2I0MTBj NGJlMmJkZjE3ZjAyMzFkMDg5YTIyYzNhMC4uM2MyNTM0ZjkyY2Y0MjM2ODM4N2NkMmNmNzMxM2E0 NWM1NDhlNDZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTEyICBZb3No aWFraSBKSVRTVUtBV0EgIDx5b3NoaWFraS5qaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAg Rml4IGJ1aWxkIGVycm9ycyBhZnRlciByMjYwOTkyIAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW50cm9kdWNlIEpTQzo6UHJvcGVydHlBdHRyaWJ1dGUg aW50byBXZWJDb3JlOjpKU0RPTUl0ZXJhdG9yUHJvdG90eXBlKCkgc2luY2UKKyAgICAgICAgUHJv cGVydHlBdHRyaWJ1dGUgaXMgdXNlZCB3aXRob3V0IEpTQyBuYW1lc3BhY2Ugc3BlY2lmaWVyIHRo ZXJlCisgICAgICAgIGJ5IEpTQ19UT19TVFJJTkdfVEFHX1dJVEhPVVRfVFJBTlNJVElPTigpIG1h Y3JvLgorCisgICAgICAgIEluIHVuaWZpZWQgYnVpbGQgc29tZSBvZiAuY3BwIGludHJvZHVjZSBK U0MgbmFtZXNwYWNlIGJ1dCBpdCdzIG5vdAorICAgICAgICBhbHdheXMgdGhlIGNhc2UuCisgICAg ICAgICogYmluZGluZ3MvanMvSlNET01JdGVyYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6SXRl cmF0b3JUcmFpdHM+OjpmaW5pc2hDcmVhdGlvbik6CisKIDIwMjAtMDUtMTAgIEFudG9pbmUgUXVp bnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIFJlZmFj dG9yIGFuaW1hdGlvbiBjb21wYXJpc29uIGJ5IGNvbXBvc2l0ZSBvcmRlciBpbiBhIHNpbmdsZSB1 dGlsaXR5IGZ1bmN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RPTUl0ZXJhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9y LmgKaW5kZXggNGRjOGJiZTBiMjkyNTFkZmM2OTQ0OWYyMDQyMGRlODliMTdlYmE2OS4uZDNlNTJh OTY5NDcxZjI2YjA4YTgyNGM2NTYyMTg3M2RiYmNlOGQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNET01JdGVyYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NSXRlcmF0b3IuaApAQCAtMjYyLDYgKzI2Miw3IEBAIHZvaWQgSlNET01J dGVyYXRvclByb3RvdHlwZTxKU1dyYXBwZXIsIEl0ZXJhdG9yVHJhaXRzPjo6ZmluaXNoQ3JlYXRp b24oSlNDOjpWTSYKICAgICBCYXNlOjpmaW5pc2hDcmVhdGlvbih2bSk7CiAgICAgQVNTRVJUKGlu aGVyaXRzKHZtLCBpbmZvKCkpKTsKIAorICAgIHVzaW5nIEpTQzo6UHJvcGVydHlBdHRyaWJ1dGU7 IC8vIEpTQ19UT19TVFJJTkdfVEFHX1dJVEhPVVRfVFJBTlNJVElPTigpIHVzZXMgUHJvcGVydHlB dHRyaWJ1dGUgd2l0aG91dCBKU0MgbmFtZXNwYWNlIHNwZWNpZmllci4KICAgICBKU0NfTkFUSVZF X0lOVFJJTlNJQ19GVU5DVElPTl9XSVRIT1VUX1RSQU5TSVRJT04odm0ucHJvcGVydHlOYW1lcy0+ bmV4dCwgbmV4dCwgMCwgMCwgSlNDOjpOb0ludHJpbnNpYyk7CiAgICAgSlNDX1RPX1NUUklOR19U QUdfV0lUSE9VVF9UUkFOU0lUSU9OKCk7CiB9Cg== 399082 2020-05-11 18:40:29 -0700 2020-05-11 20:52:26 -0700 Patch bug-211756-20200512104028.patch text/plain 3848 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 OWNjODYyZWZhNDUyN2VkZjA0ZTM4MDRiYjIxODhjZDU4NTM2OTYyLi5lMmEwNGQzM2E0YzI0ZTdh NDIxZWI2ZGU3ZTAyMGU0YzIwM2YwMmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wNS0xMiAgWW9zaGlha2kgSklUU1VLQVdBICA8eW9zaGlha2kuaml0 c3VrYXdhQHNvbnkuY29tPgorCisgICAgICAgIEZpeCBidWlsZCBlcnJvcnMgYWZ0ZXIgcjI2MDk5 MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNzU2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEpT QyBuYW1lc3BhY2Ugc3BlY2lmaWVyIHRvIE5vbkludHJpbnNpYyBhbmQgUHJvcGVydHlBdHRyaWJ1 dGUKKyAgICAgICAgaW4gdGhlIG1hY3JvcyBpbiBKU09iamVjdC5oIHNpbmNlIHRob3NlIGNhbiBi ZSB1c2VkIG91dHNpZGUgb2YKKyAgICAgICAgb3Igd2l0aG91dCBpbnRyb2R1Y2luZyBKU0MgbmFt ZXNwYWNlLiAKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0Lmg6CisKIDIwMjAtMDUtMTAgIFJv c3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFtjbGFuZy10 aWR5XSBSdW4gbW9kZXJuaXplLXVzZS1udWxscHRyIG92ZXIgSlNDCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3QuaAppbmRleCBlZjE3N2U5YjZjZmM3MWNjMTQ2NjgyMzcxY2Q1 NmMxMzg2NTdlM2RmLi40Njk4OTRlODEzYTMzMGQ0MjNmYzE0MzEyNmZlZWYwYzE3MzM0NjAzIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKQEAgLTE2MjQsMTAgKzE2 MjQsMTAgQEAgSlNfRVhQT1JUX1BSSVZBVEUgTkVWRVJfSU5MSU5FIGJvb2wgb3JkaW5hcnlTZXRT bG93KEpTR2xvYmFsT2JqZWN0KiwgSlNPYmplY3QqLAogLy8gQXMgYWJvdmUsIGJ1dCB0aGlzIGFz c3VtZXMgdGhhdCB0aGUgZnVuY3Rpb24geW91J3JlIGRlZmluaW5nIGRvZXNuJ3QgaGF2ZSBhbgog Ly8gaW50cmluc2ljLgogI2RlZmluZSBKU0NfTkFUSVZFX0ZVTkNUSU9OKGpzTmFtZSwgY3BwTmFt ZSwgYXR0cmlidXRlcywgbGVuZ3RoKSBcCi0gICAgSlNDX05BVElWRV9JTlRSSU5TSUNfRlVOQ1RJ T04oanNOYW1lLCBjcHBOYW1lLCAoYXR0cmlidXRlcyksIChsZW5ndGgpLCBOb0ludHJpbnNpYykK KyAgICBKU0NfTkFUSVZFX0lOVFJJTlNJQ19GVU5DVElPTihqc05hbWUsIGNwcE5hbWUsIChhdHRy aWJ1dGVzKSwgKGxlbmd0aCksIEpTQzo6Tm9JbnRyaW5zaWMpCiAKICNkZWZpbmUgSlNDX05BVElW RV9GVU5DVElPTl9XSVRIT1VUX1RSQU5TSVRJT04oanNOYW1lLCBjcHBOYW1lLCBhdHRyaWJ1dGVz LCBsZW5ndGgpIFwKLSAgICBKU0NfTkFUSVZFX0lOVFJJTlNJQ19GVU5DVElPTl9XSVRIT1VUX1RS QU5TSVRJT04oanNOYW1lLCBjcHBOYW1lLCAoYXR0cmlidXRlcyksIChsZW5ndGgpLCBOb0ludHJp bnNpYykKKyAgICBKU0NfTkFUSVZFX0lOVFJJTlNJQ19GVU5DVElPTl9XSVRIT1VUX1RSQU5TSVRJ T04oanNOYW1lLCBjcHBOYW1lLCAoYXR0cmlidXRlcyksIChsZW5ndGgpLCBKU0M6Ok5vSW50cmlu c2ljKQogCiAvLyBJZGVudGljYWwgaGVscGVycyBidXQgZm9yIGJ1aWx0aW5zLiBOb3RlIHRoYXQg Y3VycmVudGx5LCB3ZSBkb24ndCBzdXBwb3J0IGJ1aWx0aW5zIHRoYXQgYXJlCiAvLyBhbHNvIGlu dHJpbnNpY3MsIGJ1dCB3ZSBwcm9iYWJseSB3aWxsIGRvIHRoYXQgZXZlbnR1YWxseS4KQEAgLTE2 NDEsMjQgKzE2NDEsMjQgQEAgSlNfRVhQT1JUX1BSSVZBVEUgTkVWRVJfSU5MSU5FIGJvb2wgb3Jk aW5hcnlTZXRTbG93KEpTR2xvYmFsT2JqZWN0KiwgSlNPYmplY3QqLAogCiAjZGVmaW5lIEpTQ19U T19TVFJJTkdfVEFHX1dJVEhPVVRfVFJBTlNJVElPTigpIFwKICAgICBwdXREaXJlY3RXaXRob3V0 VHJhbnNpdGlvbih2bSwgdm0ucHJvcGVydHlOYW1lcy0+dG9TdHJpbmdUYWdTeW1ib2wsIFwKLSAg ICAgICAganNOb250cml2aWFsU3RyaW5nKHZtLCBpbmZvKCktPmNsYXNzTmFtZSksIFByb3BlcnR5 QXR0cmlidXRlOjpEb250RW51bSB8IFByb3BlcnR5QXR0cmlidXRlOjpSZWFkT25seSkKKyAgICAg ICAganNOb250cml2aWFsU3RyaW5nKHZtLCBpbmZvKCktPmNsYXNzTmFtZSksIEpTQzo6UHJvcGVy dHlBdHRyaWJ1dGU6OkRvbnRFbnVtIHwgSlNDOjpQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHkp CiAKIC8vIEhlbHBlciBmb3IgZGVmaW5pbmcgbmF0aXZlIGdldHRlcnMgb24gcHJvcGVydGllcy4K ICNkZWZpbmUgSlNDX05BVElWRV9JTlRSSU5TSUNfR0VUVEVSKGpzTmFtZSwgY3BwTmFtZSwgYXR0 cmlidXRlcywgaW50cmluc2ljKSAgXAogICAgIHB1dERpcmVjdE5hdGl2ZUludHJpbnNpY0dldHRl cihcCiAgICAgICAgIHZtLCBnbG9iYWxPYmplY3QsIG1ha2VJZGVudGlmaWVyKHZtLCAoanNOYW1l KSksIChjcHBOYW1lKSwgXAotICAgICAgICAoaW50cmluc2ljKSwgKChhdHRyaWJ1dGVzKSB8IFBy b3BlcnR5QXR0cmlidXRlOjpBY2Nlc3NvcikpCisgICAgICAgIChpbnRyaW5zaWMpLCAoKGF0dHJp YnV0ZXMpIHwgSlNDOjpQcm9wZXJ0eUF0dHJpYnV0ZTo6QWNjZXNzb3IpKQogCiAjZGVmaW5lIEpT Q19OQVRJVkVfSU5UUklOU0lDX0dFVFRFUl9XSVRIT1VUX1RSQU5TSVRJT04oanNOYW1lLCBjcHBO YW1lLCBhdHRyaWJ1dGVzLCBpbnRyaW5zaWMpICBcCiAgICAgcHV0RGlyZWN0TmF0aXZlSW50cmlu c2ljR2V0dGVyV2l0aG91dFRyYW5zaXRpb24oXAogICAgICAgICB2bSwgZ2xvYmFsT2JqZWN0LCBt YWtlSWRlbnRpZmllcih2bSwgKGpzTmFtZSkpLCAoY3BwTmFtZSksIFwKLSAgICAgICAgKGludHJp bnNpYyksICgoYXR0cmlidXRlcykgfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6QWNjZXNzb3IpKQorICAg ICAgICAoaW50cmluc2ljKSwgKChhdHRyaWJ1dGVzKSB8IEpTQzo6UHJvcGVydHlBdHRyaWJ1dGU6 OkFjY2Vzc29yKSkKIAogI2RlZmluZSBKU0NfTkFUSVZFX0dFVFRFUihqc05hbWUsIGNwcE5hbWUs IGF0dHJpYnV0ZXMpIFwKLSAgICBKU0NfTkFUSVZFX0lOVFJJTlNJQ19HRVRURVIoKGpzTmFtZSks IChjcHBOYW1lKSwgKGF0dHJpYnV0ZXMpLCBOb0ludHJpbnNpYykKKyAgICBKU0NfTkFUSVZFX0lO VFJJTlNJQ19HRVRURVIoKGpzTmFtZSksIChjcHBOYW1lKSwgKGF0dHJpYnV0ZXMpLCBKU0M6Ok5v SW50cmluc2ljKQogCiAjZGVmaW5lIEpTQ19OQVRJVkVfR0VUVEVSX1dJVEhPVVRfVFJBTlNJVElP Tihqc05hbWUsIGNwcE5hbWUsIGF0dHJpYnV0ZXMpIFwKLSAgICBKU0NfTkFUSVZFX0lOVFJJTlNJ Q19HRVRURVJfV0lUSE9VVF9UUkFOU0lUSU9OKChqc05hbWUpLCAoY3BwTmFtZSksIChhdHRyaWJ1 dGVzKSwgTm9JbnRyaW5zaWMpCisgICAgSlNDX05BVElWRV9JTlRSSU5TSUNfR0VUVEVSX1dJVEhP VVRfVFJBTlNJVElPTigoanNOYW1lKSwgKGNwcE5hbWUpLCAoYXR0cmlidXRlcyksIEpTQzo6Tm9J bnRyaW5zaWMpCiAKIAogI2RlZmluZSBTVEFUSUNfQVNTRVJUX0lTT19TVUJTUEFDRV9TSEFSQUJM RShEZXJpdmVkQ2xhc3MsIEJhc2VDbGFzcykgXAo=