211749 2020-05-11 15:11:07 -0700 [bmalloc][WTF] Add computing memory size implementation for FreeBSD 2020-05-11 20:07:14 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke benjamin cdumez cmarcelo ddkilzer ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1651472 0 basuke 2020-05-11 15:11:07 -0700 using sysinfo(3) https://www.freebsd.org/cgi/man.cgi?query=sysinfo&apropos=0&sektion=3&manpath=FreeBSD+9-current&format=html 1651503 1 399063 basuke 2020-05-11 16:06:50 -0700 Created attachment 399063 PATCH 1651579 2 399063 ddkilzer 2020-05-11 19:31:53 -0700 Comment on attachment 399063 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=399063&action=review r=me > Source/WTF/wtf/RAMSize.cpp:60 > sysinfo(&si); Should we assert that the return value here is zero (similar to what bmalloc does)? Would also be nice to use `info` like bmalloc. Neither of these are necessary to land this patch. 1651598 3 ews-feeder 2020-05-11 20:06:28 -0700 Committed r261543: <https://trac.webkit.org/changeset/261543> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399063. 1651599 4 webkit-bug-importer 2020-05-11 20:07:14 -0700 <rdar://problem/63117982> 399063 2020-05-11 16:06:50 -0700 2020-05-11 20:06:29 -0700 PATCH bug-211749.diff text/plain 2829 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMjA2ZGQ3MmJlMzdjLi5iYTJhNjUyZTFiNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjAtMDUtMTEgIEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgorCisgICAg ICAgIFtibWFsbG9jXVtXVEZdIEFkZCBjb21wdXRpbmcgbWVtb3J5IHNpemUgaW1wbGVtZW50YXRp b24gZm9yIEZyZWVCU0QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMTc0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNoYXJlIHN5c2luZm8oMykgaW1wbGVtZW50YXRpb24gd2l0aCBMaW51eCBhbmQgRnJl ZUJTRC4KKworICAgICAgICAqIHd0Zi9SQU1TaXplLmNwcDoKKyAgICAgICAgKFdURjo6Y29tcHV0 ZVJBTVNpemUpOgorCiAyMDIwLTA1LTEwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgY29weSBjb25zdHJ1Y3RvciBhbmQgYXNzaWdubWVudCBvcGVyYXRvciB0 byBSZWY8PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUkFNU2l6ZS5jcHAgYi9Tb3VyY2Uv V1RGL3d0Zi9SQU1TaXplLmNwcAppbmRleCAyODI3ODhlOTg2NDEuLmRkM2QwYzI3YWFlZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvUkFNU2l6ZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYv UkFNU2l6ZS5jcHAKQEAgLTU0LDE0ICs1NCwxNCBAQCBzdGF0aWMgc2l6ZV90IGNvbXB1dGVSQU1T aXplKCkKICAgICBpZiAoIXJlc3VsdCkKICAgICAgICAgcmV0dXJuIHJhbVNpemVHdWVzczsKICAg ICByZXR1cm4gc3RhdHVzLnVsbFRvdGFsUGh5czsKLSNlbGlmIGRlZmluZWQoVVNFX1NZU1RFTV9N QUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DCi0jaWYgT1MoTElOVVgpCisjZWxpZiBVU0UoU1lT VEVNX01BTExPQykKKyNpZiBPUyhMSU5VWCkgfHwgT1MoRlJFRUJTRCkKICAgICBzdHJ1Y3Qgc3lz aW5mbyBzaTsKICAgICBzeXNpbmZvKCZzaSk7CiAgICAgcmV0dXJuIHNpLnRvdGFscmFtICogc2ku bWVtX3VuaXQ7CiAjZWxzZQogI2Vycm9yICJNaXNzaW5nIGEgcGxhdGZvcm0gc3BlY2lmaWMgd2F5 IG9mIGRldGVybWluaW5nIHRoZSBhdmFpbGFibGUgUkFNIgotI2VuZGlmIC8vIE9TKExJTlVYKQor I2VuZGlmIC8vIE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKQogI2Vsc2UKICAgICByZXR1cm4gYm1h bGxvYzo6YXBpOjphdmFpbGFibGVNZW1vcnkoKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNl L2JtYWxsb2MvQ2hhbmdlTG9nIGIvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCmluZGV4IGM3ODU2 N2M2NzJhOS4uMWNjOTE0YzI1ZDAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VM b2cKKysrIGIvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAt MDUtMTEgIEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgorCisgICAgICAg IFtibWFsbG9jXVtXVEZdIEFkZCBjb21wdXRpbmcgbWVtb3J5IHNpemUgaW1wbGVtZW50YXRpb24g Zm9yIEZyZWVCU0QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMTc0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYm1hbGxvYy9BdmFpbGFibGVNZW1vcnkuY3BwOgorICAgICAgICAoYm1hbGxvYzo6Y29t cHV0ZUF2YWlsYWJsZU1lbW9yeSk6CisKIDIwMjAtMDUtMDkgIERvbiBPbG1zdGVhZCAgPGRvbi5v bG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFVzZSBXRUJLSVRfRVhFQ1VUQUJM RSBpbiBNYWxsb2NCZW5jaApkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFp bGFibGVNZW1vcnkuY3BwIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BdmFpbGFibGVNZW1vcnku Y3BwCmluZGV4IDA0MTAwMTViYTE5NS4uOTBmZjcwOTYxMjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0F2YWlsYWJsZU1lbW9yeS5jcHAKKysrIGIvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9BdmFpbGFibGVNZW1vcnkuY3BwCkBAIC01MCw2ICs1MCw3IEBACiAjZWxpZiBCT1Mo RlJFRUJTRCkKICNpbmNsdWRlICJWTUFsbG9jYXRlLmgiCiAjaW5jbHVkZSA8c3lzL3N5c2N0bC5o PgorI2luY2x1ZGUgPHN5cy9zeXNpbmZvLmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5j bHVkZSA8c3lzL3VzZXIuaD4KICNlbmRpZgpAQCAtMTY4LDYgKzE2OSwxMSBAQCBzdGF0aWMgc2l6 ZV90IGNvbXB1dGVBdmFpbGFibGVNZW1vcnkoKQogICAgIHJldHVybiAoKHNpemVBY2NvcmRpbmdU b0tlcm5lbCArIG11bHRpcGxlIC0gMSkgLyBtdWx0aXBsZSkgKiBtdWx0aXBsZTsKICNlbGlmIEJP UyhMSU5VWCkKICAgICByZXR1cm4gTGludXhNZW1vcnk6OnNpbmdsZXRvbigpLmF2YWlsYWJsZU1l bW9yeTsKKyNlbGlmIEJPUyhGUkVFQlNEKQorICAgIHN0cnVjdCBzeXNpbmZvIGluZm87CisgICAg aWYgKCFzeXNpbmZvKCZpbmZvKSkKKyAgICAgICAgcmV0dXJuIGluZm8udG90YWxyYW0gKiBpbmZv Lm1lbV91bml0OworICAgIHJldHVybiBhdmFpbGFibGVNZW1vcnlHdWVzczsKICNlbGlmIEJPUyhV TklYKQogICAgIGxvbmcgcGFnZXMgPSBzeXNjb25mKF9TQ19QSFlTX1BBR0VTKTsKICAgICBsb25n IHBhZ2VTaXplID0gc3lzY29uZihfU0NfUEFHRV9TSVpFKTsK