211705 2020-05-10 16:36:42 -0700 Add copy constructor and assignment operator to Ref<> 2020-06-12 13:34:44 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin benjamin cdumez cmarcelo dbates esprehn+autocc ews-watchlist ggaren kangil.han kling sam webkit-bug-importer oldest_to_newest 1651138 0 darin 2020-05-10 16:36:42 -0700 Add copy constructor and assignment operator to Ref<> 1651141 1 398986 darin 2020-05-10 16:42:46 -0700 Created attachment 398986 Patch 1651143 2 398986 darin 2020-05-10 16:46:11 -0700 Comment on attachment 398986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398986&action=review > Source/WTF/ChangeLog:19 > + These follow a similar patter to the move constructor and assignment operator. probably should spell it "pattern". 1651185 3 cdumez 2020-05-10 22:32:10 -0700 I am glad Ref will finally have this. 1651188 4 darin 2020-05-10 23:15:01 -0700 Committed r261467: <https://trac.webkit.org/changeset/261467> 1651189 5 webkit-bug-importer 2020-05-10 23:15:18 -0700 <rdar://problem/63077127> 1661552 6 kling 2020-06-11 04:24:24 -0700 Great change! :) In retrospect, efforts to avoid refcount churn are probably best limited to situations where it has a measurable impact on performance, and should not be a goal in itself. 1662121 7 darin 2020-06-12 13:34:44 -0700 Thank you, sir. Great to get a vote of confidence from the "founder of the [Ref class template] feast". 398986 2020-05-10 16:42:46 -0700 2020-05-10 18:49:05 -0700 Patch bug-211705-20200510164245.patch text/plain 6211 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGEwOTYxZmVmNzM1MDcwOGZhY2E5YzQz Mjk2NTc4YTJlNGNkNDRiOTIuLjkxZjIxMDM5NTAzZThlZDM3ODIwYzYwYjI4ZjRhOTAwN2YxMWRk MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDUtMTAgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIEFkZCBjb3B5IGNvbnN0cnVjdG9yIGFuZCBhc3NpZ25tZW50 IG9wZXJhdG9yIHRvIFJlZjw+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTE3MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBcyByZWNlbnRseSBkaXNjdXNzZWQgaW4gc29tZSBXZWJLaXQgYnVnIHBhdGNo IHJldmlldywgd2UgdGhpbmsgdGhhdCBSZWYgYW5kIFJlZlB0cgorICAgICAgICBzaG91bGQgaGF2 ZSB0aGUgc2FtZSBkZXNpZ24sIGV4Y2VwdCBmb3Igd2hldGhlciB0aGUgdmFsdWUgY2FuIGJlIG51 bGwuIFJlZiBoYWQgYQorICAgICAgICBtb3JlIGFtYml0aW91cyBhcHByb2FjaCB0byBhdm9pZGlu ZyByZWZlcmVuY2UgY291bnQgY2h1cm4sIHJlcXVpcmluZyBhCisgICAgICAgIGNhbGwgdG8gY29w eVJlZiB0byBtYWtlIGFueSBjb3B5aW5nIGV4cGxpY2l0LCBwYXJ0bHkgYnkgYW5hbG9neSB3aXRo IHJhdyBDCisgICAgICAgIHJlZmVyZW5jZXMsIHdoaWNoIGFsc28gY2FuJ3QgYmUgY29waWVkIChi dXQgdGhleSBjYW4ndCBiZSBtb3ZlZCBlaXRoZXIpLiBXZSBjaG9vc2UKKyAgICAgICAgdG8gY2hh bmdlIFJlZiB0byBtYXRjaCBSZWZQdHIgYW5kIHRvIHRha2UgdGhlIHJpc2sgb2YgYWRkaXRpb25h bCBjaHVybi4gVGhpcyBtYWtlcworICAgICAgICBpdCBlYXNpZXIgdG8gdXNlIFJlZiBpbiBjb250 ZXh0cyBsaWtlIGNvbGxlY3Rpb24gY2xhc3NlcyBhbmQgc3RydWN0dXJlcy4gQW4KKyAgICAgICAg YWx0ZXJuYXRpdmUgd291bGQgYmUgdG8gZ28gdGhlIG90aGVyIGRpcmVjdGlvbiwgYW5kIG1ha2Ug UmVmUHRyIHJlcXVpcmUgYSBjYWxsIHRvCisgICAgICAgIGNvcHlSZWY6IHNlZW1zIGxpa2UgYW4g b2J2aW91c2x5IHdvcnNlIG9wdGlvbi4KKworICAgICAgICAqIHd0Zi9SZWYuaDogQWRkIHRoZSBj b3B5IGNvbnN0cnVjdG9yIGFuZCBhc3NpZ25tZW50IG9wZXJhdG9yLgorICAgICAgICBUaGVzZSBm b2xsb3cgYSBzaW1pbGFyIHBhdHRlciB0byB0aGUgbW92ZSBjb25zdHJ1Y3RvciBhbmQgYXNzaWdu bWVudCBvcGVyYXRvci4KKyAgICAgICAgQWxzbyBhZGQgYSBkZXByZWNhdGlvbiBjb21tZW50IGJl Zm9yZSBjb3B5UmVmLCB3aGljaCB3ZSB3aWxsIGV2ZW50dWFsbHkgcmVtb3ZlLgorCiAyMDIwLTA1 LTA5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWxldGUgc29t ZSBkZWFkIGNvZGUgaW4gV29ya1F1ZXVlQ29jb2EuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZjOTIzZTIy YjU4NDJmOWJkMTMyYTAxNjRhZDQ2ZDc5NjE0NWYzMi4uYmI4YjI1YTM5NWFiZTk5NjM2MDY1YTg4 OGU1MzZiNjIzZmZhN2U4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTEw ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgY29weSBjb25z dHJ1Y3RvciBhbmQgYXNzaWdubWVudCBvcGVyYXRvciB0byBSZWY8PgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNzA1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vQm91bmRhcnlQb2ludC5oOiBB cyBhIHRlc3Qgb2YgdGhlIGNoYW5nZSB0byBSZWYsIHJlbW92ZSB0aGUgZXhwbGljaXQKKyAgICAg ICAgY29weSBhbmQgbW92ZSBjb25zdHJ1Y3RvcnMgYW5kIGFzc2lnbm1lbnQgb3BlcmF0b3JzLCBy ZWx5aW5nIG9uIHRoZSBkZWZhdWx0cworICAgICAgICBpbnN0ZWFkLCB3aGljaCBhcmUgbm93IGV4 YWN0bHkgd2hhdCB3ZSB3YW50LgorCiAyMDIwLTA1LTA5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBUaWdodGVuIHVwIGxvZ2ljIGluIERvY3VtZW50VGltZWxpbmVz Q29udHJvbGxlcjo6dXBkYXRlQW5pbWF0aW9uc0FuZFNlbmRFdmVudHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1JlZi5oIGIvU291cmNlL1dURi93dGYvUmVmLmgKaW5kZXggMWFiODIxMWMz NWI3ZDU3ZDk4MDg2YWU5NjFhZjY5NjA3YjQ5ZjgwMi4uNjJlMjIzZGY1M2YwMTk4OTcxMmUwMjE0 Yzc1NjZjOTA4YWI3MTMwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUmVmLmgKKysrIGIv U291cmNlL1dURi93dGYvUmVmLmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChD KSAyMDEzLTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSAyMDEzLTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC02Nyw5ICs2NywxNyBAQCBwdWJsaWM6CiAgICAgICAg IG9iamVjdC5yZWYoKTsKICAgICB9CiAKLSAgICAvLyBVc2UgY29weVJlZigpIGluc3RlYWQuCi0g ICAgUmVmKGNvbnN0IFJlZiYgb3RoZXIpID0gZGVsZXRlOwotICAgIHRlbXBsYXRlPHR5cGVuYW1l IFgsIHR5cGVuYW1lIFk+IFJlZihjb25zdCBSZWY8WCwgWT4mIG90aGVyKSA9IGRlbGV0ZTsKKyAg ICBSZWYoY29uc3QgUmVmJiBvdGhlcikKKyAgICAgICAgOiBtX3B0cihvdGhlci5wdHIoKSkKKyAg ICB7CisgICAgICAgIG1fcHRyLT5yZWYoKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBYLCB0eXBlbmFtZSBZPiBSZWYoY29uc3QgUmVmPFgsIFk+JiBvdGhlcikKKyAgICAgICAgOiBt X3B0cihvdGhlci5wdHIoKSkKKyAgICB7CisgICAgICAgIG1fcHRyLT5yZWYoKTsKKyAgICB9CiAK ICAgICBSZWYoUmVmJiYgb3RoZXIpCiAgICAgICAgIDogbV9wdHIoJm90aGVyLmxlYWtSZWYoKSkK QEAgLTg4LDkgKzk2LDggQEAgcHVibGljOgogICAgIFJlZiYgb3BlcmF0b3I9KFJlZiYmKTsKICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBYLCB0eXBlbmFtZSBZPiBSZWYmIG9wZXJhdG9yPShSZWY8WCwg WT4mJik7CiAKLSAgICAvLyBVc2UgY29weVJlZigpIGFuZCB0aGUgbW92ZSBhc3NpZ25tZW50IG9w ZXJhdG9ycyBpbnN0ZWFkLgotICAgIFJlZiYgb3BlcmF0b3I9KGNvbnN0IFJlZiYpID0gZGVsZXRl OwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFgsIHR5cGVuYW1lIFk+IFJlZiYgb3BlcmF0b3I9KGNv bnN0IFJlZjxYLCBZPiYpID0gZGVsZXRlOworICAgIFJlZiYgb3BlcmF0b3I9KGNvbnN0IFJlZiYp OworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFgsIHR5cGVuYW1lIFk+IFJlZiYgb3BlcmF0b3I9KGNv bnN0IFJlZjxYLCBZPiYpOwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgWCwgdHlwZW5hbWUgWT4g dm9pZCBzd2FwKFJlZjxYLCBZPiYpOwogCkBAIC0xMjQsNiArMTMxLDcgQEAgcHVibGljOgogCiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgWCwgdHlwZW5hbWUgWT4gUmVmPFQsIFB0clRyYWl0cz4gcmVw bGFjZShSZWY8WCwgWT4mJikgV0FSTl9VTlVTRURfUkVUVVJOOwogCisgICAgLy8gVGhlIGZvbGxv d2luZyBmdW5jdGlvbiBpcyBkZXByZWNhdGVkLgogICAgIFJlZiBjb3B5UmVmKCkgJiYgPSBkZWxl dGU7CiAgICAgUmVmIGNvcHlSZWYoKSBjb25zdCAmIFdBUk5fVU5VU0VEX1JFVFVSTiB7IHJldHVy biBSZWYoKm1fcHRyKTsgfQogCkBAIC0xODcsNiArMTk1LDMxIEBAIGlubGluZSBSZWY8VCwgVT4m IFJlZjxULCBVPjo6b3BlcmF0b3I9KFJlZjxYLCBZPiYmIHJlZmVyZW5jZSkKICAgICByZXR1cm4g KnRoaXM7CiB9CiAKK3RlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+CitpbmxpbmUgUmVm PFQsIFU+JiBSZWY8VCwgVT46Om9wZXJhdG9yPShjb25zdCBSZWYmIHJlZmVyZW5jZSkKK3sKKyNp ZiBBU0FOX0VOQUJMRUQKKyAgICBpZiAoX19hc2FuX2FkZHJlc3NfaXNfcG9pc29uZWQodGhpcykp CisgICAgICAgIF9fYXNhbl91bnBvaXNvbl9tZW1vcnlfcmVnaW9uKHRoaXMsIHNpemVvZigqdGhp cykpOworI2VuZGlmCisgICAgUmVmIGNvcGllZFJlZmVyZW5jZSA9IHJlZmVyZW5jZTsKKyAgICBz d2FwKGNvcGllZFJlZmVyZW5jZSk7CisgICAgcmV0dXJuICp0aGlzOworfQorCit0ZW1wbGF0ZTx0 eXBlbmFtZSBULCB0eXBlbmFtZSBVPgordGVtcGxhdGU8dHlwZW5hbWUgWCwgdHlwZW5hbWUgWT4K K2lubGluZSBSZWY8VCwgVT4mIFJlZjxULCBVPjo6b3BlcmF0b3I9KGNvbnN0IFJlZjxYLCBZPiYg cmVmZXJlbmNlKQoreworI2lmIEFTQU5fRU5BQkxFRAorICAgIGlmIChfX2FzYW5fYWRkcmVzc19p c19wb2lzb25lZCh0aGlzKSkKKyAgICAgICAgX19hc2FuX3VucG9pc29uX21lbW9yeV9yZWdpb24o dGhpcywgc2l6ZW9mKCp0aGlzKSk7CisjZW5kaWYKKyAgICBSZWYgY29waWVkUmVmZXJlbmNlID0g cmVmZXJlbmNlOworICAgIHN3YXAoY29waWVkUmVmZXJlbmNlKTsKKyAgICByZXR1cm4gKnRoaXM7 Cit9CisKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+CiB0ZW1wbGF0ZTx0eXBlbmFt ZSBYLCB0eXBlbmFtZSBZPgogaW5saW5lIHZvaWQgUmVmPFQsIFU+Ojpzd2FwKFJlZjxYLCBZPiYg b3RoZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQm91bmRhcnlQb2ludC5oIGIv U291cmNlL1dlYkNvcmUvZG9tL0JvdW5kYXJ5UG9pbnQuaAppbmRleCA0YjIyYTMxYWMxMWE5NjU0 OGU5OWY2NjgxODE1ZjQyNjJmNDEyZDBjLi41ZjhlNDc2NDNhODNiODU3ZDhjODE1YTQ1NjE2MTkx NjViZTUzNGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQm91bmRhcnlQb2ludC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Cb3VuZGFyeVBvaW50LmgKQEAgLTM1LDEyICszNSw2 IEBAIHN0cnVjdCBCb3VuZGFyeVBvaW50IHsKIAogICAgIEJvdW5kYXJ5UG9pbnQoUmVmPE5vZGU+ JiYsIHVuc2lnbmVkKTsKIAotICAgIC8vIFVubGlrZSBSZWYsIHdlIGFsbG93IGNvcHlpbmcgYSBC b3VuZGFyeVBvaW50IHdpdGhvdXQgYW4gZXhwbGljaXQgY29weVJlZigpLgotICAgIEJvdW5kYXJ5 UG9pbnQoY29uc3QgQm91bmRhcnlQb2ludCYpOwotICAgIEJvdW5kYXJ5UG9pbnQoQm91bmRhcnlQ b2ludCYmKSA9IGRlZmF1bHQ7Ci0gICAgQm91bmRhcnlQb2ludCYgb3BlcmF0b3I9KGNvbnN0IEJv dW5kYXJ5UG9pbnQmKTsKLSAgICBCb3VuZGFyeVBvaW50JiBvcGVyYXRvcj0oQm91bmRhcnlQb2lu dCYmKSA9IGRlZmF1bHQ7Ci0KICAgICBEb2N1bWVudCYgZG9jdW1lbnQoKSBjb25zdDsKIH07CiAK QEAgLTU1LDE5ICs0OSw2IEBAIGlubGluZSBCb3VuZGFyeVBvaW50OjpCb3VuZGFyeVBvaW50KFJl ZjxOb2RlPiYmIGNvbnRhaW5lciwgdW5zaWduZWQgb2Zmc2V0KQogewogfQogCi1pbmxpbmUgQm91 bmRhcnlQb2ludDo6Qm91bmRhcnlQb2ludChjb25zdCBCb3VuZGFyeVBvaW50JiBvdGhlcikKLSAg ICA6IGNvbnRhaW5lcihvdGhlci5jb250YWluZXIuY29weVJlZigpKQotICAgICwgb2Zmc2V0KG90 aGVyLm9mZnNldCkKLXsKLX0KLQotaW5saW5lIEJvdW5kYXJ5UG9pbnQmIEJvdW5kYXJ5UG9pbnQ6 Om9wZXJhdG9yPShjb25zdCBCb3VuZGFyeVBvaW50JiBvdGhlcikKLXsKLSAgICBjb250YWluZXIg PSBvdGhlci5jb250YWluZXIuY29weVJlZigpOwotICAgIG9mZnNldCA9IG90aGVyLm9mZnNldDsK LSAgICByZXR1cm4gKnRoaXM7Ci19Ci0KIGlubGluZSBEb2N1bWVudCYgQm91bmRhcnlQb2ludDo6 ZG9jdW1lbnQoKSBjb25zdAogewogICAgIHJldHVybiBjb250YWluZXItPmRvY3VtZW50KCk7Cg==