211698 2020-05-10 09:51:38 -0700 Use alias template to define `match_constness` in Wtf/wtp/TypeCasts.h 2020-05-11 01:15:08 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 211714 1 tetsuharu.ohzeki webkit-unassigned benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1651089 0 tetsuharu.ohzeki 2020-05-10 09:51:38 -0700 This is pretty trivial change.... May I change this? 1651093 1 398977 tetsuharu.ohzeki 2020-05-10 10:27:40 -0700 Created attachment 398977 Patch 1651121 2 398977 ysuzuki 2020-05-10 14:49:08 -0700 Comment on attachment 398977 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398977&action=review r=me with nit. > Source/WTF/wtf/TypeCasts.h:71 > +using match_constness = > + typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type; `match_correctness` looks like not following to the WebKit's naming convention. Based on https://bugs.webkit.org/show_bug.cgi?id=140905#c4, I guess that this is intentionally using C++ STL's naming convention here. Then, can you change this to `match_constness_t`? When using alias template and generating type without using `::type`, C++ STL uses `_t` suffix. e.g. https://en.cppreference.com/w/cpp/types/make_signed 1651154 3 398990 tetsuharu.ohzeki 2020-05-10 18:47:07 -0700 Created attachment 398990 Patch 1651157 4 398990 tetsuharu.ohzeki 2020-05-10 18:55:06 -0700 Comment on attachment 398990 Patch Yusuke, could you review this patch again? 1651179 5 ews-feeder 2020-05-10 21:46:17 -0700 Committed r261465: <https://trac.webkit.org/changeset/261465> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398990. 1651180 6 webkit-bug-importer 2020-05-10 21:47:16 -0700 <rdar://problem/63075552> 1651191 7 398990 darin 2020-05-10 23:18:09 -0700 Comment on attachment 398990 Patch Surprised that the standard library doesn’t have something like this. 1651195 8 398990 darin 2020-05-10 23:40:23 -0700 Comment on attachment 398990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398990&action=review > Source/WTF/wtf/TypeCasts.h:71 > + typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type; As long as we are modernizing, should use conditional_t, is_const_v, add_const_t, and remove_const_t. 398977 2020-05-10 10:27:40 -0700 2020-05-10 18:47:03 -0700 Patch bug-211698-20200511022728.patch text/plain 2682 tetsuharu.ohzeki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGEwOTYxZmVmNzM1MDcwOGZhY2E5YzQz Mjk2NTc4YTJlNGNkNDRiOTIuLjVhZWRhMTJjNjFlZTlkMTM4YjEyZDRjYzM4Njg2MTE2ZmI5ZGU2 NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMTAgIFRldHN1aGFydSBPaHpla2kgIDx0 ZXRzdWhhcnUub2h6ZWtpQGdtYWlsLmNvbT4KKworICAgICAgICBVc2UgYWxpYXMgdGVtcGxhdGUg dG8gZGVmaW5lIGBtYXRjaF9jb25zdG5lc3NgIGluIFd0Zi93dHAvVHlwZUNhc3RzLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTY5OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1R5cGVDYXN0 cy5oOgorICAgICAgICAoV1RGOjpkb3duY2FzdCk6CisKIDIwMjAtMDUtMDkgIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIERlbGV0ZSBzb21lIGRlYWQgY29kZSBpbiBX b3JrUXVldWVDb2NvYS5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1R5cGVDYXN0cy5o IGIvU291cmNlL1dURi93dGYvVHlwZUNhc3RzLmgKaW5kZXggNmViNjNlNWI5MTljOWI3NTVkOGY1 NWIyNDg1ZjE2MDhiMTAwNDY0Yi4uOWIyZTYzYjQ1NGY4MDM4MDhhNzFmNDk3NjBkNmU5Yzg4ZTM5 Mjk3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVHlwZUNhc3RzLmgKKysrIGIvU291cmNl L1dURi93dGYvVHlwZUNhc3RzLmgKQEAgLTY3LDI2ICs2NywyNSBAQCBpbmxpbmUgYm9vbCBpcyhB cmdUeXBlKiBzb3VyY2UpCiAKIC8vIFVwZGF0ZSBUJ3MgY29uc3RuZXNzIHRvIG1hdGNoIFJlZmVy ZW5jZSdzLgogdGVtcGxhdGUgPHR5cGVuYW1lIFJlZmVyZW5jZSwgdHlwZW5hbWUgVD4KLXN0cnVj dCBtYXRjaF9jb25zdG5lc3MgewotICAgIHR5cGVkZWYgdHlwZW5hbWUgc3RkOjpjb25kaXRpb25h bDxzdGQ6OmlzX2NvbnN0PFJlZmVyZW5jZT46OnZhbHVlLCB0eXBlbmFtZSBzdGQ6OmFkZF9jb25z dDxUPjo6dHlwZSwgdHlwZW5hbWUgc3RkOjpyZW1vdmVfY29uc3Q8VD46OnR5cGU+Ojp0eXBlIHR5 cGU7Ci19OwordXNpbmcgbWF0Y2hfY29uc3RuZXNzID0KKyAgICB0eXBlbmFtZSBzdGQ6OmNvbmRp dGlvbmFsPHN0ZDo6aXNfY29uc3Q8UmVmZXJlbmNlPjo6dmFsdWUsIHR5cGVuYW1lIHN0ZDo6YWRk X2NvbnN0PFQ+Ojp0eXBlLCB0eXBlbmFtZSBzdGQ6OnJlbW92ZV9jb25zdDxUPjo6dHlwZT46OnR5 cGU7CiAKIC8vIFNhZmUgZG93bmNhc3RpbmcgZnVuY3Rpb25zLgogdGVtcGxhdGU8dHlwZW5hbWUg VGFyZ2V0LCB0eXBlbmFtZSBTb3VyY2U+Ci1pbmxpbmUgdHlwZW5hbWUgbWF0Y2hfY29uc3RuZXNz PFNvdXJjZSwgVGFyZ2V0Pjo6dHlwZSYgZG93bmNhc3QoU291cmNlJiBzb3VyY2UpCitpbmxpbmUg bWF0Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0PiYgZG93bmNhc3QoU291cmNlJiBzb3VyY2Up CiB7CiAgICAgc3RhdGljX2Fzc2VydCghc3RkOjppc19zYW1lPFNvdXJjZSwgVGFyZ2V0Pjo6dmFs dWUsICJVbm5lY2Vzc2FyeSBjYXN0IHRvIHNhbWUgdHlwZSIpOwogICAgIHN0YXRpY19hc3NlcnQo c3RkOjppc19iYXNlX29mPFNvdXJjZSwgVGFyZ2V0Pjo6dmFsdWUsICJTaG91bGQgYmUgYSBkb3du Y2FzdCIpOwogICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGlzPFRhcmdldD4o c291cmNlKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PHR5cGVuYW1lIG1hdGNoX2NvbnN0bmVz czxTb3VyY2UsIFRhcmdldD46OnR5cGUmPihzb3VyY2UpOworICAgIHJldHVybiBzdGF0aWNfY2Fz dDxtYXRjaF9jb25zdG5lc3M8U291cmNlLCBUYXJnZXQ+Jj4oc291cmNlKTsKIH0KIHRlbXBsYXRl PHR5cGVuYW1lIFRhcmdldCwgdHlwZW5hbWUgU291cmNlPgotaW5saW5lIHR5cGVuYW1lIG1hdGNo X2NvbnN0bmVzczxTb3VyY2UsIFRhcmdldD46OnR5cGUqIGRvd25jYXN0KFNvdXJjZSogc291cmNl KQoraW5saW5lIG1hdGNoX2NvbnN0bmVzczxTb3VyY2UsIFRhcmdldD4qIGRvd25jYXN0KFNvdXJj ZSogc291cmNlKQogewogICAgIHN0YXRpY19hc3NlcnQoIXN0ZDo6aXNfc2FtZTxTb3VyY2UsIFRh cmdldD46OnZhbHVlLCAiVW5uZWNlc3NhcnkgY2FzdCB0byBzYW1lIHR5cGUiKTsKICAgICBzdGF0 aWNfYXNzZXJ0KHN0ZDo6aXNfYmFzZV9vZjxTb3VyY2UsIFRhcmdldD46OnZhbHVlLCAiU2hvdWxk IGJlIGEgZG93bmNhc3QiKTsKICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTigh c291cmNlIHx8IGlzPFRhcmdldD4oKnNvdXJjZSkpOwotICAgIHJldHVybiBzdGF0aWNfY2FzdDx0 eXBlbmFtZSBtYXRjaF9jb25zdG5lc3M8U291cmNlLCBUYXJnZXQ+Ojp0eXBlKj4oc291cmNlKTsK KyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8bWF0Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0Pio+ KHNvdXJjZSk7CiB9CiAKIC8vIEFkZCBzdXBwb3J0IGZvciB0eXBlIGNoZWNraW5nIC8gY2FzdGlu ZyB1c2luZyBpczw+KCkgLyBkb3duY2FzdDw+KCkgaGVscGVycyBmb3IgYSBzcGVjaWZpYyBjbGFz cy4K 398990 2020-05-10 18:47:07 -0700 2020-05-10 21:46:18 -0700 Patch bug-211698-20200511104700.patch text/plain 2694 tetsuharu.ohzeki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGEwOTYxZmVmNzM1MDcwOGZhY2E5YzQz Mjk2NTc4YTJlNGNkNDRiOTIuLjZjOTM2ZWU1MjY1NjA2NGNhOWYyMWVlMmM4ZDdjZmZlMjc5YTQ4 YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMTAgIFRldHN1aGFydSBPaHpla2kgIDx0 ZXRzdWhhcnUub2h6ZWtpQGdtYWlsLmNvbT4KKworICAgICAgICBVc2UgYWxpYXMgdGVtcGxhdGUg dG8gZGVmaW5lIGBtYXRjaF9jb25zdG5lc3NfdGAgaW4gV3RmL3d0cC9UeXBlQ2FzdHMuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNjk4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvVHlwZUNh c3RzLmg6CisgICAgICAgIChXVEY6OmRvd25jYXN0KToKKwogMjAyMC0wNS0wOSAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgRGVsZXRlIHNvbWUgZGVhZCBjb2RlIGlu IFdvcmtRdWV1ZUNvY29hLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVHlwZUNhc3Rz LmggYi9Tb3VyY2UvV1RGL3d0Zi9UeXBlQ2FzdHMuaAppbmRleCA2ZWI2M2U1YjkxOWM5Yjc1NWQ4 ZjU1YjI0ODVmMTYwOGIxMDA0NjRiLi5hMDE4ZjhkZjc5MWJjYzRkYmJhMmMyMzcwMGVmZTI2Y2Qy MTFlMjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9UeXBlQ2FzdHMuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9UeXBlQ2FzdHMuaApAQCAtNjcsMjYgKzY3LDI1IEBAIGlubGluZSBib29sIGlz KEFyZ1R5cGUqIHNvdXJjZSkKIAogLy8gVXBkYXRlIFQncyBjb25zdG5lc3MgdG8gbWF0Y2ggUmVm ZXJlbmNlJ3MuCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgUmVmZXJlbmNlLCB0eXBlbmFtZSBUPgotc3Ry dWN0IG1hdGNoX2NvbnN0bmVzcyB7Ci0gICAgdHlwZWRlZiB0eXBlbmFtZSBzdGQ6OmNvbmRpdGlv bmFsPHN0ZDo6aXNfY29uc3Q8UmVmZXJlbmNlPjo6dmFsdWUsIHR5cGVuYW1lIHN0ZDo6YWRkX2Nv bnN0PFQ+Ojp0eXBlLCB0eXBlbmFtZSBzdGQ6OnJlbW92ZV9jb25zdDxUPjo6dHlwZT46OnR5cGUg dHlwZTsKLX07Cit1c2luZyBtYXRjaF9jb25zdG5lc3NfdCA9CisgICAgdHlwZW5hbWUgc3RkOjpj b25kaXRpb25hbDxzdGQ6OmlzX2NvbnN0PFJlZmVyZW5jZT46OnZhbHVlLCB0eXBlbmFtZSBzdGQ6 OmFkZF9jb25zdDxUPjo6dHlwZSwgdHlwZW5hbWUgc3RkOjpyZW1vdmVfY29uc3Q8VD46OnR5cGU+ Ojp0eXBlOwogCiAvLyBTYWZlIGRvd25jYXN0aW5nIGZ1bmN0aW9ucy4KIHRlbXBsYXRlPHR5cGVu YW1lIFRhcmdldCwgdHlwZW5hbWUgU291cmNlPgotaW5saW5lIHR5cGVuYW1lIG1hdGNoX2NvbnN0 bmVzczxTb3VyY2UsIFRhcmdldD46OnR5cGUmIGRvd25jYXN0KFNvdXJjZSYgc291cmNlKQoraW5s aW5lIG1hdGNoX2NvbnN0bmVzc190PFNvdXJjZSwgVGFyZ2V0PiYgZG93bmNhc3QoU291cmNlJiBz b3VyY2UpCiB7CiAgICAgc3RhdGljX2Fzc2VydCghc3RkOjppc19zYW1lPFNvdXJjZSwgVGFyZ2V0 Pjo6dmFsdWUsICJVbm5lY2Vzc2FyeSBjYXN0IHRvIHNhbWUgdHlwZSIpOwogICAgIHN0YXRpY19h c3NlcnQoc3RkOjppc19iYXNlX29mPFNvdXJjZSwgVGFyZ2V0Pjo6dmFsdWUsICJTaG91bGQgYmUg YSBkb3duY2FzdCIpOwogICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGlzPFRh cmdldD4oc291cmNlKSk7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PHR5cGVuYW1lIG1hdGNoX2Nv bnN0bmVzczxTb3VyY2UsIFRhcmdldD46OnR5cGUmPihzb3VyY2UpOworICAgIHJldHVybiBzdGF0 aWNfY2FzdDxtYXRjaF9jb25zdG5lc3NfdDxTb3VyY2UsIFRhcmdldD4mPihzb3VyY2UpOwogfQog dGVtcGxhdGU8dHlwZW5hbWUgVGFyZ2V0LCB0eXBlbmFtZSBTb3VyY2U+Ci1pbmxpbmUgdHlwZW5h bWUgbWF0Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0Pjo6dHlwZSogZG93bmNhc3QoU291cmNl KiBzb3VyY2UpCitpbmxpbmUgbWF0Y2hfY29uc3RuZXNzX3Q8U291cmNlLCBUYXJnZXQ+KiBkb3du Y2FzdChTb3VyY2UqIHNvdXJjZSkKIHsKICAgICBzdGF0aWNfYXNzZXJ0KCFzdGQ6OmlzX3NhbWU8 U291cmNlLCBUYXJnZXQ+Ojp2YWx1ZSwgIlVubmVjZXNzYXJ5IGNhc3QgdG8gc2FtZSB0eXBlIik7 CiAgICAgc3RhdGljX2Fzc2VydChzdGQ6OmlzX2Jhc2Vfb2Y8U291cmNlLCBUYXJnZXQ+Ojp2YWx1 ZSwgIlNob3VsZCBiZSBhIGRvd25jYXN0Iik7CiAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1Q TElDQVRJT04oIXNvdXJjZSB8fCBpczxUYXJnZXQ+KCpzb3VyY2UpKTsKLSAgICByZXR1cm4gc3Rh dGljX2Nhc3Q8dHlwZW5hbWUgbWF0Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0Pjo6dHlwZSo+ KHNvdXJjZSk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PG1hdGNoX2NvbnN0bmVzc190PFNvdXJj ZSwgVGFyZ2V0Pio+KHNvdXJjZSk7CiB9CiAKIC8vIEFkZCBzdXBwb3J0IGZvciB0eXBlIGNoZWNr aW5nIC8gY2FzdGluZyB1c2luZyBpczw+KCkgLyBkb3duY2FzdDw+KCkgaGVscGVycyBmb3IgYSBz cGVjaWZpYyBjbGFzcy4K