211662 2020-05-08 23:45:56 -0700 Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI 2020-05-09 09:02:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned benjamin cdumez cmarcelo darin ews-watchlist thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1650892 0 david_quesada 2020-05-08 23:45:56 -0700 On all UIKit-having platforms that WebKit suports building for, UIScrollView has the SPI -_flashScrollIndicatorsForAxes:persistingPreviousFlashes:. The HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI platform conditional is therefore no longer necessary, and its current NO value for Mac Catalyst actually makes us send a message (_flashScrollIndicatorsPersistingPreviousFlashes:) that UIScrollView no longer responds to. 1650893 1 webkit-bug-importer 2020-05-08 23:46:15 -0700 <rdar://problem/63048713> 1650895 2 398920 david_quesada 2020-05-08 23:55:21 -0700 Created attachment 398920 Patch 1650917 3 398920 darin 2020-05-09 08:38:53 -0700 Comment on attachment 398920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398920&action=review > Source/WebKit/ChangeLog:12 > + Remove this platform conditional and unconditionally use -[UIScrolView _flashScrollIndicatorsForAxes: > + persistingPreviousFlashes:]. All supported platforms with UIScrollView have this SPI, and the conditional > + was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send a message to its scroll view that > + is no longer implemented. Seems like the headline here is fixing the bug on Mac Catalyst; a crash maybe? Removing the HAVE macro is the less important half of this, as grateful as I am to have that cleaned up too. 1650925 4 ews-feeder 2020-05-09 09:02:31 -0700 Committed r261436: <https://trac.webkit.org/changeset/261436> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398920. 398920 2020-05-08 23:55:21 -0700 2020-05-09 09:02:31 -0700 Patch file_211662.txt text/plain 5753 david_quesada Y29tbWl0IDQ5NTBkYTI1NWU2MmY3NGZlNjY0MWRiNjZhNTJjNTA4M2JkZWYzNzYNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIEZyaSBNYXkg OCAyMzo1Mzo1MiAyMDIwIC0wNzAwDQoNCiAgICBSZW1vdmUgSEFWRV9VSV9TQ1JPTExfVklFV19J TkRJQ0FUT1JfRkxBU0hJTkdfU1BJDQogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMTY2Mg0KICAgIHJkYXI6Ly9wcm9ibGVtLzYzMDQ4NzEzDQogICAgDQogICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQogICAgDQogICAgU291cmNlL1dlYktpdDoNCiAg ICANCiAgICBSZW1vdmUgdGhpcyBwbGF0Zm9ybSBjb25kaXRpb25hbCBhbmQgdW5jb25kaXRpb25h bGx5IHVzZSAtW1VJU2Nyb2xWaWV3IF9mbGFzaFNjcm9sbEluZGljYXRvcnNGb3JBeGVzOg0KICAg IHBlcnNpc3RpbmdQcmV2aW91c0ZsYXNoZXM6XS4gQWxsIHN1cHBvcnRlZCBwbGF0Zm9ybXMgd2l0 aCBVSVNjcm9sbFZpZXcgaGF2ZSB0aGlzIFNQSSwgYW5kIHRoZSBjb25kaXRpb25hbA0KICAgIHdh cyBleGNsdWRpbmcgTWFjIENhdGFseXN0LCBtYWtpbmcgV0tLZXlib2FyZFNjcm9sbFZpZXdBbmlt YXRvciBzZW5kIGEgbWVzc2FnZSB0byBpdHMgc2Nyb2xsIHZpZXcgdGhhdA0KICAgIGlzIG5vIGxv bmdlciBpbXBsZW1lbnRlZC4NCiAgICANCiAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEku aDoNCiAgICAgICAgUmVtb3ZlIHRoZSBkZWNsYXJhdGlvbiBvZiB0aGUgbm93IHVudXNlZCAtX2Zs YXNoU2Nyb2xsSW5kaWNhdG9yc1BlcnNpc3RpbmdQcmV2aW91c0ZsYXNoZXM6Lg0KICAgICogVUlQ cm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IubW06DQogICAgKGF4ZXNGb3JE ZWx0YSk6DQogICAgKC1bV0tLZXlib2FyZFNjcm9sbFZpZXdBbmltYXRvciBzY3JvbGxUb0NvbnRl bnRPZmZzZXQ6YW5pbWF0ZWQ6XSk6DQogICAgDQogICAgU291cmNlL1dURjoNCiAgICANCiAgICAq IHd0Zi9QbGF0Zm9ybUhhdmUuaDoNCg0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n IGIvU291cmNlL1dURi9DaGFuZ2VMb2cNCmluZGV4IGIzNzM4YjU2YWFlLi5mZGE4MDQ5NWNiZSAx MDA2NDQNCi0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV1RGL0NoYW5n ZUxvZw0KQEAgLTEsMyArMSwxMyBAQA0KKzIwMjAtMDUtMDggIERhdmlkIFF1ZXNhZGEgIDxkYXZp ZF9xdWVzYWRhQGFwcGxlLmNvbT4NCisNCisgICAgICAgIFJlbW92ZSBIQVZFX1VJX1NDUk9MTF9W SUVXX0lORElDQVRPUl9GTEFTSElOR19TUEkNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE2NjINCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzYzMDQ4 NzEzDQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAg ICogd3RmL1BsYXRmb3JtSGF2ZS5oOg0KKw0KIDIwMjAtMDUtMDggIEJhc3VrZSBTdXp1a2kgIDxi YXN1a2Uuc3V6dWtpQHNvbnkuY29tPg0KIA0KICAgICAgICAgW1dURl0gU2hhcmUgTGludXgncyBN ZW1vcnlQcmVzc3VyZUhhbmRsZXIgYW1vbmcgb3RoZXIgVW5peCBwb3J0cw0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1I YXZlLmgNCmluZGV4IDVhZTc0MWMzOGY3Li5kOWYwMjBlYzIyYSAxMDA2NDQNCi0tLSBhL1NvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oDQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhh dmUuaA0KQEAgLTQ2MywxMCArNDYzLDYgQEANCiAjZGVmaW5lIEhBVkVfRkFJUlBMQVlTVFJFQU1J TkdfQ0VOQ19JTklUREFUQSAxDQogI2VuZGlmDQogDQotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkp ICYmICFQTEFURk9STShNQUNDQVRBTFlTVCkNCi0jZGVmaW5lIEhBVkVfVUlfU0NST0xMX1ZJRVdf SU5ESUNBVE9SX0ZMQVNISU5HX1NQSSAxDQotI2VuZGlmDQotDQogI2lmIFBMQVRGT1JNKElPU19G QU1JTFkpICYmICFQTEFURk9STShNQUNDQVRBTFlTVCkNCiAjZGVmaW5lIEhBVkVfQVBQX0xJTktT X1dJVEhfSVNFTkFCTEVEIDENCiAjZW5kaWYNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQppbmRleCA5N2NmMGUxODk5Yy4uZDE1 MWFlMjg5ODAgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KKysrIGIvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMjIgQEANCisyMDIwLTA1LTA4ICBEYXZp ZCBRdWVzYWRhICA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQorDQorICAgICAgICBSZW1vdmUg SEFWRV9VSV9TQ1JPTExfVklFV19JTkRJQ0FUT1JfRkxBU0hJTkdfU1BJDQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNjYyDQorICAgICAgICByZGFy Oi8vcHJvYmxlbS82MzA0ODcxMw0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuDQorDQorICAgICAgICBSZW1vdmUgdGhpcyBwbGF0Zm9ybSBjb25kaXRpb25hbCBhbmQgdW5j b25kaXRpb25hbGx5IHVzZSAtW1VJU2Nyb2xWaWV3IF9mbGFzaFNjcm9sbEluZGljYXRvcnNGb3JB eGVzOg0KKyAgICAgICAgcGVyc2lzdGluZ1ByZXZpb3VzRmxhc2hlczpdLiBBbGwgc3VwcG9ydGVk IHBsYXRmb3JtcyB3aXRoIFVJU2Nyb2xsVmlldyBoYXZlIHRoaXMgU1BJLCBhbmQgdGhlIGNvbmRp dGlvbmFsDQorICAgICAgICB3YXMgZXhjbHVkaW5nIE1hYyBDYXRhbHlzdCwgbWFraW5nIFdLS2V5 Ym9hcmRTY3JvbGxWaWV3QW5pbWF0b3Igc2VuZCBhIG1lc3NhZ2UgdG8gaXRzIHNjcm9sbCB2aWV3 IHRoYXQNCisgICAgICAgIGlzIG5vIGxvbmdlciBpbXBsZW1lbnRlZC4NCisNCisgICAgICAgICog UGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOg0KKyAgICAgICAgICAgIFJlbW92ZSB0aGUgZGVj bGFyYXRpb24gb2YgdGhlIG5vdyB1bnVzZWQgLV9mbGFzaFNjcm9sbEluZGljYXRvcnNQZXJzaXN0 aW5nUHJldmlvdXNGbGFzaGVzOi4NCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJk U2Nyb2xsaW5nQW5pbWF0b3IubW06DQorICAgICAgICAoYXhlc0ZvckRlbHRhKToNCisgICAgICAg ICgtW1dLS2V5Ym9hcmRTY3JvbGxWaWV3QW5pbWF0b3Igc2Nyb2xsVG9Db250ZW50T2Zmc2V0OmFu aW1hdGVkOl0pOg0KKw0KIDIwMjAtMDUtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4NCiANCiAgICAgICAgIFJlbW92ZSBlbXB0eSBkaXJlY3RvcmllcyBmcm9tIGZyb20gc3Zu LndlYmtpdC5vcmcgcmVwb3NpdG9yeQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vc3BpL2lvcy9VSUtpdFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJ S2l0U1BJLmgNCmluZGV4IDQ3YjdmNGUwNjZjLi4xZjc5OTg0NDJlYiAxMDA2NDQNCi0tLSBhL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oDQorKysgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaA0KQEAgLTEzMDYsNyArMTMwNiw2IEBAIHR5 cGVkZWYgTlNfRU5VTShOU1VJbnRlZ2VyLCBfVUlDb250ZXh0TWVudUxheW91dCkgew0KIC0gKEJP T0wpX2NhblNjcm9sbFdpdGhvdXRCb3VuY2luZ1k7DQogLSAodm9pZClfc2V0Q29udGVudE9mZnNl dFdpdGhEZWNlbGVyYXRpb25BbmltYXRpb246KENHUG9pbnQpY29udGVudE9mZnNldDsNCiAtIChD R1BvaW50KV9hZGp1c3RlZENvbnRlbnRPZmZzZXRGb3JDb250ZW50T2Zmc2V0OihDR1BvaW50KWNv bnRlbnRPZmZzZXQ7DQotLSAodm9pZClfZmxhc2hTY3JvbGxJbmRpY2F0b3JzUGVyc2lzdGluZ1By ZXZpb3VzRmxhc2hlczooQk9PTClwZXJzaXN0aW5nOw0KIA0KIEBwcm9wZXJ0eSAobm9uYXRvbWlj KSBCT09MIHRyYWNrc0ltbWVkaWF0ZWx5V2hpbGVEZWNlbGVyYXRpbmc7DQogQHByb3BlcnR5IChu b25hdG9taWMsIGdldHRlcj1fYXZvaWRzSnVtcE9uSW50ZXJydXB0ZWRCb3VuY2UsIHNldHRlcj1f c2V0QXZvaWRzSnVtcE9uSW50ZXJydXB0ZWRCb3VuY2U6KSBCT09MIF9hdm9pZHNKdW1wT25JbnRl cnJ1cHRlZEJvdW5jZTsNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbQ0KaW5kZXggZmIwNjk0M2QxOGUuLmJk NzQ1NWNiNmZjIDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5 Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbQ0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbQ0KQEAgLTU5Myw3ICs1OTMsNiBAQCAt IChDR0Zsb2F0KWRpc3RhbmNlRm9ySW5jcmVtZW50OihXZWJLaXQ6OlNjcm9sbGluZ0luY3JlbWVu dClpbmNyZW1lbnQgaW5EaXJlY3Rpbw0KICAgICByZXR1cm4gW19kZWxlZ2F0ZSBrZXlib2FyZFNj cm9sbFZpZXdBbmltYXRvcjpzZWxmIGRpc3RhbmNlRm9ySW5jcmVtZW50OmluY3JlbWVudCBpbkRp cmVjdGlvbjpkaXJlY3Rpb25dOw0KIH0NCiANCi0jaWYgSEFWRShVSV9TQ1JPTExfVklFV19JTkRJ Q0FUT1JfRkxBU0hJTkdfU1BJKQ0KIHN0YXRpYyBVSUF4aXMgYXhlc0ZvckRlbHRhKFdlYkNvcmU6 OkZsb2F0U2l6ZSBkZWx0YSkNCiB7DQogICAgIFVJQXhpcyBheGVzID0gVUlBeGlzTmVpdGhlcjsN CkBAIC02MDMsNyArNjAyLDYgQEAgc3RhdGljIFVJQXhpcyBheGVzRm9yRGVsdGEoV2ViQ29yZTo6 RmxvYXRTaXplIGRlbHRhKQ0KICAgICAgICAgYXhlcyA9IHN0YXRpY19jYXN0PFVJQXhpcz4oYXhl cyB8IFVJQXhpc1ZlcnRpY2FsKTsNCiAgICAgcmV0dXJuIGF4ZXM7DQogfQ0KLSNlbmRpZg0KIA0K IC0gKHZvaWQpc2Nyb2xsVG9Db250ZW50T2Zmc2V0OihXZWJDb3JlOjpGbG9hdFBvaW50KWNvbnRl bnRPZmZzZXQgYW5pbWF0ZWQ6KEJPT0wpYW5pbWF0ZWQNCiB7DQpAQCAtNjEzLDExICs2MTEsNyBA QCAtICh2b2lkKXNjcm9sbFRvQ29udGVudE9mZnNldDooV2ViQ29yZTo6RmxvYXRQb2ludCljb250 ZW50T2Zmc2V0IGFuaW1hdGVkOihCT09MKQ0KICAgICBpZiAoX2RlbGVnYXRlUmVzcG9uZHNUb1dp bGxTY3JvbGwpDQogICAgICAgICBbX2RlbGVnYXRlIGtleWJvYXJkU2Nyb2xsVmlld0FuaW1hdG9y V2lsbFNjcm9sbDpzZWxmXTsNCiAgICAgW3Njcm9sbFZpZXcgc2V0Q29udGVudE9mZnNldDpjb250 ZW50T2Zmc2V0IGFuaW1hdGVkOmFuaW1hdGVkXTsNCi0jaWYgSEFWRShVSV9TQ1JPTExfVklFV19J TkRJQ0FUT1JfRkxBU0hJTkdfU1BJKQ0KICAgICBbc2Nyb2xsVmlldyBfZmxhc2hTY3JvbGxJbmRp Y2F0b3JzRm9yQXhlczpheGVzRm9yRGVsdGEoV2ViQ29yZTo6RmxvYXRQb2ludChzY3JvbGxWaWV3 LmNvbnRlbnRPZmZzZXQpIC0gY29udGVudE9mZnNldCkgcGVyc2lzdGluZ1ByZXZpb3VzRmxhc2hl czpZRVNdOw0KLSNlbHNlDQotICAgIFtzY3JvbGxWaWV3IF9mbGFzaFNjcm9sbEluZGljYXRvcnNQ ZXJzaXN0aW5nUHJldmlvdXNGbGFzaGVzOllFU107DQotI2VuZGlmDQogfQ0KIA0KIC0gKHZvaWQp c2Nyb2xsV2l0aFNjcm9sbFRvRXh0ZW50QW5pbWF0aW9uVG86KENHUG9pbnQpb2Zmc2V0DQo=