211592 2020-05-07 13:18:31 -0700 CLoop JSC broken on 32-bit big endian 2021-02-18 16:15:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Other Linux RESOLVED FIXED P2 Normal --- 1 q66 webkit-unassigned julianaito oldest_to_newest 1650325 0 398788 q66 2020-05-07 13:18:31 -0700 Created attachment 398788 proposed patch For quite a few versions, CLoop JSC has been broken on 32-bit BE (e.g. 32-bit PowerPC). I tried debugging around it some time ago and found that specifically on 32-bit BE platforms, some things need offsetting by PayloadOffset (4 on BE, 0 on LE, regardless of 32-bit or 64-bit), just like is done in various other places already, presumably because on 32-bit BE you might have 32-bit values in 64-bit storage at an offset. I attached the proposed patch. With this, all versions of WebKit I've had access to (including latest master) work on 32-bit BE (tested on a PowerBook G4; we've shipped a variant of this in my distribution at least since WebKit Gtk 2.24). I'm not sure if the JSVALUE64 ifs are needed in these specific paths, that would need figuring out if those paths ever get called on 64-bit, since on 64-bit BE WebKit works perfectly fine even now. That said, I tried the patch without the conditional JSVALUE64 checking and it also seems to have worked on both 32 and 64-bit BE - I put them there to be on the safe side (in order to possibly not regress some edge cases for 64-bit BE). Could someone with knowledge of these code paths pitch in and say if JSVALUE64 needs to be checked or not, or possibly where? For now this is here for review. Once it gets some feedback, I can make it into a proper patch with a ChangeLog entry and so on. 1714899 1 julianaito 2020-12-15 13:24:20 -0800 That patch fixes the JS runtime on OpenBSD/macppc, thanks Daniel. I hope to see that patch reviewed one day. 1731080 2 q66 2021-02-18 16:15:53 -0800 fixed https://bugs.webkit.org/show_bug.cgi?id=221710 398788 2020-05-07 13:18:31 -0700 2020-05-07 13:18:31 -0700 proposed patch ppc-llint.patch text/plain 1765 q66 LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82 NC5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIzMl82NC5hc20KQEAgLTE0ODAsMTMgKzE0ODAsMjEgQEAgbGxpbnRPcFdpdGhNZXRhZGF0YShv cF9wdXRfYnlfaWQsIE9wUHV0QnlJZCwgbWFjcm8gKHNpemUsIGdldCwgZGlzcGF0Y2gsIG1ldGFk YXQKICAgICBsb2FkcCBTdHJ1Y3R1cmVDaGFpbjo6bV92ZWN0b3JbdDNdLCB0MwogICAgIGFzc2Vy dChtYWNybyAob2spIGJ0cG56IHQzLCBvayBlbmQpCiAKLSAgICBsb2FkcCBTdHJ1Y3R1cmU6Om1f cHJvdG90eXBlW3QyXSwgdDIKKyAgICBpZiBKU1ZBTFVFNjQKKyAgICAgICAgbG9hZHAgU3RydWN0 dXJlOjptX3Byb3RvdHlwZVt0Ml0sIHQyCisgICAgZWxzZQorICAgICAgICBsb2FkcCBTdHJ1Y3R1 cmU6Om1fcHJvdG90eXBlICsgUGF5bG9hZE9mZnNldFt0Ml0sIHQyCisgICAgZW5kCiAgICAgYnRw eiB0MiwgLm9wUHV0QnlJZFRyYW5zaXRpb25DaGFpbkRvbmUKIC5vcFB1dEJ5SWRUcmFuc2l0aW9u Q2hhaW5Mb29wOgogICAgIGxvYWRwIFt0M10sIHQxCiAgICAgYmluZXEgdDEsIEpTQ2VsbDo6bV9z dHJ1Y3R1cmVJRFt0Ml0sIC5vcFB1dEJ5SWRTbG93CiAgICAgYWRkcCA0LCB0MwotICAgIGxvYWRw IFN0cnVjdHVyZTo6bV9wcm90b3R5cGVbdDFdLCB0MgorICAgIGlmIEpTVkFMVUU2NAorICAgICAg ICBsb2FkcCBTdHJ1Y3R1cmU6Om1fcHJvdG90eXBlW3QxXSwgdDIKKyAgICBlbHNlCisgICAgICAg IGxvYWRwIFN0cnVjdHVyZTo6bV9wcm90b3R5cGUgKyBQYXlsb2FkT2Zmc2V0W3QxXSwgdDIKKyAg ICBlbmQKICAgICBidHBueiB0MiwgLm9wUHV0QnlJZFRyYW5zaXRpb25DaGFpbkxvb3AKIAogLm9w UHV0QnlJZFRyYW5zaXRpb25DaGFpbkRvbmU6CkBAIC0yMDY4LDcgKzIwNzYsMTEgQEAgZW5kKQog CiAKIG9wKGxsaW50X3Rocm93X2Zyb21fc2xvd19wYXRoX3RyYW1wb2xpbmUsIG1hY3JvKCkKLSAg ICBsb2FkcCBDYWxsZWVbY2ZyXSwgdDEKKyAgICBpZiBKU1ZBTFVFNjQKKyAgICAgICAgbG9hZHAg Q2FsbGVlW2Nmcl0sIHQxCisgICAgZWxzZQorICAgICAgICBsb2FkcCBDYWxsZWUgKyBQYXlsb2Fk T2Zmc2V0W2Nmcl0sIHQxCisgICAgZW5kCiAgICAgY29udmVydENhbGxlZVRvVk0odDEpCiAgICAg Y29weUNhbGxlZVNhdmVzVG9WTUVudHJ5RnJhbWVDYWxsZWVTYXZlc0J1ZmZlcih0MSwgdDIpCiAK QEAgLTIwNzcsNyArMjA4OSwxMSBAQCBvcChsbGludF90aHJvd19mcm9tX3Nsb3dfcGF0aF90cmFt cG9saW5lLCBtYWNybygpCiAgICAgIyBXaGVuIHRocm93aW5nIGZyb20gdGhlIGludGVycHJldGVy IChpLmUuIHRocm93aW5nIGZyb20gTExJbnRTbG93UGF0aHMpLCBzbwogICAgICMgdGhlIHRocm93 IHRhcmdldCBpcyBub3QgbmVjZXNzYXJpbHkgaW50ZXJwcmV0ZWQgY29kZSwgd2UgY29tZSB0byBo ZXJlLgogICAgICMgVGhpcyBlc3NlbnRpYWxseSBlbXVsYXRlcyB0aGUgSklUJ3MgdGhyb3dpbmcg cHJvdG9jb2wuCi0gICAgbG9hZHAgQ2FsbGVlW2Nmcl0sIHQxCisgICAgaWYgSlNWQUxVRTY0Cisg ICAgICAgIGxvYWRwIENhbGxlZVtjZnJdLCB0MQorICAgIGVsc2UKKyAgICAgICAgbG9hZHAgQ2Fs bGVlICsgUGF5bG9hZE9mZnNldFtjZnJdLCB0MQorICAgIGVuZAogICAgIGNvbnZlcnRDYWxsZWVU b1ZNKHQxKQogICAgIGptcCBWTTo6dGFyZ2V0TWFjaGluZVBDRm9yVGhyb3dbdDFdCiBlbmQpCg==