211585 2020-05-07 11:46:42 -0700 [macOS] Playhead in Touch Bar continues when loading stalls 2020-05-07 16:08:49 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson darin ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1650250 0 eric.carlson 2020-05-07 11:46:42 -0700 Playhead in Touch Bar should stop when loading stalls 1650251 1 eric.carlson 2020-05-07 11:47:11 -0700 <rdar://problem/33893306> 1650254 2 398771 eric.carlson 2020-05-07 11:50:52 -0700 Created attachment 398771 Patch 1650311 3 398771 darin 2020-05-07 12:56:26 -0700 Comment on attachment 398771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146 > + bool isPlaying = this->isPlaying() && !this->isStalled(); No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting. > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436 > + return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false; I like using && for expressions like this one. 1650339 4 398771 eric.carlson 2020-05-07 13:57:31 -0700 Comment on attachment 398771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398771&action=review Thanks for the review! >> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:146 >> + bool isPlaying = this->isPlaying() && !this->isStalled(); > > No need for the second "this->". The first one is needed because of a conflict with the name of the local variable we are setting. Fixed. >> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:436 >> + return m_mediaElement ? m_mediaElement->readyState() <= HTMLMediaElement::HAVE_CURRENT_DATA : false; > > I like using && for expressions like this one. That is nicer, changed. 1650343 5 398795 eric.carlson 2020-05-07 14:01:25 -0700 Created attachment 398795 Patch for landing 1650400 6 ews-feeder 2020-05-07 16:08:49 -0700 Committed r261342: <https://trac.webkit.org/changeset/261342> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398795. 398771 2020-05-07 11:50:52 -0700 2020-05-07 14:01:23 -0700 Patch bug-211585-20200507115051.patch text/plain 3221 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRhMWU4NWE4OWM4N2Jh MDEyMjY2YWNkMmE2NDAwYjA0ZTBiZjJhYy4uMzYyMDc2NTY4NDVkZjMxNTg1MzYyZTMzZDc4ZDVi MTJlNjBhMTg1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTA3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gUGxh eWhlYWQgaW4gVG91Y2ggQmFyIGNvbnRpbnVlcyB3aGVuIGxvYWRpbmcgc3RhbGxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1ODUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzMzODkzMzA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxN ZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25N b2RlbE1lZGlhRWxlbWVudC5tbToKKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrU2Vzc2lvbk1v ZGVsTWVkaWFFbGVtZW50Ojp1cGRhdGVGb3JFdmVudE5hbWUpOiBMaXN0ZW4gZm9yIGB3YWl0aW5n RXZlbnRgCisgICAgICAgIGFuZCBgY2FucGxheWAgZXZlbnRzLiBEb24ndCBjbGFpbSB0byBiZSBw bGF5aW5nIHdoZW4gc3RhbGxlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrU2Vzc2lvbk1v ZGVsTWVkaWFFbGVtZW50Ojppc1N0YWxsZWQgY29uc3QpOiBOZXcuCisKIDIwMjAtMDUtMDcgIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBiYXNpYyBzdXBw b3J0IGZvciBnZW5lcmF0aW5nIGFjY3VyYXRlIHdoZWVsIGV2ZW50IGxpc3RlbmVyIHJlZ2lvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9u TW9kZWxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1BsYXli YWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50LmgKaW5kZXggZWRjZDNkMTM2OTcxNWMwYjI5MDgy N2JkZDI2ODFiZDk1Zjg3NmJlMC4uOTM3NDE4MzQyZDMxNjVjZmFmYTFiNWRjMDZmZTQ3NjAwZGMy OTdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tT ZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j b2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5oCkBAIC0xMDMsNiArMTAzLDcg QEAgcHJpdmF0ZToKICAgICB2b2lkIHByb2dyZXNzRXZlbnRUaW1lckZpcmVkKCk7CiAgICAgc3Rh dGljIGNvbnN0IFZlY3RvcjxXVEY6OkF0b21TdHJpbmc+JiBvYnNlcnZlZEV2ZW50TmFtZXMoKTsK ICAgICBjb25zdCBXVEY6OkF0b21TdHJpbmcmIGV2ZW50TmFtZUFsbCgpOworICAgIGJvb2wgaXNT dGFsbGVkKCkgY29uc3Q7CiAKICAgICBSZWZQdHI8SFRNTE1lZGlhRWxlbWVudD4gbV9tZWRpYUVs ZW1lbnQ7CiAgICAgYm9vbCBtX2lzTGlzdGVuaW5nIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1BsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVt ZW50Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9k ZWxNZWRpYUVsZW1lbnQubW0KaW5kZXggMDg0ZjQzMjk1ZDgxNWUzMDAzMzI1ZDk4M2I3NzAzOTNk OTY5YTRiNy4uMmFiMjE3MGI5N2M3OWQzOGFlNDZjN2IyZmFjZDkwYjNhOTljMTIxYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxN ZWRpYUVsZW1lbnQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJh Y2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQubW0KQEAgLTE0MCw4ICsxNDAsMTAgQEAgdm9pZCBQ bGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6dXBkYXRlRm9yRXZlbnROYW1lKGNvbnN0 IFdURjo6QXRvbVN0cmluZyYKICAgICBpZiAoYWxsCiAgICAgICAgIHx8IGV2ZW50TmFtZSA9PSBl dmVudE5hbWVzKCkucGF1c2VFdmVudAogICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1l cygpLnBsYXlFdmVudAotICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLnJhdGVj aGFuZ2VFdmVudCkgewotICAgICAgICBib29sIGlzUGxheWluZyA9IHRoaXMtPmlzUGxheWluZygp OworICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLnJhdGVjaGFuZ2VFdmVudAor ICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLndhaXRpbmdFdmVudAorICAgICAg ICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLmNhbnBsYXlFdmVudCkgeworICAgICAgICBi b29sIGlzUGxheWluZyA9IHRoaXMtPmlzUGxheWluZygpICYmICF0aGlzLT5pc1N0YWxsZWQoKTsK ICAgICAgICAgZmxvYXQgcGxheWJhY2tSYXRlID0gdGhpcy0+cGxheWJhY2tSYXRlKCk7CiAgICAg ICAgIGZvciAoYXV0byBjbGllbnQgOiBtX2NsaWVudHMpCiAgICAgICAgICAgICBjbGllbnQtPnJh dGVDaGFuZ2VkKGlzUGxheWluZywgcGxheWJhY2tSYXRlKTsKQEAgLTQyOSw2ICs0MzEsMTEgQEAg Ym9vbCBQbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6aXNQbGF5aW5nKCkgY29uc3QK ICAgICByZXR1cm4gbV9tZWRpYUVsZW1lbnQgPyAhbV9tZWRpYUVsZW1lbnQtPnBhdXNlZCgpIDog ZmFsc2U7CiB9CiAKK2Jvb2wgUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6OmlzU3Rh bGxlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fbWVkaWFFbGVtZW50ID8gbV9tZWRpYUVsZW1l bnQtPnJlYWR5U3RhdGUoKSA8PSBIVE1MTWVkaWFFbGVtZW50OjpIQVZFX0NVUlJFTlRfREFUQSA6 IGZhbHNlOworfQorCiBmbG9hdCBQbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6cGxh eWJhY2tSYXRlKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9tZWRpYUVsZW1lbnQgPyBtX21lZGlh RWxlbWVudC0+cGxheWJhY2tSYXRlKCkgOiAwOwo= 398795 2020-05-07 14:01:25 -0700 2020-05-07 16:08:49 -0700 Patch for landing bug-211585-20200507140124.patch text/plain 3205 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRhMWU4NWE4OWM4N2Jh MDEyMjY2YWNkMmE2NDAwYjA0ZTBiZjJhYy4uMDBhNmM2MzBjYjU5NDg2MzdkMzQ0NjEzMmMxMGJm YmQ5Nzk1ZDgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTA3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gUGxh eWhlYWQgaW4gVG91Y2ggQmFyIGNvbnRpbnVlcyB3aGVuIGxvYWRpbmcgc3RhbGxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1ODUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzMzODkzMzA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRp YUVsZW1lbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2Rl bE1lZGlhRWxlbWVudC5tbToKKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrU2Vzc2lvbk1vZGVs TWVkaWFFbGVtZW50Ojp1cGRhdGVGb3JFdmVudE5hbWUpOiBMaXN0ZW4gZm9yIGB3YWl0aW5nRXZl bnRgCisgICAgICAgIGFuZCBgY2FucGxheWAgZXZlbnRzLiBEb24ndCBjbGFpbSB0byBiZSBwbGF5 aW5nIHdoZW4gc3RhbGxlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrU2Vzc2lvbk1vZGVs TWVkaWFFbGVtZW50Ojppc1N0YWxsZWQgY29uc3QpOiBOZXcuCisKIDIwMjAtMDUtMDcgIEFudHRp IEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBiYXNpYyBzdXBwb3J0 IGZvciBnZW5lcmF0aW5nIGFjY3VyYXRlIHdoZWVsIGV2ZW50IGxpc3RlbmVyIHJlZ2lvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9k ZWxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1BsYXliYWNr U2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50LmgKaW5kZXggZWRjZDNkMTM2OTcxNWMwYjI5MDgyN2Jk ZDI2ODFiZDk1Zjg3NmJlMC4uOTM3NDE4MzQyZDMxNjVjZmFmYTFiNWRjMDZmZTQ3NjAwZGMyOTdl YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNz aW9uTW9kZWxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2Nv YS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5oCkBAIC0xMDMsNiArMTAzLDcgQEAg cHJpdmF0ZToKICAgICB2b2lkIHByb2dyZXNzRXZlbnRUaW1lckZpcmVkKCk7CiAgICAgc3RhdGlj IGNvbnN0IFZlY3RvcjxXVEY6OkF0b21TdHJpbmc+JiBvYnNlcnZlZEV2ZW50TmFtZXMoKTsKICAg ICBjb25zdCBXVEY6OkF0b21TdHJpbmcmIGV2ZW50TmFtZUFsbCgpOworICAgIGJvb2wgaXNTdGFs bGVkKCkgY29uc3Q7CiAKICAgICBSZWZQdHI8SFRNTE1lZGlhRWxlbWVudD4gbV9tZWRpYUVsZW1l bnQ7CiAgICAgYm9vbCBtX2lzTGlzdGVuaW5nIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1BsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50 Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxN ZWRpYUVsZW1lbnQubW0KaW5kZXggMDg0ZjQzMjk1ZDgxNWUzMDAzMzI1ZDk4M2I3NzAzOTNkOTY5 YTRiNy4uY2U1YjNhOGJkNDIyOTQzMGVkNWE4ZjhjZDhjNDI0NTIyOWMxYjY0NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRp YUVsZW1lbnQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tT ZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQubW0KQEAgLTE0MCw4ICsxNDAsMTAgQEAgdm9pZCBQbGF5 YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6dXBkYXRlRm9yRXZlbnROYW1lKGNvbnN0IFdU Rjo6QXRvbVN0cmluZyYKICAgICBpZiAoYWxsCiAgICAgICAgIHx8IGV2ZW50TmFtZSA9PSBldmVu dE5hbWVzKCkucGF1c2VFdmVudAogICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygp LnBsYXlFdmVudAotICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLnJhdGVjaGFu Z2VFdmVudCkgewotICAgICAgICBib29sIGlzUGxheWluZyA9IHRoaXMtPmlzUGxheWluZygpOwor ICAgICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLnJhdGVjaGFuZ2VFdmVudAorICAg ICAgICB8fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLndhaXRpbmdFdmVudAorICAgICAgICB8 fCBldmVudE5hbWUgPT0gZXZlbnROYW1lcygpLmNhbnBsYXlFdmVudCkgeworICAgICAgICBib29s IGlzUGxheWluZyA9IHRoaXMtPmlzUGxheWluZygpICYmICFpc1N0YWxsZWQoKTsKICAgICAgICAg ZmxvYXQgcGxheWJhY2tSYXRlID0gdGhpcy0+cGxheWJhY2tSYXRlKCk7CiAgICAgICAgIGZvciAo YXV0byBjbGllbnQgOiBtX2NsaWVudHMpCiAgICAgICAgICAgICBjbGllbnQtPnJhdGVDaGFuZ2Vk KGlzUGxheWluZywgcGxheWJhY2tSYXRlKTsKQEAgLTQyOSw2ICs0MzEsMTEgQEAgYm9vbCBQbGF5 YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6aXNQbGF5aW5nKCkgY29uc3QKICAgICByZXR1 cm4gbV9tZWRpYUVsZW1lbnQgPyAhbV9tZWRpYUVsZW1lbnQtPnBhdXNlZCgpIDogZmFsc2U7CiB9 CiAKK2Jvb2wgUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6OmlzU3RhbGxlZCgpIGNv bnN0Cit7CisgICAgcmV0dXJuIG1fbWVkaWFFbGVtZW50ICYmIG1fbWVkaWFFbGVtZW50LT5yZWFk eVN0YXRlKCkgPD0gSFRNTE1lZGlhRWxlbWVudDo6SEFWRV9DVVJSRU5UX0RBVEE7Cit9CisKIGZs b2F0IFBsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50OjpwbGF5YmFja1JhdGUoKSBjb25z dAogewogICAgIHJldHVybiBtX21lZGlhRWxlbWVudCA/IG1fbWVkaWFFbGVtZW50LT5wbGF5YmFj a1JhdGUoKSA6IDA7Cg==