211555 2020-05-07 01:21:09 -0700 [GTK] REGRESSION(r260996): Pressing <Tab> in an HTTP authentication dialog makes the dialog lose focus 2020-05-07 07:26:19 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez webkit-unassigned berto bugs-noreply cgarcia ews-watchlist gustavo pnormand oldest_to_newest 1650002 0 aperez 2020-05-07 01:21:09 -0700 This can be reproduced easily: 1. Navigate to https://webmail.igalia.com 2. The HTTP authentication dialog will show up, with the “Username” field focused. 3. Press <Tab>. Expected outcome: The “Pasword” field gets the focus, pressing <Tab> more time focuses the dialog buttons and then the dialog input fields again. Actual outcom: The HTTP authentication dialog loses the focus, if one keeps pressing <Tab> the dialog does not seem to ever get the focus back. Interacting with the dialog using the mouse is still possible, though. 1650003 1 aperez 2020-05-07 01:22:15 -0700 Possible related to the changes introduced with bug #211283 1650055 2 cgarcia 2020-05-07 06:22:59 -0700 Yes, I made the focus vfunc GTK4 only by mistake 1650057 3 398729 cgarcia 2020-05-07 06:24:30 -0700 Created attachment 398729 Patch 1650058 4 ews-watchlist 2020-05-07 06:25:16 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1650065 5 aperez 2020-05-07 06:34:16 -0700 (In reply to Carlos Garcia Campos from comment #3) > Created attachment 398729 [details] > Patch Nice 🤩️ 1650085 6 ews-feeder 2020-05-07 07:26:17 -0700 Committed r261284: <https://trac.webkit.org/changeset/261284> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398729. 398729 2020-05-07 06:24:30 -0700 2020-05-07 07:26:18 -0700 Patch wkgtk-focus.diff text/plain 2143 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGJkMDE0ODNlMDFiLi42YjliYzcxMDQzNjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjAtMDUtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjI2MDk5Nik6IFByZXNzaW5nIDxU YWI+IGluIGFuIEhUVFAgYXV0aGVudGljYXRpb24gZGlhbG9nIG1ha2VzIHRoZSBkaWFsb2cgbG9z ZSBmb2N1cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjExNTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QnJpbmcgYmFjayB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzIHRvIEdUSzMuIEkgbWFkZSBpdCBHVEs0 IG9ubHkgYnkgbWlzdGFrZSBpbiByMjYwOTk2LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VGb2N1 cyk6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFzc19pbml0KToKKwogMjAyMC0w NS0wNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gUmV3b3JrIGNsaXBib2FyZCBoYW5kbGluZyBpbiBwcmVwYXJhdGlvbiBmb3IgR1RL NApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcAppbmRleCA0NGJkMjZmNTViZWUuLjM3NTk5MTE2ZDNjMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAK QEAgLTE2NDYsNiArMTY0Niw3IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUdy YWJGb2N1cyhHdGtXaWRnZXQqIHdpZGdldCkKICAgICBndGtfcm9vdF9zZXRfZm9jdXMoZ3RrX3dp ZGdldF9nZXRfcm9vdCh3aWRnZXQpLCB3aWRnZXQpOwogICAgIHJldHVybiBUUlVFOwogfQorI2Vu ZGlmCiAKIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzKEd0a1dpZGdldCog d2lkZ2V0LCBHdGtEaXJlY3Rpb25UeXBlIGRpcmVjdGlvbikKIHsKQEAgLTE2NjAsNyArMTY2MSw2 IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzKEd0a1dpZGdldCogd2lk Z2V0LCBHdGtEaXJlY3Rpb25UeXBlIGRpcmVjCiAKICAgICByZXR1cm4gR1RLX1dJREdFVF9DTEFT Uyh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9wYXJlbnRfY2xhc3MpLT5mb2N1cyh3aWRnZXQsIGRpcmVj dGlvbik7CiB9Ci0jZW5kaWYKIAogc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDb25zdHJ1 Y3RlZChHT2JqZWN0KiBvYmplY3QpCiB7CkBAIC0xNzI3LDkgKzE3MjcsOSBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFzc19pbml0KFdlYktpdFdlYlZpZXdCYXNlQ2xhc3Mq IHdlYmtpdFdlYlZpZQogI2VuZGlmCiAgICAgd2lkZ2V0Q2xhc3MtPm1hcCA9IHdlYmtpdFdlYlZp ZXdCYXNlTWFwOwogICAgIHdpZGdldENsYXNzLT51bm1hcCA9IHdlYmtpdFdlYlZpZXdCYXNlVW5t YXA7CisgICAgd2lkZ2V0Q2xhc3MtPmZvY3VzID0gd2Via2l0V2ViVmlld0Jhc2VGb2N1czsKICNp ZiBVU0UoR1RLNCkKICAgICB3aWRnZXRDbGFzcy0+Z3JhYl9mb2N1cyA9IHdlYmtpdFdlYlZpZXdC YXNlR3JhYkZvY3VzOwotICAgIHdpZGdldENsYXNzLT5mb2N1cyA9IHdlYmtpdFdlYlZpZXdCYXNl Rm9jdXM7CiAjZWxzZQogICAgIHdpZGdldENsYXNzLT5mb2N1c19pbl9ldmVudCA9IHdlYmtpdFdl YlZpZXdCYXNlRm9jdXNJbkV2ZW50OwogICAgIHdpZGdldENsYXNzLT5mb2N1c19vdXRfZXZlbnQg PSB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzT3V0RXZlbnQ7Cg==