211553 2020-05-07 01:04:04 -0700 [GTK4] Stop using the GtkWidget.destroy vfunc 2020-05-07 02:05:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez aperez aperez berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1649995 0 aperez 2020-05-07 01:04:04 -0700 The GtkWidget.destroy vfunc is no more, and GObject.dispose should be used instead after the following merge request landed into GTK4: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1835 We only use .destroy in WebKitWebViewBase, and it looks like it should be possible to stop using .destroy for both GTK3 and GTK4 =) 1649997 1 398711 aperez 2020-05-07 01:12:23 -0700 Created attachment 398711 Patch 1649998 2 ews-watchlist 2020-05-07 01:13:01 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1650017 3 ews-feeder 2020-05-07 02:05:40 -0700 Committed r261276: <https://trac.webkit.org/changeset/261276> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398711. 398711 2020-05-07 01:12:23 -0700 2020-05-07 02:05:40 -0700 Patch bug-211553-20200507111222.patch text/plain 2825 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY1ZTU3NTU3NDhiYWU0MDE0 MTliODBmMWUwNGFlYWEwZmNlYjM4NjkuLjI4YmEzYmU2NzIxOTVhNmZjNGI3ZjIzMmEwYzExYzU4 YTA3ODVkMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDUtMDcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gU3Rv cCB1c2luZyB0aGUgR3RrV2lkZ2V0LmRlc3Ryb3kgdmZ1bmMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTU1MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3 ZWJraXRXZWJWaWV3QmFzZURlc3Ryb3kpOiBSZW1vdmVkLgorICAgICAgICAod2Via2l0V2ViVmll d0Jhc2VEaXNwb3NlKTogQnJpbmcgaW4gdGhlIGNvZGUgZnJvbSB0aGUgcmVtb3ZlZCBmdW5jdGlv biwgYWRhcHQKKyAgICAgICAgdG8gdXNlIGdfY2xlYXJfcG9pbnRlcigpIHRvIGRlc3Ryb3kgdGhl IG5lc3RlZCBkaWFsb2cuCisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfYmFzZV9jbGFzc19pbml0 KTogRG8gbm90IHNldCB0aGUgR3RrV2lkZ2V0LmRlc3Ryb3kgdmZ1bmMuCisKIDIwMjAtMDUtMDYg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIENv Y29hQ29sb3IgaW4gbW9yZSBwbGFjZXMgaW5zdGVhZCBvZiBwbGF0Zm9ybSBkZWZpbmVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNl LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2Uu Y3BwCmluZGV4IDYyODg2NTdmNDA0YjFjN2IzYzY3OGFmNzQ5NGY3N2UwYmEzOTI2ZTQuLjRhYTY5 ZmJjOWYyNjRlZjViMDI4YTFhOWMzODAxYzJmZTczNDExYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC01ODYs NiArNTg2LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDb21wbGV0ZUVtb2ppQ2hv b3NlclJlcXVlc3QoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlYKIHN0YXRpYyB2b2lkIHdlYmtpdFdl YlZpZXdCYXNlRGlzcG9zZShHT2JqZWN0KiBnb2JqZWN0KQogewogICAgIFdlYktpdFdlYlZpZXdC YXNlKiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXX0JBU0UoZ29iamVjdCk7CisgICAgZ19jbGVh cl9wb2ludGVyKCZ3ZWJWaWV3LT5wcml2LT5kaWFsb2csIGd0a193aWRnZXRfZGVzdHJveSk7CiAg ICAgd2Via2l0V2ViVmlld0Jhc2VTZXRUb3BsZXZlbE9uU2NyZWVuV2luZG93KHdlYlZpZXcsIG51 bGxwdHIpOwogICAgIGlmICh3ZWJWaWV3LT5wcml2LT5hY2Nlc3NpYmxlKQogICAgICAgICB3ZWJr aXRXZWJWaWV3QWNjZXNzaWJsZVNldFdlYlZpZXcoV0VCS0lUX1dFQl9WSUVXX0FDQ0VTU0lCTEUo d2ViVmlldy0+cHJpdi0+YWNjZXNzaWJsZS5nZXQoKSksIG51bGxwdHIpOwpAQCAtMTY2MSwxNSAr MTY2Miw2IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzKEd0a1dpZGdl dCogd2lkZ2V0LCBHdGtEaXJlY3Rpb25UeXBlIGRpcmVjCiAgICAgcmV0dXJuIEdUS19XSURHRVRf Q0xBU1Mod2Via2l0X3dlYl92aWV3X2Jhc2VfcGFyZW50X2NsYXNzKS0+Zm9jdXMod2lkZ2V0LCBk aXJlY3Rpb24pOwogfQogCi1zdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZURlc3Ryb3koR3Rr V2lkZ2V0KiB3aWRnZXQpCi17Ci0gICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlKiBwcml2ID0g V0VCS0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KS0+cHJpdjsKLSAgICBpZiAocHJpdi0+ZGlhbG9n KQotICAgICAgICBndGtfd2lkZ2V0X2Rlc3Ryb3kocHJpdi0+ZGlhbG9nKTsKLQotICAgIEdUS19X SURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X2Jhc2VfcGFyZW50X2NsYXNzKS0+ZGVzdHJveSh3 aWRnZXQpOwotfQotCiBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUNvbnN0cnVjdGVkKEdP YmplY3QqIG9iamVjdCkKIHsKICAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfYmFz ZV9wYXJlbnRfY2xhc3MpLT5jb25zdHJ1Y3RlZChvYmplY3QpOwpAQCAtMTc3MCw3ICsxNzYyLDYg QEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2Jhc2VfY2xhc3NfaW5pdChXZWJLaXRXZWJW aWV3QmFzZUNsYXNzKiB3ZWJraXRXZWJWaWUKICNpZiAhVVNFKEdUSzQpCiAgICAgd2lkZ2V0Q2xh c3MtPmhpZXJhcmNoeV9jaGFuZ2VkID0gd2Via2l0V2ViVmlld0Jhc2VIaWVyYXJjaHlDaGFuZ2Vk OwogI2VuZGlmCi0gICAgd2lkZ2V0Q2xhc3MtPmRlc3Ryb3kgPSB3ZWJraXRXZWJWaWV3QmFzZURl c3Ryb3k7CiAKICAgICBHT2JqZWN0Q2xhc3MqIGdvYmplY3RDbGFzcyA9IEdfT0JKRUNUX0NMQVNT KHdlYmtpdFdlYlZpZXdCYXNlQ2xhc3MpOwogICAgIGdvYmplY3RDbGFzcy0+Y29uc3RydWN0ZWQg PSB3ZWJraXRXZWJWaWV3QmFzZUNvbnN0cnVjdGVkOwo=