21155 2008-09-26 15:19:59 -0700 controls should not show when the media element is not visible 2008-10-12 17:13:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 92979 0 eric.carlson 2008-09-26 15:19:59 -0700 Playback controls are visible even when the media element is set to visibility:hidden. To reproduce: 1. Open the attached page 2. Click the "visibility" href to hide the <video> element 3. Controls still visible. 4. Show the element by clicking the "visibility" link again 5. Start the movie playing so the controls hide 6. Click the "visibility" href to hide the <video> element 7. Mouse over the hidden <video> element 8. Controls show up again. 92981 1 23860 eric.carlson 2008-09-26 15:21:26 -0700 Created attachment 23860 test case 92983 2 eric.carlson 2008-09-26 15:25:22 -0700 Also, the controls never show up again if element is set to visibility:hidden while it is also display:none. 1. Open the attached page 2. Click the "display" link to set <video> element to display:none 3. Click the "visibility" link to set visibility:hidden 4. Click the "display" link to set display:block 5. Click the "visibility" link to set visibility:visible The controls aren't visible and don't ever show up unless you make the element visible while it is display:none. 92990 3 23861 eric.carlson 2008-09-26 15:59:03 -0700 Created attachment 23861 proposed patch 95111 4 andrew 2008-10-12 17:13:40 -0700 This was landed by Eric Carlson in r37470. 23860 2008-09-26 15:21:26 -0700 2008-09-26 15:21:26 -0700 test case display_none.html text/html 1385 eric.carlson PGh0bWwgbGFuZz0iZW4iPgoJPGhlYWQ+CgkJPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBl IiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPgoJCTx0aXRsZT5kaXNwbGF5Om5v bmU8L3RpdGxlPgoJCTxtZXRhIG5hbWU9ImdlbmVyYXRvciIgY29udGVudD0iVGV4dE1hdGUgaHR0 cDovL21hY3JvbWF0ZXMuY29tLyI+CgkgICAgPHNjcmlwdD4KCQkJZnVuY3Rpb24gcmVwb3J0U3Rh dGUoZWxlbWVudElELCBwcm9wZXJ0eSkKCQkJewogICAgICAgICAgICAgICAgdmFyIGN1cnJlbnRT dGF0ZSA9IGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoZWxlbWVudElEKSwgbnVsbCkuZ2V0UHJvcGVydHlWYWx1ZShwcm9wZXJ0eSk7 CgkgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChwcm9wZXJ0eSkuaW5uZXJIVE1M ID0gJyA6ICcgKyBjdXJyZW50U3RhdGU7CgkJCX0KCgkgICAgICAgIGZ1bmN0aW9uIHRvZ2dsZVN0 YXRlKGVsZW1lbnRJRCwgcHJvcGVydHksIHN0YXRlMSwgc3RhdGUyLCBzZW5kZXIpCgkgICAgICAg IHsKCSAgICAgICAgICAgIHZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoZWxlbWVu dElEKTsKICAgICAgICAgICAgICAgIHZhciBjdXJyZW50U3RhdGUgPSBkb2N1bWVudC5kZWZhdWx0 Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsZW0sIG51bGwpLmdldFByb3BlcnR5VmFsdWUocHJvcGVy dHkpOwogICAgICAgICAgICAgICAgdmFyIG5ld1N0YXRlID0gKHN0YXRlMSA9PSBjdXJyZW50U3Rh dGUpID8gc3RhdGUyIDogc3RhdGUxOwoKICAgICAgICAgICAgICAgIGVsZW0uc3R5bGVbcHJvcGVy dHldID0gbmV3U3RhdGU7CgkJCQlyZXBvcnRTdGF0ZShlbGVtZW50SUQsIHByb3BlcnR5KTsKCSAg ICAgICAgfQoJICAgIDwvc2NyaXB0PgoKCTwvaGVhZD4KCTxib2R5PgoJCTxkaXY+CgkJCTxhIGhy ZWY9ImphdmFzY3JpcHQ6dG9nZ2xlU3RhdGUoJ3ZpZCcsICdkaXNwbGF5JywgJ25vbmUnLCAnYmxv Y2snLCB0aGlzKSI+ZGlzcGxheTwvYT4KCQkJPHNwYW4gaWQ9ImRpc3BsYXkiPiA6IGJsb2NrPC9z cGFuPgoJCQk8YnI+CgkJCTxhIGhyZWY9ImphdmFzY3JpcHQ6dG9nZ2xlU3RhdGUoJ3ZpZCcsICd2 aXNpYmlsaXR5JywgJ3Zpc2libGUnLCAnaGlkZGVuJywgdGhpcykiPnZpc2liaWxpdHk8L2E+CgkJ CTxzcGFuIGlkPSJ2aXNpYmlsaXR5Ij4gOiB2aXNpYmxlPC9zcGFuPgoJCTxkaXY+CgoJCTx2aWRl byBpZD0ndmlkJyBzcmM9Imh0dHA6Ly9tb3ZpZXMuYXBwbGUuY29tL21vdmllcy93Yi9zcGVlZF9y YWNlci9zcGVlZF9yYWNlci10bHIyX2guNDgwLm1vdiIgY29udHJvbHMgPgoJCTwvdmlkZW8+CgoJ PC9ib2R5Pgo8L2h0bWw+Cgo= 23861 2008-09-26 15:59:03 -0700 2008-10-01 10:25:24 -0700 proposed patch patch.txt text/plain 3984 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjk3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDgtMDktMjYgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBo dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6cmVjYWxjU3R5bGUpOiBOZXcsIGNhbGwgcmVuZGVyZXIoKS0+dXBkYXRlRnJvbUVsZW1l bnQgdG8ga2VlcCBpdAorICAgICAgICBpbiBzeW5jIHdpdGggdmlzaWJpbGl0eSBjaGFuZ2VzCisg ICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlck1lZGlhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1lZGlhOjpSZW5kZXJNZWRp YSk6IGluaXRpYWxpemUgbV9wcmV2aW91c1Zpc2libGUKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ck1lZGlhOjp1cGRhdGVDb250cm9sVmlzaWJpbGl0eSk6IGNvbnNpZGVyIHN0eWxlKCktPnZpc2li aWxpdHkoKSB3aGVuIGRldGVybWluaW5nCisgICAgICAgIGlmIGVsZW1lbnQgaXMgdmlzaWJsZSBv ciBub3QuIERvbid0IGFuaW1hdGUgY29udHJvbGxlciB2aXNpYmlsaXR5IHdoZW4gY2hhbmdlIHRy aWdnZXJlZCBieQorICAgICAgICBzaG93aW5nIG9yIGhpZGluZyBtZWRpYSBlbGVtZW50LgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZWRpYS5oOiBkZWNsYXJlIG1fcHJldmlvdXNWaXNpYmxl CisKIDIwMDgtMDktMjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE0OQpJbmRleDogV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMzY5NzEpCisrKyBXZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Miw2ICsxNTIsMTQgQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50OjphdHRhY2goKQogICAgICAgICByZW5kZXJlcigpLT51cGRh dGVGcm9tRWxlbWVudCgpOwogfQogCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnJlY2FsY1N0eWxl KFN0eWxlQ2hhbmdlIGNoYW5nZSkKK3sKKyAgICBIVE1MRWxlbWVudDo6cmVjYWxjU3R5bGUoY2hh bmdlKTsKKworICAgIGlmIChyZW5kZXJlcigpKQorICAgICAgICByZW5kZXJlcigpLT51cGRhdGVG cm9tRWxlbWVudCgpOworfQorCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNjaGVkdWxlTG9hZCgp CiB7CiAgICAgbV9sb2FkVGltZXIuc3RhcnRPbmVTaG90KDApOwpJbmRleDogV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oCShyZXZpc2lvbiAzNjk3MSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgdm9pZCBpbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVk RnJvbURvY3VtZW50KCk7CiAgICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpOworICAgIHZpcnR1YWwg dm9pZCByZWNhbGNTdHlsZShTdHlsZUNoYW5nZSk7CiAgICAgCiAgICAgTWVkaWFQbGF5ZXIqIHBs YXllcigpIGNvbnN0IHsgcmV0dXJuIG1fcGxheWVyLmdldCgpOyB9CiAgICAgCkluZGV4OiBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJNZWRpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTWVkaWEuY3BwCShyZXZpc2lvbiAzNjk3MSkKKysrIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1lZGlhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsNyBAQCBSZW5k ZXJNZWRpYTo6UmVuZGVyTWVkaWEoSFRNTE1lZGlhRWxlbWVuCiAgICAgLCBtX29wYWNpdHlBbmlt YXRpb25TdGFydFRpbWUoMCkKICAgICAsIG1fb3BhY2l0eUFuaW1hdGlvbkZyb20oMCkKICAgICAs IG1fb3BhY2l0eUFuaW1hdGlvblRvKDEuMGYpCisgICAgLCBtX3ByZXZpb3VzVmlzaWJsZShWSVNJ QkxFKQogewogfQogCkBAIC0zMTIsOSArMzEzLDE4IEBAIHZvaWQgUmVuZGVyTWVkaWE6OnVwZGF0 ZUNvbnRyb2xWaXNpYmlsaXQKICAgICBpZiAocGxheWVyKCkgJiYgIXBsYXllcigpLT5oYXNWaWRl bygpIHx8ICFtZWRpYS0+aXNWaWRlbygpKQogICAgICAgICByZXR1cm47CiAgICAgLy8gZG8gZmFk aW5nIG1hbnVhbGx5LCBjc3MgYW5pbWF0aW9ucyBkb24ndCB3b3JrIHdlbGwgd2l0aCBzaGFkb3cg dHJlZXMKLSAgICBib29sIHZpc2libGUgPSBtX21vdXNlT3ZlciB8fCBtZWRpYS0+cGF1c2VkKCkg fHwgbWVkaWEtPmVuZGVkKCkgfHwgbWVkaWEtPm5ldHdvcmtTdGF0ZSgpIDwgSFRNTE1lZGlhRWxl bWVudDo6TE9BREVEX01FVEFEQVRBOworICAgIGJvb2wgdmlzaWJsZSA9IHN0eWxlKCktPnZpc2li aWxpdHkoKSA9PSBWSVNJQkxFICYmIChtX21vdXNlT3ZlciB8fCBtZWRpYS0+cGF1c2VkKCkgfHwg bWVkaWEtPmVuZGVkKCkgfHwgbWVkaWEtPm5ldHdvcmtTdGF0ZSgpIDwgSFRNTE1lZGlhRWxlbWVu dDo6TE9BREVEX01FVEFEQVRBKTsKICAgICBpZiAodmlzaWJsZSA9PSAobV9vcGFjaXR5QW5pbWF0 aW9uVG8gPiAwKSkKICAgICAgICAgcmV0dXJuOworCisgICAgaWYgKHN0eWxlKCktPnZpc2liaWxp dHkoKSAhPSBtX3ByZXZpb3VzVmlzaWJsZSkgeworICAgICAgICAvLyBkb24ndCBmYWRlIGdyYWR1 YWxseSBpZiBpdCB0aGUgZWxlbWVudCBoYXMganVzdCBjaGFuZ2VkIHZpc2liaWxpdHkKKyAgICAg ICAgbV9wcmV2aW91c1Zpc2libGUgPSBzdHlsZSgpLT52aXNpYmlsaXR5KCk7CisgICAgICAgIG1f b3BhY2l0eUFuaW1hdGlvblRvID0gbV9wcmV2aW91c1Zpc2libGUgPT0gVklTSUJMRSA/IDEuMGYg OiAwOworICAgICAgICBjaGFuZ2VPcGFjaXR5KG1fcGFuZWwuZ2V0KCksIDApOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgaWYgKHZpc2libGUpIHsKICAgICAgICAgbV9vcGFjaXR5QW5p bWF0aW9uRnJvbSA9IG1fcGFuZWwtPnJlbmRlcmVyKCktPnN0eWxlKCktPm9wYWNpdHkoKTsKICAg ICAgICAgbV9vcGFjaXR5QW5pbWF0aW9uVG8gPSAxLjBmOwpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTWVkaWEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJN ZWRpYS5oCShyZXZpc2lvbiAzNjk3MSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlh LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksNyBAQCBwcml2YXRlOgogICAgIGRvdWJs ZSBtX29wYWNpdHlBbmltYXRpb25TdGFydFRpbWU7CiAgICAgZmxvYXQgbV9vcGFjaXR5QW5pbWF0 aW9uRnJvbTsKICAgICBmbG9hdCBtX29wYWNpdHlBbmltYXRpb25UbzsKKyAgICBFVmlzaWJpbGl0 eSBtX3ByZXZpb3VzVmlzaWJsZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK