211535 2020-05-06 15:17:42 -0700 Give the DFG and FTL WorkList threads more stack space on ASAN builds. 2020-05-07 12:49:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211547 InRadar P2 Normal --- 1 mark.lam mark.lam ap benjamin cdumez cmarcelo ews-watchlist ggaren keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1649848 0 mark.lam 2020-05-06 15:17:42 -0700 This is because ASAN is a memory hungry beast, and we want the ASAN builds to get to exercise the same amount of code a regular build will (instead of failing out early with a stack overflow error). 1649850 1 webkit-bug-importer 2020-05-06 15:18:05 -0700 <rdar://problem/62947884> 1649878 2 398678 mark.lam 2020-05-06 16:08:30 -0700 Created attachment 398678 proposed patch. 1649880 3 ggaren 2020-05-06 16:13:43 -0700 /Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WTF/wtf/Threading.cpp:48:46: error: unused parameter 'threadType' [-Werror,-Wunused-parameter] 1649881 4 398680 mark.lam 2020-05-06 16:15:31 -0700 Created attachment 398680 proposed patch. 1649886 5 398680 ggaren 2020-05-06 16:26:53 -0700 Comment on attachment 398680 proposed patch. r=me 1649890 6 ap 2020-05-06 16:33:08 -0700 Will you be rolling back r260692 separately? 1649892 7 mark.lam 2020-05-06 16:34:25 -0700 (In reply to Alexey Proskuryakov from comment #6) > Will you be rolling back r260692 separately? Yes. Because there's another fix that I need to land first (work in progress). This bug is only 1 of 2 fixes. 1650287 8 mark.lam 2020-05-07 12:28:45 -0700 (In reply to Mark Lam from comment #7) > (In reply to Alexey Proskuryakov from comment #6) > > Will you be rolling back r260692 separately? > > Yes. Because there's another fix that I need to land first (work in > progress). This bug is only 1 of 2 fixes. The SUPPRESS_ASAN has been undone in r261325 for https://webkit.org/b/211547. 1650288 9 398680 mark.lam 2020-05-07 12:29:09 -0700 Comment on attachment 398680 proposed patch. Thanks for the review. Landing now. 1650306 10 ews-feeder 2020-05-07 12:49:42 -0700 Committed r261328: <https://trac.webkit.org/changeset/261328> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398680. 398678 2020-05-06 16:08:30 -0700 2020-05-06 16:15:31 -0700 proposed patch. bug-211535.patch text/plain 7550 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYxMjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDIwLTA1LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBH aXZlIHRoZSBERkcgYW5kIEZUTCBXb3JrTGlzdCB0aHJlYWRzIG1vcmUgc3RhY2sgc3BhY2Ugb24g QVNBTiBidWlsZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTE1MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyOTQ3ODg0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1dvcmtsaXN0 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpXb3JrbGlzdDo6VGhyZWFkQm9keTo6VGhyZWFkQm9k eSk6CisgICAgICAgIC0gTWFyayB0aGUgQXV0b21hdGljVGhyZWFkIGFzIFRocmVhZFR5cGU6OkNv bXBpbGVyLgorCiAyMDIwLTA1LTA2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4K IAogICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKG1faXNPd25lZEJ5TWFpblRocmVhZCA9PSBp c01haW5UaHJlYWQoKSkgd2hlbiB3ZWIgaW5zcGVjdGluZwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAJKHJldmlzaW9uIDI2MDY0OSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHV29ya2xpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3 ICs0MCw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIGNsYXNzIFdvcmtsaXN0 OjpUaHJlYWRCb2R5IDogcHVibGljIEF1dG9tYXRpY1RocmVhZCB7CiBwdWJsaWM6CiAgICAgVGhy ZWFkQm9keShjb25zdCBBYnN0cmFjdExvY2tlciYgbG9ja2VyLCBXb3JrbGlzdCYgd29ya2xpc3Qs IFRocmVhZERhdGEmIGRhdGEsIEJveDxMb2NrPiBsb2NrLCBSZWY8QXV0b21hdGljVGhyZWFkQ29u ZGl0aW9uPiYmIGNvbmRpdGlvbiwgaW50IHJlbGF0aXZlUHJpb3JpdHkpCi0gICAgICAgIDogQXV0 b21hdGljVGhyZWFkKGxvY2tlciwgbG9jaywgV1RGTW92ZShjb25kaXRpb24pKQorICAgICAgICA6 IEF1dG9tYXRpY1RocmVhZChsb2NrZXIsIGxvY2ssIFdURk1vdmUoY29uZGl0aW9uKSwgVGhyZWFk VHlwZTo6Q29tcGlsZXIpCiAgICAgICAgICwgbV93b3JrbGlzdCh3b3JrbGlzdCkKICAgICAgICAg LCBtX2RhdGEoZGF0YSkKICAgICAgICAgLCBtX3JlbGF0aXZlUHJpb3JpdHkocmVsYXRpdmVQcmlv cml0eSkKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjA2NDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDIwLTA1LTA2ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBHaXZlIHRoZSBERkcgYW5kIEZUTCBXb3JrTGlz dCB0aHJlYWRzIG1vcmUgc3RhY2sgc3BhY2Ugb24gQVNBTiBidWlsZHMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1MzUKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzYyOTQ3ODg0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIDEuIEFkZCB0aGUgYWJpbGl0eSB0byBzZXQgdGhlIFRocmVhZFR5cGUgZm9y IEF1dG9tYXRpY1RocmVhZHMuCisgICAgICAgIDIuIEdpdmUgVGhyZWFkVHlwZTo6Q29tcGlsZXIg KHdoaWNoIGN1cnJlbnRseSBvbmx5IHVzZWQgZm9yIHRoZSBERkcgYW5mIEZUTAorICAgICAgICAg ICBXb3JrTGlzdCB0aHJlYWRzKSBhIGxhcmdlciBzdGFjayBmb3IgT1MoREFSV0lOKSBvbiBBU0FO IGJ1aWxkcy4KKworICAgICAgICAgICBUaGlzIGlzIG5lZWRlZCBiZWNhdXNlIEFTQU4gaXMgYSBt ZW1vcnkgaHVuZ3J5IGJlYXN0LCBhbmQgd2Ugd2FudCB0aGUgQVNBTgorICAgICAgICAgICBidWls ZHMgdG8gZ2V0IHRvIGV4ZXJjaXNlIHRoZSBzYW1lIGFtb3VudCBvZiBjb2RlIGEgcmVndWxhciBi dWlsZCB3aWxsIChpbnN0ZWFkCisgICAgICAgICAgIG9mIGZhaWxpbmcgb3V0IGVhcmx5IHdpdGgg YSBzdGFjayBvdmVyZmxvdyBlcnJvcikuCisKKyAgICAgICAgKiB3dGYvQXV0b21hdGljVGhyZWFk LmNwcDoKKyAgICAgICAgKFdURjo6QXV0b21hdGljVGhyZWFkOjpBdXRvbWF0aWNUaHJlYWQpOgor ICAgICAgICAoV1RGOjpBdXRvbWF0aWNUaHJlYWQ6OnN0YXJ0KToKKyAgICAgICAgKiB3dGYvQXV0 b21hdGljVGhyZWFkLmg6CisgICAgICAgICogd3RmL1RocmVhZGluZy5jcHA6CisgICAgICAgIChX VEY6OnN0YWNrU2l6ZSk6CisgICAgICAgICogd3RmL1RocmVhZGluZy5oOgorCiAyMDIwLTA0LTIz ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtl XSBDTUFLRV9CSU5BUllfRElSIHNob3VsZCBhbHdheXMgYmUgYSBQUklWQVRFIGluY2x1ZGUgZGly ZWN0b3J5CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9BdXRvbWF0aWNUaHJlYWQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5jcHAJKHJldmlzaW9uIDI2MDY0 OSkKKysrIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMTkgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMjAgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC0xMDUsOSArMTA1LDE1IEBAIGJvb2wgQXV0b21hdGljVGhyZWFkQ29uZGl0aW9uOjpjb250 YWlucygKIH0KIAogQXV0b21hdGljVGhyZWFkOjpBdXRvbWF0aWNUaHJlYWQoY29uc3QgQWJzdHJh Y3RMb2NrZXImIGxvY2tlciwgQm94PExvY2s+IGxvY2ssIFJlZjxBdXRvbWF0aWNUaHJlYWRDb25k aXRpb24+JiYgY29uZGl0aW9uLCBTZWNvbmRzIHRpbWVvdXQpCisgICAgOiBBdXRvbWF0aWNUaHJl YWQobG9ja2VyLCBsb2NrLCBXVEZNb3ZlKGNvbmRpdGlvbiksIFRocmVhZFR5cGU6OlVua25vd24s IHRpbWVvdXQpCit7Cit9CisKK0F1dG9tYXRpY1RocmVhZDo6QXV0b21hdGljVGhyZWFkKGNvbnN0 IEFic3RyYWN0TG9ja2VyJiBsb2NrZXIsIEJveDxMb2NrPiBsb2NrLCBSZWY8QXV0b21hdGljVGhy ZWFkQ29uZGl0aW9uPiYmIGNvbmRpdGlvbiwgVGhyZWFkVHlwZSB0eXBlLCBTZWNvbmRzIHRpbWVv dXQpCiAgICAgOiBtX2xvY2sobG9jaykKICAgICAsIG1fY29uZGl0aW9uKFdURk1vdmUoY29uZGl0 aW9uKSkKICAgICAsIG1fdGltZW91dCh0aW1lb3V0KQorICAgICwgbV90aHJlYWRUeXBlKHR5cGUp CiB7CiAgICAgaWYgKHZlcmJvc2UpCiAgICAgICAgIGRhdGFMb2coUmF3UG9pbnRlcih0aGlzKSwg IjogQWxsb2NhdGVkIEF1dG9tYXRpY1RocmVhZC5cbiIpOwpAQCAtMjI3LDcgKzIzMyw3IEBAIHZv aWQgQXV0b21hdGljVGhyZWFkOjpzdGFydChjb25zdCBBYnN0cmEKICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQocmVzdWx0ID09IFdvcmtSZXN1bHQ6OkNv bnRpbnVlKTsKICAgICAgICAgICAgIH0KLSAgICAgICAgfSktPmRldGFjaCgpOworICAgICAgICB9 LCBtX3RocmVhZFR5cGUpLT5kZXRhY2goKTsKIH0KIAogdm9pZCBBdXRvbWF0aWNUaHJlYWQ6OnRo cmVhZERpZFN0YXJ0KCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5oCShyZXZpc2lvbiAy NjA2NDkpCisrKyBTb3VyY2UvV1RGL3d0Zi9BdXRvbWF0aWNUaHJlYWQuaAkod29ya2luZyBjb3B5 KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAxNyBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlIDx3dGYvQ29uZGl0aW9uLmg+CiAjaW5jbHVk ZSA8d3RmL0xvY2suaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KKyNp bmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1l c3BhY2UgV1RGIHsKQEAgLTEzMSw2ICsxMzIsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgLy8gVGhpcyBs b2dpY2FsbHkgY3JlYXRlcyB0aGUgdGhyZWFkLCBidXQgaW4gcmVhbGl0eSB0aGUgdGhyZWFkIHdv bid0IGJlIGNyZWF0ZWQgdW50aWwgc29tZW9uZQogICAgIC8vIGNhbGxzIEF1dG9tYXRpY1RocmVh ZENvbmRpdGlvbjo6bm90aWZ5T25lKCkgb3Igbm90aWZ5QWxsKCkuCiAgICAgQXV0b21hdGljVGhy ZWFkKGNvbnN0IEFic3RyYWN0TG9ja2VyJiwgQm94PExvY2s+LCBSZWY8QXV0b21hdGljVGhyZWFk Q29uZGl0aW9uPiYmLCBTZWNvbmRzIHRpbWVvdXQgPSAxMF9zKTsKKworICAgIEF1dG9tYXRpY1Ro cmVhZChjb25zdCBBYnN0cmFjdExvY2tlciYsIEJveDxMb2NrPiwgUmVmPEF1dG9tYXRpY1RocmVh ZENvbmRpdGlvbj4mJiwgVGhyZWFkVHlwZSwgU2Vjb25kcyB0aW1lb3V0ID0gMTBfcyk7CiAgICAg CiAgICAgLy8gVG8gdW5kZXJzdGFuZCBQb2xsUmVzdWx0IGFuZCBXb3JrUmVzdWx0LCBpbWFnaW5l IHRoYXQgcG9sbCgpIGFuZCB3b3JrKCkgYXJlIGJlaW5nIGNhbGxlZCBsaWtlCiAgICAgLy8gc286 CkBAIC0xODMsNiArMTg2LDcgQEAgcHJpdmF0ZToKICAgICBCb3g8TG9jaz4gbV9sb2NrOwogICAg IFJlZjxBdXRvbWF0aWNUaHJlYWRDb25kaXRpb24+IG1fY29uZGl0aW9uOwogICAgIFNlY29uZHMg bV90aW1lb3V0OworICAgIFRocmVhZFR5cGUgbV90aHJlYWRUeXBlIHsgVGhyZWFkVHlwZTo6VW5r bm93biB9OwogICAgIGJvb2wgbV9pc1J1bm5pbmcgeyB0cnVlIH07CiAgICAgYm9vbCBtX2lzV2Fp dGluZyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2hhc1VuZGVybHlpbmdUaHJlYWQgeyBmYWxzZSB9 OwpJbmRleDogU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmcuY3BwCShyZXZpc2lvbiAyNjA2NDkpCisrKyBTb3VyY2UvV1RG L3d0Zi9UaHJlYWRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAq IENvcHlyaWdodCAoQykgMjAwOC0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoQykgMjAwOC0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNTIsOSArNTIsMTAgQEAgc3Rh dGljIE9wdGlvbmFsPHNpemVfdD4gc3RhY2tTaXplKFRocmVhZAogICAgIC8vIEVuYWJsZSBTVEFD S19TVEFUUyBpbiBTdGFja1N0YXRzLmggdG8gY3JlYXRlIGEgYnVpbGQgdGhhdCB3aWxsIHRyYWNr IHRoZSBpbmZvcm1hdGlvbiBmb3IgdHVuaW5nLgogI2lmIFBMQVRGT1JNKFBMQVlTVEFUSU9OKQog ICAgIGlmICh0aHJlYWRUeXBlID09IFRocmVhZFR5cGU6OkphdmFTY3JpcHQpCi0gICAgICAgIHJl dHVybiA1MTIgKiAxMDI0OwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0odGhyZWFkVHlwZSk7Cisg ICAgICAgIHJldHVybiA1MTIgKiBLQjsKKyNlbGlmIE9TKERBUldJTikgJiYgQVNBTl9FTkFCTEVE CisgICAgaWYgKHRocmVhZFR5cGUgPT0gVGhyZWFkVHlwZTo6Q29tcGlsZXIpCisgICAgICAgIHJl dHVybiAxICogTUI7IC8vIEFTYW4gbmVlZHMgbW9yZSBzdGFjayBzcGFjZSAoZXNwZWNpYWxseSBv biBEZWJ1ZyBidWlsZHMpLgogI2VuZGlmCiAKICNpZiBkZWZpbmVkKERFRkFVTFRfVEhSRUFEX1NU QUNLX1NJWkVfSU5fS0IpICYmIERFRkFVTFRfVEhSRUFEX1NUQUNLX1NJWkVfSU5fS0IgPiAwCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L3d0Zi9UaHJlYWRpbmcuaAkocmV2aXNpb24gMjYwNjQ5KQorKysgU291cmNlL1dURi93dGYvVGhy ZWFkaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDA3LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDA3LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29w eXJpZ2h0IChDKSAyMDA3IEp1c3RpbiBIYXlnb29kIDxqaGF5Z29vZEByZWFrdGl4LmNvbT4KICAq IENvcHlyaWdodCAoQykgMjAxNyBZdXN1a2UgU3V6dWtpIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+ CiAgKgpAQCAtODUsNiArODUsNyBAQCBlbnVtIGNsYXNzIEdDVGhyZWFkVHlwZSA6IHVpbnQ4X3Qg ewogZW51bSBjbGFzcyBUaHJlYWRUeXBlIDogdWludDhfdCB7CiAgICAgVW5rbm93biA9IDAsCiAg ICAgSmF2YVNjcmlwdCwKKyAgICBDb21waWxlciwKICAgICBHYXJiYWdlQ29sbGVjdGlvbiwKICAg ICBOZXR3b3JrLAogICAgIEdyYXBoaWNzLAo= 398680 2020-05-06 16:15:31 -0700 2020-05-07 12:49:43 -0700 proposed patch. bug-211535.patch text/plain 7463 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYxMjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDIwLTA1LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBH aXZlIHRoZSBERkcgYW5kIEZUTCBXb3JrTGlzdCB0aHJlYWRzIG1vcmUgc3RhY2sgc3BhY2Ugb24g QVNBTiBidWlsZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTE1MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyOTQ3ODg0PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1dvcmtsaXN0 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpXb3JrbGlzdDo6VGhyZWFkQm9keTo6VGhyZWFkQm9k eSk6CisgICAgICAgIC0gTWFyayB0aGUgQXV0b21hdGljVGhyZWFkIGFzIFRocmVhZFR5cGU6OkNv bXBpbGVyLgorCiAyMDIwLTA1LTA2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4K IAogICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKG1faXNPd25lZEJ5TWFpblRocmVhZCA9PSBp c01haW5UaHJlYWQoKSkgd2hlbiB3ZWIgaW5zcGVjdGluZwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAJKHJldmlzaW9uIDI2MDY0OSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHV29ya2xpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3 ICs0MCw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIGNsYXNzIFdvcmtsaXN0 OjpUaHJlYWRCb2R5IDogcHVibGljIEF1dG9tYXRpY1RocmVhZCB7CiBwdWJsaWM6CiAgICAgVGhy ZWFkQm9keShjb25zdCBBYnN0cmFjdExvY2tlciYgbG9ja2VyLCBXb3JrbGlzdCYgd29ya2xpc3Qs IFRocmVhZERhdGEmIGRhdGEsIEJveDxMb2NrPiBsb2NrLCBSZWY8QXV0b21hdGljVGhyZWFkQ29u ZGl0aW9uPiYmIGNvbmRpdGlvbiwgaW50IHJlbGF0aXZlUHJpb3JpdHkpCi0gICAgICAgIDogQXV0 b21hdGljVGhyZWFkKGxvY2tlciwgbG9jaywgV1RGTW92ZShjb25kaXRpb24pKQorICAgICAgICA6 IEF1dG9tYXRpY1RocmVhZChsb2NrZXIsIGxvY2ssIFdURk1vdmUoY29uZGl0aW9uKSwgVGhyZWFk VHlwZTo6Q29tcGlsZXIpCiAgICAgICAgICwgbV93b3JrbGlzdCh3b3JrbGlzdCkKICAgICAgICAg LCBtX2RhdGEoZGF0YSkKICAgICAgICAgLCBtX3JlbGF0aXZlUHJpb3JpdHkocmVsYXRpdmVQcmlv cml0eSkKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjA2NDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDIwLTA1LTA2ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBHaXZlIHRoZSBERkcgYW5kIEZUTCBXb3JrTGlz dCB0aHJlYWRzIG1vcmUgc3RhY2sgc3BhY2Ugb24gQVNBTiBidWlsZHMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1MzUKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzYyOTQ3ODg0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIDEuIEFkZCB0aGUgYWJpbGl0eSB0byBzZXQgdGhlIFRocmVhZFR5cGUgZm9y IEF1dG9tYXRpY1RocmVhZHMuCisgICAgICAgIDIuIEdpdmUgVGhyZWFkVHlwZTo6Q29tcGlsZXIg KHdoaWNoIGN1cnJlbnRseSBvbmx5IHVzZWQgZm9yIHRoZSBERkcgYW5mIEZUTAorICAgICAgICAg ICBXb3JrTGlzdCB0aHJlYWRzKSBhIGxhcmdlciBzdGFjayBmb3IgT1MoREFSV0lOKSBvbiBBU0FO IGJ1aWxkcy4KKworICAgICAgICAgICBUaGlzIGlzIG5lZWRlZCBiZWNhdXNlIEFTQU4gaXMgYSBt ZW1vcnkgaHVuZ3J5IGJlYXN0LCBhbmQgd2Ugd2FudCB0aGUgQVNBTgorICAgICAgICAgICBidWls ZHMgdG8gZ2V0IHRvIGV4ZXJjaXNlIHRoZSBzYW1lIGFtb3VudCBvZiBjb2RlIGEgcmVndWxhciBi dWlsZCB3aWxsIChpbnN0ZWFkCisgICAgICAgICAgIG9mIGZhaWxpbmcgb3V0IGVhcmx5IHdpdGgg YSBzdGFjayBvdmVyZmxvdyBlcnJvcikuCisKKyAgICAgICAgKiB3dGYvQXV0b21hdGljVGhyZWFk LmNwcDoKKyAgICAgICAgKFdURjo6QXV0b21hdGljVGhyZWFkOjpBdXRvbWF0aWNUaHJlYWQpOgor ICAgICAgICAoV1RGOjpBdXRvbWF0aWNUaHJlYWQ6OnN0YXJ0KToKKyAgICAgICAgKiB3dGYvQXV0 b21hdGljVGhyZWFkLmg6CisgICAgICAgICogd3RmL1RocmVhZGluZy5jcHA6CisgICAgICAgIChX VEY6OnN0YWNrU2l6ZSk6CisgICAgICAgICogd3RmL1RocmVhZGluZy5oOgorCiAyMDIwLTA0LTIz ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtl XSBDTUFLRV9CSU5BUllfRElSIHNob3VsZCBhbHdheXMgYmUgYSBQUklWQVRFIGluY2x1ZGUgZGly ZWN0b3J5CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9BdXRvbWF0aWNUaHJlYWQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5jcHAJKHJldmlzaW9uIDI2MDY0 OSkKKysrIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMTkgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE2LTIwMjAgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC0xMDUsOSArMTA1LDE1IEBAIGJvb2wgQXV0b21hdGljVGhyZWFkQ29uZGl0aW9uOjpjb250 YWlucygKIH0KIAogQXV0b21hdGljVGhyZWFkOjpBdXRvbWF0aWNUaHJlYWQoY29uc3QgQWJzdHJh Y3RMb2NrZXImIGxvY2tlciwgQm94PExvY2s+IGxvY2ssIFJlZjxBdXRvbWF0aWNUaHJlYWRDb25k aXRpb24+JiYgY29uZGl0aW9uLCBTZWNvbmRzIHRpbWVvdXQpCisgICAgOiBBdXRvbWF0aWNUaHJl YWQobG9ja2VyLCBsb2NrLCBXVEZNb3ZlKGNvbmRpdGlvbiksIFRocmVhZFR5cGU6OlVua25vd24s IHRpbWVvdXQpCit7Cit9CisKK0F1dG9tYXRpY1RocmVhZDo6QXV0b21hdGljVGhyZWFkKGNvbnN0 IEFic3RyYWN0TG9ja2VyJiBsb2NrZXIsIEJveDxMb2NrPiBsb2NrLCBSZWY8QXV0b21hdGljVGhy ZWFkQ29uZGl0aW9uPiYmIGNvbmRpdGlvbiwgVGhyZWFkVHlwZSB0eXBlLCBTZWNvbmRzIHRpbWVv dXQpCiAgICAgOiBtX2xvY2sobG9jaykKICAgICAsIG1fY29uZGl0aW9uKFdURk1vdmUoY29uZGl0 aW9uKSkKICAgICAsIG1fdGltZW91dCh0aW1lb3V0KQorICAgICwgbV90aHJlYWRUeXBlKHR5cGUp CiB7CiAgICAgaWYgKHZlcmJvc2UpCiAgICAgICAgIGRhdGFMb2coUmF3UG9pbnRlcih0aGlzKSwg IjogQWxsb2NhdGVkIEF1dG9tYXRpY1RocmVhZC5cbiIpOwpAQCAtMjI3LDcgKzIzMyw3IEBAIHZv aWQgQXV0b21hdGljVGhyZWFkOjpzdGFydChjb25zdCBBYnN0cmEKICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQocmVzdWx0ID09IFdvcmtSZXN1bHQ6OkNv bnRpbnVlKTsKICAgICAgICAgICAgIH0KLSAgICAgICAgfSktPmRldGFjaCgpOworICAgICAgICB9 LCBtX3RocmVhZFR5cGUpLT5kZXRhY2goKTsKIH0KIAogdm9pZCBBdXRvbWF0aWNUaHJlYWQ6OnRo cmVhZERpZFN0YXJ0KCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F1dG9tYXRpY1RocmVhZC5oCShyZXZpc2lvbiAy NjA2NDkpCisrKyBTb3VyY2UvV1RGL3d0Zi9BdXRvbWF0aWNUaHJlYWQuaAkod29ya2luZyBjb3B5 KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAxNyBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlIDx3dGYvQ29uZGl0aW9uLmg+CiAjaW5jbHVk ZSA8d3RmL0xvY2suaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KKyNp bmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1l c3BhY2UgV1RGIHsKQEAgLTEzMSw2ICsxMzIsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgLy8gVGhpcyBs b2dpY2FsbHkgY3JlYXRlcyB0aGUgdGhyZWFkLCBidXQgaW4gcmVhbGl0eSB0aGUgdGhyZWFkIHdv bid0IGJlIGNyZWF0ZWQgdW50aWwgc29tZW9uZQogICAgIC8vIGNhbGxzIEF1dG9tYXRpY1RocmVh ZENvbmRpdGlvbjo6bm90aWZ5T25lKCkgb3Igbm90aWZ5QWxsKCkuCiAgICAgQXV0b21hdGljVGhy ZWFkKGNvbnN0IEFic3RyYWN0TG9ja2VyJiwgQm94PExvY2s+LCBSZWY8QXV0b21hdGljVGhyZWFk Q29uZGl0aW9uPiYmLCBTZWNvbmRzIHRpbWVvdXQgPSAxMF9zKTsKKworICAgIEF1dG9tYXRpY1Ro cmVhZChjb25zdCBBYnN0cmFjdExvY2tlciYsIEJveDxMb2NrPiwgUmVmPEF1dG9tYXRpY1RocmVh ZENvbmRpdGlvbj4mJiwgVGhyZWFkVHlwZSwgU2Vjb25kcyB0aW1lb3V0ID0gMTBfcyk7CiAgICAg CiAgICAgLy8gVG8gdW5kZXJzdGFuZCBQb2xsUmVzdWx0IGFuZCBXb3JrUmVzdWx0LCBpbWFnaW5l IHRoYXQgcG9sbCgpIGFuZCB3b3JrKCkgYXJlIGJlaW5nIGNhbGxlZCBsaWtlCiAgICAgLy8gc286 CkBAIC0xODMsNiArMTg2LDcgQEAgcHJpdmF0ZToKICAgICBCb3g8TG9jaz4gbV9sb2NrOwogICAg IFJlZjxBdXRvbWF0aWNUaHJlYWRDb25kaXRpb24+IG1fY29uZGl0aW9uOwogICAgIFNlY29uZHMg bV90aW1lb3V0OworICAgIFRocmVhZFR5cGUgbV90aHJlYWRUeXBlIHsgVGhyZWFkVHlwZTo6VW5r bm93biB9OwogICAgIGJvb2wgbV9pc1J1bm5pbmcgeyB0cnVlIH07CiAgICAgYm9vbCBtX2lzV2Fp dGluZyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2hhc1VuZGVybHlpbmdUaHJlYWQgeyBmYWxzZSB9 OwpJbmRleDogU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmcuY3BwCShyZXZpc2lvbiAyNjA2NDkpCisrKyBTb3VyY2UvV1RG L3d0Zi9UaHJlYWRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAq IENvcHlyaWdodCAoQykgMjAwOC0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoQykgMjAwOC0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNTIsNyArNTIsMTAgQEAgc3Rh dGljIE9wdGlvbmFsPHNpemVfdD4gc3RhY2tTaXplKFRocmVhZAogICAgIC8vIEVuYWJsZSBTVEFD S19TVEFUUyBpbiBTdGFja1N0YXRzLmggdG8gY3JlYXRlIGEgYnVpbGQgdGhhdCB3aWxsIHRyYWNr IHRoZSBpbmZvcm1hdGlvbiBmb3IgdHVuaW5nLgogI2lmIFBMQVRGT1JNKFBMQVlTVEFUSU9OKQog ICAgIGlmICh0aHJlYWRUeXBlID09IFRocmVhZFR5cGU6OkphdmFTY3JpcHQpCi0gICAgICAgIHJl dHVybiA1MTIgKiAxMDI0OworICAgICAgICByZXR1cm4gNTEyICogS0I7CisjZWxpZiBPUyhEQVJX SU4pICYmIEFTQU5fRU5BQkxFRAorICAgIGlmICh0aHJlYWRUeXBlID09IFRocmVhZFR5cGU6OkNv bXBpbGVyKQorICAgICAgICByZXR1cm4gMSAqIE1COyAvLyBBU2FuIG5lZWRzIG1vcmUgc3RhY2sg c3BhY2UgKGVzcGVjaWFsbHkgb24gRGVidWcgYnVpbGRzKS4KICNlbHNlCiAgICAgVU5VU0VEX1BB UkFNKHRocmVhZFR5cGUpOwogI2VuZGlmCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuaAkocmV2aXNpb24gMjYw NjQ5KQorKysgU291cmNlL1dURi93dGYvVGhyZWFkaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTEs NSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA3LTIwMTggQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA3LTIwMjAgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDA3IEp1c3RpbiBIYXlnb29k IDxqaGF5Z29vZEByZWFrdGl4LmNvbT4KICAqIENvcHlyaWdodCAoQykgMjAxNyBZdXN1a2UgU3V6 dWtpIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAgKgpAQCAtODUsNiArODUsNyBAQCBlbnVtIGNs YXNzIEdDVGhyZWFkVHlwZSA6IHVpbnQ4X3QgewogZW51bSBjbGFzcyBUaHJlYWRUeXBlIDogdWlu dDhfdCB7CiAgICAgVW5rbm93biA9IDAsCiAgICAgSmF2YVNjcmlwdCwKKyAgICBDb21waWxlciwK ICAgICBHYXJiYWdlQ29sbGVjdGlvbiwKICAgICBOZXR3b3JrLAogICAgIEdyYXBoaWNzLAo=