211532 2020-05-06 14:30:47 -0700 Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange` 2020-05-07 11:39:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211523 InRadar P2 Normal --- 1 thorton thorton aakash_jain ap webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1649800 0 thorton 2020-05-06 14:30:47 -0700 Add a test for `REGRESSION (r260753): Frequent crashes under TextIndicator's estimatedTextColorsForRange` 1649801 1 398658 thorton 2020-05-06 14:31:09 -0700 Created attachment 398658 Patch 1649820 2 ews-feeder 2020-05-06 14:54:07 -0700 Committed r261251: <https://trac.webkit.org/changeset/261251> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398658. 1649822 3 webkit-bug-importer 2020-05-06 14:55:14 -0700 <rdar://problem/62946934> 1650112 4 aakash_jain 2020-05-07 08:34:17 -0700 (In reply to EWS from comment #2) > Committed r261251: <https://trac.webkit.org/changeset/261251> The newly added test fast/text-indicator/text-indicator-estimated-color-with-implicit-newline.html seems to be failing consistently on ios-wk2, as also indicated by red ews bubble. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext-indicator%2Ftext-indicator-estimated-color-with-implicit-newline.html 1650140 5 ryanhaddad 2020-05-07 09:23:41 -0700 Reverted r261251 for reason: Test is failing on iOS Committed r261295: <https://trac.webkit.org/changeset/261295> 1650247 6 thorton 2020-05-07 11:39:20 -0700 https://trac.webkit.org/changeset/261321/webkit 398658 2020-05-06 14:31:09 -0700 2020-05-06 14:54:07 -0700 Patch bug-211532-20200506143108.patch text/plain 3269 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjA1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzU5YzdkNWE5OTYyNGIyYmVkMTY3 OGRkYTgyMTNhNTMxZmU3YjYyOS4uZjM4YTQ0YmMzNDk1MWI2N2EyNzkxYWMyZmE3OTA4ODQyMzc2 OWZlYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTA2ICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIGBSRUdSRVNT SU9OIChyMjYwNzUzKTogRnJlcXVlbnQgY3Jhc2hlcyB1bmRlciBUZXh0SW5kaWNhdG9yJ3MgZXN0 aW1hdGVkVGV4dENvbG9yc0ZvclJhbmdlYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjExNTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQtaW5kaWNhdG9yL3RleHQtaW5kaWNhdG9yLWVz dGltYXRlZC1jb2xvci13aXRoLWltcGxpY2l0LW5ld2xpbmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L3RleHQtaW5kaWNhdG9yL3RleHQtaW5kaWNhdG9yLWVzdGltYXRlZC1j b2xvci13aXRoLWltcGxpY2l0LW5ld2xpbmUuaHRtbDogQWRkZWQuCisgICAgICAgIFRoaXMgdGVz dCB3b3VsZCB0cmlnZ2VyIHRoZSBudWxsIGRlcmVmIGZpeGVkIGluIHIyNjEyNDUuCisKIDIwMjAt MDUtMDUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBmYXN0L292 ZXJmbG93L2hvcml6b250YWwtc2Nyb2xsLWFmdGVyLWJhY2suaHRtbCBpcyBhIGZsYWt5IHRpbWVv dXQgb24gbWFjT1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC1pbmRpY2F0b3Iv dGV4dC1pbmRpY2F0b3ItZXN0aW1hdGVkLWNvbG9yLXdpdGgtaW1wbGljaXQtbmV3bGluZS1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQtaW5kaWNhdG9yL3RleHQtaW5kaWNhdG9y LWVzdGltYXRlZC1jb2xvci13aXRoLWltcGxpY2l0LW5ld2xpbmUtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjAwMzkyODM5YTU0ZWQzOGZkMjQ0NTlhMmViNGNmYTJlZmI0ZTYxOWUKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQtaW5kaWNhdG9yL3RleHQtaW5kaWNhdG9y LWVzdGltYXRlZC1jb2xvci13aXRoLWltcGxpY2l0LW5ld2xpbmUtZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMyBAQAoraW5kaWNhdG9yOiAKKyAgICAwIDAgODQgMjIKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC90ZXh0LWluZGljYXRvci90ZXh0LWluZGljYXRvci1lc3RpbWF0ZWQtY29s b3Itd2l0aC1pbXBsaWNpdC1uZXdsaW5lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQtaW5k aWNhdG9yL3RleHQtaW5kaWNhdG9yLWVzdGltYXRlZC1jb2xvci13aXRoLWltcGxpY2l0LW5ld2xp bmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi41OTc0YjhkNWFmYjFkN2UyZWEyMDZiYjM5YzkzOWQ0NzM5NGNm OTlmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0LWluZGljYXRvci90 ZXh0LWluZGljYXRvci1lc3RpbWF0ZWQtY29sb3Itd2l0aC1pbXBsaWNpdC1uZXdsaW5lLmh0bWwK QEAgLTAsMCArMSw1MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxl PgorKiB7IGJveC1zaXppbmc6IGJvcmRlci1ib3g7IGZvbnQtZmFtaWx5OiBhaGVtOyB9Citib2R5 IHsgbWFyZ2luOiAwOyB9CitkaXYgeyBwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMDsgbGVmdDog MDsgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVz dFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIG91dHB1dChzKQoreworICAgIHdpbmRv dy5sb2cuaW5uZXJUZXh0ICs9IHMgKyAiXG4iOworfQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sK KyAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMpIHsKKyAgICAgICAgb3V0cHV0KCJUaGlzIHRlc3Qg Y2Fubm90IGJlIHJ1biBvdXRzaWRlIG9mIFdlYktpdFRlc3RSdW5uZXIuIik7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBkdW1wSW5kaWNhdG9yQm91bmRzRm9yRWxlbWVu dChlbCkKKyAgICB7CisgICAgICAgIHZhciBpbmRpY2F0b3JPcHRpb25zID0geworICAgICAgICAg ICAgImNvbXB1dGVFc3RpbWF0ZWRCYWNrZ3JvdW5kQ29sb3IiOiB0cnVlLAorICAgICAgICB9Owor ICAgICAgICB2YXIgcmFuZ2UgPSBpbnRlcm5hbHMucmFuZ2VGcm9tTG9jYXRpb25BbmRMZW5ndGgo ZWwsIDAsIDkpOworICAgICAgICB2YXIgaW5kaWNhdG9yID0gd2luZG93LmludGVybmFscy50ZXh0 SW5kaWNhdG9yRm9yUmFuZ2UocmFuZ2UsIGluZGljYXRvck9wdGlvbnMpOworICAgICAgICB2YXIg cmVjdHMgPSBpbmRpY2F0b3IudGV4dFJlY3RzSW5Cb3VuZGluZ1JlY3RDb29yZGluYXRlczsKKwor ICAgICAgICBvdXRwdXQoYCR7ZWwuaWR9OiBgKTsKKyAgICAgICAgZm9yICh2YXIgcmVjdCBvZiBy ZWN0cykKKyAgICAgICAgICAgIG91dHB1dChgICAgICR7cmVjdC54fSAke3JlY3QueX0gJHtyZWN0 LndpZHRofSAke3JlY3QuaGVpZ2h0fWApOworICAgIH0KKworICAgIGR1bXBJbmRpY2F0b3JCb3Vu ZHNGb3JFbGVtZW50KGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbmRpY2F0b3IiKSk7CisKKyAg ICAvLyBSZW1vdmUgdGhlIHRlc3QgY2FzZXMgc28gdGhleSBkb24ndCBzaG93IHVwIGluIHRoZSBk dW1wLgorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Q2FzZXMiKS5pbm5lclRleHQg PSAiIjsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgor PGRpdiBpZD0idGVzdENhc2VzIj4KKyAgICA8ZGl2IGlkPSJpbmRpY2F0b3IiPjxpbWcgc3JjPSIu Li9pbWFnZXMvcmVzb3VyY2VzL2dyZWVuLTI1NngyNTYuanBnIj48aDM+dGV4dDwvaDM+PC9kaXY+ Cis8L2Rpdj4KKzxwcmUgaWQ9ImxvZyI+PC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQo=