211531 2020-05-06 14:30:32 -0700 DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs. 2020-05-07 11:04:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211576 https://bugs.webkit.org/show_bug.cgi?id=211543 InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1649799 0 keith_miller 2020-05-06 14:30:32 -0700 GetByVal and HasIndexedProperty should clobberTop until Fixup Phase runs. 1649809 1 398660 keith_miller 2020-05-06 14:36:59 -0700 Created attachment 398660 Patch 1649827 2 398667 keith_miller 2020-05-06 14:59:00 -0700 Created attachment 398667 Patch 1649828 3 keith_miller 2020-05-06 15:00:02 -0700 rdar://problem/62838095 1649840 4 398667 ysuzuki 2020-05-06 15:10:12 -0700 Comment on attachment 398667 Patch r=me 1649873 5 398667 mark.lam 2020-05-06 16:00:59 -0700 Comment on attachment 398667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398667&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:159 > + // Since Fixup can do widen our ArrayModes based on profiling from other nodes we pessimistically assume /can do widen/can widen/ 1649899 6 keith_miller 2020-05-06 17:00:39 -0700 Committed r261260: <https://trac.webkit.org/changeset/261260> 1649950 7 ryanhaddad 2020-05-06 20:44:03 -0700 (In reply to Keith Miller from comment #6) > Committed r261260: <https://trac.webkit.org/changeset/261260> This appears to have broken 26 JSC tests: https://build.webkit.org/builders/Apple-Catalina-Release-JSC-Tests/builds/1894 1650135 8 ryanhaddad 2020-05-07 09:19:24 -0700 Reverted r261260 for reason: Caused 26 JSC test failures Committed r261293: <https://trac.webkit.org/changeset/261293> 1650223 9 keith_miller 2020-05-07 11:01:43 -0700 I relanded this with https://trac.webkit.org/changeset/261313 398660 2020-05-06 14:36:59 -0700 2020-05-06 14:58:59 -0700 Patch bug-211531-20200506143658.patch text/plain 7326 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZTI2ZmUwMGFiYTM0YWI1MWRlMzkwZTM2N2JjMjE0ZTFjMDRlNjY3Li5kMGU5MDVlZTg1OTJiOTY1 MWRiNjU5MTY4NGVlYThhYWJmMjU2MTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMSBAQAorMjAyMC0wNS0wNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBHZXRCeVZhbCBhbmQgSGFzSW5kZXhlZFByb3BlcnR5IHNob3VsZCBj bG9iYmVyVG9wIHVudGlsIEZpeHVwIFBoYXNlIHJ1bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHBhcnNpbmcgYnl0ZWNvZGUgd2UgbWF5IHBp Y2sgYSByZWxhdGl2ZWx5IGNvbnN0cmFpbmVkCisgICAgICAgIEFycmF5TW9kZSBiYXNlZCBvbiBv dXIgcHJvZmlsaW5nLiBTb21lIG9mIHRoZXNlIG1vZGVzIG1heSBub3QKKyAgICAgICAgY2xvYmJl ciBleGl0IHN0YXRlLiAgSG93ZXZlciwgRml4dXAgc29tZXRpbWVzIHdhbnRzIHRvIHdpZGVuIHRo aXMKKyAgICAgICAgdG8gYSBtb3JlIGdlbmVyaWMgbW9kZSBiYXNlZCBvbiBvdGhlciBkYXRhLiBU aGlzIGNhdXNlZCB1cyB0bworICAgICAgICB0aGluayBpdCB3YXMgdmFsaWQgdG8gZXhpdCBpbW1l ZGlhdGVseSBhZnRlciB0aGUKKyAgICAgICAgR2V0QnlWYWwvSGFzSW5kZXhlZFByb3BlcnR5LCB3 aGljaCB3b3VsZCBiZSB3cm9uZyB3aXRoIHRoZSB3aWRlcgorICAgICAgICBBcnJheU1vZGUuCisK KyAgICAgICAgVG8gZml4IHRoaXMgY2xvYmJlcml6ZSBzaG91bGQgc2F5IEFsbAorICAgICAgICBH ZXRCeVZhbC9IYXNJbmRleGVkUHJvcGVydHkncyBjbG9iYmVyVG9wKCkgdW50aWwgYWZ0ZXIKKyAg ICAgICAgZml4dXAuIFRoZXNlIGFyZSB0aGUgb25seSBub2RlcyB0aGF0IGN1cnJlbnRseSBuZWVk IHRoaXMuIEFsbCB0aGUKKyAgICAgICAgb3RoZXIgbm9kZXMgdXNpbmcgQXJyYXlNb2RlcyBlaXRo ZXIgcGVyZm9ybSB3cml0ZXMgb3IgdGhlaXIKKyAgICAgICAgZ2VuZXJpYyBmb3JtcyBkb24ndCBj bG9iYmVyVG9wKCkuCisKKyAgICAgICAgKiBkZmcvREZHQ2xvYmJlcml6ZS5oOgorICAgICAgICAo SlNDOjpERkc6OmNsb2JiZXJpemUpOgorICAgICAgICAqIGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUpOgorICAgICAgICAoSlND OjpERkc6OnBlcmZvcm1GaXh1cCk6CisgICAgICAgICogZGZnL0RGR0dyYXBoLmg6CisKIDIwMjAt MDUtMDUgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAg IFtJbnRsXSBBbHBoYWJldGl6ZSBleHRlbnNpb24ga2V5cyBhbmQgY29ycmVjdGx5IG1hcmsgY29u c3QgbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9i YmVyaXplLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAppbmRl eCA2MGU2YmUwYmUwNDI5MjEwNDI0NjYzN2U2NTI2MGQ1MTM4YjQzNTQ1Li5jZmVjZTlhZjQ2Yjdm NjYzNTgxYjQzYzNjZGM3NThhODNkMTEzODU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Nsb2JiZXJpemUuaApAQCAtMzI2LDYgKzMyNiwxNCBAQCB2b2lkIGNsb2JiZXJpemUoR3Jh cGgmIGdyYXBoLCBOb2RlKiBub2RlLCBjb25zdCBSZWFkRnVuY3RvciYgcmVhZCwgY29uc3QgV3Jp dGVGdQogICAgIH0KIAogICAgIGNhc2UgSGFzSW5kZXhlZFByb3BlcnR5OiB7CisgICAgICAgIC8v IER1cmluZyBGaXh1cCB3ZSBtYXkgZGVjaWRlIHRvIGV4cGFuZCB0aGUgQXJyYXlNb2RlIG9mIEdl dEJ5VmFscyBiYXNlZCBvbiBzcGVjdWxhdGlvbnMuCisgICAgICAgIC8vIFRoaXMgY291bGQgaW4g dGhlb3J5IGNvbnZlcnQgdXMgdG8gYSBtb2RlIHRoYXQgY2xvYmJlcnMgZXhpdCBzdGF0ZSBzbyB3 ZSBjb25zZXJ2YXRpdmVseQorICAgICAgICAvLyBzYXkgd2UgY2xvYmJlciBleGl0IHN0YXRlIHVu dGlsIHdlIGtub3cgd2Ugd29uJ3QuCisgICAgICAgIGlmICghZ3JhcGgubV9oYXNSdW5GaXh1cCkg eworICAgICAgICAgICAgY2xvYmJlclRvcCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CisKICAgICAgICAgcmVhZChKU09iamVjdF9idXR0ZXJmbHkpOwogICAgICAgICBBcnJheU1v ZGUgbW9kZSA9IG5vZGUtPmFycmF5TW9kZSgpOwogICAgICAgICBzd2l0Y2ggKG1vZGUudHlwZSgp KSB7CkBAIC04NTcsNiArODY1LDE0IEBAIHZvaWQgY2xvYmJlcml6ZShHcmFwaCYgZ3JhcGgsIE5v ZGUqIG5vZGUsIGNvbnN0IFJlYWRGdW5jdG9yJiByZWFkLCBjb25zdCBXcml0ZUZ1CiAgICAgfQog ICAgICAgICAKICAgICBjYXNlIEdldEJ5VmFsOiB7CisgICAgICAgIC8vIER1cmluZyBGaXh1cCB3 ZSBtYXkgZGVjaWRlIHRvIGV4cGFuZCB0aGUgQXJyYXlNb2RlIG9mIEdldEJ5VmFscyBiYXNlZCBv biBzcGVjdWxhdGlvbnMuCisgICAgICAgIC8vIFRoaXMgY291bGQgaW4gdGhlb3J5IGNvbnZlcnQg dXMgdG8gYSBtb2RlIHRoYXQgY2xvYmJlcnMgZXhpdCBzdGF0ZSBzbyB3ZSBjb25zZXJ2YXRpdmVs eQorICAgICAgICAvLyBzYXkgd2UgY2xvYmJlciBleGl0IHN0YXRlIHVudGlsIHdlIGtub3cgd2Ug d29uJ3QuCisgICAgICAgIGlmICghZ3JhcGgubV9oYXNSdW5GaXh1cCkgeworICAgICAgICAgICAg Y2xvYmJlclRvcCgpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAgICAg QXJyYXlNb2RlIG1vZGUgPSBub2RlLT5hcnJheU1vZGUoKTsKICAgICAgICAgTG9jYXRpb25LaW5k IGluZGV4ZWRQcm9wZXJ0eUxvYyA9IGluZGV4ZWRQcm9wZXJ0eUxvY0ZvclJlc3VsdFR5cGUobm9k ZS0+cmVzdWx0KCkpOwogICAgICAgICBzd2l0Y2ggKG1vZGUudHlwZSgpKSB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAppbmRleCBhMDFhMDVkNjU1YzkwNjRm N2Q3YmY3YmU2MGJkMjZlNDE2NTQzNzc2Li4yZDJlZDg4MTYzZjdhY2YzYWI2N2U3ZDU0OTRlYTkw OWI0ZDEzOWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVw UGhhc2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5j cHAKQEAgLTE4MCw2ICsxODAsMTAgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAgIE5vZGVUeXBl IG9wID0gbm9kZS0+b3AoKTsKIAorI2lmIEFTU0VSVF9FTkFCTEVECisgICAgICAgIGJvb2wgdXNl ZFRvQ2xvYmJlckV4aXRTdGF0ZSA9IGNsb2JiZXJzRXhpdFN0YXRlKG1fZ3JhcGgsIG5vZGUpOwor I2VuZGlmCisKICAgICAgICAgc3dpdGNoIChvcCkgewogICAgICAgICBjYXNlIFNldExvY2FsOiB7 CiAgICAgICAgICAgICAvLyBUaGlzIGdldHMgaGFuZGxlZCBieSBmaXh1cEdldEFuZFNldExvY2Fs c0luQmxvY2soKS4KQEAgLTEyODEsNyArMTI4NSw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAg ICAgbm9kZS0+c2V0QXJyYXlNb2RlKEFycmF5TW9kZShBcnJheTo6R2VuZXJpYywgbm9kZS0+YXJy YXlNb2RlKCkuYWN0aW9uKCkpKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg IH0KLSAgICAgICAgICAgIAorCiAgICAgICAgICAgICBub2RlLT5zZXRBcnJheU1vZGUoCiAgICAg ICAgICAgICAgICAgbm9kZS0+YXJyYXlNb2RlKCkucmVmaW5lKAogICAgICAgICAgICAgICAgICAg ICBtX2dyYXBoLCBub2RlLCBiYXNlLT5wcmVkaWN0aW9uKCksIGluZGV4LT5wcmVkaWN0aW9uKCkp KTsKQEAgLTI3MjAsNiArMjcyNCwxMiBAQCBwcml2YXRlOgogICAgICAgICAgICAgYnJlYWs7CiAj ZW5kaWYgLy8gbm90IEFTU0VSVF9FTkFCTEVECiAgICAgICAgIH0KKworI2lmIEFTU0VSVF9FTkFC TEVECisgICAgICAgIC8vIEl0IHdvdWxkIGJlIGludmFsaWQgZm9yIEZpeHVwIHRvIHRha2UgYSBu b2RlIHRoYXQgZGlkbid0IGNsb2JiZXIgZXhpdCBzdGF0ZSBhbmQgbWFyayBpdCBhcyBjbG9iYmVy aW5nIGFmdGVyd29yZHMuCisgICAgICAgIERGR19BU1NFUlQobV9ncmFwaCwgbm9kZSwgdXNlZFRv Q2xvYmJlckV4aXRTdGF0ZSB8fCAhY2xvYmJlcnNFeGl0U3RhdGUobV9ncmFwaCwgbm9kZSkpOwor I2VuZGlmCisKICAgICB9CiAKICAgICB2b2lkIHdhdGNoSGF2aW5nQUJhZFRpbWUoTm9kZSogbm9k ZSkKQEAgLTQ0NDksNyArNDQ1OSw5IEBAIHByaXZhdGU6CiAgICAgCiBib29sIHBlcmZvcm1GaXh1 cChHcmFwaCYgZ3JhcGgpCiB7Ci0gICAgcmV0dXJuIHJ1blBoYXNlPEZpeHVwUGhhc2U+KGdyYXBo KTsKKyAgICBhdXRvIHJlc3VsdCA9IHJ1blBoYXNlPEZpeHVwUGhhc2U+KGdyYXBoKTsKKyAgICBn cmFwaC5tX2hhc1J1bkZpeHVwID0gdHJ1ZTsKKyAgICByZXR1cm4gcmVzdWx0OwogfQogCiB9IH0g Ly8gbmFtZXNwYWNlIEpTQzo6REZHCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0dyYXBoLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgKaW5k ZXggNzk2NWQyNzBkYjBlMDg3MWE3MmQ1YTZjMjViMTQ0YzkzNDVjNTZlZi4uMmZjZmYyN2Q0ZDI5 NTc5ZmI5YWUwY2Q2NjU1ZGMyZWE0NzBjYWVlZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdHcmFwaC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH R3JhcGguaApAQCAtMTE3NCw2ICsxMTc0LDcgQEAgcHVibGljOgogICAgIGJvb2wgbV9oYXNEZWJ1 Z2dlckVuYWJsZWQ7CiAgICAgYm9vbCBtX2hhc0V4Y2VwdGlvbkhhbmRsZXJzIHsgZmFsc2UgfTsK ICAgICBib29sIG1faXNJblNTQUNvbnZlcnNpb24geyBmYWxzZSB9OworICAgIGJvb2wgbV9oYXNS dW5GaXh1cCB7IGZhbHNlIH07CiAgICAgT3B0aW9uYWw8dWludDMyX3Q+IG1fbWF4TG9jYWxzRm9y Q2F0Y2hPU1JFbnRyeTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8Rmxvd0luZGV4aW5nPiBtX2luZGV4 aW5nQ2FjaGU7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEZsb3dNYXA8QWJzdHJhY3RWYWx1ZT4+IG1f YWJzdHJhY3RWYWx1ZXNDYWNoZTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTIzMWNhZjhlYWNmYTIyYzg1NTEwOGU3OWJmZjg3NWM0N2Q1 ZTcwMi4uYTk2YTk1NzJiMTJmNDhmMjdkNDNlMWM4ZjRiODg1MzgwMTcxZTdkYSAxMDA2NDQKLS0t IGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAyMC0wNS0wNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4K KworICAgICAgICBHZXRCeVZhbCBhbmQgSGFzSW5kZXhlZFByb3BlcnR5IHNob3VsZCBjbG9iYmVy VG9wIHVudGlsIEZpeHVwIFBoYXNlIHJ1bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9mb3Itb2YtZ2V0LWJ5LXZhbC1tYXJrcy1jbG9i YmVycy1leGl0LXN0YXRlLmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisgICAgICAgICogc3Ry ZXNzL3B1dC1ieS12YWwtY29ycmVjdGx5LWNsb2JiZXJzLWV4aXQtc3RhdGUtd2hlbi1taXNwcm9m aWxpbmctaW5kZXguanM6IEFkZGVkLgorICAgICAgICAobGV0LmZvby52bS5jcmVhdGVCdWlsdGlu KToKKwogMjAyMC0wNS0wNSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+ CiAKICAgICAgICAgW0ludGxdIEFscGhhYmV0aXplIGV4dGVuc2lvbiBrZXlzIGFuZCBjb3JyZWN0 bHkgbWFyayBjb25zdCBtZXRob2RzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9mb3Itb2Yt Z2V0LWJ5LXZhbC1tYXJrcy1jbG9iYmVycy1leGl0LXN0YXRlLmpzIGIvSlNUZXN0cy9zdHJlc3Mv Zm9yLW9mLWdldC1ieS12YWwtbWFya3MtY2xvYmJlcnMtZXhpdC1zdGF0ZS5qcwpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li42MTY3ZmE3YzNjNmI5MjIzMmIwNTJhM2YwNjQ4OWVkNjY2NjJhZTcyCi0tLSAvZGV2L251bGwK KysrIGIvSlNUZXN0cy9zdHJlc3MvZm9yLW9mLWdldC1ieS12YWwtbWFya3MtY2xvYmJlcnMtZXhp dC1zdGF0ZS5qcwpAQCAtMCwwICsxLDEwIEBACitjb25zdCBhMCA9IG5ldyBBcnJheSgxMDApOwor YTAueCA9IDA7CisKK2Z1bmN0aW9uIGZvbygpIHsKKyAgZm9yIChjb25zdCBxIG9mIGEwKSB7fQor fQorCitmb3IgKGxldCBpID0gMDsgaSA8IDEwMDA7IGkrKykgeworICBmb28oKTsKK30KZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL3B1dC1ieS12YWwtY29ycmVjdGx5LWNsb2JiZXJzLWV4aXQt c3RhdGUtd2hlbi1taXNwcm9maWxpbmctaW5kZXguanMgYi9KU1Rlc3RzL3N0cmVzcy9wdXQtYnkt dmFsLWNvcnJlY3RseS1jbG9iYmVycy1leGl0LXN0YXRlLXdoZW4tbWlzcHJvZmlsaW5nLWluZGV4 LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmYyMTYxMjJiNGEwMjFjYmFiYzRmMTg2MThhMGI2ZmY3ZjY3ZDI4YjAK LS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wdXQtYnktdmFsLWNvcnJlY3RseS1j bG9iYmVycy1leGl0LXN0YXRlLXdoZW4tbWlzcHJvZmlsaW5nLWluZGV4LmpzCkBAIC0wLDAgKzEs MTAgQEAKK2xldCBmb28gPSAkdm0uY3JlYXRlQnVpbHRpbihgKGZ1bmN0aW9uIChhcnJheSwgaW5k ZXgpIHsKKyAgICBpbmRleCA9IEBpZFdpdGhQcm9maWxlKGluZGV4LCAiU3BlY09iamVjdCIpOwor ICAgIHJldHVybiBhcnJheVtpbmRleF07Cit9KWApOworbm9JbmxpbmUoZm9vKTsKKworZm9yIChs ZXQgaSA9IDA7IGkgPCAxZTU7ICsraSkgeworICAgIGlmIChmb28oWzEsMl0sIDApICE9PSAxKQor ICAgICAgICB0aHJvdyBuZXcgRXJyb3IoKTsKK30K 398667 2020-05-06 14:59:00 -0700 2020-05-06 15:10:12 -0700 Patch bug-211531-20200506145859.patch text/plain 6554 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZTI2ZmUwMGFiYTM0YWI1MWRlMzkwZTM2N2JjMjE0ZTFjMDRlNjY3Li41OGQwMDUwOGE0MTczMDMx NGE4MmU4YmI0MDFhZDMxODFmOWE3ZjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMSBAQAorMjAyMC0wNS0wNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBERkcgQnlWYWwgbm9kZXMgd2l0aCBBcnJheU1vZGVzIHNob3VsZCBj bG9iYmVyVG9wIHVudGlsIEZpeHVwIHBoYXNlIHJ1bnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE1MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHBhcnNpbmcgYnl0ZWNvZGUgd2UgbWF5IHBp Y2sgYSByZWxhdGl2ZWx5IGNvbnN0cmFpbmVkCisgICAgICAgIEFycmF5TW9kZSBiYXNlZCBvbiBv dXIgcHJvZmlsaW5nLiBTb21lIG9mIHRoZXNlIG1vZGVzIG1heSBub3QKKyAgICAgICAgY2xvYmJl ciBleGl0IHN0YXRlLiAgSG93ZXZlciwgRml4dXAgc29tZXRpbWVzIHdhbnRzIHRvIHdpZGVuIHRo aXMKKyAgICAgICAgdG8gYSBtb3JlIGdlbmVyaWMgbW9kZSBiYXNlZCBvbiBvdGhlciBkYXRhLiBU aGlzIGNhdXNlcyB1cyB0bworICAgICAgICB0aGluayBpdCB3YXMgdmFsaWQgdG8gZXhpdCBpbW1l ZGlhdGVseSBhZnRlciB0aGUKKyAgICAgICAgR2V0QnlWYWwvSGFzSW5kZXhlZFByb3BlcnR5LCB3 aGljaCB3b3VsZCBiZSB3cm9uZyB3aXRoIHRoZSB3aWRlcgorICAgICAgICBBcnJheU1vZGUuIFdl IG1heSBhbHNvIGluY29ycmVjdGx5IGluc2VydCBpbnZhbGlkaXRpb24gcG9pbnRzCisgICAgICAg IGlmIGNsb2JiZXJpemUgZ2l2ZXMgdXMgdGhlIHdyb25nIGRhdGEuCisKKyAgICAgICAgVG8gZml4 IHRoaXMgY2xvYmJlcml6ZSBzaG91bGQgc2F5IEFsbCBCeVZhbCBub2RlcyBjbG9iYmVyVG9wKCkK KyAgICAgICAgdW50aWwgYWZ0ZXIgZml4dXAuIEFkZGl0aW9uYWxseSwgdGhpcyBwYXRjaCBhZGRz IGFuIGFzc2VydGlvbiB0aGF0CisgICAgICAgIG5vZGVzIGRvbid0IGdvIGZyb20gbm90IGNsb2Ji ZXJpbmcgZXhpdCBzdGF0ZSB0byBjbG9iYmVyaW5nIGV4aXQKKyAgICAgICAgc3RhdGUgZHVyaW5n IGZpeHVwLgorCisgICAgICAgICogZGZnL0RGR0Nsb2JiZXJpemUuaDoKKyAgICAgICAgKEpTQzo6 REZHOjpjbG9iYmVyaXplKToKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6Rml4dXBQaGFzZTo6Zml4dXBOb2RlKToKKyAgICAgICAgKEpTQzo6REZH OjpwZXJmb3JtRml4dXApOgorICAgICAgICAqIGRmZy9ERkdHcmFwaC5oOgorCiAyMDIwLTA1LTA1 ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSW50 bF0gQWxwaGFiZXRpemUgZXh0ZW5zaW9uIGtleXMgYW5kIGNvcnJlY3RseSBtYXJrIGNvbnN0IG1l dGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6 ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKaW5kZXggNjBl NmJlMGJlMDQyOTIxMDQyNDY2MzdlNjUyNjBkNTEzOGI0MzU0NS4uNzM5Yzg4YzQzY2E1NTUxYmUw ZDEyMjM0OTM1YTE1MDVlN2EyY2RjMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdDbG9iYmVyaXplLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdD bG9iYmVyaXplLmgKQEAgLTE1NSw2ICsxNTUsMTEgQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBn cmFwaCwgTm9kZSogbm9kZSwgY29uc3QgUmVhZEZ1bmN0b3ImIHJlYWQsIGNvbnN0IFdyaXRlRnUK ICAgICAgICAgcmVhZChXb3JsZCk7CiAgICAgICAgIHdyaXRlKEhlYXApOwogICAgIH07CisKKyAg ICAvLyBTaW5jZSBGaXh1cCBjYW4gZG8gd2lkZW4gb3VyIEFycmF5TW9kZXMgYmFzZWQgb24gcHJv ZmlsaW5nIGZyb20gb3RoZXIgbm9kZXMgd2UgcGVzc2ltaXN0aWNhbGx5IGFzc3VtZQorICAgIC8v IGFsbCBub2RlcyB3aXRoIGFuIEFycmF5TW9kZSBjYW4gY2xvYmJlciB0b3AuCisgICAgaWYgKCFn cmFwaC5tX2hhc1J1bkZpeHVwICYmIG5vZGUtPmhhc0FycmF5TW9kZSgpKQorICAgICAgICByZXR1 cm4gY2xvYmJlclRvcCgpOwogICAgIAogICAgIHN3aXRjaCAobm9kZS0+b3AoKSkgewogICAgIGNh c2UgSlNDb25zdGFudDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Rml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2Uu Y3BwCmluZGV4IGEwMWEwNWQ2NTVjOTA2NGY3ZDdiZjdiZTYwYmQyNmU0MTY1NDM3NzYuLjJkMmVk ODgxNjNmN2FjZjNhYjY3ZTdkNTQ5NGVhOTA5YjRkMTM5ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApAQCAtMTgwLDYgKzE4MCwxMCBAQCBwcml2YXRl OgogICAgIHsKICAgICAgICAgTm9kZVR5cGUgb3AgPSBub2RlLT5vcCgpOwogCisjaWYgQVNTRVJU X0VOQUJMRUQKKyAgICAgICAgYm9vbCB1c2VkVG9DbG9iYmVyRXhpdFN0YXRlID0gY2xvYmJlcnNF eGl0U3RhdGUobV9ncmFwaCwgbm9kZSk7CisjZW5kaWYKKwogICAgICAgICBzd2l0Y2ggKG9wKSB7 CiAgICAgICAgIGNhc2UgU2V0TG9jYWw6IHsKICAgICAgICAgICAgIC8vIFRoaXMgZ2V0cyBoYW5k bGVkIGJ5IGZpeHVwR2V0QW5kU2V0TG9jYWxzSW5CbG9jaygpLgpAQCAtMTI4MSw3ICsxMjg1LDcg QEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBub2RlLT5zZXRBcnJheU1vZGUoQXJyYXlNb2Rl KEFycmF5OjpHZW5lcmljLCBub2RlLT5hcnJheU1vZGUoKS5hY3Rpb24oKSkpOwogICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgCisKICAgICAgICAgICAg IG5vZGUtPnNldEFycmF5TW9kZSgKICAgICAgICAgICAgICAgICBub2RlLT5hcnJheU1vZGUoKS5y ZWZpbmUoCiAgICAgICAgICAgICAgICAgICAgIG1fZ3JhcGgsIG5vZGUsIGJhc2UtPnByZWRpY3Rp b24oKSwgaW5kZXgtPnByZWRpY3Rpb24oKSkpOwpAQCAtMjcyMCw2ICsyNzI0LDEyIEBAIHByaXZh dGU6CiAgICAgICAgICAgICBicmVhazsKICNlbmRpZiAvLyBub3QgQVNTRVJUX0VOQUJMRUQKICAg ICAgICAgfQorCisjaWYgQVNTRVJUX0VOQUJMRUQKKyAgICAgICAgLy8gSXQgd291bGQgYmUgaW52 YWxpZCBmb3IgRml4dXAgdG8gdGFrZSBhIG5vZGUgdGhhdCBkaWRuJ3QgY2xvYmJlciBleGl0IHN0 YXRlIGFuZCBtYXJrIGl0IGFzIGNsb2JiZXJpbmcgYWZ0ZXJ3b3Jkcy4KKyAgICAgICAgREZHX0FT U0VSVChtX2dyYXBoLCBub2RlLCB1c2VkVG9DbG9iYmVyRXhpdFN0YXRlIHx8ICFjbG9iYmVyc0V4 aXRTdGF0ZShtX2dyYXBoLCBub2RlKSk7CisjZW5kaWYKKwogICAgIH0KIAogICAgIHZvaWQgd2F0 Y2hIYXZpbmdBQmFkVGltZShOb2RlKiBub2RlKQpAQCAtNDQ0OSw3ICs0NDU5LDkgQEAgcHJpdmF0 ZToKICAgICAKIGJvb2wgcGVyZm9ybUZpeHVwKEdyYXBoJiBncmFwaCkKIHsKLSAgICByZXR1cm4g cnVuUGhhc2U8Rml4dXBQaGFzZT4oZ3JhcGgpOworICAgIGF1dG8gcmVzdWx0ID0gcnVuUGhhc2U8 Rml4dXBQaGFzZT4oZ3JhcGgpOworICAgIGdyYXBoLm1faGFzUnVuRml4dXAgPSB0cnVlOworICAg IHJldHVybiByZXN1bHQ7CiB9CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpERkcKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHR3JhcGguaAppbmRleCA3OTY1ZDI3MGRiMGUwODcxYTcyZDVhNmMyNWIx NDRjOTM0NWM1NmVmLi4yZmNmZjI3ZDRkMjk1NzlmYjlhZTBjZDY2NTVkYzJlYTQ3MGNhZWVmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCkBAIC0xMTc0LDYgKzExNzQsNyBAQCBw dWJsaWM6CiAgICAgYm9vbCBtX2hhc0RlYnVnZ2VyRW5hYmxlZDsKICAgICBib29sIG1faGFzRXhj ZXB0aW9uSGFuZGxlcnMgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc0luU1NBQ29udmVyc2lvbiB7 IGZhbHNlIH07CisgICAgYm9vbCBtX2hhc1J1bkZpeHVwIHsgZmFsc2UgfTsKICAgICBPcHRpb25h bDx1aW50MzJfdD4gbV9tYXhMb2NhbHNGb3JDYXRjaE9TUkVudHJ5OwogICAgIHN0ZDo6dW5pcXVl X3B0cjxGbG93SW5kZXhpbmc+IG1faW5kZXhpbmdDYWNoZTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8 Rmxvd01hcDxBYnN0cmFjdFZhbHVlPj4gbV9hYnN0cmFjdFZhbHVlc0NhY2hlOwpkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBlMjMxY2FmOGVh Y2ZhMjJjODU1MTA4ZTc5YmZmODc1YzQ3ZDVlNzAyLi42ZTRhZDMxNDA2MWJkZjQxM2YzZWE0Yjdi NjIxM2I2MzczYjAwNDk0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA1LTA2ICBLZWl0aCBNaWxsZXIg IDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIERGRyBCeVZhbCBub2RlcyB3aXRo IEFycmF5TW9kZXMgc2hvdWxkIGNsb2JiZXJUb3AgdW50aWwgRml4dXAgcGhhc2UgcnVucy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTUzMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2Zv ci1vZi1nZXQtYnktdmFsLW1hcmtzLWNsb2JiZXJzLWV4aXQtc3RhdGUuanM6IEFkZGVkLgorICAg ICAgICAoZm9vKToKKyAgICAgICAgKiBzdHJlc3MvcHV0LWJ5LXZhbC1jb3JyZWN0bHktY2xvYmJl cnMtZXhpdC1zdGF0ZS13aGVuLW1pc3Byb2ZpbGluZy1pbmRleC5qczogQWRkZWQuCisgICAgICAg IChsZXQuZm9vLnZtLmNyZWF0ZUJ1aWx0aW4pOgorCiAyMDIwLTA1LTA1ICBSb3NzIEtpcnNsaW5n ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSW50bF0gQWxwaGFiZXRpemUg ZXh0ZW5zaW9uIGtleXMgYW5kIGNvcnJlY3RseSBtYXJrIGNvbnN0IG1ldGhvZHMKZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL2Zvci1vZi1nZXQtYnktdmFsLW1hcmtzLWNsb2JiZXJzLWV4aXQt c3RhdGUuanMgYi9KU1Rlc3RzL3N0cmVzcy9mb3Itb2YtZ2V0LWJ5LXZhbC1tYXJrcy1jbG9iYmVy cy1leGl0LXN0YXRlLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYxNjdmYTdjM2M2YjkyMjMyYjA1MmEzZjA2NDg5 ZWQ2NjY2MmFlNzIKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9mb3Itb2YtZ2V0 LWJ5LXZhbC1tYXJrcy1jbG9iYmVycy1leGl0LXN0YXRlLmpzCkBAIC0wLDAgKzEsMTAgQEAKK2Nv bnN0IGEwID0gbmV3IEFycmF5KDEwMCk7CithMC54ID0gMDsKKworZnVuY3Rpb24gZm9vKCkgewor ICBmb3IgKGNvbnN0IHEgb2YgYTApIHt9Cit9CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDsg aSsrKSB7CisgIGZvbygpOworfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvcHV0LWJ5LXZh bC1jb3JyZWN0bHktY2xvYmJlcnMtZXhpdC1zdGF0ZS13aGVuLW1pc3Byb2ZpbGluZy1pbmRleC5q cyBiL0pTVGVzdHMvc3RyZXNzL3B1dC1ieS12YWwtY29ycmVjdGx5LWNsb2JiZXJzLWV4aXQtc3Rh dGUtd2hlbi1taXNwcm9maWxpbmctaW5kZXguanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjIxNjEyMmI0YTAyMWNi YWJjNGYxODYxOGEwYjZmZjdmNjdkMjhiMAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3Ry ZXNzL3B1dC1ieS12YWwtY29ycmVjdGx5LWNsb2JiZXJzLWV4aXQtc3RhdGUtd2hlbi1taXNwcm9m aWxpbmctaW5kZXguanMKQEAgLTAsMCArMSwxMCBAQAorbGV0IGZvbyA9ICR2bS5jcmVhdGVCdWls dGluKGAoZnVuY3Rpb24gKGFycmF5LCBpbmRleCkgeworICAgIGluZGV4ID0gQGlkV2l0aFByb2Zp bGUoaW5kZXgsICJTcGVjT2JqZWN0Iik7CisgICAgcmV0dXJuIGFycmF5W2luZGV4XTsKK30pYCk7 Citub0lubGluZShmb28pOworCitmb3IgKGxldCBpID0gMDsgaSA8IDFlNTsgKytpKSB7CisgICAg aWYgKGZvbyhbMSwyXSwgMCkgIT09IDEpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigpOworfQo=