211516 2020-05-06 08:46:50 -0700 [WebXR] Implement simulateUserActivation() 2020-05-07 12:20:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 211130 1 svillar svillar darin dino svillar webkit-bug-importer youennf zan oldest_to_newest 1649634 0 svillar 2020-05-06 08:46:50 -0700 [WebXR] Implement simulateUserActivation() 1649636 1 398622 svillar 2020-05-06 08:55:17 -0700 Created attachment 398622 Patch 1649648 2 398622 youennf 2020-05-06 09:15:43 -0700 Comment on attachment 398622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/WebXRTest.cpp:105 > + function.handleEvent(); it might be better to follow Internals::withUserGesture. Something like: UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); function.handleEvent(); 1649651 3 svillar 2020-05-06 09:23:19 -0700 (In reply to youenn fablet from comment #2) > Comment on attachment 398622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398622&action=review > > > Source/WebCore/testing/WebXRTest.cpp:105 > > + function.handleEvent(); > > it might be better to follow Internals::withUserGesture. > Something like: > UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); > function.handleEvent(); Much better indeed. I'll replace it before landing. 1649993 4 svillar 2020-05-07 00:49:11 -0700 Committed r261273: <https://trac.webkit.org/changeset/261273> 1649994 5 webkit-bug-importer 2020-05-07 00:50:13 -0700 <rdar://problem/62965108> 1650282 6 398622 darin 2020-05-07 12:20:52 -0700 Comment on attachment 398622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/XRSimulateUserActivationFunction.h:42 > + virtual CallbackResult<void> handleEvent(void) = 0; This (void) syntax is never needed in C++. It is sometimes needed in old C code. Just use "()". 398622 2020-05-06 08:55:17 -0700 2020-05-06 09:15:43 -0700 Patch bug-211516-20200506175516.patch text/plain 5182 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjU1NzU0OTk4Mjc5YWQy MTVkMjA4OTZmMGNjZTc1ZjEyZjg0NDU2Ny4uMGNiYzUwMDU0MzEwNjZkYWZkNmFmM2E5YjExOWQ1 NDllMGY2NTgwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTA2ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJYUl0g SW1wbGVtZW50IHNpbXVsYXRlVXNlckFjdGl2YXRpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2ltdWxhdGVVc2VyQWN0aXZhdGlvbigpIGlzIHRo ZSBtZXRob2QgdXNlZCBieSB0aGUgV2ViWFIgVGVzdCBBUEkgdG8KKyAgICAgICAgbW9jayBhIHVz ZXIgYWN0aXZhdGlvbiBhbmQgdGh1cyBsZXQgV2ViWFIgQVBJIHRoaW5rIHRoYXQgdGhlIHVzZXIg aXMKKyAgICAgICAgYmVoaW5kIHRoZSByZXF1ZXN0IHRoYXQgaXMgZ29pbmcgdG8gYmUgbWFkZSBp biB0aGUgZnVuY3Rpb24gcGFzc2VkIGFzCisgICAgICAgIGFyZ3VtZW50LgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBhZGRlZCBhcyB0aGUgaW1wb3J0ZWQgV2ViWFIgd2ViLXBsYXRmb3JtLXRlc3Rz IGFscmVhZHkgbWFrZQorICAgICAgICB1c2Ugb2YgdGhpcyBBUEkuCisKKyAgICAgICAgKiB0ZXN0 aW5nL1dlYlhSVGVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJYUlRlc3Q6OnNpbXVsYXRl VXNlckFjdGl2YXRpb24pOiBJbXBsZW1lbnRlZC4KKyAgICAgICAgKiB0ZXN0aW5nL1dlYlhSVGVz dC5oOiBBZGRlZCBEb2N1bWVudCBwYXJhbWV0ZXIuCisgICAgICAgICogdGVzdGluZy9XZWJYUlRl c3QuaWRsOiBDYWxsIHdpdGggRG9jdW1lbnQuCisgICAgICAgICogdGVzdGluZy9YUlNpbXVsYXRl VXNlckFjdGl2YXRpb25GdW5jdGlvbi5oOiBSZW1vdmVkIGZ1bmN0aW9uIHBhcmFtcy4KKyAgICAg ICAgKiB0ZXN0aW5nL1hSU2ltdWxhdGVVc2VyQWN0aXZhdGlvbkZ1bmN0aW9uLmlkbDogRGl0dG8u CisKIDIwMjAtMDUtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgRmFjdG9yIEV2ZW50SGFuZGxlciBjb2RlIHRoYXQgc2VuZHMgbW91c2VFbnRlcmVk Q29udGVudEFyZWEvbW91c2VFeGl0ZWRDb250ZW50QXJlYSBpbnRvIGl0cyBvd24gZnVuY3Rpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViWFJUZXN0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvV2ViWFJUZXN0LmNwcAppbmRleCAyZGI3YzI3Y2FmYzk3MDQ3ZTE4 YTQwOTg1MzNlNmM4Zjk2ZDI5YTg5Li45YzhkMGM2MDk1Mjk3NTFlNzk1MGZkMDkyZWViZGEyZmQ0 NDQyODZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYlhSVGVzdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJYUlRlc3QuY3BwCkBAIC0yOCw2ICsyOCw3 IEBACiAKICNpZiBFTkFCTEUoV0VCWFIpCiAKKyNpbmNsdWRlICJET01XaW5kb3cuaCIKICNpbmNs dWRlICJKU1dlYkZha2VYUkRldmljZS5oIgogI2luY2x1ZGUgIkpTWFJSZWZlcmVuY2VTcGFjZVR5 cGUuaCIKICNpbmNsdWRlICJXZWJYUlN5c3RlbS5oIgpAQCAtOTUsOCArOTYsMTMgQEAgdm9pZCBX ZWJYUlRlc3Q6OnNpbXVsYXRlRGV2aWNlQ29ubmVjdGlvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0 JiBjb250ZXh0LCBjb25zdAogICAgIH0pOwogfQogCi12b2lkIFdlYlhSVGVzdDo6c2ltdWxhdGVV c2VyQWN0aXZhdGlvbihYUlNpbXVsYXRlVXNlckFjdGl2YXRpb25GdW5jdGlvbiYpCit2b2lkIFdl YlhSVGVzdDo6c2ltdWxhdGVVc2VyQWN0aXZhdGlvbihEb2N1bWVudCYgZG9jdW1lbnQsIFhSU2lt dWxhdGVVc2VyQWN0aXZhdGlvbkZ1bmN0aW9uJiBmdW5jdGlvbikKIHsKKyAgICAvLyBodHRwczov L2ltbWVyc2l2ZS13ZWIuZ2l0aHViLmlvL3dlYnhyLXRlc3QtYXBpLyNkb20teHJ0ZXN0LXNpbXVs YXRldXNlcmFjdGl2YXRpb24KKyAgICAvLyBJbnZva2UgZnVuY3Rpb24gYXMgaWYgaXQgaGFkIHRy YW5zaWVudCBhY3RpdmF0aW9uLgorICAgIGlmIChhdXRvKiB3aW5kb3cgPSBkb2N1bWVudC5kb21X aW5kb3coKSkKKyAgICAgICAgd2luZG93LT5zZXRMYXN0QWN0aXZhdGlvblRpbWVzdGFtcChNb25v dG9uaWNUaW1lOjpub3coKSk7CisgICAgZnVuY3Rpb24uaGFuZGxlRXZlbnQoKTsKIH0KIAogdm9p ZCBXZWJYUlRlc3Q6OmRpc2Nvbm5lY3RBbGxEZXZpY2VzKERPTVByb21pc2VEZWZlcnJlZDx2b2lk PiYmIHByb21pc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYlhSVGVz dC5oIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJYUlRlc3QuaAppbmRleCA3YjAwYTBjNTk5 ODU0NGJhMGNjODJlZjIzNDdiY2NhZjVkZjRlZjI4Li44ZTk1NzViYzRlOTlkMmI2MzAyNzc0NmIz YmY0ZDY3MjZjOTM3NWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYlhS VGVzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViWFJUZXN0LmgKQEAgLTYzLDcg KzYzLDcgQEAgcHVibGljOgogICAgIC8vIFNpbXVsYXRlcyBhIHVzZXIgYWN0aXZhdGlvbiAoYWth IHVzZXIgZ2VzdHVyZSkgZm9yIHRoZSBjdXJyZW50IHNjb3BlLgogICAgIC8vIFRoZSBhY3RpdmF0 aW9uIGlzIG9ubHkgZ3VhcmFudGVlZCB0byBiZSB2YWxpZCBpbiB0aGUgcHJvdmlkZWQgZnVuY3Rp b24gYW5kIG9ubHkgYXBwbGllcyB0byBXZWJYUgogICAgIC8vIERldmljZSBBUEkgbWV0aG9kcy4K LSAgICB2b2lkIHNpbXVsYXRlVXNlckFjdGl2YXRpb24oWFJTaW11bGF0ZVVzZXJBY3RpdmF0aW9u RnVuY3Rpb24mKTsKKyAgICB2b2lkIHNpbXVsYXRlVXNlckFjdGl2YXRpb24oRG9jdW1lbnQmLCBY UlNpbXVsYXRlVXNlckFjdGl2YXRpb25GdW5jdGlvbiYpOwogCiAgICAgLy8gRGlzY29ubmVjdCBh bGwgZmFrZSBkZXZpY2VzCiAgICAgdm9pZCBkaXNjb25uZWN0QWxsRGV2aWNlcyhET01Qcm9taXNl RGVmZXJyZWQ8dm9pZD4mJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dl YlhSVGVzdC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYlhSVGVzdC5pZGwKaW5kZXgg MzQ1YTMyNzE5NmZhNTFhMmU0ZTY1NGQ0NTRjNjZmMDBiYTdhM2VlOC4uNGVjMmRkMWFkZGVhNmFm ODVkODdmNTNmZjA0NDA3Y2E1MmExMDAzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9XZWJYUlRlc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViWFJUZXN0 LmlkbApAQCAtMzcsNyArMzcsNyBAQAogICAgIC8vIFNpbXVsYXRlcyBhIHVzZXIgYWN0aXZhdGlv biAoYWthIHVzZXIgZ2VzdHVyZSkgZm9yIHRoZSBjdXJyZW50IHNjb3BlLgogICAgIC8vIFRoZSBh Y3RpdmF0aW9uIGlzIG9ubHkgZ3VhcmFudGVlZCB0byBiZSB2YWxpZCBpbiB0aGUgcHJvdmlkZWQg ZnVuY3Rpb24gYW5kIG9ubHkgYXBwbGllcyB0byBXZWJYUgogICAgIC8vIERldmljZSBBUEkgbWV0 aG9kcy4KLSAgICB2b2lkIHNpbXVsYXRlVXNlckFjdGl2YXRpb24oWFJTaW11bGF0ZVVzZXJBY3Rp dmF0aW9uRnVuY3Rpb24gZik7CisgICAgW0NhbGxXaXRoPURvY3VtZW50XSB2b2lkIHNpbXVsYXRl VXNlckFjdGl2YXRpb24oWFJTaW11bGF0ZVVzZXJBY3RpdmF0aW9uRnVuY3Rpb24gZik7CiAKICAg ICAvLyBEaXNjb25uZWN0IGFsbCBmYWtlIGRldmljZXMKICAgICBQcm9taXNlPHZvaWQ+IGRpc2Nv bm5lY3RBbGxEZXZpY2VzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1hS U2ltdWxhdGVVc2VyQWN0aXZhdGlvbkZ1bmN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L1hSU2ltdWxhdGVVc2VyQWN0aXZhdGlvbkZ1bmN0aW9uLmgKaW5kZXggYmYzYjg3MWMyNjEyM2M4 MTIwYmY3Njk2ZmZiZDM5OGEzYmI4YTgyNS4uNGEzZTIyNTA5N2U3ODIxYjFlZGMxYjQwNzkxNTUx NjczZTdjN2IzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9YUlNpbXVsYXRl VXNlckFjdGl2YXRpb25GdW5jdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvWFJT aW11bGF0ZVVzZXJBY3RpdmF0aW9uRnVuY3Rpb24uaApAQCAtMzksNyArMzksNyBAQCBjbGFzcyBY UlNpbXVsYXRlVXNlckFjdGl2YXRpb25GdW5jdGlvbiA6IHB1YmxpYyBSZWZDb3VudGVkPFhSU2lt dWxhdGVVc2VyQWN0aXZhdAogcHVibGljOgogICAgIHVzaW5nIEFjdGl2ZURPTUNhbGxiYWNrOjpB Y3RpdmVET01DYWxsYmFjazsKIAotICAgIHZpcnR1YWwgQ2FsbGJhY2tSZXN1bHQ8dm9pZD4gaGFu ZGxlRXZlbnQoSlNDOjpKU1ZhbHVlKSA9IDA7CisgICAgdmlydHVhbCBDYWxsYmFja1Jlc3VsdDx2 b2lkPiBoYW5kbGVFdmVudCh2b2lkKSA9IDA7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1hSU2ltdWxhdGVVc2VyQWN0aXZh dGlvbkZ1bmN0aW9uLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvWFJTaW11bGF0ZVVzZXJB Y3RpdmF0aW9uRnVuY3Rpb24uaWRsCmluZGV4IDQyZTIyYmEzNmMyYzhjNmVlNzE5NGFlYmFjYmIz YjgzYWZhN2YxMDAuLjIzMzU0MjZkMjc4NTZiYTQxNTJmMzEwZWM4ZGNiOWJhYmVmNTZjZDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvWFJTaW11bGF0ZVVzZXJBY3RpdmF0aW9u RnVuY3Rpb24uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvWFJTaW11bGF0ZVVzZXJB Y3RpdmF0aW9uRnVuY3Rpb24uaWRsCkBAIC0yNSw0ICsyNSw0IEBACiBbCiAgICAgQ29uZGl0aW9u YWw9V0VCWFIsCiAgICAgRW5hYmxlZEF0UnVudGltZT1XZWJYUgotXSBjYWxsYmFjayBYUlNpbXVs YXRlVXNlckFjdGl2YXRpb25GdW5jdGlvbiA9IHZvaWQgKGFueS4uLiBhcmd1bWVudHMpOworXSBj YWxsYmFjayBYUlNpbXVsYXRlVXNlckFjdGl2YXRpb25GdW5jdGlvbiA9IHZvaWQgKCk7Cg==