211493 2020-05-05 21:42:52 -0700 [LFC] BlockFormattingContext::computeHeightAndMargin should special case the table box 2020-05-06 07:19:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1649493 0 zalan 2020-05-05 21:42:52 -0700 table box height is special. it's mostly driven by content. 1649495 1 398587 zalan 2020-05-05 21:53:44 -0700 Created attachment 398587 Patch 1649584 2 ews-feeder 2020-05-06 07:04:42 -0700 commit-queue failed to commit attachment 398587 to WebKit repository. 1649591 3 ews-feeder 2020-05-06 07:18:22 -0700 Committed r261226: <https://trac.webkit.org/changeset/261226> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398587. 1649592 4 webkit-bug-importer 2020-05-06 07:19:16 -0700 <rdar://problem/62929452> 398587 2020-05-05 21:53:44 -0700 2020-05-06 07:18:22 -0700 Patch bug-211493-20200505215343.patch text/plain 6371 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEwYmEyOTJmNWRlZmJi NWY4Yjk0ZDdkNzNiZTI2NWJhNGZkZmM3ZC4uMTUxODdlNTE5MWU5YzQyMWJmNDQ0YTUwODJmZTI0 ZDgzYWZjNTE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQmxvY2tGb3JtYXR0 aW5nQ29udGV4dDo6Y29tcHV0ZUhlaWdodEFuZE1hcmdpbiBzaG91bGQgc3BlY2lhbCBjYXNlIHRo ZSB0YWJsZSBib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMTQ5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJ5IHRoZSB0aW1lIHdlIGdldCB0byBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRl SGVpZ2h0QW5kTWFyZ2luKCksIHRoZSB1c2VkIHZhbHVlZCBmb3IgdGhlIHRhYmxlIGhlaWdodCBp cyBhbHJlYWR5IGJlZW4gY29tcHV0ZWQuCisgICAgICAgIChUYWJsZSBib3ggaGVpZ2h0IGlzIG1v c3RseSBjb250ZW50IGRyaXZlbiwgYW5kIGJvdGggdGhlIGNvbXB1dGVkIGhlaWdodCBhbmQgdGhl IG1pbi9tYXggcGFpciBhcmUgdGFrZW4gaW50byBhY2NvdW50CisgICAgICAgIHdoaWxlIHdlIGFy ZSBsYXlpbmcgb3V0IHRoZSB0YWJsZSBjb250ZW50KS4KKworICAgICAgICAqIGxheW91dC9ibG9j a2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVIZWlnaHRBbmRNYXJnaW4p OgorICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4 dEdlb21ldHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5n Q29udGV4dDo6R2VvbWV0cnk6OmluRmxvd0hlaWdodEFuZE1hcmdpbik6CisKIDIwMjAtMDUtMDUg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtCRkNdIEZv cm1hdHRpbmdDb250ZXh0OjpDb25zdHJhaW50c0ZvckluRmxvd0NvbnRlbnQgc2hvdWxkIGluY2x1 ZGUgdGhlIGNvbXB1dGVkIHZhbHVlIG9mIGhlaWdodApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4 dC5jcHAKaW5kZXggNGJkZGQ1YWYzNWI0YzE1MmU3MGZlYjg5MGRiMzcxNTdhNjMyMzFjNy4uOGZk NGY2Y2EwN2EzYjU0MWIwMTA1ZWFiNTBhYTBmNWQzMTY2ZmRjNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0 dGluZ0NvbnRleHQuY3BwCkBAIC0zNzIsMjIgKzM3MiwzMyBAQCB2b2lkIEJsb2NrRm9ybWF0dGlu Z0NvbnRleHQ6OmNvbXB1dGVIZWlnaHRBbmRNYXJnaW4oY29uc3QgQm94JiBsYXlvdXRCb3gsIGNv bnN0CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfTsKIAotICAgIGF1dG8gY29udGVudEhlaWdo dEFuZE1hcmdpbiA9IGNvbXB1dGUoeyB9KTsKLSAgICBpZiAoYXV0byBtYXhIZWlnaHQgPSBnZW9t ZXRyeSgpLmNvbXB1dGVkTWF4SGVpZ2h0KGxheW91dEJveCkpIHsKLSAgICAgICAgaWYgKGNvbnRl bnRIZWlnaHRBbmRNYXJnaW4uY29udGVudEhlaWdodCA+ICptYXhIZWlnaHQpIHsKLSAgICAgICAg ICAgIGF1dG8gbWF4SGVpZ2h0QW5kTWFyZ2luID0gY29tcHV0ZShtYXhIZWlnaHQpOwotICAgICAg ICAgICAgLy8gVXNlZCBoZWlnaHQgc2hvdWxkIHJlbWFpbiB0aGUgc2FtZS4KLSAgICAgICAgICAg IEFTU0VSVCgobGF5b3V0U3RhdGUoKS5pblF1aXJrc01vZGUoKSAmJiAobGF5b3V0Qm94LmlzQm9k eUJveCgpIHx8IGxheW91dEJveC5pc0RvY3VtZW50Qm94KCkpKSB8fCBtYXhIZWlnaHRBbmRNYXJn aW4uY29udGVudEhlaWdodCA9PSAqbWF4SGVpZ2h0KTsKLSAgICAgICAgICAgIGNvbnRlbnRIZWln aHRBbmRNYXJnaW4gPSB7ICptYXhIZWlnaHQsIG1heEhlaWdodEFuZE1hcmdpbi5ub25Db2xsYXBz ZWRNYXJnaW4gfTsKLSAgICAgICAgfQorICAgIGF1dG8gdXNlZEhlaWdodFZhbHVlID0gT3B0aW9u YWw8TGF5b3V0VW5pdD4geyB9OworICAgIGF1dG8gaWdub3JlTWluTWF4SGVpZ2h0Q29tcHV0ZSA9 IGZhbHNlOworICAgIGlmIChsYXlvdXRCb3guZXN0YWJsaXNoZXNUYWJsZUZvcm1hdHRpbmdDb250 ZXh0KCkpIHsKKyAgICAgICAgLy8gVGFibGUgaXMgYSBzcGVjaWFsIEJGQyBjb250ZW50LiBJdHMg aGVpZ2h0IGlzIG1haW5seSBkcml2ZW4gYnkgdGhlIGNvbnRlbnQuIENvbXB1dGVkIGhlaWdodCwg bWluLWhlaWdodCBhbmQgbWF4LWhlaWdodCBhcmUgYWxsCisgICAgICAgIC8vIGFscmVhZHkgYmVl biB0YWtlbiBpbnRvIGFjY291bnQgZHVyaW5nIHRoZSBURkMgbGF5b3V0LgorICAgICAgICB1c2Vk SGVpZ2h0VmFsdWUgPSBnZW9tZXRyeSgpLmNvbnRlbnRIZWlnaHRGb3JGb3JtYXR0aW5nQ29udGV4 dFJvb3QoZG93bmNhc3Q8Q29udGFpbmVyQm94PihsYXlvdXRCb3gpKTsKKyAgICAgICAgaWdub3Jl TWluTWF4SGVpZ2h0Q29tcHV0ZSA9IHRydWU7CiAgICAgfQogCi0gICAgaWYgKGF1dG8gbWluSGVp Z2h0ID0gZ2VvbWV0cnkoKS5jb21wdXRlZE1pbkhlaWdodChsYXlvdXRCb3gpKSB7Ci0gICAgICAg IGlmIChjb250ZW50SGVpZ2h0QW5kTWFyZ2luLmNvbnRlbnRIZWlnaHQgPCAqbWluSGVpZ2h0KSB7 Ci0gICAgICAgICAgICBhdXRvIG1pbkhlaWdodEFuZE1hcmdpbiA9IGNvbXB1dGUobWluSGVpZ2h0 KTsKLSAgICAgICAgICAgIC8vIFVzZWQgaGVpZ2h0IHNob3VsZCByZW1haW4gdGhlIHNhbWUuCi0g ICAgICAgICAgICBBU1NFUlQoKGxheW91dFN0YXRlKCkuaW5RdWlya3NNb2RlKCkgJiYgKGxheW91 dEJveC5pc0JvZHlCb3goKSB8fCBsYXlvdXRCb3guaXNEb2N1bWVudEJveCgpKSkgfHwgbWluSGVp Z2h0QW5kTWFyZ2luLmNvbnRlbnRIZWlnaHQgPT0gKm1pbkhlaWdodCk7Ci0gICAgICAgICAgICBj b250ZW50SGVpZ2h0QW5kTWFyZ2luID0geyAqbWluSGVpZ2h0LCBtaW5IZWlnaHRBbmRNYXJnaW4u bm9uQ29sbGFwc2VkTWFyZ2luIH07CisgICAgYXV0byBjb250ZW50SGVpZ2h0QW5kTWFyZ2luID0g Y29tcHV0ZSh7IHVzZWRIZWlnaHRWYWx1ZSB9KTsKKyAgICBpZiAoIWlnbm9yZU1pbk1heEhlaWdo dENvbXB1dGUpIHsKKyAgICAgICAgaWYgKGF1dG8gbWF4SGVpZ2h0ID0gZ2VvbWV0cnkoKS5jb21w dXRlZE1heEhlaWdodChsYXlvdXRCb3gpKSB7CisgICAgICAgICAgICBpZiAoY29udGVudEhlaWdo dEFuZE1hcmdpbi5jb250ZW50SGVpZ2h0ID4gKm1heEhlaWdodCkgeworICAgICAgICAgICAgICAg IGF1dG8gbWF4SGVpZ2h0QW5kTWFyZ2luID0gY29tcHV0ZShtYXhIZWlnaHQpOworICAgICAgICAg ICAgICAgIC8vIFVzZWQgaGVpZ2h0IHNob3VsZCByZW1haW4gdGhlIHNhbWUuCisgICAgICAgICAg ICAgICAgQVNTRVJUKChsYXlvdXRTdGF0ZSgpLmluUXVpcmtzTW9kZSgpICYmIChsYXlvdXRCb3gu aXNCb2R5Qm94KCkgfHwgbGF5b3V0Qm94LmlzRG9jdW1lbnRCb3goKSkpIHx8IG1heEhlaWdodEFu ZE1hcmdpbi5jb250ZW50SGVpZ2h0ID09ICptYXhIZWlnaHQpOworICAgICAgICAgICAgICAgIGNv bnRlbnRIZWlnaHRBbmRNYXJnaW4gPSB7ICptYXhIZWlnaHQsIG1heEhlaWdodEFuZE1hcmdpbi5u b25Db2xsYXBzZWRNYXJnaW4gfTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAg IGlmIChhdXRvIG1pbkhlaWdodCA9IGdlb21ldHJ5KCkuY29tcHV0ZWRNaW5IZWlnaHQobGF5b3V0 Qm94KSkgeworICAgICAgICAgICAgaWYgKGNvbnRlbnRIZWlnaHRBbmRNYXJnaW4uY29udGVudEhl aWdodCA8ICptaW5IZWlnaHQpIHsKKyAgICAgICAgICAgICAgICBhdXRvIG1pbkhlaWdodEFuZE1h cmdpbiA9IGNvbXB1dGUobWluSGVpZ2h0KTsKKyAgICAgICAgICAgICAgICAvLyBVc2VkIGhlaWdo dCBzaG91bGQgcmVtYWluIHRoZSBzYW1lLgorICAgICAgICAgICAgICAgIEFTU0VSVCgobGF5b3V0 U3RhdGUoKS5pblF1aXJrc01vZGUoKSAmJiAobGF5b3V0Qm94LmlzQm9keUJveCgpIHx8IGxheW91 dEJveC5pc0RvY3VtZW50Qm94KCkpKSB8fCBtaW5IZWlnaHRBbmRNYXJnaW4uY29udGVudEhlaWdo dCA9PSAqbWluSGVpZ2h0KTsKKyAgICAgICAgICAgICAgICBjb250ZW50SGVpZ2h0QW5kTWFyZ2lu ID0geyAqbWluSGVpZ2h0LCBtaW5IZWlnaHRBbmRNYXJnaW4ubm9uQ29sbGFwc2VkTWFyZ2luIH07 CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dEdlb21l dHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAppbmRleCAwMjRjNTM4MTg0YTA5ZWYwZGNiODZkNTMy NjIzNjZkYTNmZTFhOGYyLi45MmFkZGZjMDU3ODAwNDlmZGJhYzlkMTc4ZjM1ZjYyNDg2NDQyYWRj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2Nr Rm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCkBAIC0y NTUsMTcgKzI1NSw2IEBAIENvbnRlbnRIZWlnaHRBbmRNYXJnaW4gQmxvY2tGb3JtYXR0aW5nQ29u dGV4dDo6R2VvbWV0cnk6OmluRmxvd0hlaWdodEFuZE1hcmdpbihjCiAgICAgICAgIHJldHVybiBp bmxpbmVSZXBsYWNlZEhlaWdodEFuZE1hcmdpbihkb3duY2FzdDxSZXBsYWNlZEJveD4obGF5b3V0 Qm94KSwgaG9yaXpvbnRhbENvbnN0cmFpbnRzLCB7IH0sIG92ZXJyaWRlVmVydGljYWxWYWx1ZXMp OwogCiAgICAgQ29udGVudEhlaWdodEFuZE1hcmdpbiBjb250ZW50SGVpZ2h0QW5kTWFyZ2luOwot ICAgIC8vIEZJWE1FOiBMZXQncyBzcGVjaWFsIGNhc2UgdGhlIHRhYmxlIGhlaWdodCBjb21wdXRh dGlvbiBmb3Igbm93IC0+IGZpZ3VyZSBvdXQgd2hldGhlciB0YWJsZXMgZmFsbCBpbnRvIHRoZSAi aW5GbG93Tm9uUmVwbGFjZWRIZWlnaHRBbmRNYXJnaW4iIGNhdGVnb3J5LgotICAgIGlmIChsYXlv dXRCb3guZXN0YWJsaXNoZXNUYWJsZUZvcm1hdHRpbmdDb250ZXh0KCkpIHsKLSAgICAgICAgYXV0 byYgdGFibGVCb3ggPSBkb3duY2FzdDxDb250YWluZXJCb3g+KGxheW91dEJveCk7Ci0gICAgICAg IGF1dG8gY29tcHV0ZWRUYWJsZUhlaWdodCA9IGNvbXB1dGVkSGVpZ2h0KHRhYmxlQm94KTsKLSAg ICAgICAgYXV0byBjb250ZW50SGVpZ2h0ID0gY29udGVudEhlaWdodEZvckZvcm1hdHRpbmdDb250 ZXh0Um9vdCh0YWJsZUJveCk7Ci0gICAgICAgIGlmIChjb21wdXRlZFRhYmxlSGVpZ2h0ICYmIGNv bnRlbnRIZWlnaHQgPiBjb21wdXRlZFRhYmxlSGVpZ2h0KSB7Ci0gICAgICAgICAgICAvLyBUYWJs ZSBjb250ZW50IG5lZWRzIG1vcmUgdmVydGljYWwgc3BhY2UgdGhhbiB0aGUgdGFibGUgaGFzLgot ICAgICAgICAgICAgcmV0dXJuIGNvbXBsaWNhdGVkQ2FzZXModGFibGVCb3gsIGhvcml6b250YWxD b25zdHJhaW50cywgeyBjb250ZW50SGVpZ2h0IH0pOwotICAgICAgICB9Ci0gICAgICAgIHJldHVy biBjb21wbGljYXRlZENhc2VzKHRhYmxlQm94LCBob3Jpem9udGFsQ29uc3RyYWludHMsIG92ZXJy aWRlVmVydGljYWxWYWx1ZXMpOwotICAgIH0KICAgICBpZiAobGF5b3V0Qm94LmlzT3ZlcmZsb3dW aXNpYmxlKCkgJiYgIWxheW91dEJveC5pc0RvY3VtZW50Qm94KCkpIHsKICAgICAgICAgLy8gVE9E TzogRmlndXJlIG91dCB0aGUgY2FzZSBmb3IgdGhlIGRvY3VtZW50IGVsZW1lbnQuIExldCdzIGp1 c3QgY29tcGxpY2F0ZWQtY2FzZSBpdCBmb3Igbm93LgogICAgICAgICBjb250ZW50SGVpZ2h0QW5k TWFyZ2luID0gaW5GbG93Tm9uUmVwbGFjZWRIZWlnaHRBbmRNYXJnaW4obGF5b3V0Qm94LCBob3Jp em9udGFsQ29uc3RyYWludHMsIG92ZXJyaWRlVmVydGljYWxWYWx1ZXMpOwo=