211473 2020-05-05 14:51:40 -0700 fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS 2020-08-24 12:23:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215778 InRadar P2 Normal --- 1 cdumez cdumez darin webkit-bug-importer oldest_to_newest 1649387 0 cdumez 2020-05-05 14:51:40 -0700 fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS. 1649389 1 cdumez 2020-05-05 14:55:39 -0700 <rdar://problem/61180247> 1649390 2 398554 cdumez 2020-05-05 14:55:47 -0700 Created attachment 398554 Patch 1649392 3 398554 darin 2020-05-05 15:06:12 -0700 Comment on attachment 398554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398554&action=review > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:20 > + window.sessionStorage.horizontal_scroll_after_back_test_started = true; I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:30 > + window.setTimeout("navigateAwayAndBack()", 0); I don’t think we need the "window." here. > LayoutTests/fast/overflow/horizontal-scroll-after-back.html:37 > + if (!window.sessionStorage.horizontal_scroll_after_back_test_started) > + return; > + delete window.sessionStorage.horizontal_scroll_after_back_test_started; I don’t think we need the "window." here. 1649394 4 398556 cdumez 2020-05-05 15:07:32 -0700 Created attachment 398556 Patch 1649418 5 ews-feeder 2020-05-05 16:12:35 -0700 Committed r261205: <https://trac.webkit.org/changeset/261205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398556. 398554 2020-05-05 14:55:47 -0700 2020-05-05 15:07:30 -0700 Patch bug-211473-20200505145546.patch text/plain 3308 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmUzNDIwOTdiYmM2NGFiMTNlZDFl ZTFmOTlkNzNlY2M2ZTRhMGRlMi4uY2I2Zjc1MmVjM2EwM2NkOGE0OTRiNDliYTEwMWY3ZTM4OTkx YjhkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTA1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9vdmVyZmxvdy9ob3Jpem9udGFsLXNjcm9s bC1hZnRlci1iYWNrLmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0IG9uIG1hY09TCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE0NzMKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzYxMTgwMjQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEkgbWFkZSB0aGUgZm9sbG93aW5nIGNoYW5nZXMgdG8gdGhlIHRlc3Q6 CisgICAgICAgIC0gU3RvcCByZWx5aW5nIG9uIDIwMG1zIHRpbWVycyBhbmQgaW5zdGVhZCBqdXN0 IGEgMCB0aW1lciBhZnRlciB0aGUgbG9hZCBldmVudC4KKyAgICAgICAgLSBEZXRlY3QgdGhlIGNh c2Ugd2hlcmUgd2UgZmFpbGVkIHRvIGVudGVyIHBhZ2UgY2FjaGUgYW5kIGZhaWwgbmljZWx5IGlu IHRoaXMKKyAgICAgICAgICBjYXNlIGluc3RlYWQgb2YgdGltaW5nIG91dC4KKyAgICAgICAgLSBV c2UgRWxlbWVudC5jbGljaygpIHRvIHRyaWdnZXIgdGhlIG5hdmlnYXRpb24gaW5zdGVhZCBvZiBk aXNwYXRjaGluZyBhIGN1c3RvbQorICAgICAgICAgIGNsaWNrIGV2ZW50LgorCisgICAgICAgIEkg aGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVjZSB0aGUgZmxha2luZXNzIGxvY2FsbHkuIEhv d2V2ZXIsIHRoZSBjaGFuZ2VzIGluCisgICAgICAgIHRoaXMgcGF0Y2ggd2lsbCBhdCB0aGUgdmVy eSBsZWFzdCBtYWtlIHRoZSB0ZXN0IGZhc3RlciB0byBydW4gYW5kIGNhdXNlIHRoZSB0ZXN0Cisg ICAgICAgIHRvIGZhaWwgaW5zdGVhZCBvZiB0aW1pbmcgb3V0IGlmIHRoZSBpc3N1ZSBpcyB0aGF0 IHdlIGZhaWwgdG8gZW50ZXIgdGhlIGJhY2sgLworICAgICAgICBmb3J3YXJkIGNhY2hlLCB3aGlj aCB3b3VsZCBoZWxwIHVzIGZpeCB0aGlzLgorCisgICAgICAgICogZmFzdC9vdmVyZmxvdy9ob3Jp em9udGFsLXNjcm9sbC1hZnRlci1iYWNrLmh0bWw6CisKIDIwMjAtMDUtMDUgIFNhaWQgQWJvdS1I YWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyBdIGZhc3Qv YW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWNhbmNlbDIuaHRtbCBpcyBmbGFreSBm YWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9vdmVyZmxvdy9ob3Jpem9udGFs LXNjcm9sbC1hZnRlci1iYWNrLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6 b250YWwtc2Nyb2xsLWFmdGVyLWJhY2suaHRtbAppbmRleCA3MDNjZTY0ZjY0ODdiODFjMTk4YmZk YzUwZGM3NmE1OTdiNjdmYjA1Li4yMzY5ODdkNDcxNDhmZWJkMGU1NWU5ZjNkODJlMDQ2ZGYzMDM3 NjIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6b250YWwtc2Ny b2xsLWFmdGVyLWJhY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6 b250YWwtc2Nyb2xsLWFmdGVyLWJhY2suaHRtbApAQCAtMTIsMTYgKzEyLDEzIEBAIGZ1bmN0aW9u IHZlcmlmeVBhZ2UoKQogICAgICAgICA6ICJQQVNTIjsKICAgICBkb2N1bWVudC5ib2R5LmlubmVy SFRNTCA9IHJlc3VsdDsKICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgICAgICB0 ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7 CiB9CiAKIGZ1bmN0aW9uIG5hdmlnYXRlQXdheUFuZEJhY2soKSAKIHsKLSAgICAvLyBTaW11bGF0 ZSBhIGxpbmsgY2xpY2sgdG8gY3JlYXRlIGEgaGlzdG9yeSBlbnRyeQotICAgIHZhciBldnQgPSBk b2N1bWVudC5jcmVhdGVFdmVudCgiTW91c2VFdmVudHMiKTsKLSAgICBldnQuaW5pdE1vdXNlRXZl bnQoImNsaWNrIiwgdHJ1ZSwgdHJ1ZSwgd2luZG93LAotICAgICAgMCwgMCwgMCwgMCwgMCwgZmFs c2UsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIDAsIG51bGwpOwotICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdhbmNob3InKS5kaXNwYXRjaEV2ZW50KGV2dCk7CisgICAgd2luZG93LnNlc3Npb25T dG9yYWdlLmhvcml6b250YWxfc2Nyb2xsX2FmdGVyX2JhY2tfdGVzdF9zdGFydGVkID0gdHJ1ZTsK KyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYW5jaG9yJykuY2xpY2soKTsKIH0KIAogZnVu Y3Rpb24gcnVuVGVzdFN0ZXAoKSAKQEAgLTMwLDE0ICsyNywyMyBAQCBmdW5jdGlvbiBydW5UZXN0 U3RlcCgpCiAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwogICAgICAgICB0ZXN0UnVu bmVyLndhaXRVbnRpbERvbmUoKTsKICAgICB9Ci0gICAgd2luZG93LnNldFRpbWVvdXQoIm5hdmln YXRlQXdheUFuZEJhY2soKSIsIDIwMCk7CisgICAgd2luZG93LnNldFRpbWVvdXQoIm5hdmlnYXRl QXdheUFuZEJhY2soKSIsIDApOwogfQogCiBmdW5jdGlvbiBvblZlcmlmeVBhZ2UoZXZ0KQogewor ICAgIGlmICghd2luZG93LnNlc3Npb25TdG9yYWdlLmhvcml6b250YWxfc2Nyb2xsX2FmdGVyX2Jh Y2tfdGVzdF9zdGFydGVkKQorICAgICAgICByZXR1cm47CisgICAgZGVsZXRlIHdpbmRvdy5zZXNz aW9uU3RvcmFnZS5ob3Jpem9udGFsX3Njcm9sbF9hZnRlcl9iYWNrX3Rlc3Rfc3RhcnRlZDsKKwog ICAgIC8vIElmIHBhZ2VzaG93IGlzIGhhcHBlbmluZyBhcyByZXN1bHQgb2YgbmF2aWdhdGlvbiBi YWNrIHRoZW4gd2UgcHJvY2VlZC4KICAgICBpZiAoZXZ0LnBlcnNpc3RlZCkKLSAgICAgICAgc2V0 VGltZW91dCgidmVyaWZ5UGFnZSgpIiwgMjAwKTsKKyAgICAgICAgc2V0VGltZW91dCgidmVyaWZ5 UGFnZSgpIiwgMCk7CisgICAgZWxzZSB7CisgICAgICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1M ID0gIkZBSUw6IFBhZ2UgZGlkIG5vdCBnbyBpbnRvIHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUiOwor ICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLm5v dGlmeURvbmUoKTsKKyAgICB9CiB9CiAKIHdpbmRvdy5vbnBhZ2VzaG93ID0gb25WZXJpZnlQYWdl Owo= 398556 2020-05-05 15:07:32 -0700 2020-05-05 16:12:36 -0700 Patch bug-211473-20200505150731.patch text/plain 3349 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmUzNDIwOTdiYmM2NGFiMTNlZDFl ZTFmOTlkNzNlY2M2ZTRhMGRlMi4uZThlZTE2MGZiMzk4MmNjMjU1ZWZlMjgxYjQ1M2ZlZDdjMTFm N2YyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTA1ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9vdmVyZmxvdy9ob3Jpem9udGFsLXNjcm9s bC1hZnRlci1iYWNrLmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0IG9uIG1hY09TCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE0NzMKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzYxMTgwMjQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgIEkgbWFkZSB0aGUgZm9sbG93aW5nIGNoYW5nZXMgdG8gdGhlIHRlc3Q6Cisg ICAgICAgIC0gU3RvcCByZWx5aW5nIG9uIDIwMG1zIHRpbWVycyBhbmQgaW5zdGVhZCBqdXN0IGEg MCB0aW1lciBhZnRlciB0aGUgbG9hZCBldmVudC4KKyAgICAgICAgLSBEZXRlY3QgdGhlIGNhc2Ug d2hlcmUgd2UgZmFpbGVkIHRvIGVudGVyIHBhZ2UgY2FjaGUgYW5kIGZhaWwgbmljZWx5IGluIHRo aXMKKyAgICAgICAgICBjYXNlIGluc3RlYWQgb2YgdGltaW5nIG91dC4KKyAgICAgICAgLSBVc2Ug RWxlbWVudC5jbGljaygpIHRvIHRyaWdnZXIgdGhlIG5hdmlnYXRpb24gaW5zdGVhZCBvZiBkaXNw YXRjaGluZyBhIGN1c3RvbQorICAgICAgICAgIGNsaWNrIGV2ZW50LgorCisgICAgICAgIEkgaGF2 ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVjZSB0aGUgZmxha2luZXNzIGxvY2FsbHkuIEhvd2V2 ZXIsIHRoZSBjaGFuZ2VzIGluCisgICAgICAgIHRoaXMgcGF0Y2ggd2lsbCBhdCB0aGUgdmVyeSBs ZWFzdCBtYWtlIHRoZSB0ZXN0IGZhc3RlciB0byBydW4gYW5kIGNhdXNlIHRoZSB0ZXN0CisgICAg ICAgIHRvIGZhaWwgaW5zdGVhZCBvZiB0aW1pbmcgb3V0IGlmIHRoZSBpc3N1ZSBpcyB0aGF0IHdl IGZhaWwgdG8gZW50ZXIgdGhlIGJhY2sgLworICAgICAgICBmb3J3YXJkIGNhY2hlLCB3aGljaCB3 b3VsZCBoZWxwIHVzIGZpeCB0aGlzLgorCisgICAgICAgICogZmFzdC9vdmVyZmxvdy9ob3Jpem9u dGFsLXNjcm9sbC1hZnRlci1iYWNrLmh0bWw6CisKIDIwMjAtMDUtMDUgIFNhaWQgQWJvdS1IYWxs YXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBbIE1hYyBdIGZhc3QvYW5p bWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWNhbmNlbDIuaHRtbCBpcyBmbGFreSBmYWls aW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9vdmVyZmxvdy9ob3Jpem9udGFsLXNj cm9sbC1hZnRlci1iYWNrLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6b250 YWwtc2Nyb2xsLWFmdGVyLWJhY2suaHRtbAppbmRleCA3MDNjZTY0ZjY0ODdiODFjMTk4YmZkYzUw ZGM3NmE1OTdiNjdmYjA1Li40MTQ0ZGEwOTFlMTY5YzNmZjdmZjFlYTk2OWYxOGZlZGNjNTdmZTQ1 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6b250YWwtc2Nyb2xs LWFmdGVyLWJhY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L292ZXJmbG93L2hvcml6b250 YWwtc2Nyb2xsLWFmdGVyLWJhY2suaHRtbApAQCAtMTIsMTYgKzEyLDEzIEBAIGZ1bmN0aW9uIHZl cmlmeVBhZ2UoKQogICAgICAgICA6ICJQQVNTIjsKICAgICBkb2N1bWVudC5ib2R5LmlubmVySFRN TCA9IHJlc3VsdDsKICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgICAgICB0ZXN0 UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CiB9 CiAKIGZ1bmN0aW9uIG5hdmlnYXRlQXdheUFuZEJhY2soKSAKIHsKLSAgICAvLyBTaW11bGF0ZSBh IGxpbmsgY2xpY2sgdG8gY3JlYXRlIGEgaGlzdG9yeSBlbnRyeQotICAgIHZhciBldnQgPSBkb2N1 bWVudC5jcmVhdGVFdmVudCgiTW91c2VFdmVudHMiKTsKLSAgICBldnQuaW5pdE1vdXNlRXZlbnQo ImNsaWNrIiwgdHJ1ZSwgdHJ1ZSwgd2luZG93LAotICAgICAgMCwgMCwgMCwgMCwgMCwgZmFsc2Us IGZhbHNlLCBmYWxzZSwgZmFsc2UsIDAsIG51bGwpOwotICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdhbmNob3InKS5kaXNwYXRjaEV2ZW50KGV2dCk7CisgICAgc2Vzc2lvblN0b3JhZ2UuaG9y aXpvbnRhbF9zY3JvbGxfYWZ0ZXJfYmFja190ZXN0X3N0YXJ0ZWQgPSB0cnVlOworICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdhbmNob3InKS5jbGljaygpOwogfQogCiBmdW5jdGlvbiBydW5U ZXN0U3RlcCgpIApAQCAtMzAsMTcgKzI3LDI2IEBAIGZ1bmN0aW9uIHJ1blRlc3RTdGVwKCkKICAg ICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVu dGlsRG9uZSgpOwogICAgIH0KLSAgICB3aW5kb3cuc2V0VGltZW91dCgibmF2aWdhdGVBd2F5QW5k QmFjaygpIiwgMjAwKTsKKyAgICBzZXRUaW1lb3V0KCJuYXZpZ2F0ZUF3YXlBbmRCYWNrKCkiLCAw KTsKIH0KIAogZnVuY3Rpb24gb25WZXJpZnlQYWdlKGV2dCkKIHsKKyAgICBpZiAoIXNlc3Npb25T dG9yYWdlLmhvcml6b250YWxfc2Nyb2xsX2FmdGVyX2JhY2tfdGVzdF9zdGFydGVkKQorICAgICAg ICByZXR1cm47CisgICAgZGVsZXRlIHNlc3Npb25TdG9yYWdlLmhvcml6b250YWxfc2Nyb2xsX2Fm dGVyX2JhY2tfdGVzdF9zdGFydGVkOworCiAgICAgLy8gSWYgcGFnZXNob3cgaXMgaGFwcGVuaW5n IGFzIHJlc3VsdCBvZiBuYXZpZ2F0aW9uIGJhY2sgdGhlbiB3ZSBwcm9jZWVkLgogICAgIGlmIChl dnQucGVyc2lzdGVkKQotICAgICAgICBzZXRUaW1lb3V0KCJ2ZXJpZnlQYWdlKCkiLCAyMDApOwor ICAgICAgICBzZXRUaW1lb3V0KCJ2ZXJpZnlQYWdlKCkiLCAwKTsKKyAgICBlbHNlIHsKKyAgICAg ICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiRkFJTDogUGFnZSBkaWQgbm90IGdvIGludG8g dGhlIGJhY2svZm9yd2FyZCBjYWNoZSI7CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH0KIH0KIAotd2luZG93 Lm9ucGFnZXNob3cgPSBvblZlcmlmeVBhZ2U7CitvbnBhZ2VzaG93ID0gb25WZXJpZnlQYWdlOwog PC9zY3JpcHQ+CiA8aGVhZD4KIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+Cg==