211472 2020-05-05 14:38:50 -0700 [iOS] ASSERTION FAILED: !(_keyboardFlags & WebEventKeyboardInputModifierFlagsChanged) in -[WebEvent charactersIgnoringModifiers] when pressing modifier on PDF 2020-05-06 11:33:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 13 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 dbates dbates darin webkit-bug-importer oldest_to_newest 1649383 0 dbates 2020-05-05 14:38:50 -0700 Steps to reproduce: Using a hardware keyboard. 1. Load a PDF 2. Press the Command key on the keyboard. Then assert !(_keyboardFlags & WebEventKeyboardInputModifierFlagsChanged) fails in -[WebEvent charactersIgnoringModifiers]: [[ #1 0x000000011ab0c3b0 in WTFCrashWithInfo(int, char const*, char const*, int) at /Volumes/.../Source/WTF/wtf/Assertions.h:671 #2 0x000000011e1f8e58 in -[WebEvent charactersIgnoringModifiers] at /Volumes/.../Source/WebCore/platform/ios/WebEvent.mm:389 #3 0x000000010921c908 in -[WKKeyboardScrollingAnimator keyboardScrollForEvent:] at /Volumes/.../Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:187 #4 0x000000010921d320 in -[WKKeyboardScrollingAnimator beginWithEvent:] at /Volumes/.../Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:314 #5 0x000000010921eca8 in -[WKKeyboardScrollViewAnimator beginWithEvent:] at /Volumes/.../Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:546 #6 0x0000000109222e5c in -[WKPDFView web_handleKeyEvent:] at /Volumes/.../Source/WebKit/UIProcess/ios/WKPDFView.mm:96 #7 0x0000000108d97a0c in -[WKWebView(WKViewInternalIOS) _handleKeyUIEvent:] at /Volumes/.../Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:443 ... ]] 1649406 1 398561 dbates 2020-05-05 15:31:42 -0700 Created attachment 398561 Patch 1649407 2 dbates 2020-05-05 15:32:16 -0700 Tried to write a test, but it timesout: [[ <!DOCTYPE html> <html> <head> <script> if (!window.testRunner) document.write("Must run in WebKitTestRunner"); else { testRunner.dumpAsText(); testRunner.queueLoad("resources/test.pdf"); testRunner.queueLoadingScript('testRunner.runUIScript(`uiController.keyDown("", ["leftCommand"])`, () => { testRunner.queueBackNavigation(1); })'); } </script> </head> <body>PASS</body> </html> ]] 1649414 3 dbates 2020-05-05 15:52:22 -0700 (In reply to Daniel Bates from comment #2) > Tried to write a test, but it timesout: > > [[ > <!DOCTYPE html> > <html> > <head> > <script> > if (!window.testRunner) > document.write("Must run in WebKitTestRunner"); > else { > testRunner.dumpAsText(); > testRunner.queueLoad("resources/test.pdf"); > > testRunner.queueLoadingScript('testRunner.runUIScript(`uiController. > keyDown("", ["leftCommand"])`, () => { testRunner.queueBackNavigation(1); > })'); > } > </script> > </head> > <body>PASS</body> > </html> > ]] ^^^ Test triggers to assertion failure without the patch, but times out with the patch. 1649415 4 dbates 2020-05-05 15:54:57 -0700 (In reply to Daniel Bates from comment #3) > (In reply to Daniel Bates from comment #2) > > Tried to write a test, but it timesout: > > > > [[ > > <!DOCTYPE html> > > <html> > > <head> > > <script> > > if (!window.testRunner) > > document.write("Must run in WebKitTestRunner"); > > else { > > testRunner.dumpAsText(); > > testRunner.queueLoad("resources/test.pdf"); > > > > testRunner.queueLoadingScript('testRunner.runUIScript(`uiController. > > keyDown("", ["leftCommand"])`, () => { testRunner.queueBackNavigation(1); > > })'); > > } > > </script> > > </head> > > <body>PASS</body> > > </html> > > ]] > > ^^^ Test triggers to assertion failure without the patch, but times out with > the patch. My guess, timeout because testRunner.queueLoadingScript() just eval()s the string, but that string, registers a callback, which is never run. I need to wait until the UI process has processed the script though... 1649443 5 398561 darin 2020-05-05 17:18:52 -0700 Comment on attachment 398561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398561&action=review > Source/WebKit/ChangeLog:12 > + I tried to write a test for this using testRunner.queueLoad() and queueLoadingScript(), > + but I couldn't get it to not timeout. For some reason script execution doesn't seem to > + work after loading the PDF. Hope you haven’t given up entirely. 1649444 6 398571 dbates 2020-05-05 17:19:32 -0700 Created attachment 398571 Patch and test Now with a test. 1649715 7 dbates 2020-05-06 11:32:14 -0700 Thanks for the review, Darin. 1649716 8 398571 dbates 2020-05-06 11:32:51 -0700 Comment on attachment 398571 Patch and test Clearing flags on attachment: 398571 Committed r261240: <https://trac.webkit.org/changeset/261240> 1649717 9 dbates 2020-05-06 11:32:53 -0700 All reviewed patches have been landed. Closing bug. 1649718 10 webkit-bug-importer 2020-05-06 11:33:15 -0700 <rdar://problem/62938942> 398561 2020-05-05 15:31:42 -0700 2020-05-05 17:19:31 -0700 Patch bug-211472-20200505153142.patch text/plain 1922 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhjY2M5Y2MzYmViZWJhN2Y0 Yjk5ZjMwY2RiNjgxZTllZTM0M2EzNTQuLmYzZmVkMmE3MGU2MWI5NmU4YzdhZDIyZWFhYzY2NTg2 NWY4MDFkYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDUtMDUgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFTU0VSVElPTiBGQUlM RUQ6ICEoX2tleWJvYXJkRmxhZ3MgJiBXZWJFdmVudEtleWJvYXJkSW5wdXRNb2RpZmllckZsYWdz Q2hhbmdlZCkgaW4gLVtXZWJFdmVudCBjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnNdIHdoZW4g cHJlc3NpbmcgbW9kaWZpZXIgb24gUERGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTE0NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEbyBub3QgYXNrIGZvciBldmVudCBjaGFyYWN0ZXIgc3RyaW5nIGZv ciBhIGZsYWdzIGNoYW5nZWQgZXZlbnQ6IHRoZXkgZG9uJ3QgaGF2ZSBvbmUuCisKKyAgICAgICAg SSB0cmllZCB0byB3cml0ZSBhIHRlc3QgZm9yIHRoaXMgdXNpbmcgdGVzdFJ1bm5lci5xdWV1ZUxv YWQoKSBhbmQgcXVldWVMb2FkaW5nU2NyaXB0KCksCisgICAgICAgIGJ1dCBJIGNvdWxkbid0IGdl dCBpdCB0byBub3QgdGltZW91dC4gRm9yIHNvbWUgcmVhc29uIHNjcmlwdCBleGVjdXRpb24gZG9l c24ndCBzZWVtIHRvCisgICAgICAgIHdvcmsgYWZ0ZXIgbG9hZGluZyB0aGUgUERGLgorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IubW06CisgICAg ICAgICgtW1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvciBrZXlib2FyZFNjcm9sbEZvckV2ZW50 Ol0pOgorCiAyMDIwLTA0LTMwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBbaU9TXSBJbXBsZW1lbnQgLW1hcmtlZFRleHRSYW5nZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3Iu bW0KaW5kZXggNjVjYjViNTA0MmUzMzNjOThjOThiM2ZiYWZmNDBiNTEyODQ4ZjY3ZS4uZmIwNjk0 M2QxOGVjOWUxNGZlMzI0M2NkNWVjYzkzZDljYWI0ODQ0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLm1t CkBAIC0xODQsNiArMTg0LDkgQEAgLSAoT3B0aW9uYWw8V2ViS2l0OjpLZXlib2FyZFNjcm9sbD4p a2V5Ym9hcmRTY3JvbGxGb3JFdmVudDooOjpXZWJFdmVudCAqKWV2ZW50CiAgICAgaWYgKCFbX3Nj cm9sbGFibGUgaXNLZXlib2FyZFNjcm9sbGFibGVdKQogICAgICAgICByZXR1cm4gV1RGOjpudWxs b3B0OwogCisgICAgaWYgKGV2ZW50LmtleWJvYXJkRmxhZ3MgJiBXZWJFdmVudEtleWJvYXJkSW5w dXRNb2RpZmllckZsYWdzQ2hhbmdlZCkKKyAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKwog ICAgIE5TU3RyaW5nICpjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgPSBldmVudC5jaGFyYWN0 ZXJzSWdub3JpbmdNb2RpZmllcnM7CiAgICAgaWYgKCFjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmll cnMubGVuZ3RoKQogICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0Owo= 398571 2020-05-05 17:19:32 -0700 2020-05-06 11:32:51 -0700 Patch and test bug-211472-20200505171932.patch text/plain 3892 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk1Nzg2N2EzMTU2NDc2Y2Iy NGExMmY5NjMyYjdhYWZlMmNiNTFkZTkuLjg3MjA5MjRhZjdkNWM4MWZmZmY3NjA1NzQ2NTA1YmJk MDcxOWFkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDUtMDUgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFTU0VSVElPTiBGQUlM RUQ6ICEoX2tleWJvYXJkRmxhZ3MgJiBXZWJFdmVudEtleWJvYXJkSW5wdXRNb2RpZmllckZsYWdz Q2hhbmdlZCkgaW4gLVtXZWJFdmVudCBjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnNdIHdoZW4g cHJlc3NpbmcgbW9kaWZpZXIgb24gUERGCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTE0NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEbyBub3QgYXNrIGZvciBldmVudCBjaGFyYWN0ZXIgc3RyaW5nIGZv ciBhIGZsYWdzIGNoYW5nZWQgZXZlbnQ6IHRoZXkgZG9uJ3QgaGF2ZSBvbmUuCisKKyAgICAgICAg VGVzdDogZmFzdC9ldmVudHMvaW9zL3BkZi1tb2RpZmVyLWtleS1kb3duLWNyYXNoLmh0bWwKKwor ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLm1tOgor ICAgICAgICAoLVtXS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3Iga2V5Ym9hcmRTY3JvbGxGb3JF dmVudDpdKToKKwogMjAyMC0wNS0wNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgU2hvdWxkIHNob3cgc2VsZWN0aW9uIGhpZ2hsaWdodCBkdXJpbmcgdGV4dCBp bnRlcmFjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5 Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IubW0KaW5kZXggNjVjYjViNTA0MmUzMzNjOThjOThi M2ZiYWZmNDBiNTEyODQ4ZjY3ZS4uZmIwNjk0M2QxOGVjOWUxNGZlMzI0M2NkNWVjYzkzZDljYWI0 ODQ0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRT Y3JvbGxpbmdBbmltYXRvci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tL ZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLm1tCkBAIC0xODQsNiArMTg0LDkgQEAgLSAoT3B0aW9u YWw8V2ViS2l0OjpLZXlib2FyZFNjcm9sbD4pa2V5Ym9hcmRTY3JvbGxGb3JFdmVudDooOjpXZWJF dmVudCAqKWV2ZW50CiAgICAgaWYgKCFbX3Njcm9sbGFibGUgaXNLZXlib2FyZFNjcm9sbGFibGVd KQogICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogCisgICAgaWYgKGV2ZW50LmtleWJvYXJk RmxhZ3MgJiBXZWJFdmVudEtleWJvYXJkSW5wdXRNb2RpZmllckZsYWdzQ2hhbmdlZCkKKyAgICAg ICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKwogICAgIE5TU3RyaW5nICpjaGFyYWN0ZXJzSWdub3Jp bmdNb2RpZmllcnMgPSBldmVudC5jaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnM7CiAgICAgaWYg KCFjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMubGVuZ3RoKQogICAgICAgICByZXR1cm4gV1RG OjpudWxsb3B0OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IGMwZjA3YzhiZThjMjIxOGIzYmZmNjY2NmFiYzk3NzVlYzlkZThm YTcuLmE4MDQ2NzI3NTMxZTk1ZTU1NzE5MzU4YWU3NjYxMzFiYTIwY2U2NDEgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wNS0wNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CisKKyAgICAgICAgW2lPU10gQVNTRVJUSU9OIEZBSUxFRDogIShfa2V5Ym9hcmRGbGFncyAmIFdl YkV2ZW50S2V5Ym9hcmRJbnB1dE1vZGlmaWVyRmxhZ3NDaGFuZ2VkKSBpbiAtW1dlYkV2ZW50IGNo YXJhY3RlcnNJZ25vcmluZ01vZGlmaWVyc10gd2hlbiBwcmVzc2luZyBtb2RpZmllciBvbiBQREYK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTQ3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRl c3QuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvcGRmLW1vZGlmZXIta2V5LWRvd24tY3Jh c2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvcGRmLW1v ZGlmZXIta2V5LWRvd24tY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMjAtMDMtMjUgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFNob3VsZCBzaG93IGlu cHV0IHZpZXcgd2hlbiBiZWNhbWUgZmlyc3QgcmVzcG9uZGVyIGlmIGtleWJvYXJkIHdhcyBzaG93 aW5nIHdoZW4gdGhlIHZpZXcgd2FzIHJlc2lnbmVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9pb3MvcGRmLW1vZGlmZXIta2V5LWRvd24tY3Jhc2gtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL3BkZi1tb2RpZmVyLWtleS1kb3duLWNyYXNoLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYmUxMjQ3MGZiMTljMDA3OGM5OTU5NTBmYmQ0OTRjZjBm MjE5ZTU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL3Bk Zi1tb2RpZmVyLWtleS1kb3duLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNT IGRpZCBub3QgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mv cGRmLW1vZGlmZXIta2V5LWRvd24tY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2lvcy9wZGYtbW9kaWZlci1rZXktZG93bi1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZjMGY1NTVh ZGVkMGM0MjkyMGQ1MDJmZWQ3MTkwZmQ1YTUzMzE0NWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvcGRmLW1vZGlmZXIta2V5LWRvd24tY3Jhc2guaHRtbApA QCAtMCwwICsxLDE1IEBACis8IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBb IGVuYWJsZUJhY2tGb3J3YXJkQ2FjaGU9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQ+CitpZiAoIXdpbmRvdy50ZXN0UnVubmVyKQorICAgIGRvY3VtZW50LndyaXRlKCJNdXN0IGJl IHJ1biBpbiBXZWJLaXRUZXN0UnVubmVyIik7CitlbHNlIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKKyAgICB0ZXN0UnVubmVyLnF1ZXVlTG9hZCgiLi4vLi4vL2ltYWdlcy9yZXNvdXJj ZXMvZ3JlZW5fcmVjdGFuZ2xlLnBkZiIpOworICAgIHRlc3RSdW5uZXIucXVldWVMb2FkaW5nU2Ny aXB0KCdzZXRUaW1lb3V0KCJoaXN0b3J5LmJhY2soKSIsIDApOyB0ZXN0UnVubmVyLnJ1blVJU2Ny aXB0KGB1aUNvbnRyb2xsZXIua2V5RG93bigiIiwgWyJsZWZ0Q29tbWFuZCJdKWAsICgpID0+IHt9 KTsnKTsKK30gCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PlBBU1MgZGlkIG5vdCBjcmFzaC48 L2JvZHk+Cis8L2h0bWw+Cg==