211451 2020-05-05 09:13:07 -0700 Check for app-bound domains should confirm WKAppBoundDomains key exists when checking for default app-bound protocols. 2020-05-05 11:57:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham webkit-bug-importer wilander oldest_to_newest 1649226 0 katherine_cheney 2020-05-05 09:13:07 -0700 Currently, the app-bound domains check returns true for special protocols without checking for the WKAppBoundDomains key. 1649251 1 398521 katherine_cheney 2020-05-05 10:11:25 -0700 Created attachment 398521 Patch 1649252 2 katherine_cheney 2020-05-05 10:11:58 -0700 <rdar://problem/62715316> 1649255 3 katherine_cheney 2020-05-05 10:23:24 -0700 I confirmed this fix works manually. I was unable to write a test case for the empty WKAppBoundDomains case because TestWebKitAPI has the key in its Info.plist for other tests. 1649269 4 398521 bfulgham 2020-05-05 11:06:07 -0700 Comment on attachment 398521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398521&action=review Looks good. r=me. > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:465 > + // Must check for both an empty app bound domains and an empty key before returning nullopt "both an empty app bound domains ..." maybe add set? or array? -- the plural domains with the 'an' is throwing me off. 1649278 5 398529 katherine_cheney 2020-05-05 11:20:17 -0700 Created attachment 398529 Patch for landing 1649304 6 ews-feeder 2020-05-05 11:56:36 -0700 Committed r261187: <https://trac.webkit.org/changeset/261187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398529. 1649305 7 webkit-bug-importer 2020-05-05 11:57:18 -0700 <rdar://problem/62897375> 398521 2020-05-05 10:11:25 -0700 2020-05-05 11:20:15 -0700 Patch bug-211451-20200505101124.patch text/plain 3260 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkNzhkMGEyNTExMGU1NWRh YTJjOWEyNTA5NTMzZDJkYjE5ZmU1MWQuLjlhOTZmMDE2Y2I2MDFmOTUwMzE5OTU4NDBkYzlmYzg2 M2Q1MWRmYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDUtMDUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIGFw cC1ib3VuZCBkb21haW5zIHNob3VsZCBjb25maXJtIFdLQXBwQm91bmREb21haW5zIGtleSBleGlz dHMgd2hlbiBjaGVja2luZyBmb3IgZGVmYXVsdCBhcHAtYm91bmQgcHJvdG9jb2xzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNDUxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MjcxNTMxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoZWNrcyBmb3IgV0tBcHBCb3VuZERvbWFpbnMga2V5IGJlZm9y ZSB0cmVhdGluZyBhIHByb3RvY29sIGFzCisgICAgICAgIGFwcC1ib3VuZC4gVGhpcyBpcyBhIHJl Z3Jlc3Npb24gaW4gZXhwZWN0ZWQgYmVoYXZpb3IgYWZ0ZXIgbWFraW5nCisgICAgICAgIEluLUFw cCBCcm93c2VyIHByaXZhY3kgb3B0LWluIGJhc2VkIG9uIHRoZSBwcmVzZW5jZSBvZiB0aGUga2V5 LgorCisgICAgICAgIEFsc28gbW92ZXMgdGhlIGNoZWNrIGZvciBzcGVjaWFsIHByb3RvY29scyBp bnNpZGUgb2YgdGhlIGNvbXBsZXRpb24gaGFuZGxlciBmb3IKKyAgICAgICAgZW5zdXJlQXBwQm91 bmREb21haW5zIHRvIG1ha2Ugc3VyZSB0aGUgY2hlY2sgZm9yIHRoZSBrZXkgaGFzIGZpbmlzaGVk LgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3Rv cmVDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6YmVnaW5BcHBC b3VuZERvbWFpbkNoZWNrKToKKyAgICAgICAgQWRkZWQgYSBjb21tZW50IHRvIGNsYXJpZnkgd2h5 IHdlIG5lZWQgdG8gY2hlY2sgZm9yIGJvdGggYW4gZW1wdHkKKyAgICAgICAgYXBwLWJvdW5kIGRv bWFpbnMgbGlzdCBhbmQgdGhlIHByZXNlbmNlIG9mIHRoZSBrZXkgZm9yIHRlc3RpbmcKKyAgICAg ICAgcHVycG9zZXMuCisKIDIwMjAtMDUtMDQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtDb2NvYV0gUmVtb3ZlIGEgZmV3IHVubmVlZGVkIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEIGNoZWNrcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29h Lm1tCmluZGV4IGYzNDIzYTkyYWJhZDliZmFhMGY4ZWVkOTIxMmJlMGEyYTdjNWQ0MDQuLjA4MDZi Y2FlMTkyOWRhODNlZGY2OWZlMmMwMTY0M2MwZmJlMGViNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRl RGF0YVN0b3JlQ29jb2EubW0KQEAgLTQ2MSwxNyArNDYxLDE5IEBAIHZvaWQgV2Vic2l0ZURhdGFT dG9yZTo6YmVnaW5BcHBCb3VuZERvbWFpbkNoZWNrKGNvbnN0IFVSTCYgcmVxdWVzdFVSTCwgV2Vi RnJhbWVQCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKIAotICAgIGlmIChzaG91 bGRUcmVhdFVSTFByb3RvY29sQXNBcHBCb3VuZChyZXF1ZXN0VVJMKSkgewotICAgICAgICBsaXN0 ZW5lci5kaWRSZWNlaXZlQXBwQm91bmREb21haW5SZXN1bHQoTmF2aWdhdGluZ1RvQXBwQm91bmRE b21haW46Olllcyk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBlbnN1cmVBcHBCb3Vu ZERvbWFpbnMoW2RvbWFpbiA9IFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWluKHJlcXVlc3RVUkwp LCBsaXN0ZW5lciA9IG1ha2VSZWYobGlzdGVuZXIpXSAoYXV0byYgZG9tYWlucykgbXV0YWJsZSB7 Ci0gICAgICAgIGlmIChkb21haW5zLmlzRW1wdHkoKSAmJiAha2V5RXhpc3RzKSB7CisgICAgZW5z dXJlQXBwQm91bmREb21haW5zKFsmcmVxdWVzdFVSTCwgbGlzdGVuZXIgPSBtYWtlUmVmKGxpc3Rl bmVyKV0gKGF1dG8mIGRvbWFpbnMpIG11dGFibGUgeworICAgICAgICAvLyBNdXN0IGNoZWNrIGZv ciBib3RoIGFuIGVtcHR5IGFwcCBib3VuZCBkb21haW5zIGFuZCBhbiBlbXB0eSBrZXkgYmVmb3Jl IHJldHVybmluZyBudWxsb3B0CisgICAgICAgIC8vIGJlY2F1c2UgdGVzdCBjYXNlcyBtYXkgaGF2 ZSBhcHAgYm91bmQgZG9tYWlucyBidXQgbm8ga2V5LgorICAgICAgICBib29sIGhhc0FwcEJvdW5k RG9tYWlucyA9IGtleUV4aXN0cyB8fCAhZG9tYWlucy5pc0VtcHR5KCk7CisgICAgICAgIGlmICgh aGFzQXBwQm91bmREb21haW5zKSB7CiAgICAgICAgICAgICBsaXN0ZW5lci0+ZGlkUmVjZWl2ZUFw cEJvdW5kRG9tYWluUmVzdWx0KFdURjo6bnVsbG9wdCk7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KLSAgICAgICAgbGlzdGVuZXItPmRpZFJlY2VpdmVBcHBCb3VuZERvbWFpblJlc3Vs dChkb21haW5zLmNvbnRhaW5zKGRvbWFpbikgPyBOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbjo6 WWVzIDogTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW46Ok5vKTsKKyAgICAgICAgaWYgKHNob3Vs ZFRyZWF0VVJMUHJvdG9jb2xBc0FwcEJvdW5kKHJlcXVlc3RVUkwpKSB7CisgICAgICAgICAgICBs aXN0ZW5lci0+ZGlkUmVjZWl2ZUFwcEJvdW5kRG9tYWluUmVzdWx0KE5hdmlnYXRpbmdUb0FwcEJv dW5kRG9tYWluOjpZZXMpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAg IGxpc3RlbmVyLT5kaWRSZWNlaXZlQXBwQm91bmREb21haW5SZXN1bHQoZG9tYWlucy5jb250YWlu cyhXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbihyZXF1ZXN0VVJMKSkgPyBOYXZpZ2F0aW5nVG9B cHBCb3VuZERvbWFpbjo6WWVzIDogTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW46Ok5vKTsKICAg ICB9KTsKIH0KIAo= 398529 2020-05-05 11:20:17 -0700 2020-05-05 11:56:36 -0700 Patch for landing bug-211451-20200505112016.patch text/plain 3264 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkNzhkMGEyNTExMGU1NWRh YTJjOWEyNTA5NTMzZDJkYjE5ZmU1MWQuLmRlZGJmNTVkN2MxYzM4ODQwYTA0YjdkYmI3YmQzMDFj MjBlMGVjMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDUtMDUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIGFw cC1ib3VuZCBkb21haW5zIHNob3VsZCBjb25maXJtIFdLQXBwQm91bmREb21haW5zIGtleSBleGlz dHMgd2hlbiBjaGVja2luZyBmb3IgZGVmYXVsdCBhcHAtYm91bmQgcHJvdG9jb2xzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNDUxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MjcxNTMxNgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1 bGdoYW0uCisKKyAgICAgICAgQ2hlY2tzIGZvciBXS0FwcEJvdW5kRG9tYWlucyBrZXkgYmVmb3Jl IHRyZWF0aW5nIGEgcHJvdG9jb2wgYXMKKyAgICAgICAgYXBwLWJvdW5kLiBUaGlzIGlzIGEgcmVn cmVzc2lvbiBpbiBleHBlY3RlZCBiZWhhdmlvciBhZnRlciBtYWtpbmcKKyAgICAgICAgSW4tQXBw IEJyb3dzZXIgcHJpdmFjeSBvcHQtaW4gYmFzZWQgb24gdGhlIHByZXNlbmNlIG9mIHRoZSBrZXku CisKKyAgICAgICAgQWxzbyBtb3ZlcyB0aGUgY2hlY2sgZm9yIHNwZWNpYWwgcHJvdG9jb2xzIGlu c2lkZSBvZiB0aGUgY29tcGxldGlvbiBoYW5kbGVyIGZvcgorICAgICAgICBlbnN1cmVBcHBCb3Vu ZERvbWFpbnMgdG8gbWFrZSBzdXJlIHRoZSBjaGVjayBmb3IgdGhlIGtleSBoYXMgZmluaXNoZWQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9y ZUNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpiZWdpbkFwcEJv dW5kRG9tYWluQ2hlY2spOgorICAgICAgICBBZGRlZCBhIGNvbW1lbnQgdG8gY2xhcmlmeSB3aHkg d2UgbmVlZCB0byBjaGVjayBmb3IgYm90aCBhbiBlbXB0eQorICAgICAgICBhcHAtYm91bmQgZG9t YWlucyBsaXN0IGFuZCB0aGUgcHJlc2VuY2Ugb2YgdGhlIGtleSBmb3IgdGVzdGluZworICAgICAg ICBwdXJwb3Nlcy4KKwogMjAyMC0wNS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBSZW1vdmUgYSBmZXcgdW5uZWVkZWQgX19JUEhPTkVfT1NfVkVS U0lPTl9NSU5fUkVRVUlSRUQgY2hlY2tzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2Eu bW0KaW5kZXggZjM0MjNhOTJhYmFkOWJmYWEwZjhlZWQ5MjEyYmUwYTJhN2M1ZDQwNC4uY2U4YzNl ZWVkMDBlOTZlYTlhYTA2OGRmM2U1M2Q0MGM4MTc2YjY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVE YXRhU3RvcmVDb2NvYS5tbQpAQCAtNDYxLDE3ICs0NjEsMTkgQEAgdm9pZCBXZWJzaXRlRGF0YVN0 b3JlOjpiZWdpbkFwcEJvdW5kRG9tYWluQ2hlY2soY29uc3QgVVJMJiByZXF1ZXN0VVJMLCBXZWJG cmFtZVAKIHsKICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogCi0gICAgaWYgKHNob3Vs ZFRyZWF0VVJMUHJvdG9jb2xBc0FwcEJvdW5kKHJlcXVlc3RVUkwpKSB7Ci0gICAgICAgIGxpc3Rl bmVyLmRpZFJlY2VpdmVBcHBCb3VuZERvbWFpblJlc3VsdChOYXZpZ2F0aW5nVG9BcHBCb3VuZERv bWFpbjo6WWVzKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGVuc3VyZUFwcEJvdW5k RG9tYWlucyhbZG9tYWluID0gV2ViQ29yZTo6UmVnaXN0cmFibGVEb21haW4ocmVxdWVzdFVSTCks IGxpc3RlbmVyID0gbWFrZVJlZihsaXN0ZW5lcildIChhdXRvJiBkb21haW5zKSBtdXRhYmxlIHsK LSAgICAgICAgaWYgKGRvbWFpbnMuaXNFbXB0eSgpICYmICFrZXlFeGlzdHMpIHsKKyAgICBlbnN1 cmVBcHBCb3VuZERvbWFpbnMoWyZyZXF1ZXN0VVJMLCBsaXN0ZW5lciA9IG1ha2VSZWYobGlzdGVu ZXIpXSAoYXV0byYgZG9tYWlucykgbXV0YWJsZSB7CisgICAgICAgIC8vIE11c3QgY2hlY2sgZm9y IGJvdGggYW4gZW1wdHkgYXBwIGJvdW5kIGRvbWFpbnMgbGlzdCBhbmQgYW4gZW1wdHkga2V5IGJl Zm9yZSByZXR1cm5pbmcgbnVsbG9wdAorICAgICAgICAvLyBiZWNhdXNlIHRlc3QgY2FzZXMgbWF5 IGhhdmUgYXBwIGJvdW5kIGRvbWFpbnMgYnV0IG5vIGtleS4KKyAgICAgICAgYm9vbCBoYXNBcHBC b3VuZERvbWFpbnMgPSBrZXlFeGlzdHMgfHwgIWRvbWFpbnMuaXNFbXB0eSgpOworICAgICAgICBp ZiAoIWhhc0FwcEJvdW5kRG9tYWlucykgewogICAgICAgICAgICAgbGlzdGVuZXItPmRpZFJlY2Vp dmVBcHBCb3VuZERvbWFpblJlc3VsdChXVEY6Om51bGxvcHQpOwogICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB9Ci0gICAgICAgIGxpc3RlbmVyLT5kaWRSZWNlaXZlQXBwQm91bmREb21haW5S ZXN1bHQoZG9tYWlucy5jb250YWlucyhkb21haW4pID8gTmF2aWdhdGluZ1RvQXBwQm91bmREb21h aW46OlllcyA6IE5hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluOjpObyk7CisgICAgICAgIGlmIChz aG91bGRUcmVhdFVSTFByb3RvY29sQXNBcHBCb3VuZChyZXF1ZXN0VVJMKSkgeworICAgICAgICAg ICAgbGlzdGVuZXItPmRpZFJlY2VpdmVBcHBCb3VuZERvbWFpblJlc3VsdChOYXZpZ2F0aW5nVG9B cHBCb3VuZERvbWFpbjo6WWVzKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAg ICAgICBsaXN0ZW5lci0+ZGlkUmVjZWl2ZUFwcEJvdW5kRG9tYWluUmVzdWx0KGRvbWFpbnMuY29u dGFpbnMoV2ViQ29yZTo6UmVnaXN0cmFibGVEb21haW4ocmVxdWVzdFVSTCkpID8gTmF2aWdhdGlu Z1RvQXBwQm91bmREb21haW46OlllcyA6IE5hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluOjpObyk7 CiAgICAgfSk7CiB9CiAK