211449 2020-05-05 08:51:41 -0700 Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe 2020-05-15 14:31:27 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma achristensen achristensen beidson cdumez cgarcia ggaren webkit-bug-importer oldest_to_newest 1649213 0 398515 ajuma 2020-05-05 08:51:41 -0700 Created attachment 398515 Test case Steps to reproduce: 1. Tap on a link in an iframe, that navigates the iframe (rather than the main frame) 2. Go back Expected result: After (2) completes, WKWebView.loading becomes NO Actual result: WKWebView.loading is stuck at YES until the next navigation On Safari on iOS 13.4, this bug causes the blue loading bar to remain visible after (2) is complete. 1649228 1 webkit-bug-importer 2020-05-05 09:16:43 -0700 <rdar://problem/62890213> 1650737 2 ajuma 2020-05-08 13:27:38 -0700 This is happening because PageLoadState::setPendingAPIRequest is called during WebPageProxy::goToBackForwardItem, but the pending API request is never cleared. In WebPageProxy::didStartProvisionalLoadForFrameShared, |navigation| is null, so we don't call PageLoadState::clearPendingAPIRequest. The |navigation| is null because in WebPageProxy::goToBackForwardItem, we only create an API::Navigation if the target item isn't considered same-document wrt the current item. So this bug is a regression from r249142, which changed WebPageProxy::didStartProvisionalLoadForFrameShared to only call clearPendingAPIRequest if |navigation| is non-null. 1653157 3 399506 achristensen 2020-05-15 13:33:26 -0700 Created attachment 399506 Patch 1653159 4 399506 ggaren 2020-05-15 13:45:05 -0700 Comment on attachment 399506 Patch r=me 1653179 5 ews-feeder 2020-05-15 14:31:25 -0700 Committed r261761: <https://trac.webkit.org/changeset/261761> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399506. 398515 2020-05-05 08:51:41 -0700 2020-05-05 08:51:41 -0700 Test case iframe.html text/html 185 ajuma CjxoMj4KVGFwIG9uIGEgbGluayBpbiB0aGUgaWZyYW1lIGJlbG93LCB0aGVuIG5hdmlnYXRlIGJh Y2suCk5vdGljZSB0aGUgbG9hZGluZyBpbmRpY2F0b3IgcmVtYWlucyB2aXNpYmxlLgo8L2gyPgoK PGlmcmFtZSBzcmM9Imh0dHBzOi8vd3d3LmNzLnRvcm9udG8uZWR1IiB3aWR0aD0iNDAwcHgiIGhl aWdodD0iNjAwcHgiPgo= 399506 2020-05-15 13:33:26 -0700 2020-05-15 14:31:26 -0700 Patch bug-211449-20200515133326.patch text/plain 5876 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjE2ODApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVncmVzc2lvbiAo aU9TIDEzLjQsIHIyNDkxNDIpOiBXS1dlYlZpZXcubG9hZGluZyBpcyBuZXZlciByZXNldCBhZnRl ciBhIEJhY2sgbmF2aWdhdGlvbiBpbiBhbiBpZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBjYWxsIGNsZWFyUGVuZGluZ0FQSVJlcXVl c3QgaW4gV2ViUGFnZVByb3h5OjpkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lU2hhcmVk LgorICAgICAgICByMjQ5MTQyIHJlZ3Jlc3NlZCB0aGlzIGFuZCBjYXVzZWQgbW9yZSAibG9hZGlu ZyBhcHBlYXJzIHRvIGNvbnRpbnVlIGZvcmV2ZXIiIGJ1Z3MgZml4ZWQgaW4gcjI0OTg5MC4KKyAg ICAgICAgVGhpcyBzaG91bGQgZml4IGJvdGgsIGJ5IHJlbW92aW5nIHRoZSBwcm9ibGVtYXRpYyBo YWxmIG9mIHIyNDkxNDIuCisKKyAgICAgICAgQ292ZXJlZCBieSBhbiBBUEkgdGVzdC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ YWdlUHJveHk6OmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWVTaGFyZWQpOgorCiAyMDIw LTA1LTEzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW0lQ Q10gVXNlIHRlbXBsYXRlcyB0byByZWR1Y2UgZHVwbGljYXRlIGNvZGUgaW4gSVBDOjpEZWNvZGVy IGFuZCBJUEM6OkVuY29kZXIgY2xhc3NlcwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyNjE2ODApCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDI1LDkgKzQ0MjUsNyBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkU3RhcnRQcm92aXNpb25hbExvCiAgICAgUkVMRUFTRV9M T0dfSUZfQUxMT1dFRChMb2FkaW5nLCAiZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZTog ZnJhbWVJRCA9ICUiIFBSSXU2NCwgZnJhbWVJRC50b1VJbnQ2NCgpKTsKIAogICAgIGF1dG8gdHJh bnNhY3Rpb24gPSBtX3BhZ2VMb2FkU3RhdGUudHJhbnNhY3Rpb24oKTsKLSAgICBib29sIGZyb21B bHRlcm5hdGVIVE1MQVBJID0gIXVucmVhY2hhYmxlVVJMLmlzRW1wdHkoKSAmJiB1bnJlYWNoYWJs ZVVSTCA9PSBtX3BhZ2VMb2FkU3RhdGUucGVuZGluZ0FQSVJlcXVlc3RVUkwoKTsKLSAgICBpZiAo bmF2aWdhdGlvbiB8fCBmcm9tQWx0ZXJuYXRlSFRNTEFQSSkKLSAgICAgICAgbV9wYWdlTG9hZFN0 YXRlLmNsZWFyUGVuZGluZ0FQSVJlcXVlc3QodHJhbnNhY3Rpb24pOworICAgIG1fcGFnZUxvYWRT dGF0ZS5jbGVhclBlbmRpbmdBUElSZXF1ZXN0KHRyYW5zYWN0aW9uKTsKIAogICAgIGlmIChmcmFt ZS0+aXNNYWluRnJhbWUoKSkgewogICAgICAgICBwcm9jZXNzLT5kaWRTdGFydFByb3Zpc2lvbmFs TG9hZEZvck1haW5GcmFtZSh1cmwpOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjYxNzU2KQorKysgVG9vbHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDUtMTUgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWdyZXNzaW9uIChp T1MgMTMuNCwgcjI0OTE0Mik6IFdLV2ViVmlldy5sb2FkaW5nIGlzIG5ldmVyIHJlc2V0IGFmdGVy IGEgQmFjayBuYXZpZ2F0aW9uIGluIGFuIGlmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExNDQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L05hdmlnYXRpb24ubW06CisgICAgICAgICgtW0xvYWRpbmdPYnNlcnZlciBjaGFuZ2VzT2JzZXJ2 ZWRdKToKKyAgICAgICAgKC1bTG9hZGluZ09ic2VydmVyIG9ic2VydmVWYWx1ZUZvcktleVBhdGg6 b2ZPYmplY3Q6Y2hhbmdlOmNvbnRleHQ6XSk6CisgICAgICAgIChURVNUKToKKwogMjAyMC0wNS0x NSAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtidWls ZGJvdF0gSW5jcmVhc2UgYmxvY2tzaXplIG9mIGZpbGUgdHJhbnNmZXIgaW4gVXBsb2FkVGVzdFJl c3VsdHMgc3RlcApJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9O YXZpZ2F0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvTmF2aWdhdGlvbi5tbQkocmV2aXNpb24gMjYxNTc5KQorKysgVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9OYXZpZ2F0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yNSw2ICsyNSwxMSBAQAogCiAjaW1wb3J0ICJjb25maWcuaCIKIAorI2ltcG9ydCAiSFRUUFNl cnZlci5oIgorI2ltcG9ydCAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKKyNpbXBvcnQgIlRlc3QuaCIK KyNpbXBvcnQgIlRlc3RVSURlbGVnYXRlLmgiCisjaW1wb3J0ICJUZXN0VVJMU2NoZW1lSGFuZGxl ci5oIgogI2ltcG9ydCA8V2ViS2l0L1dLQmFja0ZvcndhcmRMaXN0UHJpdmF0ZS5oPgogI2ltcG9y dCA8V2ViS2l0L1dLTmF2aWdhdGlvbkFjdGlvblByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9X S05hdmlnYXRpb25EZWxlZ2F0ZVByaXZhdGUuaD4KQEAgLTMzLDkgKzM4LDYgQEAKICNpbXBvcnQg PFdlYktpdC9XS1dlYlZpZXdDb25maWd1cmF0aW9uUHJpdmF0ZS5oPgogI2ltcG9ydCA8d3RmL1Jl dGFpblB0ci5oPgogI2ltcG9ydCA8d3RmL1ZlY3Rvci5oPgotI2ltcG9ydCAiUGxhdGZvcm1VdGls aXRpZXMuaCIKLSNpbXBvcnQgIlRlc3QuaCIKLSNpbXBvcnQgIlRlc3RVUkxTY2hlbWVIYW5kbGVy LmgiCiAKIHN0YXRpYyBib29sIGlzRG9uZTsKIHN0YXRpYyBSZXRhaW5QdHI8V0tOYXZpZ2F0aW9u PiBjdXJyZW50TmF2aWdhdGlvbjsKQEAgLTY3MSw0ICs2NzMsNjggQEAgVEVTVChXS05hdmlnYXRp b24sIExpc3RJdGVtQWRkZWRSZW1vdmVkKQogICAgIFtbd2ViVmlldyBiYWNrRm9yd2FyZExpc3Rd IF9yZW1vdmVBbGxJdGVtc107CiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZpc0RvbmUp OwogfQorCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQorCisjaWYgSEFWRShORVRXT1JLX0ZSQU1F V09SSykKKworQGludGVyZmFjZSBMb2FkaW5nT2JzZXJ2ZXIgOiBOU09iamVjdAorQHByb3BlcnR5 IChub25hdG9taWMsIHJlYWRvbmx5KSBzaXplX3QgY2hhbmdlc09ic2VydmVkOworQGVuZAorCitA aW1wbGVtZW50YXRpb24gTG9hZGluZ09ic2VydmVyIHsKKyAgICBzaXplX3QgX2NoYW5nZXNPYnNl cnZlZDsKK30KKworLSAoc2l6ZV90KWNoYW5nZXNPYnNlcnZlZAoreworICAgIHJldHVybiBfY2hh bmdlc09ic2VydmVkOworfQorCistICh2b2lkKW9ic2VydmVWYWx1ZUZvcktleVBhdGg6KE5TU3Ry aW5nICopa2V5UGF0aCBvZk9iamVjdDooaWQpb2JqZWN0IGNoYW5nZTooTlNEaWN0aW9uYXJ5ICop Y2hhbmdlIGNvbnRleHQ6KHZvaWQgKiljb250ZXh0Cit7CisgICAgRVhQRUNUX1dLX1NUUkVRKGtl eVBhdGgsICJsb2FkaW5nIik7CisgICAgX2NoYW5nZXNPYnNlcnZlZCsrOworfQorCitAZW5kCisK K1RFU1QoV0tOYXZpZ2F0aW9uLCBGcmFtZUJhY2tMb2FkaW5nKQoreworICAgIHVzaW5nIG5hbWVz cGFjZSBUZXN0V2ViS2l0QVBJOworICAgIEhUVFBTZXJ2ZXIgc2VydmVyKHsKKyAgICAgICAgeyAi LyIsIHsgIjxpZnJhbWUgc3JjPSdmcmFtZTEuaHRtbCc+PC9pZnJhbWU+IiB9IH0sCisgICAgICAg IHsgIi9mcmFtZTEuaHRtbCIsIHsgIjxhIGhyZWY9J2ZyYW1lMi5odG1sJz5saW5rPC9hPiIgfSB9 LAorICAgICAgICB7ICIvZnJhbWUyLmh0bWwiLCB7ICI8c2NyaXB0PmFsZXJ0KCdmcmFtZTIgbG9h ZGVkJyk8L3NjcmlwdD4iIH0gfSwKKyAgICB9KTsKKyAgICBhdXRvIHdlYlZpZXcgPSBbW1dLV2Vi VmlldyBuZXddIGF1dG9yZWxlYXNlXTsKKyAgICBhdXRvIGRlbGVnYXRlID0gW1tUZXN0VUlEZWxl Z2F0ZSBuZXddIGF1dG9yZWxlYXNlXTsKKyAgICBhdXRvIG9ic2VydmVyID0gW1tMb2FkaW5nT2Jz ZXJ2ZXIgbmV3XSBhdXRvcmVsZWFzZV07CisgICAgd2ViVmlldy5VSURlbGVnYXRlID0gZGVsZWdh dGU7CisgICAgW3dlYlZpZXcgYWRkT2JzZXJ2ZXI6b2JzZXJ2ZXIgZm9yS2V5UGF0aDpAImxvYWRp bmciIG9wdGlvbnM6TlNLZXlWYWx1ZU9ic2VydmluZ09wdGlvbk5ldyBjb250ZXh0Om5pbF07Cisg ICAgRVhQRUNUX0ZBTFNFKHdlYlZpZXcubG9hZGluZyk7CisgICAgRVhQRUNUX0VRKG9ic2VydmVy LmNoYW5nZXNPYnNlcnZlZCwgMHUpOworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnNlcnZlci5y ZXF1ZXN0KCldOworICAgIEVYUEVDVF9UUlVFKHdlYlZpZXcubG9hZGluZyk7CisgICAgRVhQRUNU X0VRKG9ic2VydmVyLmNoYW5nZXNPYnNlcnZlZCwgMXUpOworICAgIHdoaWxlIChvYnNlcnZlci5j aGFuZ2VzT2JzZXJ2ZWQgPCAydSkKKyAgICAgICAgVXRpbDo6c3BpblJ1bkxvb3AoKTsKKyAgICBF WFBFQ1RfRkFMU0Uod2ViVmlldy5sb2FkaW5nKTsKKyAgICBFWFBFQ1RfRVEob2JzZXJ2ZXIuY2hh bmdlc09ic2VydmVkLCAydSk7CisgICAgRVhQRUNUX0ZBTFNFKHdlYlZpZXcuY2FuR29CYWNrKTsK KyAgICBbd2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6QCJkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCdpZnJhbWUnKS5jb250ZW50V2luZG93LmRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2EnKS5jbGlj aygpIiBjb21wbGV0aW9uSGFuZGxlcjpuaWxdOworICAgIEVYUEVDVF9XS19TVFJFUShbZGVsZWdh dGUgd2FpdEZvckFsZXJ0XSwgImZyYW1lMiBsb2FkZWQiKTsKKyAgICBFWFBFQ1RfRVEob2JzZXJ2 ZXIuY2hhbmdlc09ic2VydmVkLCAydSk7CisgICAgRVhQRUNUX1RSVUUod2ViVmlldy5jYW5Hb0Jh Y2spOworICAgIFt3ZWJWaWV3IGdvQmFja107CisgICAgd2hpbGUgKG9ic2VydmVyLmNoYW5nZXNP YnNlcnZlZCA8IDMpCisgICAgICAgIFV0aWw6OnNwaW5SdW5Mb29wKCk7CisgICAgRVhQRUNUX1RS VUUod2ViVmlldy5sb2FkaW5nKTsKKyAgICB3aGlsZSAob2JzZXJ2ZXIuY2hhbmdlc09ic2VydmVk IDwgNCkKKyAgICAgICAgVXRpbDo6c3BpblJ1bkxvb3AoKTsKKyAgICBFWFBFQ1RfRkFMU0Uod2Vi Vmlldy5sb2FkaW5nKTsKKyAgICBbd2ViVmlldyByZW1vdmVPYnNlcnZlcjpvYnNlcnZlciBmb3JL ZXlQYXRoOkAibG9hZGluZyJdOworCit9CisKKyNlbmRpZiAvLyBIQVZFKE5FVFdPUktfRlJBTUVX T1JLKQo=