211445 2020-05-05 07:28:05 -0700 [JSC] JSBigInt::maxLengthBits and JSBigInt::maxLength are wrong 2020-05-05 09:25:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1649178 0 ysuzuki 2020-05-05 07:28:05 -0700 [JSC] JSBigInt::maxLengthBits and JSBigInt::maxLength are wrong 1649179 1 398502 ysuzuki 2020-05-05 07:33:15 -0700 Created attachment 398502 Patch 1649188 2 398502 ticaiolima 2020-05-05 07:41:01 -0700 Comment on attachment 398502 Patch LGTM. I'm wondering if we want to static assert that `maxLengthBits % (sizeof(Digit) * bitsPerByte) == 0`. IIUC, if this is not true, we will have `maxLengthBits` not aligned with `maxLength`. 1649192 3 ysuzuki 2020-05-05 07:47:08 -0700 (In reply to Caio Lima from comment #2) > Comment on attachment 398502 [details] > Patch > > LGTM. I'm wondering if we want to static assert that `maxLengthBits % > (sizeof(Digit) * bitsPerByte) == 0`. IIUC, if this is not true, we will have > `maxLengthBits` not aligned with `maxLength`. Sounds nice. 1649193 4 398505 ysuzuki 2020-05-05 07:49:18 -0700 Created attachment 398505 Patch 1649202 5 398505 mark.lam 2020-05-05 08:24:10 -0700 Comment on attachment 398505 Patch r=me 1649203 6 398505 mark.lam 2020-05-05 08:24:46 -0700 Comment on attachment 398505 Patch Undoing can+ for now to let EWS run. 1649204 7 mark.lam 2020-05-05 08:25:26 -0700 (In reply to Mark Lam from comment #6) > Comment on attachment 398505 [details] > Patch > > Undoing can+ for now to let EWS run. Ah autocorrect: /can+/cq+/ 1649216 8 398505 ysuzuki 2020-05-05 09:00:29 -0700 Comment on attachment 398505 Patch EWS gets green, landing 1649230 9 ews-feeder 2020-05-05 09:24:05 -0700 Committed r261174: <https://trac.webkit.org/changeset/261174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398505. 1649231 10 webkit-bug-importer 2020-05-05 09:25:18 -0700 <rdar://problem/62890572> 398502 2020-05-05 07:33:15 -0700 2020-05-05 07:49:17 -0700 Patch bug-211445-20200505073312.patch text/plain 2233 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 OTQzNGQwOTdkNjNjZDU0NTkzMjc0ZDM5NWFkNWFkOTlhNzdiZTY3Li40MmEwZGUxNzNhZGI1YjQ2 NjNhZjMzZDhkM2IzYWQzYmMyYmZjMGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wNS0wNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEpTQmlnSW50OjptYXhMZW5ndGhCaXRzIGFuZCBKU0JpZ0ludDo6 bWF4TGVuZ3RoIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjExNDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSlNCaWdJbnQ6Om1heExlbmd0aEJpdHMgYW5kIEpTQmlnSW50OjptYXhMZW5n dGggZGVmaW5pdGlvbnMgYXJlIHdyb25nLgorCisgICAgICAgIDEuIFdlIGFyZSBkZWZpbmluZyBt YXhMZW5ndGggYW5kIG1heExlbmd0aEJpdHMgYXMgYW4gdW5yZWxhdGVkIHZhbHVlIHRvIGVhY2gg b3RoZXIuIFRoaXMgaXMgd3JvbmcuCisgICAgICAgICAgIG1heExlbmd0aCBzaG91bGQgYmUgZGVm aW5lZCBhcyBtYXhMZW5ndGhCaXRzIC8gKHNpemVvZihEaWdpdCkgKiBiaXRzUGVyQnl0ZSkuCisg ICAgICAgIDIuIFdlIHVzZSBgc2l6ZW9mKHZvaWQqKWAgYW5kIGFzc3VtZSB0aGF0IGBzaXplb2Yo RGlnaXQpID09IHNpemVvZih2b2lkKilgLiBUaGlzIGlzIHdyb25nIGluIEFSTTY0XzMyIGVudmly b25tZW50CisgICAgICAgICAgIHdoZXJlIERpZ2l0IHNpemUgaXMgc2l6ZW9mKHVpbnQ2NF90KSB3 aGlsZSB0aGUgcG9pbnRlciBzaXplIGlzIHNpemVvZih1aW50MzJfdCkuIFRoaXMgY2F1c2VzIGNv bXBpbGUgZXJyb3JzIGluIEFSTTY0XzMyCisgICAgICAgICAgIHdoZW4gdGhlIGNvZGUgaXMgdXNp bmcgdGhlc2UgdmFsdWVzIHdpdGggc3RhdGljX2Fzc2VydC4KKworICAgICAgICAqIHJ1bnRpbWUv SlNCaWdJbnQuaDoKKwogMjAyMC0wNS0wNSAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBn bWFpbC5jb20+CiAKICAgICAgICAgT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZyBpcyBub3Qgc3Bl Yy1wZXJmZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0Jp Z0ludC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuaAppbmRleCA5 NjZiNTBiOTA0NWZmNmJlYTgwNTI5MWUwYTZhMDFhYTgxMzkwZTdiLi41YTNkNGQyYjgxNGVhNGUz OTA1YzhjYjEyZTVkMTlkNjc0ZjQxZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0JpZ0ludC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQmlnSW50LmgKQEAgLTQ0Miw4ICs0NDIsOCBAQCBjbGFzcyBKU0JpZ0ludCBmaW5hbCA6IHB1 YmxpYyBKU0NlbGwgewogICAgIC8vIG1heEludCAvIGRpZ2l0Qml0cy4gSG93ZXZlciwgd2UgdXNl IGEgbG93ZXIgbGltaXQgZm9yIG5vdywgYmVjYXVzZQogICAgIC8vIHJhaXNpbmcgaXQgbGF0ZXIg aXMgZWFzaWVyIHRoYW4gbG93ZXJpbmcgaXQuCiAgICAgLy8gU3VwcG9ydCB1cCB0byAxIG1pbGxp b24gYml0cy4KLSAgICBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIG1heExlbmd0aCA9IDEwMjQg KiAxMDI0IC8gKHNpemVvZih2b2lkKikgKiBiaXRzUGVyQnl0ZSk7Ci0gICAgc3RhdGljIGNvbnN0 ZXhwciB1bnNpZ25lZCBtYXhMZW5ndGhCaXRzID0gbWF4SW50IC0gc2l6ZW9mKHZvaWQqKSAqIGJp dHNQZXJCeXRlIC0gMTsKKyAgICBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIG1heExlbmd0aEJp dHMgPSAxMDI0ICogMTAyNDsKKyAgICBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIG1heExlbmd0 aCA9IG1heExlbmd0aEJpdHMgLyAoc2l6ZW9mKERpZ2l0KSAqIGJpdHNQZXJCeXRlKTsKICAgICAK ICAgICBzdGF0aWMgdWludDY0X3QgY2FsY3VsYXRlTWF4aW11bUNoYXJhY3RlcnNSZXF1aXJlZCh1 bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIHJhZGl4LCBEaWdpdCBsYXN0RGlnaXQsIGJvb2wgc2ln bik7CiAgICAgCg== 398505 2020-05-05 07:49:18 -0700 2020-05-05 09:24:06 -0700 Patch bug-211445-20200505074915.patch text/plain 2245 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YmRlYTQyMGI3NGUyYzlmYjc0MDA5ZjFhNGRlODYyOTM1YTBjMjcyLi4yMmY4YWFjYmUyMGI1NmI5 OGMwYTkzZGMwYTIzMGUwMjVhYWU5ODllIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wNS0wNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEpTQmlnSW50OjptYXhMZW5ndGhCaXRzIGFuZCBKU0JpZ0ludDo6 bWF4TGVuZ3RoIGFyZSB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjExNDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSlNCaWdJbnQ6Om1heExlbmd0aEJpdHMgYW5kIEpTQmlnSW50OjptYXhMZW5n dGggZGVmaW5pdGlvbnMgYXJlIHdyb25nLgorCisgICAgICAgIDEuIFdlIGFyZSBkZWZpbmluZyBt YXhMZW5ndGggYW5kIG1heExlbmd0aEJpdHMgYXMgYW4gdW5yZWxhdGVkIHZhbHVlIHRvIGVhY2gg b3RoZXIuIFRoaXMgaXMgd3JvbmcuCisgICAgICAgICAgIG1heExlbmd0aCBzaG91bGQgYmUgZGVm aW5lZCBhcyBtYXhMZW5ndGhCaXRzIC8gKHNpemVvZihEaWdpdCkgKiBiaXRzUGVyQnl0ZSkuCisg ICAgICAgIDIuIFdlIHVzZSBgc2l6ZW9mKHZvaWQqKWAgYW5kIGFzc3VtZSB0aGF0IGBzaXplb2Yo RGlnaXQpID09IHNpemVvZih2b2lkKilgLiBUaGlzIGlzIHdyb25nIGluIEFSTTY0XzMyIGVudmly b25tZW50CisgICAgICAgICAgIHdoZXJlIERpZ2l0IHNpemUgaXMgc2l6ZW9mKHVpbnQ2NF90KSB3 aGlsZSB0aGUgcG9pbnRlciBzaXplIGlzIHNpemVvZih1aW50MzJfdCkuIFRoaXMgY2F1c2VzIGNv bXBpbGUgZXJyb3JzIGluIEFSTTY0XzMyCisgICAgICAgICAgIHdoZW4gdGhlIGNvZGUgaXMgdXNp bmcgdGhlc2UgdmFsdWVzIHdpdGggc3RhdGljX2Fzc2VydC4KKworICAgICAgICAqIHJ1bnRpbWUv SlNCaWdJbnQuaDoKKwogMjAyMC0wNS0wNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjYxMTU2LgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQmlnSW50LmgKaW5kZXggN2E0OWQwZmQyYzZjMTlmNDE5NWQ2 OThiYWI0MGQyY2IxYjNjY2YxMi4uZDE0NjZkYzAzZTJiMWE2YzI3ZTQ1Yzg1ZDY4YjhiZjlhYjM4 ZWIzNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0JpZ0ludC5oCkBAIC00MzQs OCArNDM0LDkgQEAgY2xhc3MgSlNCaWdJbnQgZmluYWwgOiBwdWJsaWMgSlNDZWxsIHsKICAgICAv LyBtYXhJbnQgLyBkaWdpdEJpdHMuIEhvd2V2ZXIsIHdlIHVzZSBhIGxvd2VyIGxpbWl0IGZvciBu b3csIGJlY2F1c2UKICAgICAvLyByYWlzaW5nIGl0IGxhdGVyIGlzIGVhc2llciB0aGFuIGxvd2Vy aW5nIGl0LgogICAgIC8vIFN1cHBvcnQgdXAgdG8gMSBtaWxsaW9uIGJpdHMuCi0gICAgc3RhdGlj IGNvbnN0ZXhwciB1bnNpZ25lZCBtYXhMZW5ndGggPSAxMDI0ICogMTAyNCAvIChzaXplb2Yodm9p ZCopICogYml0c1BlckJ5dGUpOwotICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgbWF4TGVu Z3RoQml0cyA9IG1heEludCAtIHNpemVvZih2b2lkKikgKiBiaXRzUGVyQnl0ZSAtIDE7CisgICAg c3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBtYXhMZW5ndGhCaXRzID0gMTAyNCAqIDEwMjQ7Cisg ICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBtYXhMZW5ndGggPSBtYXhMZW5ndGhCaXRzIC8g ZGlnaXRCaXRzOworICAgIHN0YXRpY19hc3NlcnQobWF4TGVuZ3RoQml0cyAlIGRpZ2l0Qml0cyA9 PSAwKTsKICAgICAKICAgICBzdGF0aWMgdWludDY0X3QgY2FsY3VsYXRlTWF4aW11bUNoYXJhY3Rl cnNSZXF1aXJlZCh1bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIHJhZGl4LCBEaWdpdCBsYXN0RGln aXQsIGJvb2wgc2lnbik7CiAgICAgCg==