211427 2020-05-04 20:20:29 -0700 Remove now-unneeded HAVE(SANDBOX_ISSUE_MACH/READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) 2020-07-12 08:02:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214233 InRadar P2 Normal --- 1 darin darin achristensen benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1648918 0 darin 2020-05-04 20:20:29 -0700 Remove now-unneeded HAVE(SANDBOX_ISSUE_MACH/READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) 1648919 1 398464 darin 2020-05-04 20:21:07 -0700 Created attachment 398464 Patch 1648961 2 ews-feeder 2020-05-04 22:47:27 -0700 Committed r261152: <https://trac.webkit.org/changeset/261152> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398464. 1648962 3 webkit-bug-importer 2020-05-04 22:48:16 -0700 <rdar://problem/62875952> 1670855 4 darin 2020-07-12 08:02:28 -0700 This patch was incorrect. There were many instances of HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN) left behind that this accidentally disabled! But no tests that detected this screwup. Will use bug 214233 to fix the problem, and interested in finding a way to add tests as well. 398464 2020-05-04 20:21:07 -0700 2020-05-04 22:47:27 -0700 Patch bug-211427-20200504202106.patch text/plain 5186 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNkNGY0MTMwZTEyNDdjNWMzODZhMDE5 Y2Q1NGU2OWQyMWE3YTMyYzUuLjY2N2IwNDI1ZGJlODMyNDZlZGE2YTAxYWMxZWZlNjQ1ODVhMzJh NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMDQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBub3ctdW5uZWVkZWQgSEFWRShTQU5EQk9YX0lT U1VFX01BQ0gvUkVBRF9FWFRFTlNJT05fVE9fUFJPQ0VTU19CWV9BVURJVF9UT0tFTikKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTQyNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt SGF2ZS5oOiBSZW1vdmUgYm90aCBtYWNyb3MgbWVudGlvbmVkIGluIHRoZSB0aXRsZSBhYm92ZS4K KyAgICAgICAgKiB3dGYvc3BpL2Rhcndpbi9TYW5kYm94U1BJLmg6IFJlbW92ZSAjaWYgSEFWRS4K KwogMjAyMC0wNS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIHVubmVlZGVkIFVTRShNRURJQVJFTU9URSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNjAyMDFmMzhlMzY4 N2U0MjFhODRjNWZlYzBjMThmYzRhNjVlZjYzNy4uYzJhZjA1YTA2ZjRhMjIwYWUyYTcwNDQ2NWVh ZjNhMDhkNjg2N2RkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNS0wNCAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG5vdy11bm5lZWRl ZCBIQVZFKFNBTkRCT1hfSVNTVUVfTUFDSC9SRUFEX0VYVEVOU0lPTl9UT19QUk9DRVNTX0JZX0FV RElUX1RPS0VOKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjExNDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTaGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1tOgorICAgICAgICAoV2Vi S2l0OjpTYW5kYm94RXh0ZW5zaW9uSW1wbDo6c2FuZGJveEV4dGVuc2lvbkZvclR5cGUpOiBSZW1v dmUgI2lmIEhBVkUuCisKIDIwMjAtMDUtMDQgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIE1ha2UgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgY2hlY2tz IGFnYWluc3Qgb2xkIHZlcnNpb25zIGV4cGxpY2l0IGFib3V0IHdhdGNoT1MgYW5kIHR2T1MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93dGYv UGxhdGZvcm1IYXZlLmgKaW5kZXggMGQwZmM5NjAzYzQ3ZWFkMTk3NzkxNjJkNGU1Y2FhOWFkYTdm ZWY3Zi4uOWU5NmViMjNlYzE5ZmY3MzE0OGQyZTlkOGRlOTg0MmRkMmNhMDA5MyAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxh dGZvcm1IYXZlLmgKQEAgLTQ1MCwxNCArNDUwLDYgQEAKICNkZWZpbmUgSEFWRV9DU0NIRUNLRklY RElTQUJMRSAxCiAjZW5kaWYKIAotI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQotI2Rl ZmluZSBIQVZFX1NBTkRCT1hfSVNTVUVfTUFDSF9FWFRFTlNJT05fVE9fUFJPQ0VTU19CWV9BVURJ VF9UT0tFTiAxCi0jZW5kaWYKLQotI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQotI2Rl ZmluZSBIQVZFX1NBTkRCT1hfSVNTVUVfUkVBRF9FWFRFTlNJT05fVE9fUFJPQ0VTU19CWV9BVURJ VF9UT0tFTiAxCi0jZW5kaWYKLQogI2lmIFBMQVRGT1JNKENPQ09BKSAmJiAhKFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMCkgJiYgIVBMQVRG T1JNKFdBVENIT1MpICYmICFQTEFURk9STShBUFBMRVRWKQogI2RlZmluZSBIQVZFX01ETlNfRkFT VF9SRUdJU1RSQVRJT04gMQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9zcGkv ZGFyd2luL1NhbmRib3hTUEkuaCBiL1NvdXJjZS9XVEYvd3RmL3NwaS9kYXJ3aW4vU2FuZGJveFNQ SS5oCmluZGV4IDdiMjA0NDI0N2UwYjY0Yjc4NzU1NDQ0YTAzOGMyYWMyMGU2YjU3ZGYuLmJlM2Nk MjcxMjkwZDlmODJhNTAzOTY0ZDZhYmVhMTI1YzczNmYxOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL3NwaS9kYXJ3aW4vU2FuZGJveFNQSS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3NwaS9k YXJ3aW4vU2FuZGJveFNQSS5oCkBAIC02NCwxMiArNjQsOCBAQCBleHRlcm4gY29uc3QgdWludDMy X3QgU0FOREJPWF9FWFRFTlNJT05fTk9fUkVQT1JUOwogCiBjaGFyICpzYW5kYm94X2V4dGVuc2lv bl9pc3N1ZV9maWxlKGNvbnN0IGNoYXIgKmV4dGVuc2lvbl9jbGFzcywgY29uc3QgY2hhciAqcGF0 aCwgdWludDMyX3QgZmxhZ3MpOwogY2hhciAqc2FuZGJveF9leHRlbnNpb25faXNzdWVfZ2VuZXJp Yyhjb25zdCBjaGFyICpleHRlbnNpb25fY2xhc3MsIHVpbnQzMl90IGZsYWdzKTsKLSNpZiBIQVZF KFNBTkRCT1hfSVNTVUVfUkVBRF9FWFRFTlNJT05fVE9fUFJPQ0VTU19CWV9BVURJVF9UT0tFTikK IGNoYXIgKnNhbmRib3hfZXh0ZW5zaW9uX2lzc3VlX2ZpbGVfdG9fcHJvY2Vzcyhjb25zdCBjaGFy ICpleHRlbnNpb25fY2xhc3MsIGNvbnN0IGNoYXIgKnBhdGgsIHVpbnQzMl90IGZsYWdzLCBhdWRp dF90b2tlbl90KTsKLSNlbmRpZgotI2lmIEhBVkUoU0FOREJPWF9JU1NVRV9NQUNIX0VYVEVOU0lP Tl9UT19QUk9DRVNTX0JZX0FVRElUX1RPS0VOKQogY2hhciAqc2FuZGJveF9leHRlbnNpb25faXNz dWVfbWFjaF90b19wcm9jZXNzKGNvbnN0IGNoYXIgKmV4dGVuc2lvbl9jbGFzcywgY29uc3QgY2hh ciAqbmFtZSwgdWludDMyX3QgZmxhZ3MsIGF1ZGl0X3Rva2VuX3QpOwotI2VuZGlmCiBjaGFyICpz YW5kYm94X2V4dGVuc2lvbl9pc3N1ZV9tYWNoKGNvbnN0IGNoYXIgKmV4dGVuc2lvbl9jbGFzcywg Y29uc3QgY2hhciAqbmFtZSwgdWludDMyX3QgZmxhZ3MpOwogaW50IHNhbmRib3hfY2hlY2socGlk X3QsIGNvbnN0IGNoYXIgKm9wZXJhdGlvbiwgZW51bSBzYW5kYm94X2ZpbHRlcl90eXBlLCAuLi4p OwogaW50IHNhbmRib3hfY2hlY2tfYnlfYXVkaXRfdG9rZW4oYXVkaXRfdG9rZW5fdCwgY29uc3Qg Y2hhciAqb3BlcmF0aW9uLCBlbnVtIHNhbmRib3hfZmlsdGVyX3R5cGUsIC4uLik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9TYW5kYm94RXh0ZW5zaW9uQ29jb2EubW0g Yi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9TYW5kYm94RXh0ZW5zaW9uQ29jb2EubW0KaW5k ZXggZDgzMGJjNmI4NTY4NTg0YWNlYzdmZGNmZTAwODVmMDgwN2FjNWE3YS4uYWJmZjEyMDBmZTgy NDExMGVmMThkODkwZmJjYTJkNGM2YzUxNWY2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9T aGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0NvY29hL1NhbmRib3hFeHRlbnNpb25Db2NvYS5tbQpAQCAtOTgsMTMgKzk4LDcgQEAg cHJpdmF0ZToKICAgICAgICAgY2FzZSBTYW5kYm94RXh0ZW5zaW9uOjpUeXBlOjpNYWNoOgogICAg ICAgICAgICAgaWYgKCFhdWRpdFRva2VuKQogICAgICAgICAgICAgICAgIHJldHVybiBzYW5kYm94 X2V4dGVuc2lvbl9pc3N1ZV9tYWNoKCJjb20uYXBwbGUud2Via2l0LmV4dGVuc2lvbi5tYWNoIl9z LCBwYXRoLCBleHRlbnNpb25GbGFncyk7Ci0jaWYgSEFWRShTQU5EQk9YX0lTU1VFX01BQ0hfRVhU RU5TSU9OX1RPX1BST0NFU1NfQllfQVVESVRfVE9LRU4pCiAgICAgICAgICAgICByZXR1cm4gc2Fu ZGJveF9leHRlbnNpb25faXNzdWVfbWFjaF90b19wcm9jZXNzKCJjb20uYXBwbGUud2Via2l0LmV4 dGVuc2lvbi5tYWNoIl9zLCBwYXRoLCBleHRlbnNpb25GbGFncywgKmF1ZGl0VG9rZW4pOwotI2Vs c2UKLSAgICAgICAgICAgIFVOVVNFRF9QQVJBTShhdWRpdFRva2VuKTsKLSAgICAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0jZW5kaWYK ICAgICAgICAgY2FzZSBTYW5kYm94RXh0ZW5zaW9uOjpUeXBlOjpJT0tpdDoKICAgICAgICAgICAg IGlmICghYXVkaXRUb2tlbikKICAgICAgICAgICAgICAgICByZXR1cm4gc2FuZGJveF9leHRlbnNp b25faXNzdWVfaW9raXRfcmVnaXN0cnlfZW50cnlfY2xhc3MoImNvbS5hcHBsZS53ZWJraXQuZXh0 ZW5zaW9uLmlva2l0Il9zLCBwYXRoLCBleHRlbnNpb25GbGFncyk7CkBAIC0xMTIsMTUgKzEwNiw5 IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgU2FuZGJveEV4dGVuc2lvbjo6VHlwZTo6R2VuZXJp YzoKICAgICAgICAgICAgIHJldHVybiBzYW5kYm94X2V4dGVuc2lvbl9pc3N1ZV9nZW5lcmljKHBh dGgsIGV4dGVuc2lvbkZsYWdzKTsKICAgICAgICAgY2FzZSBTYW5kYm94RXh0ZW5zaW9uOjpUeXBl OjpSZWFkQnlQcm9jZXNzOgotI2lmIEhBVkUoU0FOREJPWF9JU1NVRV9SRUFEX0VYVEVOU0lPTl9U T19QUk9DRVNTX0JZX0FVRElUX1RPS0VOKQogICAgICAgICAgICAgaWYgKCFhdWRpdFRva2VuKQog ICAgICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgICAgICAgICAgcmV0dXJuIHNhbmRi b3hfZXh0ZW5zaW9uX2lzc3VlX2ZpbGVfdG9fcHJvY2VzcyhBUFBfU0FOREJPWF9SRUFELCBwYXRo LCBleHRlbnNpb25GbGFncywgKmF1ZGl0VG9rZW4pOwotI2Vsc2UKLSAgICAgICAgICAgIFVOVVNF RF9QQVJBTShhdWRpdFRva2VuKTsKLSAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwot ICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0jZW5kaWYKICAgICAgICAgfQogICAgIH0KIAo=