211419 2020-05-04 18:24:36 -0700 Relax WKRemoteObjectRegistry signature validation for bool-equivalent types 2020-05-05 00:01:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca mitz saam webkit-bug-importer oldest_to_newest 1648882 0 thorton 2020-05-04 18:24:36 -0700 Relax WKRemoteObjectRegistry signature validation for bool-equivalent types 1648883 1 398450 thorton 2020-05-04 18:25:20 -0700 Created attachment 398450 Patch 1648988 2 ews-feeder 2020-05-04 23:51:47 -0700 Committed r261155: <https://trac.webkit.org/changeset/261155> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398450. 1648989 3 webkit-bug-importer 2020-05-04 23:52:14 -0700 <rdar://problem/62877414> 1648995 4 mitz 2020-05-05 00:01:03 -0700 Why? 398450 2020-05-04 18:25:20 -0700 2020-05-04 23:51:48 -0700 Patch bug-211419-20200504182520.patch text/plain 5637 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1ZWY5YjAzNzRkZGE4NmU0 NTVhMGI1MDlkOTFiZThkYTlmMDZhYWEuLjE1M2E3Y2IxNjQ4ZTk5OTViZjU3YTU1MDcxY2Y0MGY3 MDc0MDJjM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDUtMDQgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVsYXggV0tSZW1vdGVP YmplY3RSZWdpc3RyeSBzaWduYXR1cmUgdmFsaWRhdGlvbiBmb3IgYm9vbC1lcXVpdmFsZW50IHR5 cGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE0 MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNo YXJlZC9BUEkvQ29jb2EvX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkubW06CisgICAgICAgIChibG9j a1NpZ25hdHVyZXNBcmVDb21wYXRpYmxlKToKKyAgICAgICAgKHJlcGx5QmxvY2tTaWduYXR1cmUp OgorICAgICAgICAoLVtfV0tSZW1vdGVPYmplY3RSZWdpc3RyeSBfaW52b2tlTWV0aG9kOl0pOgor ICAgICAgICAodmFsaWRhdGVSZXBseUJsb2NrU2lnbmF0dXJlKTogRGVsZXRlZC4KKyAgICAgICAg UmVsYXggcmVwbHkgYmxvY2sgc2lnbmF0dXJlIHZhbGlkYXRpb24gc2xpZ2h0bHksIGNvbnNpZGVy aW5nIHNpZ25lZCBjaGFyIGFuZCBCT09MLAorICAgICAgICB3aGljaCBhcmUgZXF1aXZhbGVudCBh bmQgc29tZXRpbWVzIHN1YnN0aXR1dGVkIGZvciBlYWNoIG90aGVyLCB0byBiZSBlcXVhbC4KKwor ICAgICAgICBUaGlzIGlzIHN0aWxsIHN0cmljdGVyIHRoYW4gTlNYUEMncyB2YWxpZGF0aW9uLCBi dXQgdGhpcyBpcyBvbmUgb2YgdGhlCisgICAgICAgIGV4Y2VwdGlvbnMgdGhhdCB0aGV5IG1ha2Uu CisKIDIwMjAtMDUtMDEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBQcm9jZXNzVGhyb3R0bGVyIGZhaWxzIHRvIHJlLXRha2UgUHJvY2Vzc0Fzc2VydGlv biBpZiB0aGUgcHJldmlvdXMgb25lIHdhcyBpbnZhbGlkYXRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tCmlu ZGV4IGYwNTFlZTgwOTJkNjI2MzRmYTQwYzIzZjY2NmY5NjdjN2MzMmNjNjUuLjA1ZjQ0ODdlODFj NWUwZGQxOGVmZGQ4Y2ZkY2U5YmRjNGRhZTYxOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RSZWdpc3RyeS5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9BUEkvQ29jb2EvX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkubW0KQEAgLTE4 Nyw3ICsxODcsMzAgQEAgLSAoV2ViS2l0OjpSZW1vdGVPYmplY3RSZWdpc3RyeSYpcmVtb3RlT2Jq ZWN0UmVnaXN0cnkKICAgICByZXR1cm4gKl9yZW1vdGVPYmplY3RSZWdpc3RyeTsKIH0KIAotc3Rh dGljIGJvb2wgdmFsaWRhdGVSZXBseUJsb2NrU2lnbmF0dXJlKE5TTWV0aG9kU2lnbmF0dXJlICp3 aXJlQmxvY2tTaWduYXR1cmUsIFByb3RvY29sICpwcm90b2NvbCwgU0VMIHNlbGVjdG9yLCBOU1VJ bnRlZ2VyIGJsb2NrSW5kZXgpCitzdGF0aWMgYm9vbCBibG9ja1NpZ25hdHVyZXNBcmVDb21wYXRp YmxlKGNvbnN0IFN0cmluZyYgd2lyZSwgY29uc3QgU3RyaW5nJiBsb2NhbCkKK3sKKyAgICBpZiAo bG9jYWwgPT0gd2lyZSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBpZiAobG9jYWwubGVu Z3RoKCkgIT0gd2lyZS5sZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgdW5z aWduZWQgbGVuZ3RoID0gbG9jYWwubGVuZ3RoKCk7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsg aSA8IGxlbmd0aDsgaSsrKSB7CisgICAgICAgIGNoYXIgbG9jYWxUeXBlID0gbG9jYWxbaV07Cisg ICAgICAgIGNoYXIgd2lyZVR5cGUgPSB3aXJlW2ldOworCisgICAgICAgIGlmIChsb2NhbFR5cGUg IT0gd2lyZVR5cGUpIHsKKyAgICAgICAgICAgIC8vIGBib29sYCBhbmQgYHNpZ25lZCBjaGFyYCBh cmUgaW50ZXJjaGFuZ2VhYmxlLgorICAgICAgICAgICAgaWYgKHN0cmNocigiQmMiLCBsb2NhbFR5 cGUpICYmIHN0cmNocigiQmMiLCB3aXJlVHlwZSkpCisgICAgICAgICAgICAgICAgY29udGludWU7 CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKyAgICB9CisgICAgcmV0dXJu IHRydWU7Cit9CisKK3N0YXRpYyBTdHJpbmcgcmVwbHlCbG9ja1NpZ25hdHVyZShQcm90b2NvbCAq cHJvdG9jb2wsIFNFTCBzZWxlY3RvciwgTlNVSW50ZWdlciBibG9ja0luZGV4KQogewogICAgIC8v IFJlcXVpcmVkLCBub24taW5oZXJpdGVkIG1ldGhvZDoKICAgICBjb25zdCBjaGFyKiBtZXRob2RU eXBlRW5jb2RpbmcgPSBfcHJvdG9jb2xfZ2V0TWV0aG9kVHlwZUVuY29kaW5nKHByb3RvY29sLCBz ZWxlY3RvciwgdHJ1ZSwgdHJ1ZSk7CkBAIC0xOTcsMTYgKzIyMCwxNCBAQCBzdGF0aWMgYm9vbCB2 YWxpZGF0ZVJlcGx5QmxvY2tTaWduYXR1cmUoTlNNZXRob2RTaWduYXR1cmUgKndpcmVCbG9ja1Np Z25hdHVyZSwgUAogCiAgICAgQVNTRVJUKG1ldGhvZFR5cGVFbmNvZGluZyk7CiAgICAgaWYgKCFt ZXRob2RUeXBlRW5jb2RpbmcpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgcmV0dXJu IHsgfTsKIAogICAgIE5TTWV0aG9kU2lnbmF0dXJlICp0YXJnZXRNZXRob2RTaWduYXR1cmUgPSBb TlNNZXRob2RTaWduYXR1cmUgc2lnbmF0dXJlV2l0aE9iakNUeXBlczptZXRob2RUeXBlRW5jb2Rp bmddOwogICAgIEFTU0VSVCh0YXJnZXRNZXRob2RTaWduYXR1cmUpOwogICAgIGlmICghdGFyZ2V0 TWV0aG9kU2lnbmF0dXJlKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgTlNNZXRob2RTaWdu YXR1cmUgKmV4cGVjdGVkQmxvY2tTaWduYXR1cmUgPSBbdGFyZ2V0TWV0aG9kU2lnbmF0dXJlIF9z aWduYXR1cmVGb3JCbG9ja0F0QXJndW1lbnRJbmRleDpibG9ja0luZGV4XTsKLSAgICBBU1NFUlQo ZXhwZWN0ZWRCbG9ja1NpZ25hdHVyZSk7CisgICAgICAgIHJldHVybiB7IH07CiAKLSAgICByZXR1 cm4gW3dpcmVCbG9ja1NpZ25hdHVyZSBpc0VxdWFsOmV4cGVjdGVkQmxvY2tTaWduYXR1cmVdOwor ICAgIHJldHVybiBbdGFyZ2V0TWV0aG9kU2lnbmF0dXJlIF9zaWduYXR1cmVGb3JCbG9ja0F0QXJn dW1lbnRJbmRleDpibG9ja0luZGV4XS5fdHlwZVN0cmluZy5VVEY4U3RyaW5nOwogfQogCiAtICh2 b2lkKV9pbnZva2VNZXRob2Q6KGNvbnN0IFdlYktpdDo6UmVtb3RlT2JqZWN0SW52b2NhdGlvbiYp cmVtb3RlT2JqZWN0SW52b2NhdGlvbgpAQCAtMjQzLDEwICsyNjQsMTcgQEAgLSAodm9pZClfaW52 b2tlTWV0aG9kOihjb25zdCBXZWJLaXQ6OlJlbW90ZU9iamVjdEludm9jYXRpb24mKXJlbW90ZU9i amVjdEludm9jYXQKICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgLy8g V2UgZm91bmQgdGhlIGJsb2NrLgotICAgICAgICAgICAgTlNNZXRob2RTaWduYXR1cmUgKndpcmVC bG9ja1NpZ25hdHVyZSA9IFtOU01ldGhvZFNpZ25hdHVyZSBzaWduYXR1cmVXaXRoT2JqQ1R5cGVz OnJlcGx5SW5mby0+YmxvY2tTaWduYXR1cmUudXRmOCgpLmRhdGEoKV07CisgICAgICAgICAgICBT dHJpbmcgd2lyZUJsb2NrU2lnbmF0dXJlID0gW05TTWV0aG9kU2lnbmF0dXJlIHNpZ25hdHVyZVdp dGhPYmpDVHlwZXM6cmVwbHlJbmZvLT5ibG9ja1NpZ25hdHVyZS51dGY4KCkuZGF0YSgpXS5fdHlw ZVN0cmluZy5VVEY4U3RyaW5nOworICAgICAgICAgICAgU3RyaW5nIGV4cGVjdGVkQmxvY2tTaWdu YXR1cmUgPSByZXBseUJsb2NrU2lnbmF0dXJlKFtpbnRlcmZhY2UgcHJvdG9jb2xdLCBpbnZvY2F0 aW9uLnNlbGVjdG9yLCBpKTsKKworICAgICAgICAgICAgaWYgKGV4cGVjdGVkQmxvY2tTaWduYXR1 cmUuaXNOdWxsKCkpIHsKKyAgICAgICAgICAgICAgICBOU0xvZyhAIl9pbnZva2VNZXRob2Q6IEZh aWxlZCB0byB2YWxpZGF0ZSByZXBseSBibG9jayBzaWduYXR1cmU6IGNvdWxkIG5vdCBmaW5kIGxv Y2FsIHNpZ25hdHVyZSIpOworICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwor ICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBp ZiAoIXZhbGlkYXRlUmVwbHlCbG9ja1NpZ25hdHVyZSh3aXJlQmxvY2tTaWduYXR1cmUsIFtpbnRl cmZhY2UgcHJvdG9jb2xdLCBpbnZvY2F0aW9uLnNlbGVjdG9yLCBpKSkgewotICAgICAgICAgICAg ICAgIE5TTG9nKEAiX2ludm9rZU1ldGhvZDogRmFpbGVkIHRvIHZhbGlkYXRlIHJlcGx5IGJsb2Nr IHNpZ25hdHVyZTogJUAiLCB3aXJlQmxvY2tTaWduYXR1cmUuX3R5cGVTdHJpbmcpOworICAgICAg ICAgICAgaWYgKCFibG9ja1NpZ25hdHVyZXNBcmVDb21wYXRpYmxlKHdpcmVCbG9ja1NpZ25hdHVy ZSwgZXhwZWN0ZWRCbG9ja1NpZ25hdHVyZSkpIHsKKyAgICAgICAgICAgICAgICBOU0xvZyhAIl9p bnZva2VNZXRob2Q6IEZhaWxlZCB0byB2YWxpZGF0ZSByZXBseSBibG9jayBzaWduYXR1cmU6ICVz ICE9ICVzIiwgd2lyZUJsb2NrU2lnbmF0dXJlLnV0ZjgoKS5kYXRhKCksIGV4cGVjdGVkQmxvY2tT aWduYXR1cmUudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICB9CkBAIC0yODcs NyArMzE1LDcgQEAgLSAodm9pZClfaW52b2tlTWV0aG9kOihjb25zdCBXZWJLaXQ6OlJlbW90ZU9i amVjdEludm9jYXRpb24mKXJlbW90ZU9iamVjdEludm9jYXQKICAgICAgICAgICAgIH07CiAKICAg ICAgICAgICAgIFJlZlB0cjxSZXBseUJsb2NrQ2FsbENoZWNrZXI+IGNoZWNrZXIgPSBSZXBseUJs b2NrQ2FsbENoZWNrZXI6OmNyZWF0ZShzZWxmLCByZXBseUlEKTsKLSAgICAgICAgICAgIGlkIHJl cGx5QmxvY2sgPSBfX05TTWFrZVNwZWNpYWxGb3J3YXJkaW5nQ2FwdHVyZUJsb2NrKHdpcmVCbG9j a1NpZ25hdHVyZS5fdHlwZVN0cmluZy5VVEY4U3RyaW5nLCBbaW50ZXJmYWNlLCByZW1vdGVPYmpl Y3RSZWdpc3RyeSwgcmVwbHlJRCwgY2hlY2tlcl0oTlNJbnZvY2F0aW9uICppbnZvY2F0aW9uKSB7 CisgICAgICAgICAgICBpZCByZXBseUJsb2NrID0gX19OU01ha2VTcGVjaWFsRm9yd2FyZGluZ0Nh cHR1cmVCbG9jayh3aXJlQmxvY2tTaWduYXR1cmUudXRmOCgpLmRhdGEoKSwgW2ludGVyZmFjZSwg cmVtb3RlT2JqZWN0UmVnaXN0cnksIHJlcGx5SUQsIGNoZWNrZXJdKE5TSW52b2NhdGlvbiAqaW52 b2NhdGlvbikgewogICAgICAgICAgICAgICAgIGF1dG8gZW5jb2RlciA9IGFkb3B0TlMoW1tXS1Jl bW90ZU9iamVjdEVuY29kZXIgYWxsb2NdIGluaXRdKTsKICAgICAgICAgICAgICAgICBbZW5jb2Rl ciBlbmNvZGVPYmplY3Q6aW52b2NhdGlvbiBmb3JLZXk6aW52b2NhdGlvbktleV07CiAK