211412 2020-05-04 16:59:27 -0700 [GTK4] Header bars no longer have title and subtitle properties 2020-05-04 21:42:32 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez aperez bugs-noreply cgarcia oldest_to_newest 1648832 0 aperez 2020-05-04 16:59:27 -0700 There is no longer gtk_header_bar_set_[sub]title() after https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1807 has been merged. The alternative is to use a vertical box with two labels, assigning GTK_STYLE_CLASS_[SUB]TITLE styles to them. 1648840 1 398438 aperez 2020-05-04 17:15:57 -0700 Created attachment 398438 Patch 1648938 2 ews-feeder 2020-05-04 21:42:31 -0700 Committed r261144: <https://trac.webkit.org/changeset/261144> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398438. 398438 2020-05-04 17:15:57 -0700 2020-05-04 21:42:31 -0700 Patch bug-211412-20200505031555.patch text/plain 3675 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0NjJmZGQ3ZDAxM2MzNmVh NzMyZmFmZDEwODA5MDMyYTU4NGZkNTUuLmI5ZGNkYWE3ZjQzNzVhMTAxNTg5YTU3MmFiYzkwYzhm NzFjMWI2NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDUtMDQgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gSGVh ZGVyIGJhcnMgbm8gbG9uZ2VyIGhhdmUgdGl0bGUgYW5kIHN1YnRpdGxlIHByb3BlcnRpZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTQxMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBuZWVkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvSW5zcGVjdG9yL2d0ay9XZWJLaXRJbnNw ZWN0b3JXaW5kb3cuY3BwOiBGb3IgR1RLNCB1c2UgYSB2ZXJ0aWNhbAorICAgICAgICBib3ggYXMg dGl0bGUgd2lkZ2V0LCB3aXRoIHR3byBsYWJlbHMgYWN0aW5nIGFzIHRpdGxlIGFuZCBzdWJ0aXRs ZS4KKyAgICAgICAgKHdlYmtpdF9pbnNwZWN0b3Jfd2luZG93X2luaXQpOgorICAgICAgICAod2Vi a2l0SW5zcGVjdG9yV2luZG93U2V0U3VidGl0bGUpOgorCiAyMDIwLTA1LTA0ICBZdXN1a2UgU3V6 dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgc3BlY3VsYXRp dmUgYnVpbGQgZml4IGZvciByMjYxMDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9JbnNwZWN0b3IvZ3RrL1dlYktpdEluc3BlY3RvcldpbmRvdy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvZ3RrL1dlYktpdEluc3BlY3RvcldpbmRvdy5jcHAKaW5k ZXggZDhiNjkzNmNhYWEwNTY5MTcyMTg5NGMwODUwNjFmMzZhOTI2OWFjMy4uZjAwMjBjZjY2MGMy OWNmNmU1N2NlNzk4ZWQ0YmM3MWUzNTIxMTFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvSW5zcGVjdG9yL2d0ay9XZWJLaXRJbnNwZWN0b3JXaW5kb3cuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9ndGsvV2ViS2l0SW5zcGVjdG9yV2luZG93 LmNwcApAQCAtMzYsNiArMzYsMTAgQEAgc3RydWN0IF9XZWJLaXRJbnNwZWN0b3JXaW5kb3cgewog ICAgIEd0a1dpbmRvdyBwYXJlbnQ7CiAKICAgICBHdGtXaWRnZXQqIGhlYWRlckJhcjsKKworI2lm IFVTRShHVEs0KQorICAgIEd0a1dpZGdldCogc3VidGl0bGVMYWJlbDsKKyNlbmRpZgogfTsKIAog c3RydWN0IF9XZWJLaXRJbnNwZWN0b3JXaW5kb3dDbGFzcyB7CkBAIC01MSwxMiArNTUsMzQgQEAg c3RhdGljIHZvaWQgd2Via2l0X2luc3BlY3Rvcl93aW5kb3dfY2xhc3NfaW5pdChXZWJLaXRJbnNw ZWN0b3JXaW5kb3dDbGFzcyopCiBzdGF0aWMgdm9pZCB3ZWJraXRfaW5zcGVjdG9yX3dpbmRvd19p bml0KFdlYktpdEluc3BlY3RvcldpbmRvdyogd2luZG93KQogewogICAgIHdpbmRvdy0+aGVhZGVy QmFyID0gZ3RrX2hlYWRlcl9iYXJfbmV3KCk7CisKKyNpZiBVU0UoR1RLNCkKKyAgICBHdGtXaWRn ZXQqIGJveCA9IGd0a19ib3hfbmV3KEdUS19PUklFTlRBVElPTl9WRVJUSUNBTCwgMCk7CisgICAg Z3RrX3dpZGdldF9zZXRfdmFsaWduKGJveCwgR1RLX0FMSUdOX0NFTlRFUik7CisKKyAgICBHdGtX aWRnZXQqIHRpdGxlTGFiZWwgPSBndGtfbGFiZWxfbmV3KF8oIldlYiBJbnNwZWN0b3IiKSk7Cisg ICAgZ3RrX3dpZGdldF9zZXRfaGFsaWduKHRpdGxlTGFiZWwsIEdUS19BTElHTl9DRU5URVIpOwor ICAgIGd0a19sYWJlbF9zZXRfc2luZ2xlX2xpbmVfbW9kZShHVEtfTEFCRUwodGl0bGVMYWJlbCks IFRSVUUpOworICAgIGd0a19sYWJlbF9zZXRfZWxsaXBzaXplKEdUS19MQUJFTCh0aXRsZUxhYmVs KSwgUEFOR09fRUxMSVBTSVpFX0VORCk7CisgICAgZ3RrX3dpZGdldF9hZGRfY3NzX2NsYXNzKHRp dGxlTGFiZWwsIEdUS19TVFlMRV9DTEFTU19USVRMRSk7CisgICAgZ3RrX3dpZGdldF9zZXRfcGFy ZW50KHRpdGxlTGFiZWwsIGJveCk7CisKKyAgICB3aW5kb3ctPnN1YnRpdGxlTGFiZWwgPSBndGtf bGFiZWxfbmV3KG51bGxwdHIpOworICAgIGd0a193aWRnZXRfc2V0X2hhbGlnbih3aW5kb3ctPnN1 YnRpdGxlTGFiZWwsIEdUS19BTElHTl9DRU5URVIpOworICAgIGd0a19sYWJlbF9zZXRfc2luZ2xl X2xpbmVfbW9kZShHVEtfTEFCRUwod2luZG93LT5zdWJ0aXRsZUxhYmVsKSwgVFJVRSk7CisgICAg Z3RrX2xhYmVsX3NldF9lbGxpcHNpemUoR1RLX0xBQkVMKHdpbmRvdy0+c3VidGl0bGVMYWJlbCks IFBBTkdPX0VMTElQU0laRV9FTkQpOworICAgIGd0a193aWRnZXRfYWRkX2Nzc19jbGFzcyh3aW5k b3ctPnN1YnRpdGxlTGFiZWwsIEdUS19TVFlMRV9DTEFTU19TVUJUSVRMRSk7CisgICAgZ3RrX3dp ZGdldF9zZXRfcGFyZW50KHdpbmRvdy0+c3VidGl0bGVMYWJlbCwgYm94KTsKKyAgICBndGtfd2lk Z2V0X2hpZGUod2luZG93LT5zdWJ0aXRsZUxhYmVsKTsKKworICAgIGd0a19oZWFkZXJfYmFyX3Nl dF90aXRsZV93aWRnZXQoR1RLX0hFQURFUl9CQVIod2luZG93LT5oZWFkZXJCYXIpLCBib3gpOwor I2Vsc2UKICAgICBndGtfaGVhZGVyX2Jhcl9zZXRfdGl0bGUoR1RLX0hFQURFUl9CQVIod2luZG93 LT5oZWFkZXJCYXIpLCBfKCJXZWIgSW5zcGVjdG9yIikpOwotI2lmICFVU0UoR1RLNCkKICAgICBn dGtfaGVhZGVyX2Jhcl9zZXRfc2hvd19jbG9zZV9idXR0b24oR1RLX0hFQURFUl9CQVIod2luZG93 LT5oZWFkZXJCYXIpLCBUUlVFKTsKLSNlbmRpZgotICAgIGd0a193aW5kb3dfc2V0X3RpdGxlYmFy KEdUS19XSU5ET1cod2luZG93KSwgd2luZG93LT5oZWFkZXJCYXIpOwogICAgIGd0a193aWRnZXRf c2hvdyh3aW5kb3ctPmhlYWRlckJhcik7CisjZW5kaWYgLy8gVVNFKEdUSzQpCisKKyAgICBndGtf d2luZG93X3NldF90aXRsZWJhcihHVEtfV0lORE9XKHdpbmRvdyksIHdpbmRvdy0+aGVhZGVyQmFy KTsKIH0KIAogR3RrV2lkZ2V0KiB3ZWJraXRJbnNwZWN0b3JXaW5kb3dOZXcoKQpAQCAtNzIsNSAr OTgsMTMgQEAgdm9pZCB3ZWJraXRJbnNwZWN0b3JXaW5kb3dTZXRTdWJ0aXRsZShXZWJLaXRJbnNw ZWN0b3JXaW5kb3cqIHdpbmRvdywgY29uc3QgY2hhcioKIHsKICAgICBnX3JldHVybl9pZl9mYWls KFdFQktJVF9JU19JTlNQRUNUT1JfV0lORE9XKHdpbmRvdykpOwogCisjaWYgVVNFKEdUSzQpCisg ICAgaWYgKHN1YnRpdGxlKSB7CisgICAgICAgIGd0a19sYWJlbF9zZXRfdGV4dChHVEtfTEFCRUwo d2luZG93LT5zdWJ0aXRsZUxhYmVsKSwgc3VidGl0bGUpOworICAgICAgICBndGtfd2lkZ2V0X3No b3cod2luZG93LT5zdWJ0aXRsZUxhYmVsKTsKKyAgICB9IGVsc2UKKyAgICAgICAgZ3RrX3dpZGdl dF9oaWRlKHdpbmRvdy0+c3VidGl0bGVMYWJlbCk7CisjZWxzZQogICAgIGd0a19oZWFkZXJfYmFy X3NldF9zdWJ0aXRsZShHVEtfSEVBREVSX0JBUih3aW5kb3ctPmhlYWRlckJhciksIHN1YnRpdGxl KTsKKyNlbmRpZiAvLyBVU0UoR1RLNCkKIH0K