21141 2008-09-26 05:27:02 -0700 REGRESSION: Exception messages for user entered commands are poor 2008-10-12 18:23:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver oliver ap ggaren mjs oliver timothy zwarich oldest_to_newest 92913 0 oliver 2008-09-26 05:27:02 -0700 Error messages in the console have very low fidelity, eg, typing the following in the terminal: proeprtyThatDoesn'tExist; results in the message "Error" 92942 1 timothy 2008-09-26 10:09:22 -0700 This is a regression in JavaScriptCore I think. Since the Inspector is getting false for: exceptionObj instanceof win.Error Where exceptionObj is a JSQuarantinedObjectWrapper around an Error object. When not using JSQuarantinedObjectWrappers this works. 92988 2 ggaren 2008-09-26 15:49:53 -0700 Probably a result of Maciej's recent instanceof optimization work. I don't think we properly honor objects that override hasInstance(). 92989 3 ggaren 2008-09-26 15:50:30 -0700 I believe you could work around this regression by checking exceptionObj.constructor == win.Error, if you'd like. 93114 4 timothy 2008-09-27 19:05:25 -0700 This also broke printing of Arrays, and other objects. 93127 5 23890 oliver 2008-09-28 00:46:36 -0700 Created attachment 23890 Fix ye olde instanceof 93133 6 23890 mjs 2008-09-28 01:25:53 -0700 Comment on attachment 23890 Fix ye olde instanceof r=me 95130 7 darin 2008-10-12 18:23:20 -0700 http://trac.webkit.org/changeset/37034 23890 2008-09-28 00:46:36 -0700 2008-09-28 01:25:53 -0700 Fix ye olde instanceof fix-inspector-instanceof.patch text/plain 2146 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzIyZWJhMi4uNmRlODY3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOC0wOS0yOCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEJ1ZyAyMTE0MTogUkVHUkVTU0lPTjogRXhjZXB0aW9uIG1lc3NhZ2VzIGZv ciB1c2VyIGVudGVyZWQgY29tbWFuZHMgYXJlIHBvb3IKKyAgICAgICAgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTE0MT4KKworICAgICAgICBUaGUgYnVnIHJlcHNv bnNpYmxlIGZvciB0aGlzIHdhcyB0aGUgdGhlIEpTSW5zcGVjdGVkT2JqZWN0V3JhcHBlciBpbnN0 YW5jZXMKKyAgICAgICAgd2VyZSBub3QgaW5pdGlhbGlzaW5nIHRoZWlyIFN0cnVjdHVyZUlEJ3Mg dG8gaW5kaWNhdGUgdGhhdCB0aGUgd3JhcHBlcgorICAgICAgICBvdmVycmlkZXMgaGFzSW5zdGFu Y2UsIGV0Yy4gIFRoZSBzb2x1dGlvbiBpcyBzaW1wbHkgdG8gdXNlIHRoZSBjcmVhdGVTdHJ1Y3R1 cmVJRAorICAgICAgICBoZWxwZXIgb24gSlNRdWFyYW50aW5lZE9iamVjdFdyYXBwZXIgdG8gY3Jl YXRlIGEgY29ycmVjdCBTdHJ1Y3R1cmVJRC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSW5z cGVjdGVkT2JqZWN0V3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0luc3BlY3RlZE9i amVjdFdyYXBwZXI6OndyYXApOgorCiAyMDA4LTA5LTI3ICBFcmljIENhcmxzb24gIDxlcmljLmNh cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVjdGVkT2JqZWN0V3JhcHBlci5jcHAg Yi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5zcGVjdGVkT2JqZWN0V3JhcHBlci5jcHAKaW5kZXgg NDdhMzdkMi4uMjVmOWQ5NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luc3Bl Y3RlZE9iamVjdFdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0 ZWRPYmplY3RXcmFwcGVyLmNwcApAQCAtNjMsOCArNjMsOCBAQCBKU1ZhbHVlKiBKU0luc3BlY3Rl ZE9iamVjdFdyYXBwZXI6OndyYXAoRXhlY1N0YXRlKiB1bndyYXBwZWRFeGVjLCBKU1ZhbHVlKiB1 bndyYQogICAgIEFTU0VSVChwcm90b3R5cGUtPmlzTnVsbCgpIHx8IHByb3RvdHlwZS0+aXNPYmpl Y3QoKSk7CiAKICAgICBpZiAocHJvdG90eXBlLT5pc051bGwoKSkKLSAgICAgICAgcmV0dXJuIG5l dyAodW53cmFwcGVkRXhlYykgSlNJbnNwZWN0ZWRPYmplY3RXcmFwcGVyKHVud3JhcHBlZEV4ZWMs IHVud3JhcHBlZE9iamVjdCwgdW53cmFwcGVkRXhlYy0+Z2xvYmFsRGF0YSgpLm51bGxQcm90b1N0 cnVjdHVyZUlEKTsKLSAgICByZXR1cm4gbmV3ICh1bndyYXBwZWRFeGVjKSBKU0luc3BlY3RlZE9i amVjdFdyYXBwZXIodW53cmFwcGVkRXhlYywgdW53cmFwcGVkT2JqZWN0LCBzdGF0aWNfY2FzdDxK U09iamVjdCo+KHdyYXAodW53cmFwcGVkRXhlYywgcHJvdG90eXBlKSktPmluaGVyaXRvcklEKCkp OworICAgICAgICByZXR1cm4gbmV3ICh1bndyYXBwZWRFeGVjKSBKU0luc3BlY3RlZE9iamVjdFdy YXBwZXIodW53cmFwcGVkRXhlYywgdW53cmFwcGVkT2JqZWN0LCBKU1F1YXJhbnRpbmVkT2JqZWN0 V3JhcHBlcjo6Y3JlYXRlU3RydWN0dXJlSUQoanNOdWxsKCkpKTsKKyAgICByZXR1cm4gbmV3ICh1 bndyYXBwZWRFeGVjKSBKU0luc3BlY3RlZE9iamVjdFdyYXBwZXIodW53cmFwcGVkRXhlYywgdW53 cmFwcGVkT2JqZWN0LCBKU1F1YXJhbnRpbmVkT2JqZWN0V3JhcHBlcjo6Y3JlYXRlU3RydWN0dXJl SUQoc3RhdGljX2Nhc3Q8SlNPYmplY3QqPih3cmFwKHVud3JhcHBlZEV4ZWMsIHByb3RvdHlwZSkp KSk7CiB9CiAKIEpTSW5zcGVjdGVkT2JqZWN0V3JhcHBlcjo6SlNJbnNwZWN0ZWRPYmplY3RXcmFw cGVyKEV4ZWNTdGF0ZSogdW53cmFwcGVkRXhlYywgSlNPYmplY3QqIHVud3JhcHBlZE9iamVjdCwg UGFzc1JlZlB0cjxTdHJ1Y3R1cmVJRD4gc3RydWN0dXJlSUQpCg==