211406 2020-05-04 15:08:16 -0700 block-spammers tool should hide attachments 2020-05-19 10:24:30 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap darin ddkilzer webkit-bug-importer oldest_to_newest 1648764 0 ap 2020-05-04 15:08:16 -0700 Unclear why spammers add attachments, yet they do. Bugzilla can delete attachments, but there is no API for that, and the manual process takes two form submissions, which is particularly fragile to automate. I guess hiding is good enough. 1648770 1 398424 ap 2020-05-04 15:11:19 -0700 Created attachment 398424 proposed patch 1648792 2 darin 2020-05-04 15:55:26 -0700 Sounds good to me. 1648837 3 ews-feeder 2020-05-04 17:09:08 -0700 Committed r261128: <https://trac.webkit.org/changeset/261128> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398424. 1648838 4 webkit-bug-importer 2020-05-04 17:10:16 -0700 <rdar://problem/62868426> 1648854 5 darin 2020-05-04 17:33:04 -0700 I used block-spammers this weekend. I wonder who else is using it besides you and me, Alexey. 1648866 6 ap 2020-05-04 17:46:51 -0700 Unsure. Maybe Dave Kilzer sometimes? It saves time for me, and improves accuracy. 1648910 7 darin 2020-05-04 19:58:19 -0700 Yes, I like it! 1654056 8 ddkilzer 2020-05-19 10:24:30 -0700 (In reply to Alexey Proskuryakov from comment #6) > Unsure. Maybe Dave Kilzer sometimes? It saves time for me, and improves > accuracy. I've never used it, but I'll try to remember to use it the next time I see spam. 398424 2020-05-04 15:11:19 -0700 2020-05-04 17:09:08 -0700 proposed patch DeleteAttachments.txt text/plain 6189 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MTExNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDIwLTA1LTA0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJsb2NrLXNwYW1tZXJzIHRvb2wgc2hvdWxkIGhpZGUgYXR0YWNobWVudHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTQwNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBsb2dp YyBpcyBuZWFybHkgaWRlbnRpY2FsIHRvIGhpZGluZyBjb21tZW50cy4gSnVzdCBuZWVkIHRvIGxp bWl0IGZpZWxkcyBpbiB0aGUKKyAgICAgICAgc2VhcmNoLCBzbyB0aGF0IHdlIGRvbid0IGhhdmUg dG8gZG93bmxvYWQgYXR0YWNobWVudCBkYXRhLgorCisgICAgICAgICogU2NyaXB0cy9ibG9jay1z cGFtbWVyczoKKyAgICAgICAgKGdldF9jb21tZW50cyk6CisgICAgICAgIChnZXRfYnVnc193aXRo X2F0dGFjaG1lbnRzX2NyZWF0ZWRfYnlfdXNlcik6CisgICAgICAgIChnZXRfYXR0YWNobWVudHMp OgorICAgICAgICAoaGlkZV9jb21tZW50cyk6CisgICAgICAgIChoaWRlX2F0dGFjaG1lbnRzKToK KyAgICAgICAgKG1haW4pOgorCiAyMDIwLTA1LTA0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5uZWVkZWQgVVNFKE1FRElBUkVNT1RFKQpJbmRleDog VG9vbHMvU2NyaXB0cy9ibG9jay1zcGFtbWVycwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L2Jsb2NrLXNwYW1tZXJzCShyZXZpc2lvbiAyNjA4NTkpCisrKyBUb29scy9TY3JpcHRzL2Jsb2Nr LXNwYW1tZXJzCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsNiArMTAyLDE5IEBAIGRlZiBnZXRfY29t bWVudHMoYnVnX2lkKToKICAgICByZXR1cm4gcmVzcG9uc2UuanNvbigpWydidWdzJ11bc3RyKGJ1 Z19pZCldWyJjb21tZW50cyJdCiAKIAorZGVmIGdldF9idWdzX3dpdGhfYXR0YWNobWVudHNfY3Jl YXRlZF9ieV91c2VyKGlkKToKKyAgICByZXNwb25zZSA9IHJlcXVlc3RzLmdldCgnaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvcmVzdC9idWcnLAorICAgICAgICBwYXJhbXM9eydwcm9kdWN0JzogWydX ZWJLaXQnLCAnU2VjdXJpdHknXSwgJ2YxJzogJ2F0dGFjaG1lbnRzLnN1Ym1pdHRlcicsICdvMSc6 ICdlcXVhbHMnLCAndjEnOiBpZCwKKyAgICAgICAgICAgICAgICAnaW5jbHVkZV9maWVsZHMnOiAn aWQsc3VtbWFyeSxwcm9kdWN0JywgJ3Rva2VuJzogYnVnemlsbGFfdG9rZW59KQorICAgIHJldHVy biByZXNwb25zZS5qc29uKClbJ2J1Z3MnXQorCisKK2RlZiBnZXRfYXR0YWNobWVudHMoYnVnX2lk KToKKyAgICByZXNwb25zZSA9IHJlcXVlc3RzLmdldCgnaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv cmVzdC9idWcvJyArIHN0cihidWdfaWQpICsgJy9hdHRhY2htZW50JywKKyAgICAgICAgcGFyYW1z PXsnaW5jbHVkZV9maWVsZHMnOiAnaWQsYnVnX2lkLGNyZWF0b3IsY3JlYXRpb25fdGltZSxzdW1t YXJ5LGlzX3ByaXZhdGUnLCAndG9rZW4nOiBidWd6aWxsYV90b2tlbn0pCisgICAgcmV0dXJuIHJl c3BvbnNlLmpzb24oKVsnYnVncyddW3N0cihidWdfaWQpXQorCisKIGRlZiBoaWRlX2J1ZyhidWdf aWQpOgogICAgIHJlc3BvbnNlID0gcmVxdWVzdHMucHV0KCdodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9yZXN0L2J1Zy8nICsgc3RyKGJ1Z19pZCksCiAgICAgICAgIGpzb249eydwcm9kdWN0JzogJ1Nw YW0nLCAnY29tcG9uZW50JzogJ1NwYW0nLCAndmVyc2lvbic6ICd1bnNwZWNpZmllZCcsICdpc19j cmVhdG9yX2FjY2Vzc2libGUnOiBGYWxzZSwgJ2lzX2NjX2FjY2Vzc2libGUnOiBGYWxzZX0sCkBA IC0xMTUsNyArMTI4LDcgQEAgZGVmIGhpZGVfY29tbWVudHMoYnVnX2lkLCBjb21tZW50X2lkcyk6 CiAgICAgICAgIGpzb249eydjb21tZW50X2lzX3ByaXZhdGUnOiB7c3RyKGlkKTogVHJ1ZSBmb3Ig aWQgaW4gY29tbWVudF9pZHN9fSwKICAgICAgICAgcGFyYW1zPXsndG9rZW4nOiBidWd6aWxsYV90 b2tlbn0pCiAgICAgaWYgbm90IHJlc3BvbnNlOgotICAgICAgICBwcmludCAnISEhIEZhaWxlZCB0 byBoaWRlIGNvbW1lbnRzIGZvciBidWcnICsgc3RyKGJ1Z19pZCkgKyAnOiAnICsgcmVzcG9uc2Uu dGV4dAorICAgICAgICBwcmludCAnISEhIEZhaWxlZCB0byBoaWRlIGNvbW1lbnRzIGZvciBidWcg JyArIHN0cihidWdfaWQpICsgJzogJyArIHJlc3BvbnNlLnRleHQKICAgICBmb3IgY29tbWVudF9p ZCBpbiBjb21tZW50X2lkczoKICAgICAgICAgcmVzcG9uc2UgPSByZXF1ZXN0cy5wdXQoJ2h0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Jlc3QvYnVnL2NvbW1lbnQvJyArIHN0cihjb21tZW50X2lkKSAr ICcvdGFncycsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGpzb249eydjb21tZW50 X2lkJzogY29tbWVudF9pZCwgJ2FkZCc6IFsnc3BhbSddfSwKQEAgLTEyMyw2ICsxMzYsMTMgQEAg ZGVmIGhpZGVfY29tbWVudHMoYnVnX2lkLCBjb21tZW50X2lkcyk6CiAgICAgICAgIGlmIG5vdCBy ZXNwb25zZToKICAgICAgICAgICAgIHByaW50ICchISEgRmFpbGVkIHRvIG1hcmsgY29tbWVudCB3 aXRoIHNwYW0gdGFnOiAnICsgcmVzcG9uc2UudGV4dAogCitkZWYgaGlkZV9hdHRhY2htZW50cyhi dWdfaWQsIGF0dGFjaG1lbnRfaWRzKToKKyAgICByZXNwb25zZSA9IHJlcXVlc3RzLnB1dCgnaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvcmVzdC9idWcvYXR0YWNobWVudC8xJywKKyAgICAgICAganNv bj17J2lkcyc6IGF0dGFjaG1lbnRfaWRzLCAnaXNfcHJpdmF0ZSc6IFRydWV9LAorICAgICAgICBw YXJhbXM9eyd0b2tlbic6IGJ1Z3ppbGxhX3Rva2VufSkKKyAgICBpZiBub3QgcmVzcG9uc2U6Cisg ICAgICAgIHByaW50ICchISEgRmFpbGVkIHRvIGhpZGUgYXR0YWNobWVudHMgZm9yIGJ1ZyAnICsg c3RyKGJ1Z19pZCkgKyAnOiAnICsgcmVzcG9uc2UudGV4dAorCiAKIGRlZiBhc2tfeWVzX25vKHF1 ZXN0aW9uLCBkZWZhdWx0PSd5ZXMnKToKICAgICBpZiBkZWZhdWx0IGlzIE5vbmU6CkBAIC0xNjcs NiArMTg3LDkgQEAgZGVmIG1haW4oKToKICAgICAgICAgdXNlcl9pbmZvWydidWdzX2NvbW1lbnRl ZCddID0gW3ggZm9yIHggaW4gZ2V0X2J1Z3NfY29tbWVudGVkX29uX2J5X3VzZXIoYWNjb3VudF9p ZCkgaWYgeFsnaWQnXSBub3QgaW4gY3JlYXRlZF9idWdfaWRzXQogICAgICAgICBmb3IgYnVnIGlu IHVzZXJfaW5mb1snYnVnc19jb21tZW50ZWQnXToKICAgICAgICAgICAgIGJ1Z1snY29tbWVudHMn XSA9IGdldF9jb21tZW50cyhidWdbJ2lkJ10pCisgICAgICAgIHVzZXJfaW5mb1snYnVnc193aXRo X2F0dGFjaG1lbnRzX2FkZGVkJ10gPSBbeCBmb3IgeCBpbiBnZXRfYnVnc193aXRoX2F0dGFjaG1l bnRzX2NyZWF0ZWRfYnlfdXNlcihhY2NvdW50X2lkKSBpZiB4WydpZCddIG5vdCBpbiBjcmVhdGVk X2J1Z19pZHNdCisgICAgICAgIGZvciBidWcgaW4gdXNlcl9pbmZvWydidWdzX3dpdGhfYXR0YWNo bWVudHNfYWRkZWQnXToKKyAgICAgICAgICAgIGJ1Z1snYXR0YWNobWVudHMnXSA9IGdldF9hdHRh Y2htZW50cyhidWdbJ2lkJ10pCiAKICAgICBmb3IgdXNlciBpbiB1c2Vyc190b19kaXNhYmxlOgog ICAgICAgICBwcmludCBzYW5pdGl6ZWRfc3RyaW5nKHVzZXJbJ3JlYWxfbmFtZSddKSArICcgPCcg KyB1c2VyWyduYW1lJ10gKyAnPicKQEAgLTE4Myw2ICsyMDYsMTMgQEAgZGVmIG1haW4oKToKICAg ICAgICAgICAgIGZvciBjb21tZW50IGluIGJ1Z1snY29tbWVudHMnXToKICAgICAgICAgICAgICAg ICBpZiBjb21tZW50WydjcmVhdG9yJ10gPT0gdXNlclsnbmFtZSddOgogICAgICAgICAgICAgICAg ICAgICBwcmludCAnQ29tbWVudCAnICsgc3RyKGNvbW1lbnRbJ2NvdW50J10pICsgJywgJyArIHN0 cihwYXJzZShjb21tZW50WydjcmVhdGlvbl90aW1lJ10pKSArICc6ICcgKyBzYW5pdGl6ZWRfc3Ry aW5nKGNvbW1lbnRbJ3RleHQnXSkKKyAgICAgICAgaWYgdXNlclsnYnVnc193aXRoX2F0dGFjaG1l bnRzX2FkZGVkJ106CisgICAgICAgICAgICBwcmludCAnQWRkZWQgYXR0YWNobWVudHMgdG8gJyAr IHN0cihsZW4odXNlclsnYnVnc193aXRoX2F0dGFjaG1lbnRzX2FkZGVkJ10pKSArICcgYnVnKHMp OicKKyAgICAgICAgZm9yIGJ1ZyBpbiB1c2VyWydidWdzX3dpdGhfYXR0YWNobWVudHNfYWRkZWQn XToKKyAgICAgICAgICAgIHByaW50ICdodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9JyArIHN0cihidWdbJ2lkJ10pICsgJyAnICsgc2FuaXRpemVkX3N0cmluZyhidWdbJ3N1 bW1hcnknXSkKKyAgICAgICAgICAgIGZvciBhdHRhY2htZW50IGluIGJ1Z1snYXR0YWNobWVudHMn XToKKyAgICAgICAgICAgICAgICBpZiBhdHRhY2htZW50WydjcmVhdG9yJ10gPT0gdXNlclsnbmFt ZSddOgorICAgICAgICAgICAgICAgICAgICBwcmludCAnQXR0YWNobWVudCAnICsgc3RyKGF0dGFj aG1lbnRbJ2lkJ10pICsgJywgJyArIHN0cihwYXJzZShhdHRhY2htZW50WydjcmVhdGlvbl90aW1l J10pKSArICc6ICcgKyBzYW5pdGl6ZWRfc3RyaW5nKGF0dGFjaG1lbnRbJ3N1bW1hcnknXSkKICAg ICAgICAgcHJpbnQKIAogICAgIGlmIG5vdCBhc2tfeWVzX25vKCJCbG9jayBhbGwgdGhlc2UgYWNj b3VudHMsIGFuZCBoaWRlIHRoZWlyIGJ1Z3MgYW5kIGNvbW1lbnRzPyIpOgpAQCAtMjA0LDYgKzIz NCw3IEBAIGRlZiBtYWluKCk6CiAgICAgICAgICAgICAgICAgY29udGludWUKICAgICAgICAgICAg IHByaW50ICdNb3ZpbmcgYnVnICcgKyBzdHIoYnVnWydpZCddKSArICcgdG8gdGhlIFNwYW0gcHJv ZHVjdCcKICAgICAgICAgICAgIGhpZGVfYnVnKGJ1Z1snaWQnXSkKKwogICAgICAgICBmb3IgYnVn IGluIHVzZXJbJ2J1Z3NfY29tbWVudGVkJ106CiAgICAgICAgICAgICBjb21tZW50c190b19oaWRl ID0gW10KICAgICAgICAgICAgIGZvciBjb21tZW50IGluIGJ1Z1snY29tbWVudHMnXToKQEAgLTIx OCw2ICsyNDksMjAgQEAgZGVmIG1haW4oKToKICAgICAgICAgICAgICAgICBwcmludCAnSGlkaW5n IGNvbW1lbnQocykgZnJvbSB1c2VyICcgKyBzdHIodXNlclsnbmFtZSddKSArICcgb24gYnVnICcg KyBzdHIoYnVnWydpZCddKQogICAgICAgICAgICAgaGlkZV9jb21tZW50cyhidWdbJ2lkJ10sIGNv bW1lbnRzX3RvX2hpZGUpCiAKKyAgICAgICAgZm9yIGJ1ZyBpbiB1c2VyWydidWdzX3dpdGhfYXR0 YWNobWVudHNfYWRkZWQnXToKKyAgICAgICAgICAgIGF0dGFjaG1lbnRzX3RvX2hpZGUgPSBbXQor ICAgICAgICAgICAgZm9yIGF0dGFjaG1lbnQgaW4gYnVnWydhdHRhY2htZW50cyddOgorICAgICAg ICAgICAgICAgIGlmIGF0dGFjaG1lbnRbJ2NyZWF0b3InXSAhPSB1c2VyWyduYW1lJ106CisgICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICAgICAgaWYgYXR0YWNobWVudFsn aXNfcHJpdmF0ZSddOgorICAgICAgICAgICAgICAgICAgICBwcmludCAnQXR0YWNobWVudCAnICsg c3RyKGF0dGFjaG1lbnRbJ2lkJ10pICsgJyBvbiBidWcgJyArIHN0cihidWdbJ2lkJ10pICsgJyBp cyBhbHJlYWR5IHByaXZhdGUsIHNraXBwaW5nJworICAgICAgICAgICAgICAgICAgICBjb250aW51 ZQorICAgICAgICAgICAgICAgIGFzc2VydChhdHRhY2htZW50WydidWdfaWQnXSA9PSBidWdbJ2lk J10pCisgICAgICAgICAgICAgICAgYXR0YWNobWVudHNfdG9faGlkZS5hcHBlbmQoYXR0YWNobWVu dFsnaWQnXSkKKyAgICAgICAgICAgIGlmIGF0dGFjaG1lbnRzX3RvX2hpZGU6CisgICAgICAgICAg ICAgICAgcHJpbnQgJ0RlbGV0aW5nIGF0dGFjaG1lbnQocykgZnJvbSB1c2VyICcgKyBzdHIodXNl clsnbmFtZSddKSArICcgb24gYnVnICcgKyBzdHIoYnVnWydpZCddKQorICAgICAgICAgICAgaGlk ZV9hdHRhY2htZW50cyhidWdbJ2lkJ10sIGF0dGFjaG1lbnRzX3RvX2hpZGUpCisKIAogaWYgX19u YW1lX18gPT0gIl9fbWFpbl9fIjoKICAgICBtYWluKCkK