211398 2020-05-04 14:02:01 -0700 Google Maps rendering corruption in simulator with ANGLE 2020-05-07 11:48:27 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jdarpinian jdarpinian achristensen ap dino ews-watchlist graouts justin_fan kondapallykalyan simon.fraser webkit-bug-importer oldest_to_newest 1648721 0 jdarpinian 2020-05-04 14:02:01 -0700 Google Maps rendering corruption in simulator with ANGLE 1648729 1 398412 jdarpinian 2020-05-04 14:10:53 -0700 Created attachment 398412 Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. 1648730 2 ews-watchlist 2020-05-04 14:11:39 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1650246 3 398412 achristensen 2020-05-07 11:38:48 -0700 Comment on attachment 398412 Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. View in context: https://bugs.webkit.org/attachment.cgi?id=398412&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:86 > + mRowStrideInPixels(0), Don't you use initializer lists in the header in ANGLE? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:98 > + // Hopefully the number of bytes per row is always an integer number of pixels. I'd put a blank line above this, but that can also be done upstream. 1650248 4 ews-feeder 2020-05-07 11:42:25 -0700 Committed r261322: <https://trac.webkit.org/changeset/261322> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398412. 1650249 5 webkit-bug-importer 2020-05-07 11:43:15 -0700 <rdar://problem/62986285> 398412 2020-05-04 14:10:53 -0700 2020-05-07 11:42:25 -0700 Fix Google Maps rendering corruption in simulator. Respect IOSurface row stride. bug-211398-20200504141053.patch text/plain 3760 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwNzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNGQzNWVlODExYjJmYzY3MzliOTNjOTZmODViY2Q4MmRmNDcxMTMwZi4uOTg4YzAxZjUxMzQy NDI2NWI0M2I2ZmJiZGU5NzRmMTk0YmNlZjUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTA0ICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGlu aWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggR29vZ2xlIE1hcHMgcmVuZGVyaW5nIGNv cnJ1cHRpb24gaW4gc2ltdWxhdG9yIHdpdGggQU5HTEUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTM5OAorCisgICAgICAgIGdsUmVhZFBpeGVscyBj YWxsIG5lZWRzIHRvIHJlc3BlY3QgdGhlIHJvdyBzdHJpZGUgb2YgdGhlIElPU3VyZmFjZS4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9saWJB TkdMRS9yZW5kZXJlci9nbC9lYWdsL0lPU3VyZmFjZVN1cmZhY2VFQUdMLmg6CisgICAgICAgICog c3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL2VhZ2wvSU9TdXJmYWNlU3VyZmFjZUVBR0wubW06Cisg ICAgICAgIChyeDo6SU9TdXJmYWNlU3VyZmFjZUVBR0w6OklPU3VyZmFjZVN1cmZhY2VFQUdMKToK KyAgICAgICAgKHJ4OjpJT1N1cmZhY2VTdXJmYWNlRUFHTDo6cmVsZWFzZVRleEltYWdlKToKKwog MjAyMC0wNC0yNyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVGVt cG9yYXJpbHkgc2tpcCBHTF9ERVBUSF9DT01QT05FTlQzMl9PRVMgcmVxdWlyZW1lbnQgZm9yIGRl cHRoIHRleHR1cmVzIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL2VhZ2wvSU9TdXJmYWNlU3VyZmFjZUVBR0wuaCBiL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9lYWdsL0lPU3Vy ZmFjZVN1cmZhY2VFQUdMLmgKaW5kZXggNGM3ZmIwNzYwZWFhMWJkNzU1NTA5MWRlOTI3ZmJkZTdk MDkxZmJjNi4uYzJjZTA2ZmE1MDUxODI0Yzc0MWQ4MGM0YjA2N2FhYjA3MDNhNWUyMCAxMDA2NDQK LS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL2Vh Z2wvSU9TdXJmYWNlU3VyZmFjZUVBR0wuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9z cmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWFnbC9JT1N1cmZhY2VTdXJmYWNlRUFHTC5oCkBAIC03 NSw2ICs3NSw3IEBAIGNsYXNzIElPU3VyZmFjZVN1cmZhY2VFQUdMIDogcHVibGljIFN1cmZhY2VH TAogICAgIGludCBtSGVpZ2h0OwogICAgIGludCBtUGxhbmU7CiAgICAgaW50IG1Gb3JtYXRJbmRl eDsKKyAgICBpbnQgbVJvd1N0cmlkZUluUGl4ZWxzOwogCiAgICAgYm9vbCBtQWxwaGFJbml0aWFs aXplZDsKICNpZiBkZWZpbmVkKEFOR0xFX1BMQVRGT1JNX0lPU19TSU1VTEFUT1IpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWFn bC9JT1N1cmZhY2VTdXJmYWNlRUFHTC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9yZW5kZXJlci9nbC9lYWdsL0lPU3VyZmFjZVN1cmZhY2VFQUdMLm1tCmluZGV4IDNj YTBlMWM5NDk0ZTMzMWNhNTVhZTQzNmE1YWRkYzAyODQ5YmU0MjguLjA2OWQ3YTM0ODNhMDIzZTk2 MGM3NzI0YjAxOWNlZTVkZWE3Y2YyNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9lYWdsL0lPU3VyZmFjZVN1cmZhY2VFQUdMLm1t CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9l YWdsL0lPU3VyZmFjZVN1cmZhY2VFQUdMLm1tCkBAIC04Myw2ICs4Myw3IEBAIElPU3VyZmFjZVN1 cmZhY2VFQUdMOjpJT1N1cmZhY2VTdXJmYWNlRUFHTChjb25zdCBlZ2w6OlN1cmZhY2VTdGF0ZSAm c3RhdGUsCiAgICAgICBtV2lkdGgoMCksCiAgICAgICBtSGVpZ2h0KDApLAogICAgICAgbVBsYW5l KDApLAorICAgICAgbVJvd1N0cmlkZUluUGl4ZWxzKDApLAogICAgICAgbUZvcm1hdEluZGV4KC0x KSwKICAgICAgIG1BbHBoYUluaXRpYWxpemVkKGZhbHNlKQogewpAQCAtOTQsNiArOTUsMTEgQEAg SU9TdXJmYWNlU3VyZmFjZUVBR0w6OklPU3VyZmFjZVN1cmZhY2VFQUdMKGNvbnN0IGVnbDo6U3Vy ZmFjZVN0YXRlICZzdGF0ZSwKICAgICBtV2lkdGggID0gc3RhdGljX2Nhc3Q8aW50PihhdHRyaWJz LmdldChFR0xfV0lEVEgpKTsKICAgICBtSGVpZ2h0ID0gc3RhdGljX2Nhc3Q8aW50PihhdHRyaWJz LmdldChFR0xfSEVJR0hUKSk7CiAgICAgbVBsYW5lICA9IHN0YXRpY19jYXN0PGludD4oYXR0cmli cy5nZXQoRUdMX0lPU1VSRkFDRV9QTEFORV9BTkdMRSkpOworICAgIC8vIEhvcGVmdWxseSB0aGUg bnVtYmVyIG9mIGJ5dGVzIHBlciByb3cgaXMgYWx3YXlzIGFuIGludGVnZXIgbnVtYmVyIG9mIHBp eGVscy4KKyAgICAvLyBXZSB1c2UgZ2xSZWFkUGl4ZWxzIHRvIGZpbGwgdGhlIElPU3VyZmFjZSBp biB0aGUgc2ltdWxhdG9yIGFuZCBpdCBjYW4gb25seQorICAgIC8vIHN1cHBvcnQgc3RyaWRlcyB0 aGF0IGFyZSBhbiBpbnRlZ2VyIG51bWJlciBvZiBwaXhlbHMuCisgICAgQVNTRVJUKElPU3VyZmFj ZUdldEJ5dGVzUGVyUm93T2ZQbGFuZShtSU9TdXJmYWNlLCBtUGxhbmUpICUgSU9TdXJmYWNlR2V0 Qnl0ZXNQZXJFbGVtZW50T2ZQbGFuZShtSU9TdXJmYWNlLCBtUGxhbmUpID09IDApOworICAgIG1S b3dTdHJpZGVJblBpeGVscyA9IHN0YXRpY19jYXN0PGludD4oSU9TdXJmYWNlR2V0Qnl0ZXNQZXJS b3dPZlBsYW5lKG1JT1N1cmZhY2UsIG1QbGFuZSkgLyBJT1N1cmZhY2VHZXRCeXRlc1BlckVsZW1l bnRPZlBsYW5lKG1JT1N1cmZhY2UsIG1QbGFuZSkpOwogCiAgICAgRUdMQXR0cmliIGludGVybmFs Rm9ybWF0ID0gYXR0cmlicy5nZXQoRUdMX1RFWFRVUkVfSU5URVJOQUxfRk9STUFUX0FOR0xFKTsK ICAgICBFR0xBdHRyaWIgdHlwZSAgICAgICAgICAgPSBhdHRyaWJzLmdldChFR0xfVEVYVFVSRV9U WVBFX0FOR0xFKTsKQEAgLTIyNyw2ICsyMzMsNyBAQCBlZ2w6OkVycm9yIElPU3VyZmFjZVN1cmZh Y2VFQUdMOjpyZWxlYXNlVGV4SW1hZ2UoY29uc3QgZ2w6OkNvbnRleHQgKmNvbnRleHQsIEVHTAog ICAgICAgICBmdW5jdGlvbnMtPmZyYW1lYnVmZmVyVGV4dHVyZTJEKEdMX0ZSQU1FQlVGRkVSLCBH TF9DT0xPUl9BVFRBQ0hNRU5UMCwgR0xfVEVYVFVSRV8yRCwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBtQm91bmRUZXh0dXJlSUQsIDApOwogICAgICAgICBnbDo6UGl4 ZWxQYWNrU3RhdGUgc3RhdGU7CisgICAgICAgIHN0YXRlLnJvd0xlbmd0aCA9IG1Sb3dTdHJpZGVJ blBpeGVsczsKICAgICAgICAgc3RhdGUuYWxpZ25tZW50ID0gMTsKICAgICAgICAgc3RhdGVNYW5h Z2VyLT5zZXRQaXhlbFBhY2tTdGF0ZShzdGF0ZSk7CiAgICAgICAgIC8vIFRPRE8oa2JyKTogcG9z c2libHkgbW9yZSBzdGF0ZSB0byBiZSBzZXQgaGVyZSwgaW5jbHVkaW5nIHNldHRpbmcgYW55Cg==