211393 2020-05-04 13:07:11 -0700 REGRESSION (r260228): Linker warning about limitsNavigationsToAppBoundDomains property overriding instance methods from class 2020-05-08 10:53:27 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210620 1 ddkilzer ddkilzer bfulgham katherine_cheney ryanhaddad webkit-bug-importer wilander oldest_to_newest 1648699 0 ddkilzer 2020-05-04 13:07:11 -0700 Linker warning about limitsNavigationsToAppBoundDomains/setLimitsNavigationsToAppBoundDomains: overriding instance method from class when building WebKit: ld: warning: instance method 'setLimitsNavigationsToAppBoundDomains:' in category from WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o overrides method from class in WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o ld: warning: instance method 'limitsNavigationsToAppBoundDomains' in category from WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o overrides method from class in WebKit.build/Debug/WebKit.build/Objects-normal/x86_64/UnifiedSource24-mm.o I think this was introduced 2-3 weeks ago. (Might be the cause of flaky behavior if the wrong method is being called.) 1648702 1 ddkilzer 2020-05-04 13:08:41 -0700 I first noticed this on Apr 17, 2020. 1650419 2 ddkilzer 2020-05-07 17:08:39 -0700 This warning means that the @property was added to the public header: @property (nonatomic) BOOL limitsNavigationsToAppBoundDomains WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); But the implementation was added to a category: @implementation WKWebViewConfiguration (WKPrivate) [...] - (BOOL)limitsNavigationsToAppBoundDomains { return _pageConfiguration->limitsNavigationsToAppBoundDomains(); } - (void)setLimitsNavigationsToAppBoundDomains:(BOOL)limitsToAppBoundDomains { _pageConfiguration->setLimitsNavigationsToAppBoundDomains(limitsToAppBoundDomains); } [...] @end 1650428 3 398818 ddkilzer 2020-05-07 17:25:15 -0700 Created attachment 398818 Patch v1 1650429 4 ddkilzer 2020-05-07 17:25:53 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 398818 [details] > Patch v1 (I got tired of seeing the warning when building. :) 1650475 5 webkit-bug-importer 2020-05-07 19:45:54 -0700 <rdar://problem/63004163> 1650666 6 398818 bfulgham 2020-05-08 10:19:30 -0700 Comment on attachment 398818 Patch v1 r=me 1650683 7 ews-feeder 2020-05-08 10:53:27 -0700 Committed r261396: <https://trac.webkit.org/changeset/261396> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398818. 398818 2020-05-07 17:25:15 -0700 2020-05-08 10:53:27 -0700 Patch v1 bug-211393-20200507172843.patch text/plain 2338 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzNGY5YjQxN2Y5N2MwMTdl NDY4YjgwY2M1MTA2OTA2ZGFhZWQ1YmEuLmUwOTQ5MjQ2NDVjMzcxZTk4YWNmMGY3MjhiZTlmYWRl YmM5NjhmMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDUtMDcgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYwMjI4 KTogTGlua2VyIHdhcm5pbmcgYWJvdXQgbGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlu cyBwcm9wZXJ0eSBvdmVycmlkaW5nIGluc3RhbmNlIG1ldGhvZHMgZnJvbSBjbGFzcworICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjExMzkzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdD b25maWd1cmF0aW9uLm1tOgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIGxpbWl0 c05hdmlnYXRpb25zVG9BcHBCb3VuZERvbWFpbnNdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3Q29u ZmlndXJhdGlvbiBzZXRMaW1pdHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5zOl0pOgorICAg ICAgICAtIE1vdmUgZnJvbSBXS1ByaXZhdGUgY2F0ZWdvcnkgdG8gbWFpbiBjYXRlZ29yeSB0byBm aXggbGlua2VyCisgICAgICAgICAgd2FybmluZ3MuCisKIDIwMjAtMDUtMDUgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggZGVwcmVjYXRlZCBOU0dyYXBo aWNzQ29udGV4dCBtZXRob2RzIHVzaW5nICdncmFwaGljc1BvcnQnCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Q29uZmlndXJhdGlvbi5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9u Lm1tCmluZGV4IDlmYjcwNTY3OWI1ZmVlYTdjMTc3ZjA1NWE4YzE5NmIxMTgzMjUxZDIuLmM1NzBl NDIyOGQ4MTNmMWY5ZjU2NThmZGNlZmViOWVhMmY2NTE0YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9u Lm1tCkBAIC01OTIsNiArNTkyLDE2IEBAIC0gKFJlZjxBUEk6OlBhZ2VDb25maWd1cmF0aW9uPilj b3B5UGFnZUNvbmZpZ3VyYXRpb24KICAgICByZXR1cm4gX3BhZ2VDb25maWd1cmF0aW9uLT5jb3B5 KCk7CiB9CiAKKy0gKEJPT0wpbGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5kRG9tYWlucworewor ICAgIHJldHVybiBfcGFnZUNvbmZpZ3VyYXRpb24tPmxpbWl0c05hdmlnYXRpb25zVG9BcHBCb3Vu ZERvbWFpbnMoKTsKK30KKworLSAodm9pZClzZXRMaW1pdHNOYXZpZ2F0aW9uc1RvQXBwQm91bmRE b21haW5zOihCT09MKWxpbWl0c1RvQXBwQm91bmREb21haW5zCit7CisgICAgX3BhZ2VDb25maWd1 cmF0aW9uLT5zZXRMaW1pdHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5zKGxpbWl0c1RvQXBw Qm91bmREb21haW5zKTsKK30KKwogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV0tXZWJWaWV3Q29u ZmlndXJhdGlvbiAoV0tQcml2YXRlKQpAQCAtNjg2LDE2ICs2OTYsNiBAQCAtICh2b2lkKV9zZXRB bGxvd1RvcE5hdmlnYXRpb25Ub0RhdGFVUkxzOihCT09MKWFsbG93VG9wTmF2aWdhdGlvblRvRGF0 YVVSTHMKICAgICBfYWxsb3dUb3BOYXZpZ2F0aW9uVG9EYXRhVVJMcyA9IGFsbG93VG9wTmF2aWdh dGlvblRvRGF0YVVSTHM7CiB9CiAKLS0gKEJPT0wpbGltaXRzTmF2aWdhdGlvbnNUb0FwcEJvdW5k RG9tYWlucwotewotICAgIHJldHVybiBfcGFnZUNvbmZpZ3VyYXRpb24tPmxpbWl0c05hdmlnYXRp b25zVG9BcHBCb3VuZERvbWFpbnMoKTsKLX0KLQotLSAodm9pZClzZXRMaW1pdHNOYXZpZ2F0aW9u c1RvQXBwQm91bmREb21haW5zOihCT09MKWxpbWl0c1RvQXBwQm91bmREb21haW5zCi17Ci0gICAg X3BhZ2VDb25maWd1cmF0aW9uLT5zZXRMaW1pdHNOYXZpZ2F0aW9uc1RvQXBwQm91bmREb21haW5z KGxpbWl0c1RvQXBwQm91bmREb21haW5zKTsKLX0KLQogLSAoQk9PTClfY29udmVydHNQb3NpdGlv blN0eWxlT25Db3B5CiB7CiAgICAgcmV0dXJuIF9jb252ZXJ0c1Bvc2l0aW9uU3R5bGVPbkNvcHk7 Cg==