211390 2020-05-04 11:18:38 -0700 Web Inspector: the divider before the console message icons in the tab bar is shown even if there are no other icons 2020-05-05 14:02:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1648631 0 hi 2020-05-04 11:18:38 -0700 # STEPS TO REPRODUCE 1. inspect any service worker 2. evaluate `error(42)` in the Console prompt => there is a divider before the warning icon 1648633 1 398393 hi 2020-05-04 11:23:20 -0700 Created attachment 398393 Patch 1649365 2 398393 bburg 2020-05-05 13:59:18 -0700 Comment on attachment 398393 Patch r=me, good catch! 1649368 3 ews-feeder 2020-05-05 14:01:31 -0700 Committed r261198: <https://trac.webkit.org/changeset/261198> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398393. 1649369 4 webkit-bug-importer 2020-05-05 14:02:15 -0700 <rdar://problem/62902419> 398393 2020-05-04 11:23:20 -0700 2020-05-05 14:01:32 -0700 Patch bug-211390-20200504122319.patch text/plain 2859 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDljYTc1ZTViYWFmMGNhOTZmYzY4MDI5OTZjOWQ3 YjhlYjY2NzhmODAuLjE3NTkwODc0ZGYwMDFkODk3M2YyYjc1ZGI1NDE4MzI0MmQyOTI1NDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA1LTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB0 aGUgZGl2aWRlciBiZWZvcmUgdGhlIGNvbnNvbGUgbWVzc2FnZSBpY29ucyBpbiB0aGUgdGFiIGJh ciBpcyBzaG93biBldmVuIGlmIHRoZXJlIGFyZSBubyBvdGhlciBpY29ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMzkwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qczoKKyAgICAgICAgKFdJLl91cGRhdGVUYWJCYXJEaXZpZGVycyk6CisgICAgICAgIChX SS5fdXBkYXRlVGFiQmFyRGl2aWRlcnMuaXNIaWRkZW4pOiBBZGRlZC4KKyAgICAgICAgSWYgdGhl IHZhcmlvdXMgYFdJLkJ1dHRvbk5hdmlnYXRpb25JdGVtYCBhcmVuJ3QgYWN0dWFsbHkgY3JlYXRl ZCwgdGhlbiB0aGUgb3B0aW9uYWwgY2hhaW4KKyAgICAgICAgd2lsbCByZXR1cm4gYHVuZGVmaW5l ZGAgaW5zdGVhZCBvZiB0aGUgZGVzaXJlZCBgdHJ1ZWAgd2hlbiBjaGVja2luZyB3aGV0aGVyIGl0 IGlzIGBoaWRkZW5gLgorICAgICAgICBFZmZlY3RpdmVseSwgYSBgV0kuQnV0dG9uTmF2aWdhdGlv bkl0ZW1gIHRoYXQgZG9lcyBub3QgZXhpc3Qgc2hvdWxkIGJlIGNvbnNpZGVyZWQgYGhpZGRlbmAu CisKIDIwMjAtMDQtMzAgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29tcHV0ZWQ6IHNob3VsZG4ndCBkaXNwbGF5IGZvY3Vz IG91dGxpbmUgb24gY2xpY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qcwppbmRleCA0YmM2MmIzNDBmYzliYjk5ZDkyMzVjYTRhNzA4OGU5MDhm MDdkMDZhLi42NTkyNzY3YTY5YjhmYmUwMzhhNjgwN2E0YTVkMDA4MmNlYjIyZmE5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0y NDA2LDE1ICsyNDA2LDE5IEBAIFdJLl91cGRhdGVJbnNwZWN0TW9kZVRhYkJhckJ1dHRvbiA9IGZ1 bmN0aW9uKCkKIAogV0kuX3VwZGF0ZVRhYkJhckRpdmlkZXJzID0gZnVuY3Rpb24oKQogewotICAg IGxldCBjbG9zZUhpZGRlbiA9IFdJLl9jbG9zZVRhYkJhckJ1dHRvbj8uaGlkZGVuOwotICAgIGxl dCBkb2NrVG9TaWRlSGlkZGVuID0gV0kuX2RvY2tUb1NpZGVUYWJCYXJCdXR0b24/LmhpZGRlbjsK LSAgICBsZXQgZG9ja0JvdHRvbUhpZGRlbiA9IFdJLl9kb2NrQm90dG9tVGFiQmFyQnV0dG9uPy5o aWRkZW47Ci0gICAgbGV0IHVuZG9ja0hpZGRlbiA9IFdJLl91bmRvY2tUYWJCYXJCdXR0b24/Lmhp ZGRlbjsKKyAgICBmdW5jdGlvbiBpc0hpZGRlbihuYXZpZ2F0aW9uSXRlbSkgeworICAgICAgICBy ZXR1cm4gIW5hdmlnYXRpb25JdGVtIHx8IG5hdmlnYXRpb25JdGVtLmhpZGRlbjsKKyAgICB9CiAK LSAgICBsZXQgaW5zcGVjdE1vZGVIaWRkZW4gPSBXSS5faW5zcGVjdE1vZGVUYWJCYXJCdXR0b24u aGlkZGVuOwotICAgIGxldCBkZXZpY2VTZXR0aW5nc0hpZGRlbiA9IFdJLl9kZXZpY2VTZXR0aW5n c1RhYkJhckJ1dHRvbiAmJiBXSS5fZGV2aWNlU2V0dGluZ3NUYWJCYXJCdXR0b24uaGlkZGVuOwot ICAgIGxldCByZWxvYWRIaWRkZW4gPSBXSS5fcmVsb2FkVGFiQmFyQnV0dG9uICYmIFdJLl9yZWxv YWRUYWJCYXJCdXR0b24uaGlkZGVuOwotICAgIGxldCBkb3dubG9hZEhpZGRlbiA9IFdJLl9kb3du bG9hZFRhYkJhckJ1dHRvbiAmJiBXSS5fZG93bmxvYWRUYWJCYXJCdXR0b24uaGlkZGVuOworICAg IGxldCBjbG9zZUhpZGRlbiA9IGlzSGlkZGVuKFdJLl9jbG9zZVRhYkJhckJ1dHRvbik7CisgICAg bGV0IGRvY2tUb1NpZGVIaWRkZW4gPSBpc0hpZGRlbihXSS5fZG9ja1RvU2lkZVRhYkJhckJ1dHRv bik7CisgICAgbGV0IGRvY2tCb3R0b21IaWRkZW4gPSBpc0hpZGRlbihXSS5fZG9ja0JvdHRvbVRh YkJhckJ1dHRvbik7CisgICAgbGV0IHVuZG9ja0hpZGRlbiA9IGlzSGlkZGVuKFdJLl91bmRvY2tU YWJCYXJCdXR0b24pOworCisgICAgbGV0IGluc3BlY3RNb2RlSGlkZGVuID0gaXNIaWRkZW4oV0ku X2luc3BlY3RNb2RlVGFiQmFyQnV0dG9uKTsKKyAgICBsZXQgZGV2aWNlU2V0dGluZ3NIaWRkZW4g PSBpc0hpZGRlbihXSS5fZGV2aWNlU2V0dGluZ3NUYWJCYXJCdXR0b24pOworICAgIGxldCByZWxv YWRIaWRkZW4gPSBpc0hpZGRlbihXSS5fcmVsb2FkVGFiQmFyQnV0dG9uKTsKKyAgICBsZXQgZG93 bmxvYWRIaWRkZW4gPSBpc0hpZGRlbihXSS5fZG93bmxvYWRUYWJCYXJCdXR0b24pOwogCiAgICAg bGV0IHdhcm5pbmdzSGlkZGVuID0gV0kuX2NvbnNvbGVXYXJuaW5nc1RhYkJhckJ1dHRvbi5oaWRk ZW47CiAgICAgbGV0IGVycm9yc0hpZGRlbiA9IFdJLl9jb25zb2xlRXJyb3JzVGFiQmFyQnV0dG9u LmhpZGRlbjsK