211383 2020-05-04 09:03:51 -0700 [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks 2020-05-04 18:04:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin webkit-bug-importer oldest_to_newest 1648560 0 darin 2020-05-04 09:03:51 -0700 [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks 1648561 1 398373 darin 2020-05-04 09:05:45 -0700 Created attachment 398373 Patch 1648818 2 398373 ap 2020-05-04 16:32:37 -0700 Comment on attachment 398373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) This check can be removed now, 10.14 is the oldest supported version for macOS. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 > #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 This can be removed too. We are 13.4+ now. 1648855 3 darin 2020-05-04 17:33:55 -0700 All right. I have some more patches coming up removing even more version checks. 1648874 4 398373 darin 2020-05-04 18:01:32 -0700 Comment on attachment 398373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review >> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151 >> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV) > > This check can be removed now, 10.14 is the oldest supported version for macOS. OK, will do. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534 >> #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400 > > This can be removed too. We are 13.4+ now. Are you sure? This says > 130400, not >= 130400. 1648875 5 darin 2020-05-04 18:03:16 -0700 Committed r261134: <https://trac.webkit.org/changeset/261134> 1648876 6 webkit-bug-importer 2020-05-04 18:04:18 -0700 <rdar://problem/62870095> 398373 2020-05-04 09:05:45 -0700 2020-05-04 16:32:37 -0700 Patch bug-211383-20200504090543.patch text/plain 4999 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0NjJmZGQ3ZDAxM2MzNmVh NzMyZmFmZDEwODA5MDMyYTU4NGZkNTUuLjMxMmQ5YzAzZWQyMGExNjM1N2ZmMzk1YWM4YTJjMmRh OTFmYjg1MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDUtMDQgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gUmVtb3ZlIGEgZmV3IHVu bmVlZGVkIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIGNoZWNrcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMzgzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zv cm1zL1dLQWlyUGxheVJvdXRlUGlja2VyLmg6IFJlbW92ZWQgYSBjaGVjayBhZ2FpbnN0CisgICAg ICAgIGlPUyAxMSwgaW4gY29kZSB0aGF0IGFscmVhZHkgZXhwbGljaXRseSBjaGVja3MgZm9yIHdh dGNoT1MgYW5kIHR2T1MuCisKIDIwMjAtMDUtMDQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBzcGVjdWxhdGl2ZSBidWlsZCBmaXggZm9y IHIyNjEwNzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9X S0FpclBsYXlSb3V0ZVBpY2tlci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1z L1dLQWlyUGxheVJvdXRlUGlja2VyLmgKaW5kZXggMDIyZjc2YjU2YzAzMWNlMGUyZmYxOWJmMWQ4 YzVjN2ZjMDAwYThjMy4uYjBiMGVkNjI2YThmYmRiZmExZTE4NjI5NDE1ZjY4N2QzNzUyYWQxMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJv dXRlUGlja2VyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWly UGxheVJvdXRlUGlja2VyLmgKQEAgLTI1LDcgKzI1LDcgQEAKIAogI2lmIFBMQVRGT1JNKElPU19G QU1JTFkpICYmIEVOQUJMRShBSVJQTEFZX1BJQ0tFUikKIAotI2lmIF9fSVBIT05FX09TX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID49IDExMDAwMCAmJiAhUExBVEZPUk0oV0FUQ0hPUykgJiYgIVBMQVRG T1JNKEFQUExFVFYpCisjaWYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFURk9STShBUFBMRVRW KQogCiAjaW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIApkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDU1OWRiMTM3YzFmMDUwNWFlZjJi M2M3ZGVjYjMzNjllNWNjMzE3NzguLjk5NDNiNmYwMWYxYzA0ZGMyNjBmMzMxMmVjZDJmYjdmNjc5 MWE3NWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAyMC0wNS0wNCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5j b20+CisKKyAgICAgICAgW0NvY29hXSBSZW1vdmUgYSBmZXcgdW5uZWVkZWQgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgY2hlY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEzODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9jb2NvYS9B VkZvdW5kYXRpb25Tb2Z0TGlua1Rlc3QubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNU KTogUmVtb3ZlZCBjaGVja3MgYWdhaW5zdCBpT1MgMTIgYW5kIDEzIGluIGNvZGUgdGhhdAorICAg ICAgICB1c2VzIFBMQVRGT1JNKElPUyksIG5vdCBQTEFURk9STShJT1NfRkFNSUxZKS4KKworICAg ICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmln YXRpb24ubW06IFJlbW92ZWQgYQorICAgICAgICBjaGVjayBhZ2FpbnN0IGlPUyAxMSBpbiBjb2Rl IHVzaW5nIFBMQVRGT1JNKElPUykuCisKIDIwMjAtMDUtMDQgIEFuZHJlcyBHb256YWxleiAgPGFu ZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBXVFI6OkFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQ6OmF0dHJpYnV0ZVZhbHVlQXN5bmMgdG8gcmV0cmlldmUgYXR0cmlidXRlIHZhbHVlcyBp biBpc29sYXRlZCB0cmVlIG1vZGUuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvY29jb2EvQVZGb3VuZGF0aW9uU29mdExpbmtUZXN0Lm1tIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL2NvY29hL0FWRm91bmRhdGlvblNvZnRMaW5rVGVzdC5t bQppbmRleCAzOTM0NGJiNGY1OGNkNzA3NzQ3NDgwMGNjMDdmNmJmMmI1ZDUzM2Q1Li4wODQzYTE3 MGYzOTdmNTA1YzYyYWMzYjQ4M2NhZGFlNzBiNTgyNjhiIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvY29jb2EvQVZGb3VuZGF0aW9uU29mdExpbmtUZXN0Lm1t CisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9jb2NvYS9BVkZvdW5kYXRp b25Tb2Z0TGlua1Rlc3QubW0KQEAgLTE0NSwxMiArMTQ1LDEwIEBAIFRFU1QoQVZGb3VuZGF0aW9u U29mdExpbmssIENvbnN0YW50cykKICAgICBpZiAoUEFMOjpjYW5Mb2FkX0FWRm91bmRhdGlvbl9B VlNhbXBsZVJhdGVLZXkoKSkKICAgICAgICAgRVhQRUNUX1RSVUUoW0FWU2FtcGxlUmF0ZUtleSBp c0VxdWFsVG9TdHJpbmc6QCJBVlNhbXBsZVJhdGVLZXkiXSk7CiAKLSNpZiBQTEFURk9STShNQUMp IHx8IChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDExMDAwMCkgfHwgUExBVEZPUk0oV0FUQ0hPUykgfHwgUExBVEZPUk0oQVBQTEVUVikKICAgICBF WFBFQ1RfVFJVRShQQUw6OmNhbkxvYWRfQVZGb3VuZGF0aW9uX0FWVVJMQXNzZXRPdXRPZkJhbmRN SU1FVHlwZUtleSgpKTsKICAgICBFWFBFQ1RfVFJVRShbQVZVUkxBc3NldE91dE9mQmFuZE1JTUVU eXBlS2V5IGlzRXF1YWxUb1N0cmluZzpAIkFWVVJMQXNzZXRPdXRPZkJhbmRNSU1FVHlwZUtleSJd KTsKLSNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMDE0MDApIHx8IChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMCkgfHwgUExBVEZPUk0oV0FUQ0hPUykgfHwgUExB VEZPUk0oQVBQTEVUVikKKyNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEID49IDEwMTQwMCkgfHwgUExBVEZPUk0oSU9TKSB8fCBQTEFURk9STShXQVRD SE9TKSB8fCBQTEFURk9STShBUFBMRVRWKQogICAgIEVYUEVDVF9UUlVFKFBBTDo6Y2FuTG9hZF9B VkZvdW5kYXRpb25fQVZVUkxBc3NldFVzZUNsaWVudFVSTExvYWRpbmdFeGNsdXNpdmVseSgpKTsK ICAgICBFWFBFQ1RfVFJVRShbQVZVUkxBc3NldFVzZUNsaWVudFVSTExvYWRpbmdFeGNsdXNpdmVs eSBpc0VxdWFsVG9TdHJpbmc6QCJBVlVSTEFzc2V0VXNlQ2xpZW50VVJMTG9hZGluZ0V4Y2x1c2l2 ZWx5Il0pOwogI2VuZGlmCkBAIC0xNjUsNyArMTYzLDcgQEAgVEVTVChBVkZvdW5kYXRpb25Tb2Z0 TGluaywgQ29uc3RhbnRzKQogICAgIEVYUEVDVF9UUlVFKFtBVkNvbnRlbnRLZXlSZXF1ZXN0UHJv dG9jb2xWZXJzaW9uc0tleSBpc0VxdWFsVG9TdHJpbmc6QCJQcm90b2NvbFZlcnNpb25zS2V5Il0p OwogI2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwMTUwMCkgfHwgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8fCBQTEFURk9STShXQVRDSE9TKSB8fCBQTEFU Rk9STShBUFBMRVRWKQorI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTAxNTAwKSB8fCBQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKFdBVENI T1MpIHx8IFBMQVRGT1JNKEFQUExFVFYpCiAgICAgRVhQRUNUX1RSVUUoUEFMOjpjYW5Mb2FkX0FW Rm91bmRhdGlvbl9BVlZpZGVvQ29kZWNUeXBlSEVWQ1dpdGhBbHBoYSgpKTsKICAgICBFWFBFQ1Rf VFJVRShbQVZWaWRlb0NvZGVjVHlwZUhFVkNXaXRoQWxwaGEgaXNFcXVhbFRvU3RyaW5nOkAibXV4 YSJdKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KaW5kZXggMDE2ZWJk MTIyNWU3ZDM3YzZhODNkMzY3MGNlMzBiOGRmZjMxNjEzNC4uMDY0NzhjNGJhNTNiMTVlODk5MzIx NmZmNDNlODhmMmJlMDVjYmVhMCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCkBA IC02NTI5LDcgKzY1MjksNyBAQCBURVNUKFByb2Nlc3NTd2FwLCBQYWdlT3ZlcmxheUxheWVyUGVy c2lzdGVuY2UpCiAjZW5kaWYKIH0KIAotI2lmIFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMDAwCisjaWYgUExBVEZPUk0oSU9TKQogCiAjaWYg X19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMzA0MDAKIFRFU1QoUHJvY2Vzc1N3 YXAsIFF1aWNrTG9va1JlcXVlc3RzUGFzc3dvcmRBZnRlclN3YXApCg==