211368 2020-05-03 23:22:15 -0700 Remove some unused and broken functions in Bitmap. 2020-05-04 00:16:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1648447 0 mark.lam 2020-05-03 23:22:15 -0700 Bitmap::operator[] never worked. There's currently no way to use it to read a bit value. We also can't use it to set a bit value because it relies on Bitmap::iterator::operator= to set the value. However, Bitmap::iterator stores the Bitmap* as a const pointer, and Bitmap::iterator::operator= calls set() on the const pointer. If we try to use operator[] to set a bit, we'll get a compilation error. This patch removes the 2 variants of Bitmap::operator[] and Bitmap::iterator::operator=. 1648448 1 398348 mark.lam 2020-05-03 23:34:12 -0700 Created attachment 398348 proposed patch. 1648452 2 398348 ysuzuki 2020-05-04 00:01:25 -0700 Comment on attachment 398348 proposed patch. r=me 1648454 3 mark.lam 2020-05-04 00:15:58 -0700 Thanks for the review. Landed in r261073: <http://trac.webkit.org/r261073>. 1648455 4 webkit-bug-importer 2020-05-04 00:16:15 -0700 <rdar://problem/62834067> 398348 2020-05-03 23:34:12 -0700 2020-05-04 00:01:25 -0700 proposed patch. bug-211368.patch text/plain 2889 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjEwNzEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA1LTAzICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSB1bnVzZWQgYW5kIGJyb2tlbiBmdW5j dGlvbnMgaW4gQml0bWFwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjExMzY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQml0bWFwOjpvcGVyYXRvcltdIG5ldmVyIHdvcmtlZC4gIFRoZXJlJ3MgY3VycmVu dGx5IG5vIHdheSB0byB1c2UgaXQgdG8gcmVhZCBhCisgICAgICAgIGJpdCB2YWx1ZS4gIFdlIGFs c28gY2FuJ3QgdXNlIGl0IHRvIHNldCBhIGJpdCB2YWx1ZSBiZWNhdXNlIGl0IHJlbGllcyBvbgor ICAgICAgICBCaXRtYXA6Oml0ZXJhdG9yOjpvcGVyYXRvcj0gdG8gc2V0IHRoZSB2YWx1ZS4gIEhv d2V2ZXIsIEJpdG1hcDo6aXRlcmF0b3Igc3RvcmVzCisgICAgICAgIHRoZSBCaXRtYXAqIGFzIGEg Y29uc3QgcG9pbnRlciwgYW5kIEJpdG1hcDo6aXRlcmF0b3I6Om9wZXJhdG9yPSBjYWxscyBzZXQo KSBvbgorICAgICAgICB0aGUgY29uc3QgcG9pbnRlci4gIElmIHdlIHRyeSB0byB1c2Ugb3BlcmF0 b3JbXSB0byBzZXQgYSBiaXQsIHdlJ2xsIGdldCBhCisgICAgICAgIGNvbXBpbGF0aW9uIGVycm9y LgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgMiB2YXJpYW50cyBvZiBCaXRtYXA6 Om9wZXJhdG9yW10gYW5kIEJpdG1hcDo6aXRlcmF0b3I6Om9wZXJhdG9yPS4KKworICAgICAgICAq IHd0Zi9CaXRtYXAuaDoKKyAgICAgICAgKFdURjo6V29yZFR5cGU+OjpvcGVyYXRvcik6IERlbGV0 ZWQuCisgICAgICAgIChXVEY6OldvcmRUeXBlPjo6b3BlcmF0b3IgY29uc3QgY29uc3QpOiBEZWxl dGVkLgorCiAyMDIwLTA1LTAzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAg ICAgYXRvYigpIHNob3VsZCBub3QgYWNjZXB0IGEgdmVydGljYWwgdGFiCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9CaXRtYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9CaXRtYXAuaAko cmV2aXNpb24gMjYxMDcxKQorKysgU291cmNlL1dURi93dGYvQml0bWFwLmgJKHdvcmtpbmcgY29w eSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogIENvcHlyaWdodCAoQykgMjAxMC0yMDE5IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMTAtMjAyMCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkg aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCkBAIC0x MDMsMTIgKzEwMyw2IEBAIHB1YmxpYzoKICAgICAgICAgICAgIHJldHVybiAhKCp0aGlzID09IG90 aGVyKTsKICAgICAgICAgfQogCi0gICAgICAgIGl0ZXJhdG9yJiBvcGVyYXRvcj0oYm9vbCB2YWx1 ZSkKLSAgICAgICAgewotICAgICAgICAgICAgbV9iaXRtYXAtPnNldChtX2luZGV4LCB2YWx1ZSk7 Ci0gICAgICAgICAgICByZXR1cm4gKnRoaXM7Ci0gICAgICAgIH0KLQogICAgIHByaXZhdGU6CiAg ICAgICAgIGNvbnN0IEJpdG1hcCogbV9iaXRtYXA7CiAgICAgICAgIHNpemVfdCBtX2luZGV4OwpA QCAtMTE4LDkgKzExMiw2IEBAIHB1YmxpYzoKICAgICBpdGVyYXRvciBiZWdpbigpIGNvbnN0IHsg cmV0dXJuIGl0ZXJhdG9yKCp0aGlzLCBmaW5kQml0KDAsIHRydWUpKTsgfQogICAgIGl0ZXJhdG9y IGVuZCgpIGNvbnN0IHsgcmV0dXJuIGl0ZXJhdG9yKCp0aGlzLCBiaXRtYXBTaXplKTsgfQogICAg IAotICAgIGl0ZXJhdG9yIG9wZXJhdG9yW10oc2l6ZV90KTsKLSAgICBjb25zdCBpdGVyYXRvciBv cGVyYXRvcltdKHNpemVfdCkgY29uc3Q7Ci0KICAgICB2b2lkIG1lcmdlQW5kQ2xlYXIoQml0bWFw Jik7CiAgICAgdm9pZCBzZXRBbmRDbGVhcihCaXRtYXAmKTsKICAgICAKQEAgLTQyNywxOSArNDE4 LDYgQEAgaW5saW5lIGJvb2wgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPgogfQogCiB0ZW1w bGF0ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlwZW5hbWUgV29yZFR5cGU+Ci1pbmxpbmUgYXV0byBC aXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+OjpvcGVyYXRvcltdKHNpemVfdCBpbmRleCkgLT4g aXRlcmF0b3IKLXsKLSAgICBBU1NFUlQoaW5kZXggPCBzaXplKCkpOwotICAgIHJldHVybiBpdGVy YXRvcigqdGhpcywgaW5kZXgpOwotfQotCi10ZW1wbGF0ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlw ZW5hbWUgV29yZFR5cGU+Ci1pbmxpbmUgYXV0byBCaXRtYXA8Yml0bWFwU2l6ZSwgV29yZFR5cGU+ OjpvcGVyYXRvcltdKHNpemVfdCBpbmRleCkgY29uc3QgLT4gY29uc3QgaXRlcmF0b3IKLXsKLSAg ICByZXR1cm4gKCpjb25zdF9jYXN0PEJpdG1hcDxiaXRtYXBTaXplLCBXb3JkVHlwZT4qPih0aGlz KSlbaW5kZXhdOwotfQotCi10ZW1wbGF0ZTxzaXplX3QgYml0bWFwU2l6ZSwgdHlwZW5hbWUgV29y ZFR5cGU+CiBpbmxpbmUgdW5zaWduZWQgQml0bWFwPGJpdG1hcFNpemUsIFdvcmRUeXBlPjo6aGFz aCgpIGNvbnN0CiB7CiAgICAgdW5zaWduZWQgcmVzdWx0ID0gMDsK