211365 2020-05-03 21:08:27 -0700 [GTK] Tests exiting early due to TextureMapperShaderProgram variables ASSERTING isMainThread 2020-05-04 00:33:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 211355 https://bugs.webkit.org/show_bug.cgi?id=161800 https://bugs.webkit.org/show_bug.cgi?id=211264 P2 Normal --- 1 lmoura zan bugs-noreply cmarcelo ews-watchlist kondapallykalyan luiz noam ysuzuki zan oldest_to_newest 1648438 0 lmoura 2020-05-03 21:08:27 -0700 From bug161800: >> Since AtomString has thread-affinity, static NeverDestroyed<const AtomString> is basically only safe for the main-thread use. >> We should ensure that this is only used in the main-thread. To do that, this patch introduces MainThreadNeverDestroyed and >> MainThreadLazyNeverDestroyed. They are NeverDestroyed and LazyNeverDestroyed + main-thread assertions. The patch for that bug changed the TEXMAP_DECLARE_VARIABLE field 'name' type from NeverDestroyed to MainThreadNeverDestroyed. Sample backtrace: ASSERTION FAILED: isMainThread() DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h(55) : static void WTF::MainThreadAccessTraits::assertAccess() 1 0x7efd83ffb94f WTFCrash 2 0x7efd91e1eb7a WTF::ConditionalCrashOnOverflow::setShouldCrashOnOverflow(bool) 3 0x7efd93529bcf WTF::MainThreadAccessTraits::assertAccess() 4 0x7efd9352ba49 WTF::NeverDestroyed<WTF::AtomString const, WTF::MainThreadAccessTraits>::NeverDestroyed<char const (&) [10], WTF::AtomString::ConstructFromLiteralTag>(char const (&) [10], WTF::AtomString::ConstructFromLiteralTag&&) 5 0x7efd9352a95e WebCore::TextureMapperShaderProgram::samplerLocation() 6 0x7efd9352812c WebCore::TextureMapperGL::drawTexturedQuadWithProgram(WebCore::TextureMapperShaderProgram&, unsigned int, int, WebCore::IntSize const&, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float) 7 0x7efd93526441 WebCore::TextureMapperGL::drawTexture(unsigned int, int, WebCore::IntSize const&, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float, unsigned int) 8 0x7efd935260e7 WebCore::TextureMapperGL::drawTexture(WebCore::BitmapTexture const&, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float, unsigned int) 9 0x7efd96643b2e WebCore::TextureMapperTile::paint(WebCore::TextureMapper&, WebCore::TransformationMatrix const&, float, unsigned int) 10 0x7efd9353ab45 WebCore::CoordinatedBackingStore::paintTilesToTextureMapper(WTF::Vector<WebCore::TextureMapperTile*, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::TextureMapper&, WebCore::TransformationMatrix const&, float, WebCore::FloatRect const&) 11 0x7efd9353afe4 WebCore::CoordinatedBackingStore::paintToTextureMapper(WebCore::TextureMapper&, WebCore::FloatRect const&, WebCore::TransformationMatrix const&, float) 12 0x7efd9351cf2c WebCore::TextureMapperLayer::paintSelf(WebCore::TextureMapperPaintOptions const&) 13 0x7efd9351d4fa WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 14 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 15 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 16 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 17 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 18 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 19 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 20 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 21 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 22 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 23 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 24 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 25 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 26 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 27 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 28 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 29 0x7efd9351dae6 WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 30 0x7efd9351f8c9 WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 31 0x7efd9351d77f WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 1648439 1 lmoura 2020-05-03 21:10:33 -0700 Sorry, the correct bug to be referenced is bug211264. (Which introduced this issue). Bug 161800 is a previous fix for this specific TextureMapperShaderProgram piece regarding AtomString and threading (which solved the issues for a while but now needs some rework). 1648449 2 ysuzuki 2020-05-03 23:39:33 -0700 (In reply to Lauro Moura from comment #1) > Sorry, the correct bug to be referenced is bug211264. (Which introduced this > issue). > > Bug 161800 is a previous fix for this specific TextureMapperShaderProgram > piece regarding AtomString and threading (which solved the issues for a > while but now needs some rework). That patch introduces assertions and found suspicious use. I've uploaded the patch which fixes TextureMapperShaderProgram issue. https://bugs.webkit.org/show_bug.cgi?id=211355 *** This bug has been marked as a duplicate of bug 211355 *** 1648459 3 zan 2020-05-04 00:21:04 -0700 Reopening to attach new patch. 1648460 4 398350 zan 2020-05-04 00:21:07 -0700 Created attachment 398350 Patch 1648464 5 zan 2020-05-04 00:33:54 -0700 *** This bug has been marked as a duplicate of bug 211355 *** 398350 2020-05-04 00:21:07 -0700 2020-05-04 00:33:42 -0700 Patch bug-211365-20200504092106.patch text/plain 3749 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc0MDliNjI3YzgzNzE2 NTBiNDQ0MzRiMGNkZGNiZWFkYzQ0YmFlMS4uMWEyNmYzN2E1N2M0OGVkMjllOTBmMGM4MjZjZDNm MjIwZTU0ZTMzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA1LTA0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0cyBl eGl0aW5nIGVhcmx5IGR1ZSB0byBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbSB2YXJpYWJsZXMg QVNTRVJUSU5HIGlzTWFpblRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjExMzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRHJvcCB0aGUgQXRvbVN0cmluZyB1c2FnZSBpbiBUZXh0dXJlTWFwcGVy IGluIGZhdm9yIG9mIHJhdyBzdGF0aWMgc3RyaW5nCisgICAgICAgIGRhdGEsIGF2b2lkaW5nIG5l dmVyLWRlc3Ryb3llZCBBdG9tU3RyaW5nIGJlaGF2aW9yIG5vdyBiZWluZyB0aWVkIHRvCisgICAg ICAgIG1haW4gdGhyZWFkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVN YXBwZXJTaGFkZXJQcm9ncmFtOjpnZXRMb2NhdGlvbik6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmg6CisKIDIwMjAtMDUtMDMg IERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgTG9jYWxD dXJyZW50R3JhcGhpY3NDb250ZXh0IGluIFdlYktpdDo6Y29udmVydFBsYXRmb3JtSW1hZ2VUb0Jp dG1hcCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcAppbmRleCAx MzA5Y2ZkNmZjZTVhYzgyN2Y0MWE0MWM1ZGU5YzcxY2ZiZGYwMmNhLi5mNDNjNjU3NWJmYzYxMmU0 NjY5Zjk5NDdlMTFhYWM1NjhkODk2MGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hh ZGVyUHJvZ3JhbS5jcHAKQEAgLTU4NywxNiArNTg3LDE1IEBAIHZvaWQgVGV4dHVyZU1hcHBlclNo YWRlclByb2dyYW06OnNldE1hdHJpeChHTHVpbnQgbG9jYXRpb24sIGNvbnN0IFRyYW5zZm9ybWF0 aW9uCiAgICAgZ2xVbmlmb3JtTWF0cml4NGZ2KGxvY2F0aW9uLCAxLCBmYWxzZSwgZmxvYXRNYXRy aXguZGF0YSgpKTsKIH0KIAotR0x1aW50IFRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpnZXRM b2NhdGlvbihjb25zdCBBdG9tU3RyaW5nJiBuYW1lLCBWYXJpYWJsZVR5cGUgdHlwZSkKK0dMdWlu dCBUZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbTo6Z2V0TG9jYXRpb24oY29uc3QgY2hhciogbmFt ZSwgVmFyaWFibGVUeXBlIHR5cGUpCiB7CiAgICAgYXV0byBhZGRSZXN1bHQgPSBtX3ZhcmlhYmxl cy5lbnN1cmUobmFtZSwKICAgICAgICAgW3RoaXMsICZuYW1lLCB0eXBlXSB7Ci0gICAgICAgICAg ICBDU3RyaW5nIG5hbWVDU3RyaW5nID0gbmFtZS5zdHJpbmcoKS51dGY4KCk7CiAgICAgICAgICAg ICBzd2l0Y2ggKHR5cGUpIHsKICAgICAgICAgICAgIGNhc2UgVW5pZm9ybVZhcmlhYmxlOgotICAg ICAgICAgICAgICAgIHJldHVybiBnbEdldFVuaWZvcm1Mb2NhdGlvbihtX2lkLCBuYW1lQ1N0cmlu Zy5kYXRhKCkpOworICAgICAgICAgICAgICAgIHJldHVybiBnbEdldFVuaWZvcm1Mb2NhdGlvbiht X2lkLCBuYW1lKTsKICAgICAgICAgICAgIGNhc2UgQXR0cmliVmFyaWFibGU6Ci0gICAgICAgICAg ICAgICAgcmV0dXJuIGdsR2V0QXR0cmliTG9jYXRpb24obV9pZCwgbmFtZUNTdHJpbmcuZGF0YSgp KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gZ2xHZXRBdHRyaWJMb2NhdGlvbihtX2lkLCBuYW1l KTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAg ICAgICAgICAgcmV0dXJuIDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5o CmluZGV4IDA5ODk5ODBlNDY1Njk4ZGVjZjY0ZTRmNDc1YjU0MTJiYjgyMDhkYjAuLmNkNGUyNTMy Y2NiZWUyMzI4MzdjMDNhMzRiMDg1N2MyYTVmOWU5ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyU2hhZGVyUHJvZ3JhbS5oCkBAIC0yOCwxNCArMjgsMTMgQEAKICNpbmNsdWRlIDx3dGYvSGFz aE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogI2luY2x1ZGUgPHd0Zi9S ZWYuaD4KLSNpbmNsdWRlIDx3dGYvdGV4dC9BdG9tU3RyaW5nSGFzaC5oPgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICNkZWZpbmUgVEVYTUFQX0RFQ0xBUkVfVkFSSUFCTEUoQWNjZXNzb3IsIE5h bWUsIFR5cGUpIFwKICAgICBHTHVpbnQgQWNjZXNzb3IjI0xvY2F0aW9uKCkgeyBcCi0gICAgICAg IHN0YXRpYyBNYWluVGhyZWFkTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgQXRvbVN0cmluZz4gbmFtZShO YW1lLCBBdG9tU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7IFwKLSAgICAgICAgcmV0dXJu IGdldExvY2F0aW9uKG5hbWUuZ2V0KCksIFR5cGUpOyBcCisgICAgICAgIHN0YXRpYyBjb25zdCBj aGFyKiBzX2xvY2F0aW9uTmFtZSB7IE5hbWUgfTsgXAorICAgICAgICByZXR1cm4gZ2V0TG9jYXRp b24oc19sb2NhdGlvbk5hbWUsIFR5cGUpOyBcCiAgICAgfQogCiAjZGVmaW5lIFRFWE1BUF9ERUNM QVJFX1VOSUZPUk0oQWNjZXNzb3IpIFRFWE1BUF9ERUNMQVJFX1ZBUklBQkxFKEFjY2Vzc29yLCAi dV8iI0FjY2Vzc29yLCBVbmlmb3JtVmFyaWFibGUpCkBAIC0xMDgsMTAgKzEwNywxMCBAQCBwcml2 YXRlOgogICAgIEdMdWludCBtX2ZyYWdtZW50U2hhZGVyOwogCiAgICAgZW51bSBWYXJpYWJsZVR5 cGUgeyBVbmlmb3JtVmFyaWFibGUsIEF0dHJpYlZhcmlhYmxlIH07Ci0gICAgR0x1aW50IGdldExv Y2F0aW9uKGNvbnN0IEF0b21TdHJpbmcmLCBWYXJpYWJsZVR5cGUpOworICAgIEdMdWludCBnZXRM b2NhdGlvbihjb25zdCBjaGFyKiwgVmFyaWFibGVUeXBlKTsKIAogICAgIEdMdWludCBtX2lkOwot ICAgIEhhc2hNYXA8QXRvbVN0cmluZywgR0x1aW50PiBtX3ZhcmlhYmxlczsKKyAgICBIYXNoTWFw PGNvbnN0IGNoYXIqLCBHTHVpbnQ+IG1fdmFyaWFibGVzOwogfTsKIAogfQo=