211351 2020-05-03 06:45:13 -0700 lh / rlh units don't work properly for some elements. 2022-10-14 08:00:51 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 211356 195180 1 emilio webkit-unassigned bfulgham koivisto ntim rune.lillesveen simon.fraser twilco.o tyler_w webkit-bug-importer ysuzuki oldest_to_newest 1648336 0 emilio 2020-05-03 06:45:13 -0700 There's a bunch of setLineHeight calls in RenderTheme / StyleAdjuster that happen when all other CSS values have already been computed. So the lh units will refer to a line-height that's fundamentally wrong. I filed https://github.com/w3c/csswg-drafts/issues/3257 on that a while ago but it seems WebKit has implemented the broken behavior :( 1648360 1 emilio 2020-05-03 11:52:38 -0700 Ah, that's a MainThreadNeverDestroyed, introduced by: https://bugs.webkit.org/show_bug.cgi?id=211264 So this is a regression from that change. 1648399 2 ysuzuki 2020-05-03 15:16:19 -0700 (In reply to Emilio Cobos Álvarez (:emilio) from comment #1) > Ah, that's a MainThreadNeverDestroyed, introduced by: > > https://bugs.webkit.org/show_bug.cgi?id=211264 > > So this is a regression from that change. Could you upload the crash trace of this? If non main thread is touching `const AtomString` generated by `MainThreadNeverDestroyed<>`, this potentially means that `MainThreadNeverDestroyed<>` finds the real bug. 1648400 3 ysuzuki 2020-05-03 15:18:35 -0700 (In reply to Yusuke Suzuki from comment #2) > (In reply to Emilio Cobos Álvarez (:emilio) from comment #1) > > Ah, that's a MainThreadNeverDestroyed, introduced by: > > > > https://bugs.webkit.org/show_bug.cgi?id=211264 > > > > So this is a regression from that change. > > Could you upload the crash trace of this? If non main thread is touching > `const AtomString` generated by `MainThreadNeverDestroyed<>`, this > potentially means that `MainThreadNeverDestroyed<>` finds the real bug. OK, found that, thanks :) 1648410 4 ysuzuki 2020-05-03 16:13:51 -0700 (In reply to Yusuke Suzuki from comment #3) > (In reply to Yusuke Suzuki from comment #2) > > (In reply to Emilio Cobos Álvarez (:emilio) from comment #1) > > > Ah, that's a MainThreadNeverDestroyed, introduced by: > > > > > > https://bugs.webkit.org/show_bug.cgi?id=211264 > > > > > > So this is a regression from that change. > > > > Could you upload the crash trace of this? If non main thread is touching > > `const AtomString` generated by `MainThreadNeverDestroyed<>`, this > > potentially means that `MainThreadNeverDestroyed<>` finds the real bug. > > OK, found that, thanks :) Looks like that patch (adding new assertions) found a GTK specific bug, which cannot be caught due to lack of GTK Debug EWS. 1648414 5 emilio 2020-05-03 16:46:35 -0700 Yes, sorry, but I pasted comment 1 in the wrong bug, should've been in bug 211355, that's why I tagged it as off-topic. 1648418 6 ysuzuki 2020-05-03 17:45:53 -0700 (In reply to Emilio Cobos Álvarez (:emilio) from comment #5) > Yes, sorry, but I pasted comment 1 in the wrong bug, should've been in bug > 211355, that's why I tagged it as off-topic. np! Thanks for reporting :D 1880043 7 tyler_w 2022-07-01 11:40:09 -0700 rdar://96305580 1905590 8 rune.lillesveen 2022-10-14 05:32:26 -0700 Given the resolution in [1], this issue is most likely a Wontfix? [1] https://github.com/w3c/csswg-drafts/issues/3257#issuecomment-1204146452