211343 2020-05-02 12:58:41 -0700 Page::editableElementsInRect() should return root editable elements 2020-05-02 14:21:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates simon.fraser webkit-bug-importer oldest_to_newest 1648267 0 dbates 2020-05-02 12:58:41 -0700 Consider a page with the following markup: <body contenteditable='true' style="margin: 0"><div style='width: 200px; height: 200px; background-color: blue'>Hello World</div></body> In the rect {10, 10, 20, 20} the <div> is hit and is editable, but Page::editableElementsInRect() return 0 elements because the <div> is not a root editable element: it is a child of a root editable element (<body>). For non form controls, Page::editableElementsInRect() is most meaningful if it returns the root editable element for each hit editable element. 1648269 1 dbates 2020-05-02 13:03:40 -0700 <rdar://problem/60015801> 1648276 2 398295 dbates 2020-05-02 13:12:55 -0700 Created attachment 398295 Patch 1648282 3 398295 dbates 2020-05-02 14:21:23 -0700 Comment on attachment 398295 Patch Clearing flags on attachment: 398295 Committed r261054: <https://trac.webkit.org/changeset/261054> 1648283 4 dbates 2020-05-02 14:21:25 -0700 All reviewed patches have been landed. Closing bug. 398295 2020-05-02 13:12:55 -0700 2020-05-02 14:21:23 -0700 Patch bug-211343-20200502131254.patch text/plain 6826 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmNWFmNzQ0YjNlOTA0 MjE4OWY4ZDhlMjRkYzVmMjIxZTU5YTZlMS4uNTkyNzQwMDA5YWI5MzU0MzJjYmM5MGI2OGI0NzRl N2ZmZmYyMmM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA1LTAyICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBQYWdlOjplZGl0YWJsZUVs ZW1lbnRzSW5SZWN0KCkgc2hvdWxkIHJldHVybiByb290IGVkaXRhYmxlIGVsZW1lbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEzNDMKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzYwMDE1ODAxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJldHVybiB0aGUgcm9vdCBlZGl0YWJsZSBlbGVtZW50IGZv ciBlYWNoIG5vbi10ZXh0IGZvcm0gY29udHJvbCBlZGl0YWJsZSBlbGVtZW50CisgICAgICAgIGlu c2lkZSB0aGUgc2VhcmNoIHJlY3QgYXMgaXQgbWF5IG5vdCBoYXZlIGJlZW4gaGl0IGl0c2VsZi4g VGhpcyBjYW4gaGFwcGVuIGlmIHRoZQorICAgICAgICBzZWFyY2ggcmVjdCBpcyBzbWFsbCBlbm91 Z2ggdG8gaW50ZXJzZWN0IG9ubHkgY2hpbGQgZWxlbWVudHMgb2YgdGhlIHJvb3QgZWRpdGFibGUK KyAgICAgICAgZWxlbWVudHMuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGFnZTo6ZWRpdGFibGVFbGVtZW50c0luUmVjdCBjb25zdCk6CisgICAgICAgIChX ZWJDb3JlOjppc0VkaXRhYmxlVGV4dElucHV0RWxlbWVudCk6IERlbGV0ZWQuCisKIDIwMjAtMDUt MDEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIHVu bmVjZXNzYXJ5IGNvcHlpbmcgaW4gQW5pbWF0aW9uVGltZWxpbmUgYW5kIG90aGVyIGNsZWFuIHVw cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggZDk3MjAxZjVjNTc5ODRkOGZhYTBkZDJjMWFlZWMwMjc0 NjExODVlOC4uYjgzNjg1NmQ1MjdlMThkZTk2Y2Y1MjdkYTg3M2ExMzQ2MzNkOTcyMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2UuY3BwCkBAIC05MTIsMTYgKzkxMiw2IEBAIHZvaWQgUGFnZTo6dW5tYXJrQWxsVGV4 dE1hdGNoZXMoKQogICAgIH0pOwogfQogCi1zdGF0aWMgYm9vbCBpc0VkaXRhYmxlVGV4dElucHV0 RWxlbWVudChjb25zdCBFbGVtZW50JiBlbGVtZW50KQotewotICAgIGlmIChpczxIVE1MVGV4dEZv cm1Db250cm9sRWxlbWVudD4oZWxlbWVudCkpIHsKLSAgICAgICAgaWYgKCFlbGVtZW50LmlzVGV4 dEZpZWxkKCkgJiYgIWlzPEhUTUxUZXh0QXJlYUVsZW1lbnQ+KGVsZW1lbnQpKQotICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwotICAgICAgICByZXR1cm4gZG93bmNhc3Q8SFRNTFRleHRGb3JtQ29u dHJvbEVsZW1lbnQ+KGVsZW1lbnQpLmlzSW5uZXJUZXh0RWxlbWVudEVkaXRhYmxlKCk7Ci0gICAg fQotICAgIHJldHVybiBlbGVtZW50LmlzUm9vdEVkaXRhYmxlRWxlbWVudCgpOwotfQotCiBWZWN0 b3I8UmVmPEVsZW1lbnQ+PiBQYWdlOjplZGl0YWJsZUVsZW1lbnRzSW5SZWN0KGNvbnN0IEZsb2F0 UmVjdCYgc2VhcmNoUmVjdEluUm9vdFZpZXdDb29yZGluYXRlcykgY29uc3QKIHsKICAgICBhdXRv IGZyYW1lVmlldyA9IG1ha2VSZWZQdHIobWFpbkZyYW1lKCkudmlldygpKTsKQEAgLTkzOCwxNiAr OTI4LDI0IEBAIFZlY3RvcjxSZWY8RWxlbWVudD4+IFBhZ2U6OmVkaXRhYmxlRWxlbWVudHNJblJl Y3QoY29uc3QgRmxvYXRSZWN0JiBzZWFyY2hSZWN0SW5SCiAgICAgaWYgKCFkb2N1bWVudC0+aGl0 VGVzdChoaXRUeXBlLCBoaXRUZXN0UmVzdWx0KSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAotICAg IFZlY3RvcjxSZWY8RWxlbWVudD4+IHJlc3VsdDsKKyAgICBhdXRvIHJvb3RFZGl0YWJsZUVsZW1l bnQgPSBbXShOb2RlJiBub2RlKSAtPiBFbGVtZW50KiB7CisgICAgICAgIGlmIChpczxIVE1MVGV4 dEZvcm1Db250cm9sRWxlbWVudD4obm9kZSkpIHsKKyAgICAgICAgICAgIGlmIChkb3duY2FzdDxI VE1MVGV4dEZvcm1Db250cm9sRWxlbWVudD4obm9kZSkuaXNJbm5lclRleHRFbGVtZW50RWRpdGFi bGUoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gJmRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpOwor ICAgICAgICB9IGVsc2UgaWYgKGlzPEVsZW1lbnQ+KG5vZGUpICYmIG5vZGUuaGFzRWRpdGFibGVT dHlsZSgpKQorICAgICAgICAgICAgcmV0dXJuIG5vZGUucm9vdEVkaXRhYmxlRWxlbWVudCgpOwor ICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9OworCisgICAgTGlzdEhhc2hTZXQ8UmVmPEVs ZW1lbnQ+PiByb290RWRpdGFibGVFbGVtZW50czsKICAgICBhdXRvJiBub2RlU2V0ID0gaGl0VGVz dFJlc3VsdC5saXN0QmFzZWRUZXN0UmVzdWx0KCk7Ci0gICAgcmVzdWx0LnJlc2VydmVJbml0aWFs Q2FwYWNpdHkobm9kZVNldC5zaXplKCkpOwogICAgIGZvciAoYXV0byYgbm9kZSA6IG5vZGVTZXQp IHsKLSAgICAgICAgaWYgKGlzPEVsZW1lbnQ+KG5vZGUpICYmIGlzRWRpdGFibGVUZXh0SW5wdXRF bGVtZW50KGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUuZ2V0KCkpKSkgewotICAgICAgICAgICAgQVNT RVJUKHNlYXJjaFJlY3RJblJvb3RWaWV3Q29vcmRpbmF0ZXMuaW50ZXJzZWN0cyhkb3duY2FzdDxF bGVtZW50Pihub2RlLmdldCgpKS5jbGllbnRSZWN0KCkpKTsKLSAgICAgICAgICAgIHJlc3VsdC51 bmNoZWNrZWRBcHBlbmQoc3RhdGljX3JlZmVyZW5jZV9jYXN0PEVsZW1lbnQ+KG5vZGUpKTsKKyAg ICAgICAgaWYgKGF1dG8qIGVkaXRhYmxlRWxlbWVudCA9IHJvb3RFZGl0YWJsZUVsZW1lbnQobm9k ZSkpIHsKKyAgICAgICAgICAgIEFTU0VSVChzZWFyY2hSZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVz LmludGVyc2VjdHMoZWRpdGFibGVFbGVtZW50LT5jbGllbnRSZWN0KCkpKTsKKyAgICAgICAgICAg IHJvb3RFZGl0YWJsZUVsZW1lbnRzLmFkZCgqZWRpdGFibGVFbGVtZW50KTsKICAgICAgICAgfQog ICAgIH0KLSAgICByZXR1cm4gcmVzdWx0OworICAgIHJldHVybiBXVEY6Om1hcChyb290RWRpdGFi bGVFbGVtZW50cywgW10oY29uc3QgYXV0byYgZWxlbWVudCkgeyByZXR1cm4gZWxlbWVudC5jb3B5 UmVmKCk7IH0pOwogfQogCiBjb25zdCBWaXNpYmxlU2VsZWN0aW9uJiBQYWdlOjpzZWxlY3Rpb24o KSBjb25zdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDJkMDhmMzRkMDdmNmMyMDRjNDQ2YzJkNjNlYzM1ZmI1NGJkMDAyMTIuLjI0MzBiMzZiYjBl YTI4YzM1MTU0ODAzYzRkOTJjOGRjZWMwNTgwMDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNS0wMiAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZTo6ZWRpdGFibGVF bGVtZW50c0luUmVjdCgpIHNob3VsZCByZXR1cm4gcm9vdCBlZGl0YWJsZSBlbGVtZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMzQzCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MDAxNTgwMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc29tZSB0ZXN0cy4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVxdWVzdFRleHRJbnB1dENvbnRleHQubW06Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMC0wNC0zMCAgRGFuaWVsIEJhdGVz ICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gSW1wbGVtZW50IC1tYXJrZWRU ZXh0UmFuZ2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvUmVxdWVzdFRleHRJbnB1dENvbnRleHQubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL1JlcXVlc3RUZXh0SW5wdXRDb250ZXh0Lm1tCmluZGV4IDU1ODZjNWEyMTUw ZDgyZTEzNTEwM2VhOTNhZDI5N2FkZDk2ZGQ4NzkuLjM2NWRiYmYzZjVmNjg1MTk0MjFjOWY4NDRk NTMzYzg4NzVhMmRmZGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvUmVxdWVzdFRleHRJbnB1dENvbnRleHQubW0KKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbQpAQCAtMjg1 LDYgKzI4NSwzMyBAQCBURVNUKFJlcXVlc3RUZXh0SW5wdXRDb250ZXh0LCBDb21wb3NpdGVkT3Zl cmxhcCkKICAgICBFWFBFQ1RfRVEoMVVMLCBjb250ZXh0cy5jb3VudCk7CiB9CiAKK1RFU1QoUmVx dWVzdFRleHRJbnB1dENvbnRleHQsIFJlY3RDb250YWluc0VkaXRhYmxlTm9uUm9vdENoaWxkKQor eworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0 V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CisgICAgW3dlYlZpZXcgc3lu Y2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOmFwcGx5U3R5bGUoQCI8Ym9keSBjb250ZW50ZWRpdGFi bGU9J3RydWUnIHN0eWxlPSd3aWR0aDogNTAwcHg7IGhlaWdodDogNTAwcHgnPjxkaXYgc3R5bGU9 J3dpZHRoOiAyMDBweDsgaGVpZ2h0OiAyMDBweDsgYmFja2dyb3VuZC1jb2xvcjogYmx1ZSc+SGVs bG8gV29ybGQ8L2Rpdj48L2JvZHk+IildOworICAgIE5TQXJyYXk8X1dLVGV4dElucHV0Q29udGV4 dCAqPiAqY29udGV4dHMgPSBbd2ViVmlldyBzeW5jaHJvbm91c2x5UmVxdWVzdFRleHRJbnB1dENv bnRleHRzSW5SZWN0OkNHUmVjdE1ha2UoMTAsIDEwLCAyMCwgMjApXTsKKyAgICBFWFBFQ1RfRVEo MVVMLCBjb250ZXh0cy5jb3VudCk7CisgICAgRVhQRUNUX0VRKENHUmVjdE1ha2UoMCwgMCwgNTAw LCA1MDApLCBjb250ZXh0c1swXS5ib3VuZGluZ1JlY3QpOworfQorCitURVNUKFJlcXVlc3RUZXh0 SW5wdXRDb250ZXh0LCBSZWN0Q29udGFpbnNOZXN0ZWRFZGl0YWJsZU5vblJvb3RDaGlsZCkKK3sK KyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdp dGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOworICAgIFt3ZWJWaWV3IHN5bmNo cm9ub3VzbHlMb2FkSFRNTFN0cmluZzphcHBseVN0eWxlKEAiPGJvZHkgY29udGVudGVkaXRhYmxl PSd0cnVlJyBzdHlsZT0nd2lkdGg6IDUwMHB4OyBoZWlnaHQ6IDUwMHB4Jz48ZGl2IHN0eWxlPSd3 aWR0aDogMjAwcHg7IGhlaWdodDogMjAwcHg7IGJhY2tncm91bmQtY29sb3I6IGJsdWUnPjxkaXYg c3R5bGU9J3dpZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBweDsgYmFja2dyb3VuZC1jb2xvcjogeWVs bG93JyBjb250ZW50ZWRpdGFibGU9J3RydWUnPkhlbGxvIFdvcmxkPC9kaXY+PC9kaXY+PC9ib2R5 PiIpXTsKKyAgICBOU0FycmF5PF9XS1RleHRJbnB1dENvbnRleHQgKj4gKmNvbnRleHRzID0gW3dl YlZpZXcgc3luY2hyb25vdXNseVJlcXVlc3RUZXh0SW5wdXRDb250ZXh0c0luUmVjdDpDR1JlY3RN YWtlKDEwLCAxMCwgMjAsIDIwKV07CisgICAgRVhQRUNUX0VRKDFVTCwgY29udGV4dHMuY291bnQp OworICAgIEVYUEVDVF9FUShDR1JlY3RNYWtlKDAsIDAsIDUwMCwgNTAwKSwgY29udGV4dHNbMF0u Ym91bmRpbmdSZWN0KTsKK30KKworVEVTVChSZXF1ZXN0VGV4dElucHV0Q29udGV4dCwgUmVjdENv bnRhaW5zSW5uZXJFZGl0YWJsZU5vblJvb3RDaGlsZCkKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSBh ZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAs IDAsIDgwMCwgNjAwKV0pOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmlu ZzphcHBseVN0eWxlKEAiPGJvZHkgY29udGVudGVkaXRhYmxlPSd0cnVlJyBzdHlsZT0nd2lkdGg6 IDUwMHB4OyBoZWlnaHQ6IDUwMHB4Jz48ZGl2IHN0eWxlPSd3aWR0aDogMjAwcHg7IGhlaWdodDog MjAwcHg7IGJhY2tncm91bmQtY29sb3I6IGJsdWUnIGNvbnRlbnRlZGl0YWJsZT0nZmFsc2UnPjxk aXYgc3R5bGU9J3dpZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBweDsgYmFja2dyb3VuZC1jb2xvcjog eWVsbG93JyBjb250ZW50ZWRpdGFibGU9J3RydWUnPkhlbGxvIFdvcmxkPC9kaXY+PC9kaXY+PHA+ Qm9keTwvcD48L2JvZHk+IildOworICAgIE5TQXJyYXk8X1dLVGV4dElucHV0Q29udGV4dCAqPiAq Y29udGV4dHMgPSBbd2ViVmlldyBzeW5jaHJvbm91c2x5UmVxdWVzdFRleHRJbnB1dENvbnRleHRz SW5SZWN0OkNHUmVjdE1ha2UoMTAsIDEwLCAyMCwgMjApXTsKKyAgICBFWFBFQ1RfRVEoMVVMLCBj b250ZXh0cy5jb3VudCk7CisgICAgRVhQRUNUX0VRKENHUmVjdE1ha2UoMCwgMCwgMTAwLCAxMDAp LCBjb250ZXh0c1swXS5ib3VuZGluZ1JlY3QpOworfQorCiBURVNUKFJlcXVlc3RUZXh0SW5wdXRD b250ZXh0LCBSZWFkT25seUZpZWxkKQogewogICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IGFkb3B0 TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7Cg==