211340 2020-05-02 09:22:10 -0700 editing/undo-manager/undo-manager-delete-stale-undo-items.html is timing out. 2020-05-02 23:20:19 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 211328 1 mark.lam mark.lam cdumez ddkilzer webkit-bug-importer wenson_hsieh oldest_to_newest 1648247 0 mark.lam 2020-05-02 09:22:10 -0700 editing/undo-manager/undo-manager-delete-stale-undo-items.html is always timing out. I'm seeing this with r261048 on WebKit trunk. 1648248 1 webkit-bug-importer 2020-05-02 09:22:29 -0700 <rdar://problem/62767874> 1648313 2 398305 mark.lam 2020-05-02 23:16:06 -0700 Created attachment 398305 proposed patch. 1648314 3 mark.lam 2020-05-02 23:19:03 -0700 Thanks for the review. Landed in r261058: <http://trac.webkit.org/r261058>. 398305 2020-05-02 23:16:06 -0700 2020-05-02 23:16:47 -0700 proposed patch. bug-211340.patch text/plain 3949 mark.lam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2MTA1NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDIwLTA1LTAyICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBlZGl0aW5nL3VuZG8tbWFuYWdlci91bmRvLW1hbmFn ZXItZGVsZXRlLXN0YWxlLXVuZG8taXRlbXMuaHRtbCBpcyB0aW1pbmcgb3V0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMzQwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82Mjc2Nzg3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgdGVzdCBhaW1zIHRvIG1lYXN1cmUgdGhlIG51bWJlciBvZiBH QydlZCBVbmRvIHJlbGF0ZWQgb2JqZWN0cy4gIEl0IGNyZWF0ZWQKKyAgICAgICAgYW5kIGVzdGlt YXRlZCA2MDAgb2JqZWN0cyBhbmQgYWxsb3dzIGFuIGVycm9yIG9mIDIwIG9iamVjdHMgYWZ0ZXIg R0MgaXMgZXhwZWN0ZWQKKyAgICAgICAgdG8gaGF2ZSBjb2xsZWN0ZWQgdGhlc2Ugb2JqZWN0cy4g IFRoaXMgdHVybnMgb3V0IHRvIGJlIHRvbyB0aWdodCBhbiBlcnJvciBhbGxvd2FuY2UuCisgICAg ICAgIEp1c3QgcnVubmluZyBhbnkgSlMgY29kZSBjb3VsZCBpbmFkdmVydGFudGx5IGNyZWF0ZSBt b3JlIG9iamVjdHMsIHRoYXQgd2lsbCBleGNlZWQKKyAgICAgICAgdGhhdCBlcnJvciBhbGxvd2Fu Y2UuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhdHRlbXB0cyB0byBtYWtlIHRoZSB0ZXN0IG1vcmUg cm9idXN0IGJ5IGluY3JlYXNpbmcgdGhlIGNyZWF0ZWQgb2JqZWN0CisgICAgICAgIGNvdW50IHRv IGFuIGVzdGltYXRlZCAzMDAwIG9iamVjdHMgYW5kIGFsbG93cyBhbiBlcnJvciBvZiAzMDAgb2Jq ZWN0cy4gIFRoaXMgbWVhbnMKKyAgICAgICAgd2UnbGwgZXhwZWN0IHRvIHNlZSBhdCBsZWFzdCAy NzAwIG9iamVjdHMgY29sbGVjdGVkLiAgVGhhdCBpcyBhIGhpZ2ggZW5vdWdoIG51bWJlcgorICAg ICAgICB0aGF0IGl0IGNhbm5vdCBiZSBhdHRyaWJ1dGVkIHRvIHVuZXhwZWN0ZWQgb2JqZWN0cyBj cmVhdGVkIGJ5IHRoZSBKUyBydW50aW1lIGJlaW5nCisgICAgICAgIEdDZWQuICBUaGUgYWxsb3dh bmNlIG9mIDMwMCBpcyBhbHNvIG11Y2ggaGlnaGVyIHRoYW4gbnVtYmVyIG9mIHVuZXhwZWN0ZWQg b2JqZWN0cworICAgICAgICB0aGF0IHRoZSBKUyBydW50aW1lIG1heSByZWFzb25hYmx5IGNyZWF0 ZSBiZXlvbmQgdGhvc2UgbWFuYWdlZCBieSB0aGlzIHRlc3QuCisKKyAgICAgICAgV2l0aCB0aGlz IGNoYW5nZSwgdGhlIHRlc3Qgbm8gbG9uZ2VyIHRpbWVzIG91dC4KKworICAgICAgICAqIGVkaXRp bmcvdW5kby1tYW5hZ2VyL3VuZG8tbWFuYWdlci1kZWxldGUtc3RhbGUtdW5kby1pdGVtcy1leHBl Y3RlZC50eHQ6CisgICAgICAgICogZWRpdGluZy91bmRvLW1hbmFnZXIvdW5kby1tYW5hZ2VyLWRl bGV0ZS1zdGFsZS11bmRvLWl0ZW1zLmh0bWw6CisKIDIwMjAtMDUtMDIgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byB0 ZXN0IG92ZXJsYXkgc2Nyb2xsYmFyIGludGVyYWN0aW9ucwpJbmRleDogTGF5b3V0VGVzdHMvZWRp dGluZy91bmRvLW1hbmFnZXIvdW5kby1tYW5hZ2VyLWRlbGV0ZS1zdGFsZS11bmRvLWl0ZW1zLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8tbWFuYWdl ci91bmRvLW1hbmFnZXItZGVsZXRlLXN0YWxlLXVuZG8taXRlbXMtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAyNjEwNTcpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8tbWFuYWdlci91bmRvLW1h bmFnZXItZGVsZXRlLXN0YWxlLXVuZG8taXRlbXMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0zLDcgKzMsNyBAQCBWZXJpZmllcyB0aGF0IEpTVW5kb0l0ZW1zIGFyZSBkZWxldGVkIHdo CiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAotUEFTUyBvYmplY3RDb3VudEJlZm9yZUNs ZWFyaW5nVW5kb1N0YWNrIC0gb2JqZWN0Q291bnRBZnRlckNsZWFyaW5nVW5kb1N0YWNrIGlzID49 IDU4MAorUEFTUyBvYmplY3RDb3VudEJlZm9yZUNsZWFyaW5nVW5kb1N0YWNrIC0gb2JqZWN0Q291 bnRBZnRlckNsZWFyaW5nVW5kb1N0YWNrIGlzID49IDI3MDAKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy91 bmRvLW1hbmFnZXIvdW5kby1tYW5hZ2VyLWRlbGV0ZS1zdGFsZS11bmRvLWl0ZW1zLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvLW1hbmFnZXIvdW5kby1tYW5hZ2Vy LWRlbGV0ZS1zdGFsZS11bmRvLWl0ZW1zLmh0bWwJKHJldmlzaW9uIDI2MTA1NykKKysrIExheW91 dFRlc3RzL2VkaXRpbmcvdW5kby1tYW5hZ2VyL3VuZG8tbWFuYWdlci1kZWxldGUtc3RhbGUtdW5k by1pdGVtcy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw3ICsyMyw3IEBACiAgICAgICAgICAg ICBlZGl0b3IgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZWRpdG9yIik7CiAgICAgICAgICAg ICBlZGl0b3IuZm9jdXMoKTsKIAotICAgICAgICAgICAgY29uc3QgdW5kb0l0ZW1Db3VudCA9IDIw MDsKKyAgICAgICAgICAgIGNvbnN0IHVuZG9JdGVtQ291bnQgPSAxMDAwOwogCiAgICAgICAgICAg ICBmb3IgKGxldCBpID0gMDsgaSA8IHVuZG9JdGVtQ291bnQ7ICsraSkgewogICAgICAgICAgICAg ICAgIGRvY3VtZW50LnVuZG9NYW5hZ2VyLmFkZEl0ZW0obmV3IFVuZG9JdGVtKHsKQEAgLTQ2LDcg KzQ2LDcgQEAKICAgICAgICAgICAgIC8vIHNvbWUgd2lnZ2xlIHJvb20gZm9yIGFkZGl0aW9uYWwg d3JhcHBlcnMgY3JlYXRlZCB3aGVuIGNhbGxpbmcgc29tZSB0ZXN0aW5nIGhlbHBlciBmdW5jdGlv bnMuIFRoaXMgaXMKICAgICAgICAgICAgIC8vIHN0aWxsIGEgdXNlZnVsIHRlc3QsIHNpbmNlIGl0 IHdpbGwgdGltZSBvdXQgaW4gdGhlIGNhc2Ugd2hlcmUgZWl0aGVyIG91ciB1bmRvIGl0ZW1zIG9y IHRoZWlyIHVuZG8vcmVkbwogICAgICAgICAgICAgLy8gaGFuZGxlcnMgYXJlIG5vdCBwcm9wZXJs eSByZWxpbnF1aXNoZWQgb25jZSB0aGV5J3JlIG5vIGxvbmdlciBuZWVkZWQuCi0gICAgICAgICAg ICBjb25zdCBtaW5pbXVtTnVtYmVyT2ZXcmFwcGVyc1RvQ29sbGVjdEJlZm9yZVBhc3NpbmcgPSAz ICogdW5kb0l0ZW1Db3VudCAtIDIwOworICAgICAgICAgICAgY29uc3QgbWluaW11bU51bWJlck9m V3JhcHBlcnNUb0NvbGxlY3RCZWZvcmVQYXNzaW5nID0gMyAqIHVuZG9JdGVtQ291bnQgLSAzMDA7 CiAgICAgICAgICAgICBvYmplY3RDb3VudEFmdGVyQ2xlYXJpbmdVbmRvU3RhY2sgPSBvYmplY3RD b3VudEJlZm9yZUNsZWFyaW5nVW5kb1N0YWNrOwogICAgICAgICAgICAgd2hpbGUgKG9iamVjdENv dW50QmVmb3JlQ2xlYXJpbmdVbmRvU3RhY2sgLSBvYmplY3RDb3VudEFmdGVyQ2xlYXJpbmdVbmRv U3RhY2sgPCBtaW5pbXVtTnVtYmVyT2ZXcmFwcGVyc1RvQ29sbGVjdEJlZm9yZVBhc3NpbmcpIHsK ICAgICAgICAgICAgICAgICBhd2FpdCBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHNldFRpbWVvdXQo cmVzb2x2ZSwgMTAwKSk7Cg==