211327 2020-05-01 17:52:40 -0700 Web Inspector: Timelines: Memory: the stacked area graph should not extend beyond the "stopping time" marker 2020-05-05 14:01:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1648161 0 hi 2020-05-01 17:52:40 -0700 # STEPS TO REPRODUCE 1. inspect any super busy page (preferably using a debug build) 2. enable the Memory timeline 3. start a recording 4. do a bunch of stuff to enqueue a bunch of records 5. stop the active timeline recording => take note of the "stopping time" marker 6. wait for the active timeline recording to actually stop => the memory graph continues beyond the "stopping time" marker all the way to the "current time" marker 1648168 1 398268 hi 2020-05-01 18:21:48 -0700 Created attachment 398268 Patch 1649364 2 398268 bburg 2020-05-05 13:58:15 -0700 Comment on attachment 398268 Patch rs=me 1649366 3 ews-feeder 2020-05-05 14:00:58 -0700 Committed r261197: <https://trac.webkit.org/changeset/261197> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398268. 1649367 4 webkit-bug-importer 2020-05-05 14:01:16 -0700 <rdar://problem/62902384> 398268 2020-05-01 18:21:48 -0700 2020-05-05 14:00:58 -0700 Patch bug-211327-20200501192148.patch text/plain 2272 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDljYTc1ZTViYWFmMGNhOTZmYzY4MDI5OTZjOWQ3 YjhlYjY2NzhmODAuLjNmNjBhOTg3MDVkZjA5Njg0NzI0MmI4N2JmOTliYWNlNDliZjE0MjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTAxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBU aW1lbGluZXM6IE1lbW9yeTogdGhlIHN0YWNrZWQgYXJlYSBncmFwaCBzaG91bGQgbm90IGV4dGVu ZCBiZXlvbmQgdGhlICJzdG9wcGluZyB0aW1lIiBtYXJrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTMyNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9NZW1vcnlU aW1lbGluZU92ZXJ2aWV3R3JhcGguanM6CisgICAgICAgIChXSS5NZW1vcnlUaW1lbGluZU92ZXJ2 aWV3R3JhcGgucHJvdG90eXBlLmxheW91dCk6CisgICAgICAgIChXSS5NZW1vcnlUaW1lbGluZU92 ZXJ2aWV3R3JhcGgucHJvdG90eXBlLmxheW91dC5pbnNlcnREaXNjb250aW51aXR5KToKKwogMjAy MC0wNC0zMCAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBDb21wdXRlZDogc2hvdWxkbid0IGRpc3BsYXkgZm9jdXMgb3V0bGlu ZSBvbiBjbGljawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTWVtb3J5VGltZWxpbmVPdmVydmlld0dyYXBoLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWVtb3J5VGltZWxpbmVPdmVydmlld0dyYXBoLmpz CmluZGV4IDQwYmMxYjI1OTg3NWY4NjBjZDJhNDYzNjc0ZDkzNmQwNzU3MzQxNTYuLjA1MWFlNTEz NDExM2ZkY2QyMTUyNzQ0MjA5OGM4MWEyN2I3MTQzOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9yeVRpbWVsaW5lT3ZlcnZpZXdHcmFw aC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9NZW1v cnlUaW1lbGluZU92ZXJ2aWV3R3JhcGguanMKQEAgLTE2NSw3ICsxNjUsNyBAQCBXSS5NZW1vcnlU aW1lbGluZU92ZXJ2aWV3R3JhcGggPSBjbGFzcyBNZW1vcnlUaW1lbGluZU92ZXJ2aWV3R3JhcGgg ZXh0ZW5kcyBXSS5UaQogICAgICAgICAgICAgaWYgKCEocHJldmlvdXNSZWNvcmQgfHwgbmV4dFJl Y29yZCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgICAgICBsZXQgeFN0YXJ0 ID0geFNjYWxlKHN0YXJ0RGlzY29udGludWl0eS5zdGFydFRpbWUpOworICAgICAgICAgICAgbGV0 IHhTdGFydCA9IHhTY2FsZShwcmV2aW91c1JlY29yZCA/IHByZXZpb3VzUmVjb3JkLmVuZFRpbWUg OiBzdGFydERpc2NvbnRpbnVpdHkuc3RhcnRUaW1lKTsKICAgICAgICAgICAgIGxldCB4RW5kID0g eFNjYWxlKGVuZERpc2NvbnRpbnVpdHkuZW5kVGltZSk7CiAKICAgICAgICAgICAgIC8vIEV4dGVu ZCB0aGUgcHJldmlvdXMgcmVjb3JkIHRvIHRoZSBzdGFydCBvZiB0aGUgZGlzY29udGludWl0eS4K QEAgLTIwOCw3ICsyMDgsNyBAQCBXSS5NZW1vcnlUaW1lbGluZU92ZXJ2aWV3R3JhcGggPSBjbGFz cyBNZW1vcnlUaW1lbGluZU92ZXJ2aWV3R3JhcGggZXh0ZW5kcyBXSS5UaQogICAgICAgICAgICAg Ly8gRXh0ZW5kIHRoZSBsYXN0IHZhbHVlIHRvIGN1cnJlbnQgLyBlbmQgdGltZS4KICAgICAgICAg ICAgIGxldCBsYXN0UmVjb3JkID0gdmlzaWJsZVJlY29yZHMubGFzdFZhbHVlOwogICAgICAgICAg ICAgaWYgKGxhc3RSZWNvcmQuc3RhcnRUaW1lIDw9IHZpc2libGVFbmRUaW1lKSB7Ci0gICAgICAg ICAgICAgICAgbGV0IHggPSBNYXRoLmZsb29yKHhTY2FsZSh2aXNpYmxlRW5kVGltZSkpOworICAg ICAgICAgICAgICAgIGxldCB4ID0gTWF0aC5mbG9vcih4U2NhbGUobGFzdFJlY29yZC5lbmRUaW1l KSk7CiAgICAgICAgICAgICAgICAgdGhpcy5fY2hhcnQuYWRkUG9pbnRTZXQoeCwgcG9pbnRTZXRG b3JSZWNvcmQobGFzdFJlY29yZCkpOwogICAgICAgICAgICAgfQogICAgICAgICB9Cg==