211319 2020-05-01 13:42:16 -0700 Add a test for webkit.org/b/211311 2020-05-01 16:12:12 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin darin megan_gardner thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1648029 0 wenson_hsieh 2020-05-01 13:42:16 -0700 SSIA 1648031 1 wenson_hsieh 2020-05-01 13:46:35 -0700 Test for rdar://62663459 1648044 2 398235 wenson_hsieh 2020-05-01 14:05:52 -0700 Created attachment 398235 Patch 1648051 3 398235 darin 2020-05-01 14:10:33 -0700 Comment on attachment 398235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398235&action=review > Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100 > + virtual void didLoadURL(WKView *wkView) { } I don’t understand this. Is this just the way to write a legacy-WebKit-only test? 1648053 4 wenson_hsieh 2020-05-01 14:12:56 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 398235 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398235&action=review > > > Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100 > > + virtual void didLoadURL(WKView *wkView) { } > > I don’t understand this. Is this just the way to write a legacy-WebKit-only > test? It isn’t the only way to test WebKitLegacy, but it’s the way these other attributed string tests in this file work, so I decided to go with the existing pattern. 1648133 5 ews-feeder 2020-05-01 16:12:11 -0700 Committed r261037: <https://trac.webkit.org/changeset/261037> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398235. 398235 2020-05-01 14:05:52 -0700 2020-05-01 16:12:12 -0700 Patch bug-211319-20200501140551.patch text/plain 7207 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGNiODMxZDhlZTMyN2Y1MTYyZWNkMTYxMDVkMmJhMDA3 NWUwZjllNC4uNjVmMTZjMjkzYjU5NzQwM2MxYWQ1YWU5ZGMwNzVkZWZkZThmOWJjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA1LTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBhIHRlc3QgZm9yIHdlYmtpdC5vcmcvYi8yMTEzMTEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTMxOQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNjI2NjM0NTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRXhlcmNpc2UgdGhlIGNyYXNoIGZpeGVkIGluIHIyNjEwMTcgd2l0aCBh IG5ldyBBUEkgdGVzdCB0aGF0IGxvYWRzIGEgcGFnZSBhbmQgdGhlbiB1c2VzCisgICAgICAgIGAt W1dlYkhUTUxWaWV3IGF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2U6XWAgdG8gdHJ5IGFuZCBn cmFiIHRoZSBjb250ZW50cyBvZiB0aGUgcGFnZSBhcyBhbiBhdHRyaWJ1dGVkIHN0cmluZy4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL0F0dHJpYnV0ZWRTdHJp bmcubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpBdHRyaWJ1dGVkU3RyaW5nVGVzdF9OZXds aW5lQXRFbmRPZkRvY3VtZW50OjpkaWRMb2FkVVJMKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6 OkF0dHJpYnV0ZWRTdHJpbmdUZXN0X05ld2xpbmVBdEVuZE9mRG9jdW1lbnQ6OnVybCBjb25zdCk6 CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpBdHRyaWJ1dGVkU3RyaW5nVGVzdF9OZXdsaW5lQXRF bmRPZkRvY3VtZW50OjpydW5TeW5jVGVzdCk6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0 cy9tYWMvYXR0cmlidXRlZFN0cmluZ05ld2xpbmVBdEVuZE9mRG9jdW1lbnQuaHRtbDogQWRkZWQu CisKIDIwMjAtMDQtMzAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBUZXN0V2ViS2l0QVBJLldlYktpdC5EZWZhdWx0RGlzcGxheU5hbWUgYW5k IFRlc3RXZWJLaXRBUEkuV2ViS2l0LkN1c3RvbURpc3BsYXlOYW1lIGFyZSBmbGFreSBmYWlsdXJl cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJv ai9wcm9qZWN0LnBieHByb2ogYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCA3MzEyOTU0ODBjN2E3NWM5YjlmNmYxOGNlNGVm NmE2ZmU4MDZmYmY5Li5kOGZjYzA0ZDRhNzA4MzU1ODk2NmQ3NjYwODhlOTZhNjY0MDQyNzEzIDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvagorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMTA1MSw2ICsxMDUxLDcgQEAKIAkJRjQxQUI5QUEx RUY0Njk2QjAwODNGQTA4IC8qIHRleHRhcmVhLXRvLWlucHV0Lmh0bWwgaW4gQ29weSBSZXNvdXJj ZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gRjQxQUI5OTUxRUY0NjkyQzAw ODNGQTA4IC8qIHRleHRhcmVhLXRvLWlucHV0Lmh0bWwgKi87IH07CiAJCUY0MjJBM0U5MjM1QUNB OUIwMENGMDBDQSAvKiBDbGlwYm9hcmRUZXN0cy5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBC WEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEY0MjJBM0U4MjM1QUNBOUIwMENGMDBDQSAvKiBDbGlwYm9h cmRUZXN0cy5tbSAqLzsgfTsKIAkJRjQyMkEzRUIyMzVCQjE2MjAwQ0YwMENBIC8qIGNsaXBib2Fy ZC5odG1sIGluIENvcHkgUmVzb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJl ZiA9IEY0MjJBM0VBMjM1QkIxNDUwMENGMDBDQSAvKiBjbGlwYm9hcmQuaHRtbCAqLzsgfTsKKwkJ RjQyQkQ3RDkyNDVDQzUwODAwMUUyMDdBIC8qIGF0dHJpYnV0ZWRTdHJpbmdOZXdsaW5lQXRFbmRP ZkRvY3VtZW50Lmh0bWwgaW4gQ29weSBSZXNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxl OyBmaWxlUmVmID0gRjQyQkQ3RDgyNDVDQzRFNjAwMUUyMDdBIC8qIGF0dHJpYnV0ZWRTdHJpbmdO ZXdsaW5lQXRFbmRPZkRvY3VtZW50Lmh0bWwgKi87IH07CiAJCUY0MkQ2MzQ0MjJBMTcyOUYwMEQy RkIzQSAvKiBBdXRvY29ycmVjdGlvblRlc3RzSU9TLm1tIGluIFNvdXJjZXMgKi8gPSB7aXNhID0g UEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gRjQyRDYzNDMyMkExNzI5RjAwRDJGQjNBIC8qIEF1dG9j b3JyZWN0aW9uVGVzdHNJT1MubW0gKi87IH07CiAJCUY0MkRBNTE2MUQ4Q0VGRTQwMDMzNkY0MCAv KiBsYXJnZS1pbnB1dC1maWVsZC1mb2N1cy1vbmxvYWQuaHRtbCBpbiBDb3B5IFJlc291cmNlcyAq LyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBGNDJEQTUxNTFEOENFRkRCMDAzMzZG NDAgLyogbGFyZ2UtaW5wdXQtZmllbGQtZm9jdXMtb25sb2FkLmh0bWwgKi87IH07CiAJCUY0MzRD QTFBMjJFNjVCQ0EwMDVEREIyNiAvKiBTY3JvbGxUb1JldmVhbFNlbGVjdGlvbi5tbSBpbiBTb3Vy Y2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEY0MzRDQTE5MjJFNjVCQ0Ew MDVEREIyNiAvKiBTY3JvbGxUb1JldmVhbFNlbGVjdGlvbi5tbSAqLzsgfTsKQEAgLTEyMjcsNiAr MTIyOCw3IEBACiAJCQkJMTFDMjU5OEQyMUZBNjMyNDAwNEM5RTIzIC8qIGFzeW5jLXNjcmlwdC1s b2FkLmh0bWwgaW4gQ29weSBSZXNvdXJjZXMgKi8sCiAJCQkJRjQ4NTZDQTMxRTY0OUVBODAwOUQ3 RUU3IC8qIGF0dGFjaG1lbnQtZWxlbWVudC5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJ CUI1NUYxMUI3MTUxN0QwMzMwMDkxNTkxNiAvKiBhdHRyaWJ1dGVkU3RyaW5nQ3VzdG9tRm9udC5o dG1sIGluIENvcHkgUmVzb3VyY2VzICovLAorCQkJCUY0MkJEN0Q5MjQ1Q0M1MDgwMDFFMjA3QSAv KiBhdHRyaWJ1dGVkU3RyaW5nTmV3bGluZUF0RW5kT2ZEb2N1bWVudC5odG1sIGluIENvcHkgUmVz b3VyY2VzICovLAogCQkJCTdDOUVEOThCMTdBMTlGNEIwMEU0REMzMyAvKiBhdHRyaWJ1dGVkU3Ry aW5nU3RyaWtldGhyb3VnaC5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJCTM3MTM3RTRC MjExMjREMDEwMDJCRUVBNCAvKiBBdHRyU3R5bGUuaHRtbCBpbiBDb3B5IFJlc291cmNlcyAqLywK IAkJCQlDRDlFMjkyRTFDOTBDMzNGMDAwQkI4MDAgLyogYXVkaW8tb25seS5odG1sIGluIENvcHkg UmVzb3VyY2VzICovLApAQCAtMjY4MCw2ICsyNjgyLDcgQEAKIAkJRjQxQUI5OUUxRUY0NjkyQzAw ODNGQTA4IC8qIGRpdi1hbmQtbGFyZ2UtaW1hZ2UuaHRtbCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVm ZXJlbmNlOyBsYXN0S25vd25GaWxlVHlwZSA9IHRleHQuaHRtbDsgcGF0aCA9ICJkaXYtYW5kLWxh cmdlLWltYWdlLmh0bWwiOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGNDIyQTNFODIz NUFDQTlCMDBDRjAwQ0EgLyogQ2xpcGJvYXJkVGVzdHMubW0gKi8gPSB7aXNhID0gUEJYRmlsZVJl ZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5vYmpjcHA7IHBhdGgg PSBDbGlwYm9hcmRUZXN0cy5tbTsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJRjQyMkEz RUEyMzVCQjE0NTAwQ0YwMENBIC8qIGNsaXBib2FyZC5odG1sICovID0ge2lzYSA9IFBCWEZpbGVS ZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gdGV4dC5odG1s OyBwYXRoID0gY2xpcGJvYXJkLmh0bWw7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCUY0 MkJEN0Q4MjQ1Q0M0RTYwMDFFMjA3QSAvKiBhdHRyaWJ1dGVkU3RyaW5nTmV3bGluZUF0RW5kT2ZE b2N1bWVudC5odG1sICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGxhc3RLbm93bkZpbGVU eXBlID0gdGV4dC5odG1sOyBwYXRoID0gYXR0cmlidXRlZFN0cmluZ05ld2xpbmVBdEVuZE9mRG9j dW1lbnQuaHRtbDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJRjQyRDYzNDMyMkExNzI5 RjAwRDJGQjNBIC8qIEF1dG9jb3JyZWN0aW9uVGVzdHNJT1MubW0gKi8gPSB7aXNhID0gUEJYRmls ZVJlZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5vYmpjcHA7IHBh dGggPSBBdXRvY29ycmVjdGlvblRlc3RzSU9TLm1tOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9 OwogCQlGNDJEQTUxNTFEOENFRkRCMDAzMzZGNDAgLyogbGFyZ2UtaW5wdXQtZmllbGQtZm9jdXMt b25sb2FkLmh0bWwgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0g NDsgbGFzdEtub3duRmlsZVR5cGUgPSB0ZXh0Lmh0bWw7IG5hbWUgPSAibGFyZ2UtaW5wdXQtZmll bGQtZm9jdXMtb25sb2FkLmh0bWwiOyBwYXRoID0gIlRlc3RzL1dlYktpdENvY29hL2xhcmdlLWlu cHV0LWZpZWxkLWZvY3VzLW9ubG9hZC5odG1sIjsgc291cmNlVHJlZSA9IFNPVVJDRV9ST09UOyB9 OwogCQlGNDM0Q0ExOTIyRTY1QkNBMDA1RERCMjYgLyogU2Nyb2xsVG9SZXZlYWxTZWxlY3Rpb24u bW0gKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3Vy Y2Vjb2RlLmNwcC5vYmpjcHA7IHBhdGggPSBTY3JvbGxUb1JldmVhbFNlbGVjdGlvbi5tbTsgc291 cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKQEAgLTQyNDMsNiArNDI0Niw3IEBACiAJCQkJMzc5MDI4 QjgxNEZBQkU0OTAwN0U2QjQzIC8qIGFjY2VwdHNGaXJzdE1vdXNlLmh0bWwgKi8sCiAJCQkJNzI1 QzNFRjIyMjA1ODRCQTAwN0MzNkZDIC8qIEFkZGl0aW9uYWxTdXBwb3J0ZWRJbWFnZVR5cGVzLmh0 bWwgKi8sCiAJCQkJQjU1RjExQjAxNTE3QTJDNDAwOTE1OTE2IC8qIGF0dHJpYnV0ZWRTdHJpbmdD dXN0b21Gb250Lmh0bWwgKi8sCisJCQkJRjQyQkQ3RDgyNDVDQzRFNjAwMUUyMDdBIC8qIGF0dHJp YnV0ZWRTdHJpbmdOZXdsaW5lQXRFbmRPZkRvY3VtZW50Lmh0bWwgKi8sCiAJCQkJN0M5RUQ5OEEx N0ExOUQwNjAwRTREQzMzIC8qIGF0dHJpYnV0ZWRTdHJpbmdTdHJpa2V0aHJvdWdoLmh0bWwgKi8s CiAJCQkJMjZERjVBNjExNUEyQTIyQjAwMzY4OUMyIC8qIENhbmNlbExvYWRGcm9tUmVzb3VyY2VM b2FkRGVsZWdhdGUuaHRtbCAqLywKIAkJCQk1MTQyQjI3MjE1MTdDODkxMDBDMzJCMTkgLyogQ29u dGV4dE1lbnVDYW5Db3B5VVJMLmh0bWwgKi8sCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL21hYy9BdHRyaWJ1dGVkU3RyaW5nLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9tYWMvQXR0cmlidXRlZFN0cmluZy5tbQppbmRleCBmN2ZiZDk1ZmIwNDA0MWQzMDEwOTcy ODA3MjQ2ODdlOGFhNDRlNDg4Li5hMzY3MzNhMDVhOGIxMTI3ZGY3OGZkMzdjYjg2NGI5ZTlmZmJm ZjFlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9BdHRyaWJ1dGVk U3RyaW5nLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL0F0dHJpYnV0ZWRT dHJpbmcubW0KQEAgLTkyLDQgKzkyLDI1IEBAIFRFU1RfRihBdHRyaWJ1dGVkU3RyaW5nVGVzdF9T dHJpa2V0aHJvdWdoLCBXZWJLaXQpCiAgICAgcnVuV2ViS2l0MVRlc3QoKTsKIH0KIAorY2xhc3Mg QXR0cmlidXRlZFN0cmluZ1Rlc3RfTmV3bGluZUF0RW5kT2ZEb2N1bWVudCA6IHB1YmxpYyBXZWJL aXRBZ25vc3RpY1Rlc3QgeworcHVibGljOgorICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBWaWV3PiB2 b2lkIHJ1blN5bmNUZXN0KFZpZXcpOworCisgICAgdmlydHVhbCB2b2lkIGRpZExvYWRVUkwoV2Vi VmlldyAqd2ViVmlldykgeyBydW5TeW5jVGVzdCh3ZWJWaWV3KTsgfQorICAgIHZpcnR1YWwgdm9p ZCBkaWRMb2FkVVJMKFdLVmlldyAqd2tWaWV3KSB7IH0KKworICAgIHZpcnR1YWwgTlNVUkwgKnVy bCgpIGNvbnN0IHsgcmV0dXJuIFtbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6 QCJhdHRyaWJ1dGVkU3RyaW5nTmV3bGluZUF0RW5kT2ZEb2N1bWVudCIgd2l0aEV4dGVuc2lvbjpA Imh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3VyY2VzIl07IH0KK307CisK K3RlbXBsYXRlIDx0eXBlbmFtZSBWaWV3Pgordm9pZCBBdHRyaWJ1dGVkU3RyaW5nVGVzdF9OZXds aW5lQXRFbmRPZkRvY3VtZW50OjpydW5TeW5jVGVzdChWaWV3IHZpZXcpCit7CisgICAgRVhQRUNU X1dLX1NUUkVRKCJhXG4iLCBhdHRyaWJ1dGVkU3RyaW5nKHZpZXcsIE5TTWFrZVJhbmdlKDAsIDIp KS5zdHJpbmcpOworfQorCitURVNUX0YoQXR0cmlidXRlZFN0cmluZ1Rlc3RfTmV3bGluZUF0RW5k T2ZEb2N1bWVudCwgV2ViS2l0KQoreworICAgIHJ1bldlYktpdDFUZXN0KCk7Cit9CisKIH0gLy8g bmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvbWFjL2F0dHJpYnV0ZWRTdHJpbmdOZXdsaW5lQXRFbmRPZkRvY3VtZW50Lmh0bWwgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9hdHRyaWJ1dGVkU3RyaW5nTmV3bGluZUF0RW5k T2ZEb2N1bWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU1Y2M0NjEzOWRmMmU2ZTBhYjgzZDgzNzA0N2Ey NWM5NjQxZTRjOTMKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L21hYy9hdHRyaWJ1dGVkU3RyaW5nTmV3bGluZUF0RW5kT2ZEb2N1bWVudC5odG1sCkBAIC0wLDAg KzEsMTAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keSBjb250ZW50ZWRpdGFibGU+ CisgICA8ZGl2PmE8L2Rpdj4KKyAgIDxkaXYgaWQ9J3RhcmdldCc+CisgICAgICAgPGJyPgorICAg PC9kaXY+CisgICA8c2NyaXB0PmdldFNlbGVjdGlvbigpLnNldFBvc2l0aW9uKHRhcmdldCk7PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==