211305 2020-05-01 11:30:39 -0700 REGRESSION (r260791?): Assert not reached in ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() and ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary() 2020-05-08 12:19:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211190 https://bugs.webkit.org/show_bug.cgi?id=211637 InRadar P2 Normal --- 1 ryanhaddad katherine_cheney achristensen beidson bfulgham katherine_cheney webkit-bot-watchers-bugzilla webkit-bug-importer wilander oldest_to_newest 1647941 0 ryanhaddad 2020-05-01 11:30:39 -0700 One or both of the following assertion failures and errors are seen with various resource load statistics, storage access, or indexeddb tests on iOS debug bots: ERROR: SQLite database failed to set journal_mode to WAL, error: database is locked ./platform/sql/SQLiteDatabase.cpp(175) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: SQLite database failed to checkpoint: database is locked ./platform/sql/SQLiteDatabase.cpp(185) : void WebCore::SQLiteDatabase::useWALJournalMode() ERROR: Unable to prepare statement to fetch schema for the ObservedDomains table. /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(507) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(508) : void WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 1 0x12312ae79 WTFCrash 2 0x112f74beb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x113689e7f WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 4 0x113689a06 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 5 0x11368a903 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 6 0x11372736c std::__1::__unique_if<WebKit::ResourceLoadStatisticsDatabaseStore>::__unique_single std::__1::make_unique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 7 0x113726f53 decltype(auto) WTF::makeUnique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 8 0x113726ca6 WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42::operator()() const 9 0x113726b5e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42, void>::call() 10 0x1130583e2 WTF::Function<void ()>::operator()() const 11 0x1136fd41e WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const 12 0x1136fd34e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'(), void>::call() 13 0x1231555f2 WTF::Function<void ()>::operator()() const 14 0x12325fe0e WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0::operator()() const 15 0x123260002 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::operator()(void*) const 16 0x12325ffd5 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*) 17 0x10e282951 _dispatch_call_block_and_release 18 0x10e2838cb _dispatch_client_callout 19 0x10e28960c _dispatch_lane_serial_drain 20 0x10e28a044 _dispatch_lane_invoke 21 0x10e2940c4 _dispatch_workloop_worker_thread 22 0x10e70aa3d _pthread_wqthread 23 0x10e709b77 start_wqthread MRMediaRemoteSetNowPlayingApplicationPlaybackStateForOrigin(stopped) failed with error 3 SHOULD NEVER BE REACHED /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp(492) : void WebKit::ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary() 1 0x1229dce79 WTFCrash 2 0x111df3beb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11250c7ea WebKit::ResourceLoadStatisticsDatabaseStore::addMissingTablesIfNecessary() 4 0x112508dc8 WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary() 5 0x112508a06 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 6 0x112509903 WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore(WebKit::WebResourceLoadStatisticsStore&, WTF::WorkQueue&, WebKit::ShouldIncludeLocalhost, WTF::String const&, PAL::SessionID) 7 0x1125a636c std::__1::__unique_if<WebKit::ResourceLoadStatisticsDatabaseStore>::__unique_single std::__1::make_unique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 8 0x1125a5f53 decltype(auto) WTF::makeUnique<WebKit::ResourceLoadStatisticsDatabaseStore, WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&>(WebKit::WebResourceLoadStatisticsStore&, WTF::Ref<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&, WebKit::ShouldIncludeLocalhost const&, WTF::String const&, PAL::SessionID const&) 9 0x1125a5ca6 WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42::operator()() const 10 0x1125a5b5e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore(WebKit::NetworkSession&, WTF::String const&, WebKit::ShouldIncludeLocalhost, WebCore::ResourceLoadStatistics::IsEphemeral)::$_42, void>::call() 11 0x111ed73e2 WTF::Function<void ()>::operator()() const 12 0x11257c41e WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'()::operator()() const 13 0x11257c34e WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::postTask(WTF::Function<void ()>&&)::'lambda'(), void>::call() 14 0x122a075f2 WTF::Function<void ()>::operator()() const 15 0x122b11e0e WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0::operator()() const 16 0x122b12002 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::operator()(void*) const 17 0x122b11fd5 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*) 18 0x10f658951 _dispatch_call_block_and_release 19 0x10f6598cb _dispatch_client_callout 20 0x10f65f60c _dispatch_lane_serial_drain 21 0x10f660044 _dispatch_lane_invoke 22 0x10f66a0c4 _dispatch_workloop_worker_thread 23 0x10fae0a3d _pthread_wqthread 24 0x10fadfb77 start_wqthread There are also 15 unassociated com.apple.WebKit.Networking.Development crashes on this run that look related https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r260998%20(3465)/results.html 1647945 1 ryanhaddad 2020-05-01 11:32:17 -0700 rdar://62737871 1648881 2 398449 katherine_cheney 2020-05-04 18:23:03 -0700 Created attachment 398449 Patch 1648942 3 ews-feeder 2020-05-04 21:55:10 -0700 Committed r261146: <https://trac.webkit.org/changeset/261146> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398449. 1650708 4 ryanhaddad 2020-05-08 12:19:02 -0700 We are still seeing some crashes after this fix. See https://bugs.webkit.org/show_bug.cgi?id=211637 398449 2020-05-04 18:23:03 -0700 2020-05-04 21:55:10 -0700 Patch bug-211305-20200504182302.patch text/plain 2719 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI5ODg5ZjNmMzU2Y2E3NDNh NGY2MzZjMTE5MTNlZDEyMGIxZTJmOTguLjI1MjFlMmZhZjA2OTQyOGU3NTdlYzY4YzIyOWZkMTQ5 OGU5NjU3N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDUtMDQgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjI2MDc5MT8pOiBBc3NlcnQgbm90IHJlYWNoZWQgaW4gUmVzb3VyY2VMb2FkU3RhdGlzdGljc0Rh dGFiYXNlU3RvcmU6Om9wZW5BbmRVcGRhdGVTY2hlbWFJZk5lY2Vzc2FyeSgpIGFuZCBSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6YWRkTWlzc2luZ1RhYmxlc0lmTmVjZXNzYXJ5 KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMTMw NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjI3Mzc4NzE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgYnVzeSB0aW1l b3V0IGZvciB0aGUgSVRQIGRhdGFiYXNlIHRvIGFsbG93IGZvcgorICAgICAgICBzb21lIGNvbmN1 cnJlbmN5IGZsZXhpYmlsaXR5IHdoZW4gcnVubmluZyBtYW55IFdlYktpdFRlc3RSdW5uZXIgdGVz dHMsIHdoaWNoCisgICAgICAgIHJlY3JlYXRlIHRoZSBJVFAgZGF0YWJhc2Ugc3RvcmUgdmVyeSBv ZnRlbiB0byB0ZXN0IGJvdGggdGhlIG1lbW9yeSBhbmQKKyAgICAgICAgZGF0YWJhc2Ugc3RvcmVz LgorCisgICAgICAgIFdpdGggdGhlIHRpbWVvdXQsIGFuIGF0dGVtcHQgdG8gd3JpdGUgdG8gdGhl IGRhdGFiYXNlIHdoZW4gYW5vdGhlcgorICAgICAgICB0aHJlYWQgaXMgaG9sZGluZyB0aGUgbG9j ayB3aWxsIGtlZXAgYXR0ZW1wdGluZyB0byBpbnNlcnQgZm9yIDUKKyAgICAgICAgc2Vjb25kcyBh cyBsb25nIGFzIHRoZSBzdGF0ZW1lbnQgZXhlY3V0aW9uIHJldHVybnMgU1FMSVRFX0JVU1kuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3Rp Y3NEYXRhYmFzZVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVzb3VyY2VMb2FkU3RhdGlz dGljc0RhdGFiYXNlU3RvcmU6Om9wZW5JVFBEYXRhYmFzZSk6CisKIDIwMjAtMDUtMDQgIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgZGVmYXVsdCBjb25z dHJ1Y3RvciBhbmQgZGVmYXVsdCBpbml0aWFsaXplciBmb3IgU2VjSXRlbVJlcXVlc3REYXRhCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlLmNw cAppbmRleCA0YjI0Y2U1MTIxMWVmMWMyMmY2MGEwNmUyYjNmMTNlY2MyZWRjNTllLi4xYjdhN2Nm Y2Y1MzdhYzJiYzk5ZjY4NjIyNDA3Nzc2MDIwZmNkZTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFi YXNlU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmll ci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAKQEAgLTM1MCw2ICszNTAs MTMgQEAgdm9pZCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6b3BlbklUUERh dGFiYXNlKCkKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogICAgIAorICAg IFNRTGl0ZVN0YXRlbWVudCBzZXRCdXN5VGltZW91dChtX2RhdGFiYXNlLCAiUFJBR01BIGJ1c3lf dGltZW91dCA9IDUwMDAiKTsKKyAgICBpZiAoc2V0QnVzeVRpbWVvdXQucHJlcGFyZSgpICE9IFNR TElURV9PSyB8fCBzZXRCdXN5VGltZW91dC5zdGVwKCkgIT0gU1FMSVRFX1JPVykgeworICAgICAg ICBSRUxFQVNFX0xPR19FUlJPUihOZXR3b3JrLCAiJXAgLSBSZXNvdXJjZUxvYWRTdGF0aXN0aWNz RGF0YWJhc2VTdG9yZTo6c2V0QnVzeVRpbWVvdXQgZmFpbGVkLCBlcnJvciBtZXNzYWdlOiAle3By aXZhdGV9cyIsIHRoaXMsIG1fZGF0YWJhc2UubGFzdEVycm9yTXNnKCkpOworICAgICAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlmIChtX2lz TmV3UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlRmlsZSkgewogICAgICAgICBpZiAoIWNy ZWF0ZVNjaGVtYSgpKSB7CiAgICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihOZXR3b3JrLCAi JXAgLSBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6Y3JlYXRlU2NoZW1hIGZh aWxlZCwgZXJyb3IgbWVzc2FnZTogJSIgUFVCTElDX0xPR19TVFJJTkcgIiwgZGF0YWJhc2UgcGF0 aDogJSIgUFVCTElDX0xPR19TVFJJTkcsIHRoaXMsIG1fZGF0YWJhc2UubGFzdEVycm9yTXNnKCks IG1fc3RvcmFnZURpcmVjdG9yeVBhdGgudXRmOCgpLmRhdGEoKSk7Cg==