211288 2020-05-01 07:16:31 -0700 [GTK] Specify action group name when binding context menu models 2020-05-02 05:54:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170553 P2 Normal --- 1 aperez aperez bugs-noreply cgarcia oldest_to_newest 1647833 0 aperez 2020-05-01 07:16:31 -0700 This will avoid a round of string allocation+free for each menu item added to a context menu model, every time the context menu is requested. 1647834 1 398179 aperez 2020-05-01 07:20:42 -0700 Created attachment 398179 Patch 1648237 2 ews-feeder 2020-05-02 05:54:40 -0700 Committed r261047: <https://trac.webkit.org/changeset/261047> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398179. 398179 2020-05-01 07:20:42 -0700 2020-05-02 05:54:40 -0700 Patch bug-211288-20200501172040.patch text/plain 3003 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5OGY1ZGY4ZDQ5YTQ5ZmUy MWEzNDJmZTc3YTY2M2ViOWMzNmJkYjguLjU4MzFkYzA4ZWY4ZDhmMDA2MTVjMTkyYTg2ZDI1NjY0 YzcyMjI4NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDUtMDEgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTcGVj aWZ5IGFjdGlvbiBncm91cCBuYW1lIHdoZW4gYmluZGluZyBjb250ZXh0IG1lbnUgbW9kZWxzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEyODgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgbmVlZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJDb250ZXh0TWVudVByb3h5 R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eUd0azo6YXBwZW5k KTogVXNlIHRoZSBhY3Rpb24gbmFtZSBkaXJlY3RseSBmb3IgdGhlIG1lbnUgaXRlbS4KKyAgICAg ICAgKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eUd0azo6cG9wdWxhdGUpOiBJbmRpY2F0ZSB0 aGUgYWN0aW9uIGdyb3VwIG5hbWUgd2hlbiBiaW5kaW5nIHRoZQorICAgICAgICBtZW51IG1vZGVs LCB3aGljaCBhdXRvbWF0aWNhbGx5IGFkZHMgdGhlIGdyb3VwIG5hbWUgYXMgYWN0aW9uIG5hbWUg cHJlZml4IHdpdGhvdXQgbmVlZGluZworICAgICAgICB0byBzcGVjaWZ5IGl0IGJ5IGhhbmQgd2hl biBhZGRpbmcgbWVudSBpdGVtcy4KKwogMjAyMC0wNC0zMCAgQWRyaWFuIFBlcmV6IGRlIENhc3Ry byAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEs0XSBEaXNhYmxlIGFycm93IG9u IGNvbnRleHQgbWVudSBwb3BvdmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9ndGsvV2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9ndGsvV2ViQ29udGV4dE1lbnVQcm94eUd0ay5jcHAKaW5kZXggOWMyMjk1ZmNmYWY0ZDY2Njhj YzVmMWI4MzA3NTQyMDc2NjYyNmY3Mi4uOTlkNWU5MjJkZDI1NDZjNGViN2NhOGM0MzBiYWYxNjYz OGMxZWNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRl eHRNZW51UHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XZWJD b250ZXh0TWVudVByb3h5R3RrLmNwcApAQCAtNzIsOSArNzIsOCBAQCB2b2lkIFdlYkNvbnRleHRN ZW51UHJveHlHdGs6OmFwcGVuZChHTWVudSogbWVudSwgY29uc3QgV2ViQ29udGV4dE1lbnVJdGVt R2xpYiYgbQogICAgIHN3aXRjaCAobWVudUl0ZW0udHlwZSgpKSB7CiAgICAgY2FzZSBBY3Rpb25U eXBlOgogICAgIGNhc2UgQ2hlY2thYmxlQWN0aW9uVHlwZTogewotICAgICAgICBHVW5pcXVlUHRy PGNoYXI+IGFjdGlvbk5hbWUoZ19zdHJkdXBfcHJpbnRmKCIlcy4lcyIsIGdDb250ZXh0TWVudUl0 ZW1Hcm91cCwgZ19hY3Rpb25fZ2V0X25hbWUoYWN0aW9uKSkpOwogICAgICAgICBnTWVudUl0ZW0g PSBhZG9wdEdSZWYoZ19tZW51X2l0ZW1fbmV3KG1lbnVJdGVtLnRpdGxlKCkudXRmOCgpLmRhdGEo KSwgbnVsbHB0cikpOwotICAgICAgICBnX21lbnVfaXRlbV9zZXRfYWN0aW9uX2FuZF90YXJnZXRf dmFsdWUoZ01lbnVJdGVtLmdldCgpLCBhY3Rpb25OYW1lLmdldCgpLCBtZW51SXRlbS5nQWN0aW9u VGFyZ2V0KCkpOworICAgICAgICBnX21lbnVfaXRlbV9zZXRfYWN0aW9uX2FuZF90YXJnZXRfdmFs dWUoZ01lbnVJdGVtLmdldCgpLCBnX2FjdGlvbl9nZXRfbmFtZShhY3Rpb24pLCBtZW51SXRlbS5n QWN0aW9uVGFyZ2V0KCkpOwogCiAgICAgICAgIGlmIChtZW51SXRlbS5hY3Rpb24oKSA8IENvbnRl eHRNZW51SXRlbUJhc2VBcHBsaWNhdGlvblRhZykgewogICAgICAgICAgICAgZ19vYmplY3Rfc2V0 X2RhdGEoR19PQkpFQ1QoYWN0aW9uKSwgZ0NvbnRleHRNZW51QWN0aW9uSWQsIEdJTlRfVE9fUE9J TlRFUihtZW51SXRlbS5hY3Rpb24oKSkpOwpAQCAtMTI4LDcgKzEyNyw3IEBAIFZlY3RvcjxXZWJD b250ZXh0TWVudUl0ZW1HbGliPiBXZWJDb250ZXh0TWVudVByb3h5R3RrOjpwb3B1bGF0ZVN1Yk1l bnUoY29uc3QgV2ViCiB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlHdGs6OnBvcHVsYXRlKGNvbnN0 IFZlY3RvcjxXZWJDb250ZXh0TWVudUl0ZW1HbGliPiYgaXRlbXMpCiB7CiAgICAgR1JlZlB0cjxH TWVudT4gbWVudSA9IGJ1aWxkTWVudShpdGVtcyk7Ci0gICAgZ3RrX3BvcG92ZXJfYmluZF9tb2Rl bChtX21lbnUsIEdfTUVOVV9NT0RFTChtZW51LmdldCgpKSwgbnVsbHB0cik7CisgICAgZ3RrX3Bv cG92ZXJfYmluZF9tb2RlbChtX21lbnUsIEdfTUVOVV9NT0RFTChtZW51LmdldCgpKSwgZ0NvbnRl eHRNZW51SXRlbUdyb3VwKTsKIH0KIAogdm9pZCBXZWJDb250ZXh0TWVudVByb3h5R3RrOjpwb3B1 bGF0ZShjb25zdCBWZWN0b3I8UmVmPFdlYkNvbnRleHRNZW51SXRlbT4+JiBpdGVtcykKQEAgLTE1 Niw3ICsxNTUsNyBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlHdGs6OnBvcHVsYXRlKGNvbnN0 IFZlY3RvcjxSZWY8V2ViQ29udGV4dE1lbnVJdGVtPj4mIGl0ZQogICAgICAgICB9CiAgICAgICAg IH0KICAgICB9Ci0gICAgZ3RrX3BvcG92ZXJfYmluZF9tb2RlbChtX21lbnUsIEdfTUVOVV9NT0RF TChtZW51LmdldCgpKSwgbnVsbHB0cik7CisgICAgZ3RrX3BvcG92ZXJfYmluZF9tb2RlbChtX21l bnUsIEdfTUVOVV9NT0RFTChtZW51LmdldCgpKSwgZ0NvbnRleHRNZW51SXRlbUdyb3VwKTsKIH0K IAogdm9pZCBXZWJDb250ZXh0TWVudVByb3h5R3RrOjpzaG93KCkK