211286 2020-05-01 06:22:27 -0700 [GTK4] Re-inject key press events not handled by the web process 2020-05-02 05:56:04 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1647824 0 cgarcia 2020-05-01 06:22:27 -0700 So that they can be handled by parent widgets. 1647826 1 398177 cgarcia 2020-05-01 06:26:22 -0700 Created attachment 398177 Patch 1647827 2 ews-watchlist 2020-05-01 06:27:23 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1648238 3 cgarcia 2020-05-02 05:56:04 -0700 Committed r261048: <https://trac.webkit.org/changeset/261048> 398177 2020-05-01 06:26:22 -0700 2020-05-01 06:41:03 -0700 Patch wkgtk4-reinject-keys.diff text/plain 6161 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZWQ5ODA3MWVhNmEyLi4wNTAxZGFmODZiYmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjEgQEAKKzIwMjAtMDUtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEs0XSBSZS1pbmplY3Qga2V5IHByZXNzIGV2ZW50cyBub3Qg aGFuZGxlZCBieSB0aGUgd2ViIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMTI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVzZSBnZGtfZGlzcGxheV9wdXRfZXZlbnQoKSBzaW5jZSBndGtf bWFpbl9kb19ldmVudCgpIGlzIG5vIGxvbmdlciBhdmFpbGFibGUgaW4gR1RLNC4gQWxzbyBzdG9w IGZvcndhcmRpbmcga2V5CisgICAgICAgIHJlbGVhc2UgZXZlbnRzIGluIEdUSzMgY2FzZSwgdGhp cyBvbmx5IG1ha2VzIHNlbnNlIGZvciBrZXkgcHJlc3MgZXZlbnRzIGFuZCB3ZSB3ZXJlIHJlLWlu amVjdGluZyBldmVyeSByZWxlYXNlCisgICAgICAgIGV2ZW50IHNpbmNlIHRoZXkgYXJlIG5vdCBo YW5kbGVkIGJ5IHdlYiBlbGVtZW50cyBpbiBtb3N0IG9mIHRoZSBjYXNlcy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UGFnZUNsaWVudEltcGw6OmRvbmVXaXRoS2V5RXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNl S2V5UHJlc3NFdmVudCk6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUtleVJlbGVhc2VFdmVu dCk6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZUtleVByZXNzZWQpOgorCiAyMDIwLTA0LTI5 ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLNF1bWDExXSBBZGQgc3VwcG9ydCBmb3IgcmVuZGVyaW5nIHdlYiB2aWV3IGNvbnRlbnRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBs LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3Bw CmluZGV4IDU5YTI4MmNjMzdkMy4uNjhmZGExNzAyY2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtMjM5LDExICsyMzks MTQgQEAgV2ViQ29yZTo6SW50UmVjdCBQYWdlQ2xpZW50SW1wbDo6cm9vdFZpZXdUb0FjY2Vzc2li aWxpdHlTY3JlZW4oY29uc3QgV2ViQ29yZTo6SW4KIAogdm9pZCBQYWdlQ2xpZW50SW1wbDo6ZG9u ZVdpdGhLZXlFdmVudChjb25zdCBOYXRpdmVXZWJLZXlib2FyZEV2ZW50JiBldmVudCwgYm9vbCB3 YXNFdmVudEhhbmRsZWQpCiB7Ci0gICAgaWYgKHdhc0V2ZW50SGFuZGxlZCkKKyAgICBpZiAod2Fz RXZlbnRIYW5kbGVkIHx8IGV2ZW50LnR5cGUoKSAhPSBXZWJFdmVudDo6VHlwZTo6S2V5RG93bikK ICAgICAgICAgcmV0dXJuOwotI2lmICFVU0UoR1RLNCkKKwogICAgIFdlYktpdFdlYlZpZXdCYXNl KiB3ZWJraXRXZWJWaWV3QmFzZSA9IFdFQktJVF9XRUJfVklFV19CQVNFKG1fdmlld1dpZGdldCk7 CiAgICAgd2Via2l0V2ViVmlld0Jhc2VGb3J3YXJkTmV4dEtleUV2ZW50KHdlYmtpdFdlYlZpZXdC YXNlKTsKKyNpZiBVU0UoR1RLNCkKKyAgICBnZGtfZGlzcGxheV9wdXRfZXZlbnQoZ3RrX3dpZGdl dF9nZXRfZGlzcGxheShtX3ZpZXdXaWRnZXQpLCBldmVudC5uYXRpdmVFdmVudCgpKTsKKyNlbHNl CiAgICAgZ3RrX21haW5fZG9fZXZlbnQoZXZlbnQubmF0aXZlRXZlbnQoKSk7CiAjZW5kaWYKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll d0Jhc2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHAKaW5kZXggMTE3OGZlNjAxNmQxLi5lMGIzY2JkN2FhNTcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBA IC04MTYsNiArODE2LDE1IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUtleVBy ZXNzRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50S2V5KiBrCiAgICAgV2ViS2l0V2Vi Vmlld0Jhc2UqIHdlYlZpZXdCYXNlID0gV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KTsKICAg ICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKIAor ICAgIC8vIFNpbmNlIFdlYlByb2Nlc3Mga2V5IGV2ZW50IGhhbmRsaW5nIGlzIG5vdCBzeW5jaHJv bm91cywgaGFuZGxlIHRoZSBldmVudCBpbiB0d28gcGFzc2VzLgorICAgIC8vIFdoZW4gV2ViUHJv Y2VzcyBwcm9jZXNzZXMgdGhlIGlucHV0IGV2ZW50LCBpdCB3aWxsIGNhbGwgUGFnZUNsaWVudElt cGw6OmRvbmVXaXRoS2V5RXZlbnQKKyAgICAvLyB3aXRoIGV2ZW50IGhhbmRsZWQgc3RhdHVzIHdo aWNoIGRldGVybWluZXMgd2hldGhlciB0byBwYXNzIHRoZSBpbnB1dCBldmVudCB0byBwYXJlbnQg b3Igbm90CisgICAgLy8gdXNpbmcgZ3RrX21haW5fZG9fZXZlbnQoKS4KKyAgICBpZiAocHJpdi0+ c2hvdWxkRm9yd2FyZE5leHRLZXlFdmVudCkgeworICAgICAgICBwcml2LT5zaG91bGRGb3J3YXJk TmV4dEtleUV2ZW50ID0gZmFsc2U7CisgICAgICAgIHJldHVybiBHVEtfV0lER0VUX0NMQVNTKHdl YmtpdF93ZWJfdmlld19iYXNlX3BhcmVudF9jbGFzcyktPmtleV9wcmVzc19ldmVudCh3aWRnZXQs IGtleUV2ZW50KTsKKyAgICB9CisKICAgICBHZGtNb2RpZmllclR5cGUgc3RhdGU7CiAgICAgZ3Vp bnQga2V5dmFsOwogICAgIGdka19ldmVudF9nZXRfc3RhdGUocmVpbnRlcnByZXRfY2FzdDxHZGtF dmVudCo+KGtleUV2ZW50KSwgJnN0YXRlKTsKQEAgLTgyNSw3ICs4MzQsNiBAQCBzdGF0aWMgZ2Jv b2xlYW4gd2Via2l0V2ViVmlld0Jhc2VLZXlQcmVzc0V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBH ZGtFdmVudEtleSogawogICAgIGlmICgoc3RhdGUgJiBHREtfQ09OVFJPTF9NQVNLKSAmJiAoc3Rh dGUgJiBHREtfU0hJRlRfTUFTSykgJiYga2V5dmFsID09IEdES19LRVlfRykgewogICAgICAgICBh dXRvJiBwcmVmZXJlbmNlcyA9IHByaXYtPnBhZ2VQcm94eS0+cHJlZmVyZW5jZXMoKTsKICAgICAg ICAgcHJlZmVyZW5jZXMuc2V0UmVzb3VyY2VVc2FnZU92ZXJsYXlWaXNpYmxlKCFwcmVmZXJlbmNl cy5yZXNvdXJjZVVzYWdlT3ZlcmxheVZpc2libGUoKSk7Ci0gICAgICAgIHByaXYtPnNob3VsZEZv cndhcmROZXh0S2V5RXZlbnQgPSBGQUxTRTsKICAgICAgICAgcmV0dXJuIEdES19FVkVOVF9TVE9Q OwogICAgIH0KICNlbmRpZgpAQCAtODQ3LDE0ICs4NTUsNiBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Vi a2l0V2ViVmlld0Jhc2VLZXlQcmVzc0V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEtl eSogawogICAgIH0KICNlbmRpZgogCi0gICAgLy8gU2luY2UgV2ViUHJvY2VzcyBrZXkgZXZlbnQg aGFuZGxpbmcgaXMgbm90IHN5bmNocm9ub3VzLCBoYW5kbGUgdGhlIGV2ZW50IGluIHR3byBwYXNz ZXMuCi0gICAgLy8gV2hlbiBXZWJQcm9jZXNzIHByb2Nlc3NlcyB0aGUgaW5wdXQgZXZlbnQsIGl0 IHdpbGwgY2FsbCBQYWdlQ2xpZW50SW1wbDo6ZG9uZVdpdGhLZXlFdmVudAotICAgIC8vIHdpdGgg ZXZlbnQgaGFuZGxlZCBzdGF0dXMgd2hpY2ggZGV0ZXJtaW5lcyB3aGV0aGVyIHRvIHBhc3MgdGhl IGlucHV0IGV2ZW50IHRvIHBhcmVudCBvciBub3QKLSAgICAvLyB1c2luZyBndGtfbWFpbl9kb19l dmVudCgpLgotICAgIGlmIChwcml2LT5zaG91bGRGb3J3YXJkTmV4dEtleUV2ZW50KSB7Ci0gICAg ICAgIHByaXYtPnNob3VsZEZvcndhcmROZXh0S2V5RXZlbnQgPSBGQUxTRTsKLSAgICAgICAgcmV0 dXJuIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X2Jhc2VfcGFyZW50X2NsYXNzKS0+ a2V5X3ByZXNzX2V2ZW50KHdpZGdldCwga2V5RXZlbnQpOwotICAgIH0KICAgICBhdXRvIGZpbHRl clJlc3VsdCA9IHByaXYtPmlucHV0TWV0aG9kRmlsdGVyLmZpbHRlcktleUV2ZW50KHJlaW50ZXJw cmV0X2Nhc3Q8R2RrRXZlbnQqPihrZXlFdmVudCkpOwogICAgIGlmICghZmlsdGVyUmVzdWx0Lmhh bmRsZWQpIHsKICAgICAgICAgcHJpdi0+cGFnZVByb3h5LT5oYW5kbGVLZXlib2FyZEV2ZW50KE5h dGl2ZVdlYktleWJvYXJkRXZlbnQocmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGtleUV2ZW50 KSwgZmlsdGVyUmVzdWx0LmtleVRleHQsCkBAIC04NjksMTEgKzg2OSw2IEBAIHN0YXRpYyBnYm9v bGVhbiB3ZWJraXRXZWJWaWV3QmFzZUtleVJlbGVhc2VFdmVudChHdGtXaWRnZXQqIHdpZGdldCwg R2RrRXZlbnRLZXkqCiAgICAgV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlID0gV0VCS0lU X1dFQl9WSUVXX0JBU0Uod2lkZ2V0KTsKICAgICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHBy aXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKIAotICAgIGlmIChwcml2LT5zaG91bGRGb3J3YXJkTmV4 dEtleUV2ZW50KSB7Ci0gICAgICAgIHByaXYtPnNob3VsZEZvcndhcmROZXh0S2V5RXZlbnQgPSBG QUxTRTsKLSAgICAgICAgcmV0dXJuIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X2Jh c2VfcGFyZW50X2NsYXNzKS0+a2V5X3JlbGVhc2VfZXZlbnQod2lkZ2V0LCBrZXlFdmVudCk7Ci0g ICAgfQotCiAgICAgaWYgKCFwcml2LT5pbnB1dE1ldGhvZEZpbHRlci5maWx0ZXJLZXlFdmVudChy ZWludGVycHJldF9jYXN0PEdka0V2ZW50Kj4oa2V5RXZlbnQpKS5oYW5kbGVkKSB7CiAgICAgICAg IHByaXYtPnBhZ2VQcm94eS0+aGFuZGxlS2V5Ym9hcmRFdmVudChOYXRpdmVXZWJLZXlib2FyZEV2 ZW50KHJlaW50ZXJwcmV0X2Nhc3Q8R2RrRXZlbnQqPihrZXlFdmVudCksIHsgfSwKICAgICAgICAg ICAgIE5hdGl2ZVdlYktleWJvYXJkRXZlbnQ6OkhhbmRsZWRCeUlucHV0TWV0aG9kOjpObywgV1RG OjpudWxsb3B0LCBXVEY6Om51bGxvcHQsIHsgfSkpOwpAQCAtODk4LDYgKzg5MywxNSBAQCBzdGF0 aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VLZXlQcmVzc2VkKFdlYktpdFdlYlZpZXdCYXNl KiB3ZWJWaWV3QmFzZSwgdW5zaQogewogICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJp diA9IHdlYlZpZXdCYXNlLT5wcml2OwogCisgICAgLy8gU2luY2UgV2ViUHJvY2VzcyBrZXkgZXZl bnQgaGFuZGxpbmcgaXMgbm90IHN5bmNocm9ub3VzLCBoYW5kbGUgdGhlIGV2ZW50IGluIHR3byBw YXNzZXMuCisgICAgLy8gV2hlbiBXZWJQcm9jZXNzIHByb2Nlc3NlcyB0aGUgaW5wdXQgZXZlbnQs IGl0IHdpbGwgY2FsbCBQYWdlQ2xpZW50SW1wbDo6ZG9uZVdpdGhLZXlFdmVudAorICAgIC8vIHdp dGggZXZlbnQgaGFuZGxlZCBzdGF0dXMgd2hpY2ggZGV0ZXJtaW5lcyB3aGV0aGVyIHRvIHBhc3Mg dGhlIGlucHV0IGV2ZW50IHRvIHBhcmVudCBvciBub3QKKyAgICAvLyB1c2luZyBnZGtfZGlzcGxh eV9wdXRfZXZlbnQoKS4KKyAgICBpZiAocHJpdi0+c2hvdWxkRm9yd2FyZE5leHRLZXlFdmVudCkg eworICAgICAgICBwcml2LT5zaG91bGRGb3J3YXJkTmV4dEtleUV2ZW50ID0gZmFsc2U7CisgICAg ICAgIHJldHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOworICAgIH0KKwogI2lmIEVOQUJMRShERVZF TE9QRVJfTU9ERSkgJiYgT1MoTElOVVgpCiAgICAgaWYgKChzdGF0ZSAmIEdES19DT05UUk9MX01B U0spICYmIChzdGF0ZSAmIEdES19TSElGVF9NQVNLKSAmJiBrZXl2YWwgPT0gR0RLX0tFWV9HKSB7 CiAgICAgICAgIGF1dG8mIHByZWZlcmVuY2VzID0gcHJpdi0+cGFnZVByb3h5LT5wcmVmZXJlbmNl cygpOwo=