211283 2020-05-01 04:50:01 -0700 [GTK] Move focus out of the web view when tab is pressed and there isn't a next element to focus 2020-05-01 05:24:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1647811 0 cgarcia 2020-05-01 04:50:01 -0700 We just need to implement API::UIClient::takeFocus() 1647812 1 398173 cgarcia 2020-05-01 04:51:52 -0700 Created attachment 398173 Patch 1647813 2 398174 cgarcia 2020-05-01 04:57:35 -0700 Created attachment 398174 Patch 1647814 3 ews-watchlist 2020-05-01 04:58:30 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1647817 4 398174 aperez 2020-05-01 05:09:46 -0700 Comment on attachment 398174 Patch Lovely nice little patch 😸️ 1647818 5 cgarcia 2020-05-01 05:24:01 -0700 Committed r260996: <https://trac.webkit.org/changeset/260996> 398173 2020-05-01 04:51:52 -0700 2020-05-01 04:57:35 -0700 Patch wkgtk4-focus.diff text/plain 1679 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmNhYWIzMGJkODlmLi5lM2FiNGJiM2VlMGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjAtMDUtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIE1vdmUgZm9jdXMgb3V0IG9mIHRoZSB3ZWIgdmlldyB3 aGVuIHRhYiBpcyBwcmVzc2VkIGFuZCB0aGVyZSBpc24ndCBhIG5leHQgZWxlbWVudCB0byBmb2N1 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjgz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50IEFQSTo6VUlDbGllbnQ6OnRha2VGb2N1cygpIHRoYXQgaXMgY2FsbGVkIHdoZW4gV2ViQ29y ZSB3YW50cyB0byBmb2N1cyB0aGUgY2hyb21lLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFVJQ2xpZW50LmNwcDoKKwogMjAyMC0wNC0yNCAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9w dGlvbnNHVEsuY21ha2UgYW5kIE5FV1MgZm9yIDIuMjguMiByZWxlYXNlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKaW5kZXggOWVl MGE0MDk2MmI4Li5iM2I0NTczMWMyZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKQEAgLTI3NCw2ICsyNzQsMjAgQEAgcHJp dmF0ZToKICAgICB9CiAKICNpZiBQTEFURk9STShHVEspCisgICAgYm9vbCB0YWtlRm9jdXMoV2Vi UGFnZVByb3h5KiBwYWdlLCBXS0ZvY3VzRGlyZWN0aW9uIGRpcmVjdGlvbikgZmluYWwKKyAgICB7 CisgICAgICAgIGlmICghZ3RrX3dpZGdldF9oYXNfZm9jdXMoR1RLX1dJREdFVChtX3dlYlZpZXcp KSkgeworICAgICAgICAgICAgZm9jdXMocGFnZSk7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICAgICAgfQorICAgICAgICByZXR1cm4gZ3RrX3dpZGdldF9jaGlsZF9mb2N1cyhndGtfd2lk Z2V0X2dldF90b3BsZXZlbChHVEtfV0lER0VUKG1fd2ViVmlldykpLCBkaXJlY3Rpb24gPT0ga1dL Rm9jdXNEaXJlY3Rpb25CYWNrd2FyZCA/IEdUS19ESVJfVEFCX0JBQ0tXQVJEIDogR1RLX0RJUl9U QUJfRk9SV0FSRCk7CisgICAgfQorCisgICAgdm9pZCBmb2N1cyhXZWJQYWdlUHJveHkqKSBmaW5h bAorICAgIHsKKyAgICAgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKEdUS19XSURHRVQobV93ZWJW aWV3KSk7CisgICAgfQorCiAgICAgdm9pZCBwcmludEZyYW1lKFdlYlBhZ2VQcm94eSYsIFdlYkZy YW1lUHJveHkmIGZyYW1lKSBmaW5hbAogICAgIHsKICAgICAgICAgd2Via2l0V2ViVmlld1ByaW50 RnJhbWUobV93ZWJWaWV3LCAmZnJhbWUpOwo= 398174 2020-05-01 04:57:35 -0700 2020-05-01 05:09:46 -0700 Patch wkgtk4-focus.diff text/plain 1708 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDM0OTc0Nzk1NTk4Li5kNTMwNjVhMTQ3YTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjAtMDUtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIE1vdmUgZm9jdXMgb3V0IG9mIHRoZSB3ZWIgdmlldyB3 aGVuIHRhYiBpcyBwcmVzc2VkIGFuZCB0aGVyZSBpc24ndCBhIG5leHQgZWxlbWVudCB0byBmb2N1 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjgz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50IEFQSTo6VUlDbGllbnQ6OnRha2VGb2N1cygpIHRoYXQgaXMgY2FsbGVkIHdoZW4gV2ViQ29y ZSB3YW50cyB0byBmb2N1cyB0aGUgY2hyb21lLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFVJQ2xpZW50LmNwcDoKKwogMjAyMC0wNS0wMSAgQWRyaWFuIFBlcmV6IGRlIENh c3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEs0XSBEaXNhYmxlIGFycm93 IG9uIGNvbnRleHQgbWVudSBwb3BvdmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKaW5kZXggZjlhMWFkZDVhY2U3Li4wN2RhOTYx MzhkYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFVJQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRVSUNsaWVudC5jcHAKQEAgLTI5NCw2ICsyOTQsMjAgQEAgcHJpdmF0ZToKICAgICB9CiAKICNp ZiBQTEFURk9STShHVEspCisgICAgYm9vbCB0YWtlRm9jdXMoV2ViUGFnZVByb3h5KiBwYWdlLCBX S0ZvY3VzRGlyZWN0aW9uIGRpcmVjdGlvbikgZmluYWwKKyAgICB7CisgICAgICAgIGlmICghZ3Rr X3dpZGdldF9oYXNfZm9jdXMoR1RLX1dJREdFVChtX3dlYlZpZXcpKSkgeworICAgICAgICAgICAg Zm9jdXMocGFnZSk7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgICAg ICByZXR1cm4gZ3RrX3dpZGdldF9jaGlsZF9mb2N1cyhndGtfd2lkZ2V0X2dldF90b3BsZXZlbChH VEtfV0lER0VUKG1fd2ViVmlldykpLCBkaXJlY3Rpb24gPT0ga1dLRm9jdXNEaXJlY3Rpb25CYWNr d2FyZCA/IEdUS19ESVJfVEFCX0JBQ0tXQVJEIDogR1RLX0RJUl9UQUJfRk9SV0FSRCk7CisgICAg fQorCisgICAgdm9pZCBmb2N1cyhXZWJQYWdlUHJveHkqKSBmaW5hbAorICAgIHsKKyAgICAgICAg Z3RrX3dpZGdldF9ncmFiX2ZvY3VzKEdUS19XSURHRVQobV93ZWJWaWV3KSk7CisgICAgfQorCiAg ICAgdm9pZCBwcmludEZyYW1lKFdlYlBhZ2VQcm94eSYsIFdlYkZyYW1lUHJveHkmIGZyYW1lLCBD b21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpIGZpbmFsCiAgICAg ewogICAgICAgICB3ZWJraXRXZWJWaWV3UHJpbnRGcmFtZShtX3dlYlZpZXcsICZmcmFtZSk7Cg==