211277 2020-04-30 20:53:47 -0700 [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path 2020-05-01 02:49:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply pnormand webkit-bug-importer oldest_to_newest 1647754 0 lmoura 2020-04-30 20:53:47 -0700 Currently flatpakutils.py hardcodes the path to the document portal to /run/user/$UID/doc, but in practice, it depends on the value of $XDG_RUNTIME_DIR (which typically is /run/user/$UID). Problems with this var can lead to bubblewrap (used by flatpak) to fail with messages like 'brwap: Can't find source path : No such file or directory.' 1647756 1 398156 lmoura 2020-04-30 21:06:14 -0700 Created attachment 398156 Patch This version checks environment for XDG_RUNTIME_DIR instead of using the dbus method GetMountPoint. Currently there is no direct dbus usage from webkitpy. One issue that may still be present is the complete absence of the runtime directory. Should flatpakutils.py create a 'fake' one or this should be in charge of whoever uses webkit-flatpak? (e.g. the bots scripts). 1647800 2 ews-feeder 2020-05-01 02:48:26 -0700 Committed r260991: <https://trac.webkit.org/changeset/260991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398156. 1647802 3 webkit-bug-importer 2020-05-01 02:49:16 -0700 <rdar://problem/62714503> 398156 2020-04-30 21:06:14 -0700 2020-05-01 02:48:26 -0700 Patch bug-211277-20200501010611.patch text/plain 2931 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU4YjZjODk0NjIzZjg0NjE3ZmU4ZGQzN2M4Y2U3NjYx ZmNkN2JlNC4uN2Q5ZDBmMDRlNjI3YjIyNjNlMzNlMDQ2ZmFkMGFlYzk5ZWFmZTkyZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA0LTMwICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtGbGF0cGFrIFNES10gSG9ub3IgWERHX1JVTlRJTUVfRElSIHdoZW4gc2V0dGluZyB0aGUg ZG9jdW1lbnQgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjExMjc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmbGF0cGFrL2ZsYXRwYWt1dGlscy5weToKKyAgICAgICAgKFdlYmtpdEZsYXRwYWsu cnVuX2luX3NhbmRib3gpOiBQcmVmZXIgdXNpbmcgdGhlIHZhbHVlIG9mCisgICAgICAgICRYREdf UlVOVElNRV9ESVIgaW5zdGVhZCBvZiB0aGUgaGFyZGNvZGVkIHBhdGggd2hlbiBzZXR0aW5nIHRo ZQorICAgICAgICBkb2N1bWVudCBwb3J0YWwgcGF0aCBtb3VudC4KKwogMjAyMC0wNC0yOSAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MDc5 MSkgTmV0d29yayBwcm9jZXNzIGZhaWxzIHRvIHN1c3BlbmQgcHJvbXB0bHkKZGlmZiAtLWdpdCBh L1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRp bHMucHkKaW5kZXggNzQ2MDBmNzg2Mjg2MzQ1YjBhNjRhYTg0MWFmMzBiYmZmMWZhNTI0NS4uOWZj YjJhYTcxYjY4YjExOGQ4OTZmMTdjMjViNzVlOTM2YWNmMWJiMiAxMDA2NDQKLS0tIGEvVG9vbHMv ZmxhdHBhay9mbGF0cGFrdXRpbHMucHkKKysrIGIvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMu cHkKQEAgLTY1OSwxNiArNjU5LDIyIEBAIGNsYXNzIFdlYmtpdEZsYXRwYWs6CiAgICAgICAgICAg ICAgICAgIi0tdGFsay1uYW1lPW9yZy5mcmVlZGVza3RvcC5GbGF0cGFrIgogICAgICAgICAgICAg XSkKIAotICAgICAgICAgICAgdHJ5OgotICAgICAgICAgICAgICAgIHdpdGggb3Blbihvcy5kZXZu dWxsLCAndycpIGFzIGRldm51bGw6Ci0gICAgICAgICAgICAgICAgICAgIHVpZCA9IHN1YnByb2Nl c3MuY2hlY2tfb3V0cHV0KCgiaWQiLCAiLXUiKSwgc3RkZXJyPWRldm51bGwpLnN0cmlwKCkuZGVj b2RlKCkKLSAgICAgICAgICAgICAgICAgICAgdWlkX2RvY19wYXRoID0gJy9ydW4vdXNlci97dWlk fS9kb2MnLmZvcm1hdCh1aWQ9dWlkKQotICAgICAgICAgICAgICAgICAgICBpZiBvcy5wYXRoLmV4 aXN0cyh1aWRfZG9jX3BhdGgpOgotICAgICAgICAgICAgICAgICAgICAgICAgZmxhdHBha19jb21t YW5kLmFwcGVuZCgiLS1iaW5kLW1vdW50PXt1aWRfZG9jX3BhdGh9PXt1aWRfZG9jX3BhdGh9Ii5m b3JtYXQodWlkX2RvY19wYXRoPXVpZF9kb2NfcGF0aCkpCi0gICAgICAgICAgICAgICAgICAgIGVs c2U6Ci0gICAgICAgICAgICAgICAgICAgICAgICBfbG9nLmRlYnVnKCJDYW4ndCBmaW5kIHVzZXIg ZG9jdW1lbnQgcGF0aCBhdCAne3VpZF9kb2NfcGF0aH0nLiBOb3QgbW91bnRpbmcgaXQuIi5mb3Jt YXQodWlkX2RvY19wYXRoPXVpZF9kb2NfcGF0aCkpCi0gICAgICAgICAgICBleGNlcHQgc3VicHJv Y2Vzcy5DYWxsZWRQcm9jZXNzRXJyb3I6Ci0gICAgICAgICAgICAgICAgcGFzcworICAgICAgICAg ICAgeGRnX3J1bnRpbWVfZGlyID0gb3MuZW52aXJvbi5nZXQoJ1hER19SVU5USU1FX0RJUicsIE5v bmUpCisgICAgICAgICAgICBpZiBub3QgeGRnX3J1bnRpbWVfZGlyOgorICAgICAgICAgICAgICAg IF9sb2cuZGVidWcoJ1hER19SVU5USU1FX0RJUiBub3Qgc2V0LiBUcnlpbmcgZGVmYXVsdCBsb2Nh dGlvbi4nKQorICAgICAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICAgICAgd2l0aCBv cGVuKG9zLmRldm51bGwsICd3JykgYXMgZGV2bnVsbDoKKyAgICAgICAgICAgICAgICAgICAgICAg IHVpZCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KCgiaWQiLCAiLXUiKSwgc3RkZXJyPWRldm51 bGwpLmRlY29kZSgpLnN0cmlwKCkKKyAgICAgICAgICAgICAgICAgICAgICAgIHhkZ19ydW50aW1l X2RpciA9ICcvcnVuL3VzZXIve3VpZH0nLmZvcm1hdCh1aWQ9dWlkKQorICAgICAgICAgICAgICAg IGV4Y2VwdCBzdWJwcm9jZXNzLkNhbGxlZFByb2Nlc3NFcnJvcjoKKyAgICAgICAgICAgICAgICAg ICAgX2xvZy5kZWJ1ZygiQ291bGQgbm90IGRldGVybWluZSBYREdfUlVOSU1FX0RJUi4gVGhpcyBt YXkgY2F1c2UgYnViYmxld3JhcCB0byBmYWlsLiIpCisKKyAgICAgICAgICAgIGlmIHhkZ19ydW50 aW1lX2RpcjoKKyAgICAgICAgICAgICAgICB1aWRfZG9jX3BhdGggPSBvcy5wYXRoLmpvaW4oeGRn X3J1bnRpbWVfZGlyLCAnZG9jJykKKyAgICAgICAgICAgICAgICBpZiBvcy5wYXRoLmV4aXN0cyh1 aWRfZG9jX3BhdGgpOgorICAgICAgICAgICAgICAgICAgICBmbGF0cGFrX2NvbW1hbmQuYXBwZW5k KCItLWJpbmQtbW91bnQ9e3VpZF9kb2NfcGF0aH09e3VpZF9kb2NfcGF0aH0iLmZvcm1hdCh1aWRf ZG9jX3BhdGg9dWlkX2RvY19wYXRoKSkKKyAgICAgICAgICAgICAgICBlbHNlOgorICAgICAgICAg ICAgICAgICAgICBfbG9nLmRlYnVnKCJDYW4ndCBmaW5kIHVzZXIgZG9jdW1lbnQgcGF0aCBhdCAn e3VpZF9kb2NfcGF0aH0nLiBOb3QgbW91bnRpbmcgaXQuIi5mb3JtYXQodWlkX2RvY19wYXRoPXVp ZF9kb2NfcGF0aCkpCiAKICAgICAgICAgICAgIGZvcndhcmRlZC51cGRhdGUoewogICAgICAgICAg ICAgICAgICJUWiI6ICJQU1Q4UERUIiwK