211276 2020-04-30 20:19:09 -0700 REGRESSION (r260214): Leak of _WKTextInputContext in -[WKContentView _isTextInputContextFocused:] 2020-05-01 03:26:38 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210611 1 ddkilzer ddkilzer darin dbates webkit-bug-importer oldest_to_newest 1647736 0 ddkilzer 2020-04-30 20:19:09 -0700 Leak of _WKTextInputContext in -[WKContentView _isTextInputContextFocused:]. Found by clang static analyzer. Regressed in: [iOS] Add a way to focus a text input and place a caret <https://bugs.webkit.org/show_bug.cgi?id=210611> <rdar://problem/61893062> <https://trac.webkit.org/r260214> 1647737 1 webkit-bug-importer 2020-04-30 20:19:24 -0700 <rdar://problem/62696724> 1647738 2 398151 ddkilzer 2020-04-30 20:21:37 -0700 Created attachment 398151 Patch v1 1647745 3 398151 dbates 2020-04-30 20:35:57 -0700 Comment on attachment 398151 Patch v1 Patch looks good. What a silly mistake. 1647747 4 ddkilzer 2020-04-30 20:37:34 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 398151 [details] > Patch v1 > > Patch looks good. What a silly mistake. Would have been fine with ARC. Someday we'll have nice things. :) 1647808 5 ews-feeder 2020-05-01 03:26:37 -0700 Committed r260994: <https://trac.webkit.org/changeset/260994> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398151. 398151 2020-04-30 20:21:37 -0700 2020-05-01 03:26:37 -0700 Patch v1 bug-211276-20200430202422.patch text/plain 2340 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI3MGVjY2U2MWRiNDFiNWFk MzMwODUwYzUyM2EwZGZlOTQ3ODBhOGIuLjUwMmJiZjg5MDgzM2YyMzY3MTJiNTk5N2YzNjUxMmQz NzI2MjU5YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMzAgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYwMjE0 KTogTGVhayBvZiBfV0tUZXh0SW5wdXRDb250ZXh0IGluIC1bV0tDb250ZW50VmlldyBfaXNUZXh0 SW5wdXRDb250ZXh0Rm9jdXNlZDpdCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTEy NzY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjY5NjcyND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9mb2N1c1RleHRJ bnB1dENvbnRleHQ6cGxhY2VDYXJldEF0OmNvbXBsZXRpb25IYW5kbGVyOl0pOgorICAgICAgICAt IFVzZSBSZXRhaW5QdHI8PiB0byBwYXNzIHRoZSBjb3B5IG9mIF9XS1RleHRJbnB1dENvbnRleHQg aW50bworICAgICAgICAgIHRoZSBibG9jayB0byBmaXggdGhlIGxlYWsuCisKIDIwMjAtMDQtMzAg IERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBGaXgg Y29uZnVzaW5nIGlkaW9tIGZvciByZWxlYXNpbmcgX3NlbGVjdGlvblJlY3RzIGluIC1bV0tUZXh0 UmFuZ2UgZGVhbGxvY10KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDQ4YjNiMTMxZTEyOTY1MmFkYTRlZDZj NzNkNTRjMmUyM2Q3Y2Q0OTcuLmE3NDE2ZDdiZTc2YjEwNTdhZmMyNjBhYmQ0ZDAwMzdlYTQzMDJh NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNTEzMCwxMyArNTEzMCwxMyBAQCAtICh2b2lkKV9mb2N1 c1RleHRJbnB1dENvbnRleHQ6KF9XS1RleHRJbnB1dENvbnRleHQgKiljb250ZXh0IHBsYWNlQ2Fy ZXRBdDooQ0dQbwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIF91c2luZ0dlc3R1cmVGb3JT ZWxlY3Rpb24gPSBZRVM7Ci0gICAgYXV0byBjaGVja0ZvY3VzZWRFbGVtZW50ID0gW3dlYWtTZWxm ID0gV2Vha09iakNQdHI8V0tDb250ZW50Vmlldz4geyBzZWxmIH0sIGNvbnRleHQgPSBbY29udGV4 dCBjb3B5XSwgY29tcGxldGlvbkhhbmRsZXIgPSBtYWtlQmxvY2tQdHIoY29tcGxldGlvbkhhbmRs ZXIpXSAoYm9vbCBzdWNjZXNzKSB7CisgICAgYXV0byBjaGVja0ZvY3VzZWRFbGVtZW50ID0gW3dl YWtTZWxmID0gV2Vha09iakNQdHI8V0tDb250ZW50Vmlldz4geyBzZWxmIH0sIGNvbnRleHQgPSBh ZG9wdE5TKFtjb250ZXh0IGNvcHldKSwgY29tcGxldGlvbkhhbmRsZXIgPSBtYWtlQmxvY2tQdHIo Y29tcGxldGlvbkhhbmRsZXIpXSAoYm9vbCBzdWNjZXNzKSB7CiAgICAgICAgIGF1dG8gc3Ryb25n U2VsZiA9IHdlYWtTZWxmLmdldCgpOwogICAgICAgICBpZiAoIXN0cm9uZ1NlbGYpIHsKICAgICAg ICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKG5pbCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgIH0KLSAgICAgICAgYm9vbCBpc0ZvY3VzZWQgPSBzdWNjZXNzICYmIFtzdHJvbmdTZWxmIF9p c1RleHRJbnB1dENvbnRleHRGb2N1c2VkOmNvbnRleHRdOworICAgICAgICBib29sIGlzRm9jdXNl ZCA9IHN1Y2Nlc3MgJiYgW3N0cm9uZ1NlbGYgX2lzVGV4dElucHV0Q29udGV4dEZvY3VzZWQ6Y29u dGV4dC5nZXQoKV07CiAgICAgICAgIGJvb2wgaXNFZGl0YWJsZSA9IHN1Y2Nlc3MgJiYgIXN0cm9u Z1NlbGYtPl9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmlzUmVhZE9ubHk7CiAgICAgICAgIHN0 cm9uZ1NlbGYtPl90ZXh0SW50ZXJhY3Rpb25EaWRDaGFuZ2VGb2N1c2VkRWxlbWVudCB8PSBpc0Zv Y3VzZWQ7CiAgICAgICAgIHN0cm9uZ1NlbGYtPl91c2luZ0dlc3R1cmVGb3JTZWxlY3Rpb24gPSBO TzsK