211266 2020-04-30 16:31:14 -0700 REGRESSION (r258994): Prevents diagnostic logging of network resource loads 2022-10-10 16:08:40 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209522 1 bfulgham bfulgham ahmad.saleem792 mjs webkit-bug-importer oldest_to_newest 1647648 0 bfulgham 2020-04-30 16:31:14 -0700 The change in r258994 was too heavy-handed. Although the SPI is called "_allowSensitiveLogging", it actually prevents any network logging. We need to hold off on adopting this until it is revised to only address sensitive load logging. 1647650 1 bfulgham 2020-04-30 16:33:59 -0700 <rdar://problem/62461099> 1647651 2 398121 bfulgham 2020-04-30 16:35:09 -0700 Created attachment 398121 Patch 1647876 3 bfulgham 2020-05-01 09:42:16 -0700 After speaking with Maciej, we will do this another way. 1648134 4 bfulgham 2020-05-01 16:14:17 -0700 We spoke again, and will take this change, but we need to hold off until a blocking bug is fixed. 1648135 5 bfulgham 2020-05-01 16:14:37 -0700 Note: Holding for <rdar://problem/62727212> to be landed. 1648212 6 398121 mjs 2020-05-01 23:53:21 -0700 Comment on attachment 398121 Patch Maybe this is a stretch, but is it possible to make an API test that verifies that logging happens when it's supposed to (and not when it isn't supposed to, i.e. private browsing)? In any case, r=me 1650381 7 bfulgham 2020-05-07 15:35:25 -0700 (In reply to Brent Fulgham from comment #5) > Note: Holding for <rdar://problem/62727212> to be landed. Actually, it's <rdar://problem/62901456> we are holding for. 1904630 8 ahmad.saleem792 2022-10-10 14:44:15 -0700 Checking by BugID, it seems this r+ patch didn't landed. Do we need this now? Thanks! 1904663 9 bfulgham 2022-10-10 16:08:40 -0700 Oh! The relevant changes landed in https://trac.webkit.org/changeset/262332/webkit, after coordinating with the CFNetwork changes needed here. We can close this. The fix shipped back in 2020. 398121 2020-04-30 16:35:09 -0700 2020-05-01 23:53:21 -0700 Patch bug-211266-20200430163508.patch text/plain 1979 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVlNTYwOTZlMTdiZjUzZTRm ZGY1MGM4Yzc2ZjVmNGUwMWE2NDE3YzguLjNlYmFjYjA3ZjllNWY0MDAwYTNhN2M1Mjk3NDYzM2E1 YWUxY2QwN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDQtMzAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1ODk5 NCk6IFByZXZlbnRzIGRpYWdub3N0aWMgbG9nZ2luZyBvZiBuZXR3b3JrIHJlc291cmNlIGxvYWRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEyNjYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyNDYxMDk5PgorICAgICAgICAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZSBpbiByMjU4OTk0 IHdhcyB0b28gaGVhdnktaGFuZGVkLiBBbHRob3VnaCB0aGUgU1BJIGlzIGNhbGxlZCAiX2FsbG93 U2Vuc2l0aXZlTG9nZ2luZyIsCisgICAgICAgIGl0IGFjdHVhbGx5IHByZXZlbnRzIGFueSBuZXR3 b3JrIGxvZ2dpbmcuCisKKyAgICAgICAgV2UgbmVlZCB0byBob2xkIG9mZiBvbiBhZG9wdGluZyB0 aGlzIHVudGlsIGl0IGlzIHJldmlzZWQgdG8gb25seSBhZGRyZXNzIHNlbnNpdGl2ZSBsb2FkIGxv Z2dpbmcuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNv Y29hLm1tOgorICAgICAgICAoV2ViS2l0Ojpjb25maWd1cmF0aW9uRm9yU2Vzc2lvbklEKToKKwog MjAyMC0wNC0zMCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJBdXRobl0gT3B0aW1pemUgTG9jYWxBdXRoZW50aWNhdG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0K aW5kZXggM2U5YmIyMWU4OWZhMzVlYTZiMDBhYzcwMGY4NmJjNGMwZWM5NWNmNy4uYzQwZWZkMWU2 MjU5MDZhNzNjYTM1Mzg4YWZmOGEzNjk5N2Q2MDdkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAt MTAyMCwxMiArMTAyMCwxMiBAQCBzdGF0aWMgTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlvbiAqY29u ZmlndXJhdGlvbkZvclNlc3Npb25JRChjb25zdCBQQUw6OlNlc3Npb25JRAogICAgIGlmIChzZXNz aW9uLmlzRXBoZW1lcmFsKCkpIHsKICAgICAgICAgY29uZmlndXJhdGlvbiA9IFtOU1VSTFNlc3Np b25Db25maWd1cmF0aW9uIGVwaGVtZXJhbFNlc3Npb25Db25maWd1cmF0aW9uXTsKICAgICAgICAg Y29uZmlndXJhdGlvbi5fc2hvdWxkU2tpcFByZWZlcnJlZENsaWVudENlcnRpZmljYXRlTG9va3Vw ID0gWUVTOworI2lmIEhBVkUoQUxMT1dTX1NFTlNJVElWRV9MT0dHSU5HKQorICAgICAgICBjb25m aWd1cmF0aW9uLl9hbGxvd3NTZW5zaXRpdmVMb2dnaW5nID0gTk87CisjZW5kaWYKICAgICB9IGVs c2UKICAgICAgICAgY29uZmlndXJhdGlvbiA9IFtOU1VSTFNlc3Npb25Db25maWd1cmF0aW9uIGRl ZmF1bHRTZXNzaW9uQ29uZmlndXJhdGlvbl07CiAKLSNpZiBIQVZFKEFMTE9XU19TRU5TSVRJVkVf TE9HR0lORykKLSAgICBjb25maWd1cmF0aW9uLl9hbGxvd3NTZW5zaXRpdmVMb2dnaW5nID0gTk87 Ci0jZW5kaWYKICAgICByZXR1cm4gY29uZmlndXJhdGlvbjsKIH0KIAo=