211255 2020-04-30 14:21:26 -0700 clearApplicationBundleIdentifierTestingOverride() should set the bundle identifier to a null string, not an empty string 2020-04-30 14:58:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham pvollan wilander oldest_to_newest 1647547 0 katherine_cheney 2020-04-30 14:21:26 -0700 After the bundle identifier is cleared in a testing override call, subsequent calls to applicationBundleIdentifier() should check the NSBundle mainBundle object. This only happens if the testing bundle identifier is null (currently it is set to the empty string between calls). 1647549 1 katherine_cheney 2020-04-30 14:21:47 -0700 <rdar://problem/62651110> 1647552 2 398091 katherine_cheney 2020-04-30 14:25:10 -0700 Created attachment 398091 Patch 1647555 3 katherine_cheney 2020-04-30 14:26:40 -0700 An empty bundle identifier is causing flaky tests. I was able to reproduce before using: run-webkit-tests LayoutTests/http/tests/in-app-browser-privacy/ LayoutTests/userscripts/mixed-case-stylesheet.html LayoutTests/userscripts/simple-stylesheet.html LayoutTests/userscripts/user-style* -f --iphone-simulator --no-build --no-retry-failures --debug-rwt-logging --exit-after-n-failures 1 --force But not able to reproduce with this patch. 1647556 4 398091 wilander 2020-04-30 14:27:48 -0700 Comment on attachment 398091 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398091&action=review r=me. Please address the comment. > Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:72 > + applicationBundleIdentifierOverride() = String(); The bug title indicates that this should be nullptr. Either the title or this assignment should be changed. 1647557 5 katherine_cheney 2020-04-30 14:28:45 -0700 (In reply to John Wilander from comment #4) > Comment on attachment 398091 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398091&action=review > > r=me. Please address the comment. > > > Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:72 > > + applicationBundleIdentifierOverride() = String(); > > The bug title indicates that this should be nullptr. Either the title or > this assignment should be changed. You're right. It should be "null string" not just null. 1647558 6 398093 katherine_cheney 2020-04-30 14:32:49 -0700 Created attachment 398093 Patch for landing 1647572 7 ews-feeder 2020-04-30 14:58:13 -0700 Committed r260969: <https://trac.webkit.org/changeset/260969> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398093. 398091 2020-04-30 14:25:10 -0700 2020-04-30 14:32:47 -0700 Patch bug-211255-20200430142509.patch text/plain 1908 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzkzYzAzNWUzNDcxNzRk OTY3NWQ4MmI1ODg3YTFmYmM1Y2EwNTNjYS4uN2U4ZDZmZTU5NDZkMmQ2NzM0NDlhNWM4OTE2ZGQx NDlhYjUxMmY2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTMwICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIGNsZWFyQXBw bGljYXRpb25CdW5kbGVJZGVudGlmaWVyVGVzdGluZ092ZXJyaWRlKCkgc2hvdWxkIHNldCB0aGUg YnVuZGxlIGlkZW50aWZpZXIgdG8gbnVsbCwgbm90IGFuIGVtcHR5IHN0cmluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjU1CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82MjY1MTExMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIGNvbmZpcm1lZCBieSBleGlz dGluZyB0ZXN0cy4KKworICAgICAgICBDbGVhcmluZyB0aGUgYnVuZGxlIGlkZW50aWZpZXIgZHVy aW5nIHRlc3RzIHNob3VsZCByZXNldCB0aGUgb3ZlcnJpZGUKKyAgICAgICAgdmFsdWUgdG8gYmUg bnVsbCBzbyB0aGF0IHRoZSBmb2xsb3dpbmcgY2FsbHMgdG8gYXBwbGljYXRpb25CdW5kbGVJZGVu dGlmaWVyKCkKKyAgICAgICAgdXNlIHRoZSBbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gYnVuZGxlSWRl bnRpZmllcl0gY2FsbC4KKworICAgICAgICAqIHBsYXRmb3JtL2NvY29hL1J1bnRpbWVBcHBsaWNh dGlvbkNoZWNrc0NvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6Y2xlYXJBcHBsaWNhdGlvbkJ1 bmRsZUlkZW50aWZpZXJUZXN0aW5nT3ZlcnJpZGUpOgorCiAyMDIwLTA0LTMwICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBj aGFuZ2UgYSBXS1dlYlZpZXcncyBDT1JTIGRpc2FibGluZyBwYXR0ZXJuIGFmdGVyIGluaXRpYWxp emF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9SdW50aW1l QXBwbGljYXRpb25DaGVja3NDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29h L1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tCmluZGV4IGI1NmQwMDY4NDM3NDMzNGRj NTlkOTZhM2VlNTI0YjZlYjY2NTgyNzMuLmQ3YzUwMjk4NDEzNjhhYWZjOTU5NWVhZTU4MzhjOWIx MGZiMGI2NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1J1bnRp bWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tCkBAIC02OSw3ICs2OSw3IEBA IHZvaWQgc2V0QXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKGNvbnN0IFN0cmluZyYgYnVuZGxl SWRlbnRpZmllcikKIHZvaWQgY2xlYXJBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXJUZXN0aW5n T3ZlcnJpZGUoKQogewogICAgIEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7Ci0gICAgYXBwbGlj YXRpb25CdW5kbGVJZGVudGlmaWVyT3ZlcnJpZGUoKSA9IGVtcHR5U3RyaW5nKCk7CisgICAgYXBw bGljYXRpb25CdW5kbGVJZGVudGlmaWVyT3ZlcnJpZGUoKSA9IFN0cmluZygpOwogI2lmICFBU1NF UlRfTVNHX0RJU0FCTEVECiAgICAgYXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyT3ZlcnJpZGVX YXNRdWVyaWVkID0gZmFsc2U7CiAjZW5kaWYK 398093 2020-04-30 14:32:49 -0700 2020-04-30 14:58:14 -0700 Patch for landing bug-211255-20200430143248.patch text/plain 1925 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzkzYzAzNWUzNDcxNzRk OTY3NWQ4MmI1ODg3YTFmYmM1Y2EwNTNjYS4uMDJiZGRjNDdlMDFhZDgzNzIyYzFmNzI2YTVjNmQx NzkyMjY4N2FlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTMwICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIGNsZWFyQXBw bGljYXRpb25CdW5kbGVJZGVudGlmaWVyVGVzdGluZ092ZXJyaWRlKCkgc2hvdWxkIHNldCB0aGUg YnVuZGxlIGlkZW50aWZpZXIgdG8gYSBudWxsIHN0cmluZywgbm90IGFuIGVtcHR5IHN0cmluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjExMjU1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjY1MTExMD4KKworICAgICAgICBSZXZpZXdlZCBieSBK b2huIFdpbGFuZGVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3IgY29uZmlybWVk IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIENsZWFyaW5nIHRoZSBidW5kbGUgaWRlbnRp ZmllciBkdXJpbmcgdGVzdHMgc2hvdWxkIHJlc2V0IHRoZSBvdmVycmlkZQorICAgICAgICB2YWx1 ZSB0byBiZSBhIG51bGwgc3RyaW5nIHNvIHRoYXQgdGhlIGZvbGxvd2luZyBjYWxscyB0byBhcHBs aWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIoKQorICAgICAgICB1c2UgdGhlIFtOU0J1bmRsZSBtYWlu QnVuZGxlXSBidW5kbGVJZGVudGlmaWVyXSBjYWxsLgorCisgICAgICAgICogcGxhdGZvcm0vY29j b2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpj bGVhckFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllclRlc3RpbmdPdmVycmlkZSk6CisKIDIwMjAt MDQtMzAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBBZGQgU1BJIHRvIGNoYW5nZSBhIFdLV2ViVmlldydzIENPUlMgZGlzYWJsaW5nIHBhdHRl cm4gYWZ0ZXIgaW5pdGlhbGl6YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrc0NvY29hLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KaW5kZXgg YjU2ZDAwNjg0Mzc0MzM0ZGM1OWQ5NmEzZWU1MjRiNmViNjY1ODI3My4uZDdjNTAyOTg0MTM2OGFh ZmM5NTk1ZWFlNTgzOGM5YjEwZmIwYjY0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0K QEAgLTY5LDcgKzY5LDcgQEAgdm9pZCBzZXRBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIoY29u c3QgU3RyaW5nJiBidW5kbGVJZGVudGlmaWVyKQogdm9pZCBjbGVhckFwcGxpY2F0aW9uQnVuZGxl SWRlbnRpZmllclRlc3RpbmdPdmVycmlkZSgpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFp bigpKTsKLSAgICBhcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXJPdmVycmlkZSgpID0gZW1wdHlT dHJpbmcoKTsKKyAgICBhcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXJPdmVycmlkZSgpID0gU3Ry aW5nKCk7CiAjaWYgIUFTU0VSVF9NU0dfRElTQUJMRUQKICAgICBhcHBsaWNhdGlvbkJ1bmRsZUlk ZW50aWZpZXJPdmVycmlkZVdhc1F1ZXJpZWQgPSBmYWxzZTsKICNlbmRpZgo=