211253 2020-04-30 14:16:42 -0700 REGRESSION (r260932): ASSERTION FAILED: ok in webkit::SandboxExtension::consumePermanently for 3 tests 2020-04-30 16:46:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211103 InRadar P2 Normal --- 1 tsavell bfulgham bfulgham pvollan webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1647539 0 tsavell 2020-04-30 14:16:42 -0700 This API test: TestWebKitAPI.WebKit.UploadDirectory and these two Layout Tests: http/tests/misc/form-submit-file-cross-site-redirect.html http/tests/misc/form-submit-file-cross-site.html are all crashing after the changes in https://trac.webkit.org/changeset/260932/webkit History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=api-tests&test=http%2Ftests%2Fmisc%2Fform-submit-file-cross-site-redirect.html&test=http%2Ftests%2Fmisc%2Fform-submit-file-cross-site.html&test=TestWebKitAPI.WebKit.UploadDirectory Logs: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r260952%20(3943)/results.html Crashed TestWebKitAPI.WebKit.UploadDirectory ASSERTION FAILED: ok /Volumes/Data/slave/catalina-debug/build/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm(506) : static bool WebKit::SandboxExtension::consumePermanently(const WebKit::SandboxExtension::HandleArray &) 1 0x108267609 WTFCrash 2 0x11147aeeb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x111c649ac WebKit::SandboxExtension::consumePermanently(WebKit::SandboxExtension::HandleArray const&) 4 0x11171c71b IPC::FormDataReference::decode(IPC::Decoder&) 5 0x11171c49c WTF::Optional<IPC::FormDataReference> IPC::ArgumentCoder<IPC::FormDataReference>::decode<IPC::FormDataReference, (void*)0>(IPC::Decoder&) [tag] [reply] [−] Comment 14 1647540 1 webkit-bug-importer 2020-04-30 14:17:07 -0700 <rdar://problem/62673727> 1647599 2 bfulgham 2020-04-30 15:35:10 -0700 This test uncovered a bug in our handling of Sandbox extensions that only occurs with our test infrastructure. The TestWebKitAPI (and WKTR) processes are not sandboxed, and it is possible that WebKit clients might themselves be unsandboxed. When WebKit code linked into an unsandboxed process attempts to consume a sandbox extension, we get a null handle and no error code. We should treat this as a valid and expected result. I.e., we attempted to consume a valid sandbox extension supplied by a sandboxed helper process, and the Sandbox framework says "I didn't do anything since you are not sandboxed." 1647622 3 398113 bfulgham 2020-04-30 16:08:49 -0700 Created attachment 398113 Patch 1647637 4 398113 pvollan 2020-04-30 16:21:09 -0700 Comment on attachment 398113 Patch R=me. 1647655 5 ews-feeder 2020-04-30 16:46:43 -0700 Committed r260974: <https://trac.webkit.org/changeset/260974> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398113. 398113 2020-04-30 16:08:49 -0700 2020-04-30 16:46:44 -0700 Patch bug-211253-20200430160848.patch text/plain 2264 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJmZjY3MWU5YWM4NmJlODE0 YTA5ZTcwYmI2YTE4MmRmYmVjNjMxYWMuLmNhMzljMjY4MTBmNDEzN2VjZmE5YWNiOTU0YzFlZDAw YzJiZjcyMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDQtMzAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2MDkz Mik6IEFTU0VSVElPTiBGQUlMRUQ6IG9rIGluIHdlYmtpdDo6U2FuZGJveEV4dGVuc2lvbjo6Y29u c3VtZVBlcm1hbmVudGx5IGZvciAzIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTEyNTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyNjcz NzI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu IHIyNjA5MzIgSSBhZGRlZCBhbiBhc3NlcnRpb24gdG8gY29uZmlybSB0aGF0IGEgc2FuZGJveCBl eHRlbnNpb24gd2FzIHN1Y2Nlc3NmdWxseSBjb25zdW1lZC4gVGhpcyB0cmlnZ2VyZWQgdGhyZWUK KyAgICAgICAgdGVzdCBmYWlsdXJlcyBiZWNhdXNlIHRob3NlIHRlc3RzIGF0dGVtcHQgdG8gcGFz cyBhIHNhbmRib3ggZXh0ZW5zaW9uIGZyb20gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyB0byB0aGUg VUlQcm9jZXNzLgorCisgICAgICAgIEFmdGVyIHNwZWFraW5nIHdpdGggdGhlIFNhbmRib3ggdGVh bSwgSSBsZWFybmVkIHRoYXQgYW4gdW5zYW5kYm94ZWQgcHJvZ3JhbSB0aGF0IGF0dGVtcHRzIHRv IGNvbnN1bWUgYSB2YWxpZAorICAgICAgICBzYW5kYm94IGV4dGVuc2lvbiB3aWxsIHJldHVybiAw LiBTYW5kYm94ZWQgcHJvY2Vzc2VzIGVpdGhlciByZWNlaXZlIC0xIChmb3IgZXJyb3IpLCBvciBh IGhhbmRsZSByZXByZXNlbnRpbmcgdGhlCisgICAgICAgIG5ld2x5IGFkZGVkIGV4dGVuc2lvbiAo c28gdGhhdCBpdCBjYW4gYmUgcmVtb3ZlZCB3aGVuIG5vIGxvbmdlciBuZWVkZWQpLgorICAgICAg ICAKKyAgICAgICAgU2luY2UgdGhlIFRlc3RXZWJLaXRBUEkgKGFuZCBXZWJLaXRUZXN0UnVubmVy KSBwcm9jZXNzZXMgYXJlIG5vdCBzYW5kYm94ZWQgdGhleSByZWNlaXZlIGEgemVybyByZXR1cm4g dmFsdWUgaGVyZS4KKworICAgICAgICBXZSBzaG91bGQgcmVjb2duaXplIHRoaXMgYXMgYSB2YWxp ZCBhbmQgZXhwZWN0ZWQgcmVzdWx0LiBXZSBzaG91bGQgYWxzbyBjb25zaWRlciBtYWtpbmcgc29t ZSBmb3JtIG9mIHNhbmRib3hlZAorICAgICAgICBkcml2ZXIgZm9yIFdlYktpdC4KKworICAgICAg ICAqIFNoYXJlZC9Db2NvYS9TYW5kYm94RXh0ZW5zaW9uQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OlNhbmRib3hFeHRlbnNpb25JbXBsOjpjb25zdW1lKTogUmVjb2duaXplIGEgMCBoYW5kbGUg YXMgdmFsaWQuCisKIDIwMjAtMDQtMzAgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBh cHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIGRlZmF1bHQgb2YgImluQXBwQnJvd3NlclByaXZh Y3lRdWlya3MiIHRlc3RpbmcgdG9nZ2xlIHRvIHVzZSBpdCBmb3IgdGVzdHMgb25seQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1t IGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1tCmlu ZGV4IDFlMzc1Zjk2NWU4M2RjYzZmZTc1ZWZiMTgxZjY2YmVlOWJhZmIyZjkuLmQ4MzBiYzZiODU2 ODU4NGFjZWM3ZmRjZmUwMDg1ZjA4MDdhYzVhN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL0NvY29hL1NhbmRib3hFeHRlbnNpb25Db2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9Db2NvYS9TYW5kYm94RXh0ZW5zaW9uQ29jb2EubW0KQEAgLTY4LDcgKzY4LDcgQEAg cHVibGljOgogICAgICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZCBub3QgY3JlYXRlIGEgc2FuZGJv eCBleHRlbnNpb24gZm9yICclcycsIGVycm5vID0gJWQiLCBtX3Rva2VuLCBlcnJubyk7CiAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIG1faGFuZGxl OworICAgICAgICByZXR1cm4gdHJ1ZTsKICNlbmRpZgogICAgIH0KIAo=