211251 2020-04-30 14:07:24 -0700 Web Inspector: Browser: crash when handling `disable` 2020-05-01 14:10:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1647534 0 hi 2020-04-30 14:07:24 -0700 ASSERTION FAILED: inspector /Volumes/DATA/OpenSource/Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp(91) : virtual void WebKit::InspectorBrowserAgent::disable(WebKit::ErrorString &) 1 0x10dcc8919 WTFCrash 2 0x114704d8b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1158b1234 WebKit::InspectorBrowserAgent::disable(WTF::String&) 4 0x1158b1140 WebKit::InspectorBrowserAgent::willDestroyFrontendAndBackend(Inspector::DisconnectReason) 5 0x10ee6e7fc Inspector::AgentRegistry::willDestroyFrontendAndBackend(Inspector::DisconnectReason) 6 0x1158ae225 WebKit::WebPageInspectorController::disconnectFrontend(Inspector::FrontendChannel&) 7 0x1158ab5d5 WebKit::WebInspectorProxy::closeFrontendPageAndWindow() 8 0x1158ab49c WebKit::WebInspectorProxy::invalidate() 9 0x1155a8587 WebKit::WebPageProxy::close() 10 0x1157c066d WKPageClose 1647551 1 398090 hi 2020-04-30 14:24:21 -0700 Created attachment 398090 Patch 1648010 2 398090 dbates 2020-05-01 13:09:49 -0700 Comment on attachment 398090 Patch Patch looks good. A better patch would add a unit test for this as it looks testable. 1648049 3 ews-feeder 2020-05-01 14:09:56 -0700 Committed r261020: <https://trac.webkit.org/changeset/261020> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398090. 1648050 4 webkit-bug-importer 2020-05-01 14:10:19 -0700 <rdar://problem/62746484> 398090 2020-04-30 14:24:21 -0700 2020-05-01 14:09:57 -0700 Patch bug-211251-20200430152420.patch text/plain 1767 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTVjM2RiMTc5ZmY3NjE3N2JiZjg1ZmQzODNlOGE3ZjI0ZjRiNzQwZi4uNTg4 ZDViYmJkZjBhZmFiYTBhMjM3OWM4NzMxNWIzNzYxZmQ1ZWI1OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAyMC0wNC0zMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViIEluc3BlY3RvcjogQnJvd3NlcjogY3Jhc2ggd2hlbiBoYW5kbGluZyBgZGlz YWJsZWAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MTI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0luc3BlY3Rvci9BZ2VudHMvSW5zcGVjdG9yQnJvd3NlckFnZW50LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6SW5zcGVjdG9yQnJvd3NlckFnZW50OjpkaXNhYmxlKToKKyAgICAgICAg SWYgdGhlIGluc3BlY3RlZCBwYWdlIGNyYXNoZWQsIHdlIHdvbid0IGhhdmUgYSBgV2ViSW5zcGVj dG9yUHJveHlgIGFueW1vcmUuCisKIDIwMjAtMDQtMzAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgU1BJIHRvIGNoYW5nZSBhIFdLV2Vi VmlldydzIENPUlMgZGlzYWJsaW5nIHBhdHRlcm4gYWZ0ZXIgaW5pdGlhbGl6YXRpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9BZ2VudHMvSW5zcGVjdG9y QnJvd3NlckFnZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9BZ2Vu dHMvSW5zcGVjdG9yQnJvd3NlckFnZW50LmNwcAppbmRleCBhYjIzODY5ZjEzMDNlNWYwYjQ5ZWJm Njk2OTU0N2M3OTU5ZDUyYjBjLi4wNDBmOTUxYWE5NjgwYzE2MGY3MmJiZGVjZDg5MDQ1OWI4NWZl YzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvQWdlbnRz L0luc3BlY3RvckJyb3dzZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv SW5zcGVjdG9yL0FnZW50cy9JbnNwZWN0b3JCcm93c2VyQWdlbnQuY3BwCkBAIC04Nyw5ICs4Nyw4 IEBAIHZvaWQgSW5zcGVjdG9yQnJvd3NlckFnZW50OjpkaXNhYmxlKEVycm9yU3RyaW5nJiBlcnJv clN0cmluZykKIAogICAgIG1faW5zcGVjdGVkUGFnZS5pbnNwZWN0b3JDb250cm9sbGVyKCkuc2V0 RW5hYmxlZEluc3BlY3RvckJyb3dzZXJBZ2VudChudWxscHRyKTsKIAotICAgIGF1dG8qIGluc3Bl Y3RvciA9IG1faW5zcGVjdGVkUGFnZS5pbnNwZWN0b3IoKTsKLSAgICBBU1NFUlQoaW5zcGVjdG9y KTsKLSAgICBtX2luc3BlY3RlZFBhZ2UuaW5zcGVjdG9yQ2xpZW50KCkuYnJvd3NlckRvbWFpbkRp c2FibGVkKG1faW5zcGVjdGVkUGFnZSwgKmluc3BlY3Rvcik7CisgICAgaWYgKGF1dG8qIGluc3Bl Y3RvciA9IG1faW5zcGVjdGVkUGFnZS5pbnNwZWN0b3IoKSkKKyAgICAgICAgbV9pbnNwZWN0ZWRQ YWdlLmluc3BlY3RvckNsaWVudCgpLmJyb3dzZXJEb21haW5EaXNhYmxlZChtX2luc3BlY3RlZFBh Z2UsICppbnNwZWN0b3IpOwogfQogCiB2b2lkIEluc3BlY3RvckJyb3dzZXJBZ2VudDo6ZXh0ZW5z aW9uc0VuYWJsZWQoSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4mJiBleHRlbnNpb25JRFRvTmFtZSkK