211243 2020-04-30 11:46:41 -0700 REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m 2020-05-07 12:13:25 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=211235 InRadar P2 Normal --- 139308 166801 211587 211586 1 ddkilzer ddkilzer commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 1647456 0 ddkilzer 2020-04-30 11:46:41 -0700 Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m. Regressed here: Bug 139308: Add a private browsing mode to MiniBrowser <https://bugs.webkit.org/show_bug.cgi?id=139308> <https://trac.webkit.org/r176862> Bug 166801: Add the ability to create empty contentEditable windows in MiniBrowser <https://bugs.webkit.org/show_bug.cgi?id=166801> <https://trac.webkit.org/r210483> Found by clang static analyzer. 1647457 1 398073 ddkilzer 2020-04-30 11:48:54 -0700 Created attachment 398073 Patch v1 1647458 2 webkit-bug-importer 2020-04-30 11:49:13 -0700 <rdar://problem/62663549> 1647471 3 398073 ddkilzer 2020-04-30 11:59:28 -0700 Comment on attachment 398073 Patch v1 MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully. 1647488 4 ews-feeder 2020-04-30 12:19:50 -0700 Committed r260959: <https://trac.webkit.org/changeset/260959> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398073. 1650258 5 commit-queue 2020-05-07 11:55:19 -0700 Re-opened since this is blocked by bug 211587 1650277 6 webkit-bug-importer 2020-05-07 12:13:25 -0700 <rdar://problem/62987575> 398073 2020-04-30 11:48:54 -0700 2020-04-30 12:19:50 -0700 Patch v1 bug-211243-20200430115136.patch text/plain 1627 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGY4NWI5NzkwZTVkYzYyNDlhMTIzYWY0MmNmMWNhNTAx OGFlN2Y0MS4uOWQ3ZjM2ZDEzYzBhNjEzNDU5OTFmMTM3ODg2YTM2NjVjMWI1ZWY5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA0LTMwICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjE3Njg2MiwgcjIxMDQ4Myk6IExlYWtzIG9mIEJyb3dzZXJXaW5k b3dDb250cm9sbGVyIGluIE1pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8yMTEyNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubToKKyAg ICAgICAgKC1bQnJvd3NlckFwcERlbGVnYXRlIGNyZWF0ZUJyb3dzZXJXaW5kb3dDb250cm9sbGVy Ol0pOgorICAgICAgICAtIEF1dG9yZWxlYXNlIHJldHVybiB2YWx1ZSB0byBmaXggbGVhay4KKyAg ICAgICAgKC1bQnJvd3NlckFwcERlbGVnYXRlIG5ld1ByaXZhdGVXaW5kb3c6XSk6CisgICAgICAg IC0gUmVsZWFzZSBjb250cm9sbGVyIHRvIGZpeCBsZWFrLgorCiAyMDIwLTA0LTMwICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI0NzQ5 MCk6IExlYWsgb2YgTWluaUJyb3dzZXJOU1RleHRGaW5kZXIuX2hpZGVJbnRlcmZhY2VDYWxsYmFj awpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0gYi9Ub29s cy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubQppbmRleCA2MWYxYmE2MGQ1OTllMWVmNTll NWNkNzQxYjMyNWRmNjI3YzgzMDI3Li44ZmY2OTRiZTU0OGQ0NzdkOTU5NzE3ZTBiYmUyMjk4OTM3 ODllOTIwIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubQor KysgYi9Ub29scy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubQpAQCAtMTgzLDcgKzE4Myw3 IEBAIC0gKEJyb3dzZXJXaW5kb3dDb250cm9sbGVyICopY3JlYXRlQnJvd3NlcldpbmRvd0NvbnRy b2xsZXI6KGlkKXNlbmRlcgogCiAgICAgW19icm93c2VyV2luZG93Q29udHJvbGxlcnMgYWRkT2Jq ZWN0OmNvbnRyb2xsZXJdOwogCi0gICAgcmV0dXJuIGNvbnRyb2xsZXI7CisgICAgcmV0dXJuIFtj b250cm9sbGVyIGF1dG9yZWxlYXNlXTsKIH0KIAogLSAoSUJBY3Rpb24pbmV3V2luZG93OihpZClz ZW5kZXIKQEAgLTIwOCw2ICsyMDgsNyBAQCAtIChJQkFjdGlvbiluZXdQcml2YXRlV2luZG93Oihp ZClzZW5kZXIKICAgICBbX2Jyb3dzZXJXaW5kb3dDb250cm9sbGVycyBhZGRPYmplY3Q6Y29udHJv bGxlcl07CiAKICAgICBbY29udHJvbGxlciBsb2FkVVJMU3RyaW5nOl9zZXR0aW5nc0NvbnRyb2xs ZXIuZGVmYXVsdFVSTF07CisgICAgW2NvbnRyb2xsZXIgcmVsZWFzZV07CiB9CiAKIC0gKElCQWN0 aW9uKW5ld0VkaXRvcldpbmRvdzooaWQpc2VuZGVyCg==